Re: [PATCH] qapi: net/tap: deprecate vhostforce option

2025-09-01 Thread Vladimir Sementsov-Ogievskiy
On 01.09.25 14:50, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: On 30.08.25 11:17, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: This option simply duplicates the @vhost option since long ago (10 years!) commit 1e7398a140f7a6 ("vhost: enable vhost without w

Re: [PATCH] qapi: net/tap: deprecate vhostforce option

2025-09-01 Thread Markus Armbruster via Devel
Vladimir Sementsov-Ogievskiy writes: > On 30.08.25 11:17, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> This option simply duplicates the @vhost option since long ago >>> (10 years!) >>> commit 1e7398a140f7a6 ("vhost: enable vhost without without MSI-X"). >> >> This is

Re: [PATCH] qapi: net/tap: deprecate vhostforce option

2025-09-01 Thread Vladimir Sementsov-Ogievskiy
On 30.08.25 11:17, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: This option simply duplicates the @vhost option since long ago (10 years!) commit 1e7398a140f7a6 ("vhost: enable vhost without without MSI-X"). This isn't obvious to me. As far as I can see, their only use is i

Re: [PATCH] qapi: net/tap: deprecate vhostforce option

2025-08-30 Thread Markus Armbruster via Devel
Vladimir Sementsov-Ogievskiy writes: > This option simply duplicates the @vhost option since long ago > (10 years!) > commit 1e7398a140f7a6 ("vhost: enable vhost without without MSI-X"). This isn't obvious to me. As far as I can see, their only use is in net_init_tap_one(): if (tap->has_vh

[PATCH] qapi: net/tap: deprecate vhostforce option

2025-08-29 Thread Vladimir Sementsov-Ogievskiy
This option simply duplicates the @vhost option since long ago (10 years!) commit 1e7398a140f7a6 ("vhost: enable vhost without without MSI-X"). Let's finally deprecate it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- docs/about/deprecated.rst | 7 +++ qapi/net.json | 6 +-