Re: [PATCH 00/21] qemu: Refactor domstats code to avoid error reporting

2025-02-24 Thread Peter Krempa
On Mon, Feb 24, 2025 at 10:42:05 +0100, Peter Krempa wrote: > On Mon, Feb 24, 2025 at 09:33:51 +, Daniel P. Berrangé wrote: > > On Thu, Feb 20, 2025 at 10:01:13AM +0100, Peter Krempa wrote: > > > The workers of qemuDomainGetStats should not report errors if they can't > > > fetch data; but rath

Re: [PATCH 00/21] qemu: Refactor domstats code to avoid error reporting

2025-02-24 Thread Daniel P . Berrangé
On Mon, Feb 24, 2025 at 10:42:05AM +0100, Peter Krempa wrote: > On Mon, Feb 24, 2025 at 09:33:51 +, Daniel P. Berrangé wrote: > > On Thu, Feb 20, 2025 at 10:01:13AM +0100, Peter Krempa wrote: > > > The workers of qemuDomainGetStats should not report errors if they can't > > > fetch data; but ra

Re: [PATCH 00/21] qemu: Refactor domstats code to avoid error reporting

2025-02-24 Thread Peter Krempa
On Mon, Feb 24, 2025 at 09:33:51 +, Daniel P. Berrangé wrote: > On Thu, Feb 20, 2025 at 10:01:13AM +0100, Peter Krempa wrote: > > The workers of qemuDomainGetStats should not report errors if they can't > > fetch data; but rather omit the entries. Refactor the code to > > de-incentivize error r

Re: [PATCH 00/21] qemu: Refactor domstats code to avoid error reporting

2025-02-24 Thread Daniel P . Berrangé
On Thu, Feb 20, 2025 at 10:01:13AM +0100, Peter Krempa wrote: > The workers of qemuDomainGetStats should not report errors if they can't > fetch data; but rather omit the entries. Refactor the code to > de-incentivize error reporting. Why shouldn't they report errors ? Can you give an example of

Re: [PATCH 00/21] qemu: Refactor domstats code to avoid error reporting

2025-02-20 Thread Ján Tomko
On a Thursday in 2025, Peter Krempa wrote: The workers of qemuDomainGetStats should not report errors if they can't fetch data; but rather omit the entries. Refactor the code to de-incentivize error reporting. Peter Krempa (21): qemuDomainGetStatsBlockExportHeader: Remove return value qemuDoma

Re: [PATCH 00/21] qemu: Refactor domstats code to avoid error reporting

2025-02-20 Thread Michal Prívozník
On 2/20/25 10:01, Peter Krempa wrote: > The workers of qemuDomainGetStats should not report errors if they can't > fetch data; but rather omit the entries. Refactor the code to > de-incentivize error reporting. > > Peter Krempa (21): > qemuDomainGetStatsBlockExportHeader: Remove return value >

[PATCH 00/21] qemu: Refactor domstats code to avoid error reporting

2025-02-20 Thread Peter Krempa
The workers of qemuDomainGetStats should not report errors if they can't fetch data; but rather omit the entries. Refactor the code to de-incentivize error reporting. Peter Krempa (21): qemuDomainGetStatsBlockExportHeader: Remove return value qemuDomainGetStatsBlockExportFrontend: Remove retur