[PATCH] qemu: validate: Reword error message when CCW addresses are not supported for a machine

Reword the error message to clearly state that the machine type doesn't support the address type. It doesn't matter which device it's for. Additionally the alias may be still NULL at the point when the error is being reported misleading users that they have something wrong with a specific device.

Re: [PATCH] qemu: validate: Reword error message when CCW addresses are not supported for a machine

On a Tuesday in 2023, Peter Krempa wrote: Reword the error message to clearly state that the machine type doesn't support the address type. It doesn't matter which device it's for. Additionally the alias may be still NULL at the point when the error is being reported misleading users that they h

[PATCH 1/6] vbox_snapshot_conf: Parse XMLs without net access

When working with VirtualBox's snapshots, the snapshot XML is firstly parsed, stored in memory (with some parts being stored as verbatim XML snippets, strings), requested changes are made and then this modified XML is formatted via virVBoxSnapshotConfSaveVboxFile() which calls xmlParseInNodeContext

[PATCH 3/6] virxml: include for xmlIndentTreeOutput declaration

After libxml2's commit of v2.12.0~101 we no longer get xmlIndentTreeOutput declaration by us including just libxml/xpathInternals.h and libxml2's header files leakage. Resolves: https://bugs.gentoo.org/917516 Signed-off-by: Michal Privoznik --- src/util/virxml.c | 1 + 1 file changed, 1 insertio

[PATCH 0/6] Adapt to libxml2-2.12.0

There is a new release of libxml2 and we have a technical debt we need to address before we can compile with it cleanly. Michal Prívozník (6): vbox_snapshot_conf: Parse XMLs without net access vbox_snapshot_conf: Keep indent in snapshot XML virxml: include for xmlIndentTreeOutput declaratio

[PATCH 2/6] vbox_snapshot_conf: Keep indent in snapshot XML

As mentioned in previous commit, VirtualBox has its own snapshot XML which we parse, change and then format back. During this, we ought to keep the indentation to produce better looking result (especially when we want to compare the output in tests later on, like we do in vboxsnapshotxmltest). Sig

[PATCH 4/6] virXMLParseHelper: Store XML parsing flags in a variable

The virXMLParseHelper() can work in two modes: either it parses a file or a string. Either way, the same set of flags is specified in call of corresponding function. Save flags in a local variable instead. Signed-off-by: Michal Privoznik --- src/util/virxml.c | 10 -- 1 file changed, 4 i

[PATCH 6/6] lib: Replace xmlKeepBlanksDefault() with virXMLParseWithIndent()

Now that we have virXMLParseWithIndent() and virXMLParseStringCtxtWithIndent(), we can use them directly and drop calls to xmlKeepBlanksDefault(). Signed-off-by: Michal Privoznik --- src/conf/backup_conf.c | 8 +++- src/conf/checkpoint_conf.c | 8 +++- src/conf/domain_conf.c |

[PATCH 5/6] virxml: Introduce parsing APIs that keep indentation

When parsing an XML it may be important to keep indentation to produce a better looking result when formatting the XML back. Just look at all those xmlKeepBlanksDefault() calls just before virXMLParse() is called. Anyway, as of libxml2 commit v2.12.0~108 xmlKeepBlanksDefault() is deprecated. There

Re: [PATCH 1/6] vbox_snapshot_conf: Parse XMLs without net access

On a Tuesday in 2023, Michal Privoznik wrote: When working with VirtualBox's snapshots, the snapshot XML is firstly parsed, stored in memory (with some parts being stored as verbatim XML snippets, strings), requested changes are made and then this modified XML is formatted via virVBoxSnapshotConf

Re: [PATCH 2/6] vbox_snapshot_conf: Keep indent in snapshot XML

On a Tuesday in 2023, Michal Privoznik wrote: As mentioned in previous commit, VirtualBox has its own snapshot XML which we parse, change and then format back. During this, we ought to keep the indentation to produce better looking result (especially when we want to compare the output in tests la

Re: [PATCH 3/6] virxml: include for xmlIndentTreeOutput declaration

On a Tuesday in 2023, Michal Privoznik wrote: After libxml2's commit of v2.12.0~101 we no longer get xmlIndentTreeOutput declaration by us including just libxml/xpathInternals.h and libxml2's header files leakage. Resolves: https://bugs.gentoo.org/917516 Signed-off-by: Michal Privoznik --- src/

Re: [PATCH 4/6] virXMLParseHelper: Store XML parsing flags in a variable

On a Tuesday in 2023, Michal Privoznik wrote: The virXMLParseHelper() can work in two modes: either it parses a file or a string. Either way, the same set of flags is specified in call of corresponding function. Save flags in a local variable instead. Signed-off-by: Michal Privoznik --- src/uti

Re: [PATCH 5/6] virxml: Introduce parsing APIs that keep indentation

On a Tuesday in 2023, Michal Privoznik wrote: When parsing an XML it may be important to keep indentation to produce a better looking result when formatting the XML back. Just look at all those xmlKeepBlanksDefault() calls just before virXMLParse() is called. Anyway, as of libxml2 commit v2.12.0

Re: [PATCH 6/6] lib: Replace xmlKeepBlanksDefault() with virXMLParseWithIndent()

On a Tuesday in 2023, Michal Privoznik wrote: Now that we have virXMLParseWithIndent() and virXMLParseStringCtxtWithIndent(), we can use them directly and drop calls to xmlKeepBlanksDefault(). Signed-off-by: Michal Privoznik --- src/conf/backup_conf.c | 8 +++- src/conf/checkpoint_conf.

Re: [libvirt PATCH v2] qemu: add runtime config option for nbdkit

On Wed, Nov 15, 2023 at 01:52:48PM -0600, Jonathon Jongsma wrote: > > The main concern I have is how this will be handled for upgrades. At > > some point we want to make nbdkit the default, right? But that would > > mean changing how existing installations behave. I guess that is fine > > in this c

[libvirt PATCH] security: drop virSecurityDACRestoreImageLabelSingle()

It only has a single, trivial caller. Signed-off-by: Andrea Bolognani --- src/security/security_dac.c | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index c07e488db7..35b9b56c66 100644 --- a/src

Re: [libvirt PATCH] security: drop virSecurityDACRestoreImageLabelSingle()

On Tue, Nov 21, 2023 at 16:46:59 +0100, Andrea Bolognani wrote: > It only has a single, trivial caller. > > Signed-off-by: Andrea Bolognani > --- > src/security/security_dac.c | 21 - > 1 file changed, 4 insertions(+), 17 deletions(-) Reviewed-by: Peter Krempa _

[PATCH 0/3] qemuDomainAttachDeviceDiskLiveInternal: Fix error handling and properly hotplug empty cdroms

Patch 3 is best viewed with '-w' Peter Krempa (3): qemuDomainAttachDeviceDiskLiveInternal: Fix jumps on error qemuDomainAttachDeviceDiskLiveInternal: Add missing jump to 'cleanup' on error qemu: hotplug: Don't try to setup disk image when hotplugging empty cdrom drive src/qemu/qemu

[PATCH 2/3] qemuDomainAttachDeviceDiskLiveInternal: Add missing jump to 'cleanup' on error

Commit allowing hotplug of CDROMs moved the logic forbidding the hotplug to the appropriate blocks based on the disk frontend but forgot to actually bail out on such error. Fixes: 3078799fef82d45ac10624e3bacded7a285d8a4f Signed-off-by: Peter Krempa --- src/qemu/qemu_hotplug.c | 1 + 1 file chang

[PATCH 1/3] qemuDomainAttachDeviceDiskLiveInternal: Fix jumps on error

When I've originally refactored the function in commit 0d981bcefcb5defa2 the logic was still correct, but then later in commit 52f865543920b0 I've moved most of the image setup logic into the function neglecting to add the 'goto cleanup;' needed to skip over the setup of the disk images. Fixes: 52

[PATCH 3/3] qemu: hotplug: Don't try to setup disk image when hotplugging empty cdrom drive

Originally the disk hotplug code didn't know how to attach a CD-ROM drive, thus didn't have the necessary logic to handle empty cdroms. Other disks can't be empty which is enforced by the parser validation logic. When support for hotplugging cdroms was added the code was not adjusted to deal with

[libvirt PATCH] gitlab: adjust url to Coverity tools

The URL to the Coverity tools download has changed; the old one points to an obsolete version that is not supported anymore. Adjust to point to the correct and supported tools. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt PATCH] gitlab: adjust url to Coverity tools

On Tue, Nov 21, 2023 at 05:36:10PM +, Daniel P. Berrangé wrote: > The URL to the Coverity tools download has changed; the old one points > to an obsolete version that is not supported anymore. Adjust to point > to the correct and supported tools. > > Signed-off-by: Daniel P. Berrangé > --- R

Plans for 9.10.0 release (freeze on Monday 27 Nov)

We are getting close to 9.10.0 release of libvirt. To aim for the release on Friday 01 Dec I suggest entering the freeze on Monday 27 Nov and tagging RC2 on Wednesday 29 Nov. I hope this works for everyone. Jirka ___ Devel mailing list -- devel@lists.li