Re: [PATCH] remote: Fix cached hypervisor type

2023-12-08 Thread Daniel P . Berrangé
On Thu, Dec 07, 2023 at 06:56:09PM -0700, Jim Fehlig wrote: > Commit 501825011c switched the remote driver to using g_auto, but missed > one case of needing to steal a pointer holding the hypervisor type. > Without it, memory is freed and the output of 'virsh version' has random > output Opps, yea

[PATCH 0/3] Allow reserving more memory for PCI controllers

2023-12-08 Thread Michal Privoznik
*** BLURB HERE *** Michal Prívozník (3): conf: Introduce @memReserve to qemu_validate: Restrict setting @memReserve only to some controllers qemu_command: Generate mem-reserve for controllers docs/formatdomain.rst | 6 + src/conf/domain_conf.c

[PATCH 1/3] conf: Introduce @memReserve to

2023-12-08 Thread Michal Privoznik
There are PCI devices with pretty large non-prefetchable memory, for instance: Memory at 9d80 (64-bit, non-prefetchable) [size=8M] Memory at a680 (64-bit, non-prefetchable) [size=16K] For cold plugged devices this is not a problem, because firmware sets PCI controllers in a way that m

[PATCH 2/3] qemu_validate: Restrict setting @memReserve only to some controllers

2023-12-08 Thread Michal Privoznik
Only two controller models allow setting mem-reserve: pcie-root-port and pci-bridge. Reflect this fact during validation. Signed-off-by: Michal Privoznik --- src/qemu/qemu_validate.c | 25 + 1 file changed, 25 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qem

[PATCH 3/3] qemu_command: Generate mem-reserve for controllers

2023-12-08 Thread Michal Privoznik
Pretty straightforward. Just put mem-reserve attribute whenever it's set. Previous commit ensures it's set only for valid controller models. Resolves: https://issues.redhat.com/browse/RHEL-7461 Signed-off-by: Michal Privoznik --- src/qemu/qemu_command.c| 3 +++ tests/

Re: [PATCH v2 0/9] RFC: Add versioned CPUs to libvirt

2023-12-08 Thread Daniel P . Berrangé
On Thu, Dec 07, 2023 at 04:07:48PM -0600, Jonathon Jongsma wrote: > For SEV-SNP support we will need to be able to specify versioned CPU models > that are not yet available in libvirt. Rather than just adding a versioned CPU > or two that would satisfy that immediate need, I decided to try to add >

Re: [PATCH v2 0/9] RFC: Add versioned CPUs to libvirt

2023-12-08 Thread Jonathon Jongsma
On 12/8/23 5:03 AM, Daniel P. Berrangé wrote: On Thu, Dec 07, 2023 at 04:07:48PM -0600, Jonathon Jongsma wrote: For SEV-SNP support we will need to be able to specify versioned CPU models that are not yet available in libvirt. Rather than just adding a versioned CPU or two that would satisfy tha

Re: [libvirt PATCH v2 01/15] util: properly deal with module vs. driver when binding device to driver

2023-12-08 Thread Laine Stump
On 11/28/23 8:21 AM, Ján Tomko wrote: The commit message is longer than it needs to be and the long explanation actually made it harder to comprehend for me. Well, without *enough* explanation, it all seems like pointlessly pushing bits around :-). I guess my extra explanation failed though,

Re: [libvirt PATCH v2 03/15] conf: move/rename hostdev PCI driver type enum to device_conf.h

2023-12-08 Thread Laine Stump
On 11/27/23 9:41 AM, Peter Krempa wrote: On Mon, Nov 06, 2023 at 02:38:48 -0500, Laine Stump wrote: Currently this enum is defined in domain_conf.h and named virDomainHostdevSubsysPCIDriverType. I want to use it in parts of the network and networkport config, so am moving its definition to devic

[PATCH v2 0/4] Support for dirty-limit live migration

2023-12-08 Thread Hyman Huang
v2: - mark the VIR_MIGRATE_DIRTY_LIMIT flag since 10.0.0 v1: The dirty-limit functionality for live migration was introduced since qemu>=8.1. In the live migration scenario, it implements the force convergence using the dirty-limit approach, which results in better reliable read performance. A s

[PATCH v2 1/4] Add VIR_MIGRATE_DIRTY_LIMIT flag

2023-12-08 Thread Hyman Huang
The flag can be used to enable dirty-limit capability for live migration. Signed-off-by: Hyman Huang --- include/libvirt/libvirt-domain.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index a1902546bb..44af09823c 1006

[PATCH v2 2/4] qemu_migration: Implement VIR_MIGRATE_DIRTY_LIMIT flag

2023-12-08 Thread Hyman Huang
Signed-off-by: Hyman Huang --- src/qemu/qemu_migration.c| 8 src/qemu/qemu_migration.h| 1 + src/qemu/qemu_migration_params.c | 6 ++ src/qemu/qemu_migration_params.h | 1 + 4 files changed, 16 insertions(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migr

[PATCH v2 3/4] virsh: Add support for VIR_MIGRATE_DIRTY_LIMIT flag

2023-12-08 Thread Hyman Huang
Introudce option to enable dirty-limit convergence algorithim during live migration. Signed-off-by: Hyman Huang --- docs/manpages/virsh.rst | 10 +- src/libvirt-domain.c| 8 tools/virsh-domain.c| 10 ++ 3 files changed, 27 insertions(+), 1 deletion(-) diff --gi

[PATCH v2 4/4] NEWS: document support for dirty-limit live migration

2023-12-08 Thread Hyman Huang
Signed-off-by: Hyman Huang --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index dc40602c72..4d1ff489b0 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,14 @@ v10.0.0 (unreleased) * **New features** + * QEMU: Support dirty-limit live migration +