Re: [PATCH v2] Improve error message in remoteGetUNIXSocket

On Thu, Dec 21, 2023 at 03:48:30PM +0100, Martin Kletzander wrote: > By adding a link to an explanation in the kbase. > > Signed-off-by: Martin Kletzander > --- > v2: > - Do not print first socket path > - Add a kbase article explaining the details and solutions > - Add a link to said article >

[PATCH vf-token 1/8] virpci: Define the vf-token extension for PCI device

Define the vf-token extension for PCI device Signed-off-by: Vivek Kashyap --- src/util/virpci.h | 8 1 file changed, 8 insertions(+) diff --git a/src/util/virpci.h b/src/util/virpci.h index bc7cb2329f..da32c2f4d2 100644 --- a/src/util/virpci.h +++ b/src/util/virpci.h @@ -50,6 +50,13 @@

[ PATCH vf-token 0/8] Introduce vf-token when using userspace PF

The VFIO PCI ABI has been extended to require userspace PF driver to set a VF token to a known value. The VF drivers are then required to provide this token to access the VF device. The vf-token is set by the PF driver before VF drivers can access the device. The kernel provides no means to retrie

[PATCH vf-token 2/8] qemu: capabilities: Introduce QEMU_CAPS_VFIO_VFTOKEN

Introduce the vf-token qemu capability Signed-off-by: Vivek Kashyap --- src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 + tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml | 1 +

[PATCH vf-token 3/8] conf: Define PCI address vf-token extension

This patch introduces the PCI address extension flag for vf-token Signed-off-by: Vivek Kashyap --- src/conf/domain_addr.h | 1 + src/qemu/qemu_domain_address.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/conf/domain_addr.h b/src/conf/domain_addr.h index e72fb48847..29e725

[PATCH vf-token 5/8] qemu: Introduce validation for vf-token

Introduce a validation function for vf-token support in qemu and generate vf-token device attribute in qemu command line Signed-off-by: Vivek Kashyap --- src/qemu/qemu_command.c | 8 src/qemu/qemu_validate.c | 20 2 files changed, 28 insertions(+) diff --git a/sr

[PATCH vf-token 4/8] conf: XML parsing and formatting of vf-token

This patch introduces new XML parser/formatter functions for parsing the vf-token Signed-off-by: Vivek Kashyap Signed-off-by: Ciara Loftus --- src/conf/device_conf.c | 49 ++-- src/conf/domain_conf.c | 8 +++ src/libvirt_private.syms | 1 + src/util

[PATCH vf-token 6/8] docs: Update documentation and vf-token schema

Provide information about the vf-token flag Signed-off-by: Vivek Kashyap --- docs/formatdomain.rst | 3 +++ src/conf/schemas/basictypes.rng | 7 +++ 2 files changed, 10 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 310d2bc427..29a7b3145e 100644 ---

[PATCH vf-token 7/8] test: add tests for the vf-token flag

Add tests for the vf-token flag to the qemuxml2argv and qemuxml2xml test suites Signed-off-by: Vivek Kashyap Signed-off-by: Ciara Loftus --- .../hostdev-vfio-vf-token.x86_64-latest.args | 34 .../hostdev-vfio-vf-token.xml | 22 ++ tests/qemuxml2argvtest

[PATCH vf-token 8/8] NEWS: Update news about vf-token

Update news about vf-token Signed-off-by: Vivek Kashyap --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index dc40602c72..5e6a7c3147 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,14 @@ v10.0.0 (unreleased) * **New features** + * qemu: suppor

Re: Re: [libvirt PATCH 4/5] Implement the method of getting host info for loongarch

On Tue, Dec 19, 2023 at 05:23:36PM +0800, lixianglai wrote: > > On Thu, Dec 14, 2023 at 02:08:48PM +0800, xianglai li wrote: > > > +++ b/src/util/virhostcpu.c > > > @@ -579,7 +579,7 @@ virHostCPUParsePhysAddrSize(FILE *cpuinfo, unsigned > > > int *addrsz) > > > char *str; > > >

Re: Re: [libvirt PATCH 5/5] Add bios path for loongarch

On Tue, Dec 19, 2023 at 07:44:02PM +0800, lixianglai wrote: > > On Thu, Dec 14, 2023 at 02:08:49PM +0800, xianglai li wrote: > > The way firmware is configured these days is through firmware > > descriptor files. See src/qemu/qemu_firmware* and tests/qemufirmware* > > for additional information, bu

Re: [PATCH] storage_util: Fix the false condition in virStorageBackendDeviceIsEmpty

On a Wednesday in 2023, Han Han wrote: In virStorageBackendDeviceIsEmpty, the return value for virStorageBackendPARTEDValidLabel is -1 or 0. That makes the later condition 'ret == -2' make always false. Remove the always false condition. Found by Linux Verification Center (portal.linuxtesting.ru

Re: Re: [libvirt PATCH 0/5] add loongarch support for libvirt

On Mon, Dec 18, 2023 at 11:40:03AM +0800, lixianglai wrote: > On Thu, Dec 14, 2023 at 02:08:44PM +0800, xianglai li wrote: > > Great to see that edk2 support has already been mainlined! An > > excellent next step would be to get an edk2-loongarch64 package into > > the various distros... Please con

Re: Re: [libvirt PATCH 3/5] Config some capabilities for loongarch virt machine

On Tue, Dec 19, 2023 at 11:52:03AM +0800, lixianglai wrote: > > So does loongarch actually have ioapic support? Just making sure. I'm > > surprised because apparently no other non-x86 architecture supports > > it... > > Yes, loongarch does have IOAPIC, but this feature has no effect on loongarch >

Re: [ PATCH vf-token 0/8] Introduce vf-token when using userspace PF

On Tue, 2 Jan 2024 18:55:10 +0530 Vivek Kashyap wrote: > The VFIO PCI ABI has been extended to require userspace PF driver to set > a VF token to a known value. The VF drivers are then required to provide > this token to access the VF device. The vf-token is set by the PF driver > before VF dri