I wonder if I can hear any feedback about the change.
# This is my first time to propose a change to libvirt and I appreciate
# any comments in case I made something wrong.
On 2/20/24 15:31, Takashi Kajinami wrote:
This introduces the new "model" field in sev elements so that clients can
check w
On Wed, Mar 27, 2024 at 10:51:05AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:05 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 03/21] hw/usb/hcd-xhci: Remove
> XHCI_FLAG_SS_FIRST flag
> X-Mailer: git-send-email 2.41.0
>
> XHCI_FLAG_SS_FIRST was only u
On Wed, Mar 27, 2024 at 10:51:06AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:06 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 04/21] hw/i386/acpi: Remove
> PCMachineClass::legacy_acpi_table_size
> X-Mailer: git-send-email 2.41.0
>
> PCMachineClass::l
On Wed, Mar 27, 2024 at 10:51:09AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:09 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 07/21] hw/i386/pc: Remove deprecated
> pc-i440fx-2.1 machine
> X-Mailer: git-send-email 2.41.0
>
> The pc-i440fx-2.1 machine
Hi Philippe,
On Wed, Mar 27, 2024 at 10:51:11AM +0100, Philippe Mathieu-Daudé wrote:
[snip]
> diff --git a/hw/i386/fw_cfg.c b/hw/i386/fw_cfg.c
> index d802d2787f..f7c2501161 100644
> --- a/hw/i386/fw_cfg.c
> +++ b/hw/i386/fw_cfg.c
> @@ -63,8 +63,7 @@ void fw_cfg_build_smbios(PCMachineState *pcms
> Since this parameter is always ture, then we can drop it and further
> clean up the static flag "smbios_uuid_encoded" in hw/smbios/smbios.c.
Oops, my email didn't sync up well, the next two patches were doing
just that.
Thanks,
Zhao
___
Devel mailing
On Wed, Mar 27, 2024 at 10:51:12AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:12 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 10/21] hw/smbios: Remove 'uuid_encoded' argument
> from smbios_set_defaults()
> X-Mailer: git-send-email 2.41.0
>
> 'uuid_en
On Wed, Mar 27, 2024 at 10:51:13AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:13 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 11/21] hw/smbios: Remove 'smbios_uuid_encoded',
> simplify smbios_encode_uuid()
> X-Mailer: git-send-email 2.41.0
>
> 'smbio
W dniu 27.03.2024 o 17:54, Philippe Mathieu-Daudé pisze:
diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 7b548519b5..345c35507f 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -208,6 +208,13 @@ is no longer packaged in any distro making it harder
On Wed, Mar 27, 2024 at 10:51:14AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:14 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 12/21] hw/i386/pc: Remove
> PCMachineClass::enforce_aligned_dimm
> X-Mailer: git-send-email 2.41.0
>
> PCMachineClass::enfor
On Wed, Mar 27, 2024 at 10:51:15AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:15 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 13/21] hw/mem/pc-dimm: Remove legacy_align
> argument from pc_dimm_pre_plug()
> X-Mailer: git-send-email 2.41.0
>
> 'legacy_
On Wed, Mar 27, 2024 at 10:51:16AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:16 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 14/21] hw/mem/memory-device: Remove legacy_align
> from memory_device_pre_plug()
> X-Mailer: git-send-email 2.41.0
>
> 'lega
On Wed, Mar 27, 2024 at 10:51:17AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:17 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 15/21] hw/i386/pc: Remove deprecated
> pc-i440fx-2.2 machine
> X-Mailer: git-send-email 2.41.0
>
> The pc-i440fx-2.2 machine
On Wed, Mar 27, 2024 at 10:51:18AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:18 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 16/21] hw/i386/pc: Remove
> PCMachineClass::resizable_acpi_blob
> X-Mailer: git-send-email 2.41.0
>
> PCMachineClass::resiza
On Wed, Mar 27, 2024 at 10:51:19AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:19 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 17/21] hw/i386/pc: Remove
> PCMachineClass::rsdp_in_ram
> X-Mailer: git-send-email 2.41.0
>
> PCMachineClass::rsdp_in_ram wa
On Wed, Mar 27, 2024 at 10:51:20AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:20 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 18/21] hw/i386/acpi: Remove AcpiBuildState::rsdp
> field
> X-Mailer: git-send-email 2.41.0
>
> AcpiBuildState::rsdp is alway
Hi Philippe,
On Wed, Mar 27, 2024 at 10:51:21AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:21 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 19/21] hw/i386/pc: Remove 2.3 and deprecate 2.4
> to 2.7 pc-i440fx machines
> X-Mailer: git-send-email 2.41.0
>
On Wed, Mar 27, 2024 at 10:51:22AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:22 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 20/21] target/i386: Remove
> X86CPU::kvm_no_smi_migration field
> X-Mailer: git-send-email 2.41.0
>
> X86CPU::kvm_no_smi_mig
Hi Philippe,
On Wed, Mar 27, 2024 at 10:51:23AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:23 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 21/21] hw/i386/pc: Replace
> PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE
> X-Mailer: git-send-email 2.4
On Wed, Mar 27, 2024 at 10:51:07AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:07 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 05/21] hw/acpi/ich9: Remove
> 'memory-hotplug-support' property
> X-Mailer: git-send-email 2.41.0
>
> No external code sets
On Wed, Mar 27, 2024 at 10:51:08AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:08 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 06/21] hw/acpi/ich9: Remove dead code related to
> 'acpi_memory_hotplug'
> X-Mailer: git-send-email 2.41.0
>
> acpi_memory_h
On Wed, Mar 27, 2024 at 10:51:10AM +0100, Philippe Mathieu-Daudé wrote:
> Date: Wed, 27 Mar 2024 10:51:10 +0100
> From: Philippe Mathieu-Daudé
> Subject: [PATCH-for-9.1 v2 08/21] target/i386/kvm: Remove
> x86_cpu_change_kvm_default() and 'kvm-cpu.h'
> X-Mailer: git-send-email 2.41.0
>
> x86_cpu_
On Wed, Mar 27, 2024 at 11:55:48AM +0100, Philippe Mathieu-Daudé wrote:
> The whole RDMA subsystem was deprecated in commit e9a54265f5
> ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
> released in v8.2. Time to remove it.
>
> Keep the RAM_SAVE_FLAG_HOOK definition since it might
Vladimir Sementsov-Ogievskiy writes:
> Look at block-job-change command: we have to specify both 'id' to chose
> the job to operate on and 'type' for QAPI union be parsed. But for user
> this looks redundant: when we specify 'id', QEMU should be able to get
> corresponding job's type.
>
> This co
Vladimir Sementsov-Ogievskiy writes:
> We are going to add more parameters to change. We want to make possible
> to change only one or any subset of available options. So all the
> options should be optional.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/mirror.c | 5 +
Subject: all unions are type-based. Perhaps "support implicit union
tags on the wire"?
Do you need this schema language feature for folding block jobs into the
jobs abstraction, or is it just for making the wire protocol nicer in
places?
___
Devel maili
On Thu, Mar 28, 2024 at 07:43:06AM +0100, Thomas Huth wrote:
> On 27/03/2024 11.55, Philippe Mathieu-Daudé wrote:
> > The whole RDMA subsystem was deprecated in commit e9a54265f5
> > ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
> > released in v8.2. Time to remove it.
> >
> > Ke
On 28.03.24 12:40, Markus Armbruster wrote:
Subject: all unions are type-based. Perhaps "support implicit union
tags on the wire"?
Yes, sounds good.
Do you need this schema language feature for folding block jobs into the
jobs abstraction, or is it just for making the wire protocol nicer in
On 28.03.24 12:15, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Look at block-job-change command: we have to specify both 'id' to chose
the job to operate on and 'type' for QAPI union be parsed. But for user
this looks redundant: when we specify 'id', QEMU should be able to ge
On 28.03.24 12:24, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
We are going to add more parameters to change. We want to make possible
to change only one or any subset of available options. So all the
options should be optional.
Signed-off-by: Vladimir Sementsov-Ogievskiy
-
I have just tagged v10.2.0-rc2 in the repository and pushed signed
tarballs to https://download.libvirt.org/
Please give the release candidate some testing and in case you find a
serious issue which should have a fix in the upcoming release, feel
free to reply to this thread to make sure the issue
Hi Zhao,
On 28/3/24 04:44, Zhao Liu wrote:
Hi Philippe,
On Wed, Mar 27, 2024 at 10:51:21AM +0100, Philippe Mathieu-Daudé wrote:
Date: Wed, 27 Mar 2024 10:51:21 +0100
From: Philippe Mathieu-Daudé
Subject: [PATCH-for-9.1 v2 19/21] hw/i386/pc: Remove 2.3 and deprecate 2.4
to 2.7 pc-i440fx mach
On 28/3/24 10:06, Daniel P. Berrangé wrote:
On Wed, Mar 27, 2024 at 11:55:48AM +0100, Philippe Mathieu-Daudé wrote:
The whole RDMA subsystem was deprecated in commit e9a54265f5
("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
released in v8.2. Time to remove it.
Keep the RAM_SAVE
On Thu, Mar 28, 2024 at 01:57:27PM +0100, Philippe Mathieu-Daudé wrote:
> On 28/3/24 10:06, Daniel P. Berrangé wrote:
> > On Wed, Mar 27, 2024 at 11:55:48AM +0100, Philippe Mathieu-Daudé wrote:
> > > The whole RDMA subsystem was deprecated in commit e9a54265f5
> > > ("hw/rdma: Deprecate the pvrdma
Since v1:
- split in 3 (Thomas)
- justify gluster removal
Philippe Mathieu-Daudé (3):
hw/rdma: Remove pvrdma device and rdmacm-mux helper
migration: Remove RDMA protocol handling
block/gluster: Remove RDMA protocol handling
MAINTAINERS | 17 -
docs/about
GlusterFS+RDMA has been deprecated 8 years ago in commit
0552ff2465 ("block/gluster: deprecate rdma support"):
gluster volfile server fetch happens through unix and/or tcp,
it doesn't support volfile fetch over rdma. The rdma code may
actually mislead, so to make sure things do not break, fo
Upcoming patches will require that possibly multiple occurences of the
string to drop are present in the output string thus we need to adapt
testFilterLine to handle them.
Additionally we drop the unused return value.
Signed-off-by: Peter Krempa
---
tests/virshtest.c | 23 +++---
Add support for reading a file and passing it to virsh in 'batch' mode
so that multiple commands can be easily tested with one invocation of
virsh.
To show how it's used adapt the alias handling tests to be invoked all
at once.
As in batch mode the arguments are read from a string and separated
i
Optimize invocation of the tests to share one 'virsh' binary as they
don't influence each other.
Signed-off-by: Peter Krempa
---
tests/virshtest.c | 11 +--
tests/virshtestdata/echo-split.in | 5 +
tests/virshtestdata/echo-split.out | 24
3
Both argument passing and multiple command handling is already tested in
the 'multiple commands' cases.
Signed-off-by: Peter Krempa
---
tests/virshtest.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/tests/virshtest.c b/tests/virshtest.c
index 51314859b9..a60cfdf7a0 100644
--- a
Part 3 was supposed to be the refactor of the command parser but since
I wanted to add few tests I've noticed that there's a lot of old cruft
and many tests are skipped.
This series refactors virshtest and optimizes it to run multiple
commands with one virsh instance. Doing this allows us to do mo
Express what's possible via a "virsh script" rather than invoking
separate virsh for each one.
We need to keep a few for parity as the argument parser behaves
differently when processing argv-like input compared to a string.
Signed-off-by: Peter Krempa
---
tests/virshtest.c
Embedding the expected output in a C source code makes it very hard to
extend tests. In order to be able to test the outputs against data in
files on disk we need better naming of the tests themselves.
Use virTestCounterNext/Reset with appropriate tags to give reasonable
names to the 'virsh echo'
Managing output files is much simpler especially with
VIR_TEST_REGENERATE_OUTPUT compared to putting the expected string blobs
into the C source file.
For now the output is tested both against the hardcoded strings as well
as the output files.
Signed-off-by: Peter Krempa
---
tests/virshtest.c
s/vrishtest/virshtest/ in the summary
Jano
On a Thursday in 2024, Peter Krempa wrote:
Embedding the expected output in a C source code makes it very hard to
extend tests. In order to be able to test the outputs against data in
files on disk we need better naming of the tests themselves.
Use vi
On a Thursday in 2024, Peter Krempa wrote:
Part 3 was supposed to be the refactor of the command parser but since
I wanted to add few tests I've noticed that there's a lot of old cruft
and many tests are skipped.
This series refactors virshtest and optimizes it to run multiple
commands with one
On 27/03/2024 07:09, Gerd Hoffmann wrote:
On Tue, Mar 26, 2024 at 01:30:48PM +, Mark Cave-Ayland wrote:
Heh I've actually been using isapc over the past couple of weeks to fire up
some old programs in a Windows 3 VM :)
I'm wondering why these use cases can't simply use the 'pc' machine
ty
Philippe Mathieu-Daudé writes:
> The whole RDMA subsystem was deprecated in commit e9a54265f5
> ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
> released in v8.2.
>
> Remove:
> - RDMA handling from migration
> - dependencies on libibumad, libibverbs and librdmacm
>
> Keep the R
On a Wednesday in 2024, Marc Hartmayer wrote:
Make sure the old value in `scsi_target->wwpn` is free'd before replacing it.
While at it, simplify the code.
"While at it" usually means it should have been a separate commit,
especially if the simplification changes the behavior of the code.
==
On a Wednesday in 2024, Marc Hartmayer wrote:
I'm not familiar with the code so I cannot decide if ignoring the return values
is a bug or not. At least, it looks awkward and should be annotated.
Adding error reporting after years of real-world usage can be tricky (as
evidenced by the VPD error
On Thu, Mar 28, 2024 at 11:18:04AM -0300, Fabiano Rosas wrote:
> Philippe Mathieu-Daudé writes:
>
> > The whole RDMA subsystem was deprecated in commit e9a54265f5
> > ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
> > released in v8.2.
> >
> > Remove:
> > - RDMA handling from mi
On 27/03/2024 16:54, Philippe Mathieu-Daudé wrote:
Per Daniel suggestion [*]:
> isapc could arguably be restricted to just 32-bit CPU models,
> because we should not need it to support any feature that didn't
> exist prior to circa 1995. eg refuse to start with isapc, if 'lm'
> is prese
On Wed, Mar 27, 2024 at 05:54:56PM +0100, Philippe Mathieu-Daudé wrote:
> Per Daniel suggestion [*]:
>
> > isapc could arguably be restricted to just 32-bit CPU models,
> > because we should not need it to support any feature that didn't
> > exist prior to circa 1995. eg refuse to start with is
On 28/03/2024 16.01, Peter Xu wrote:
On Thu, Mar 28, 2024 at 11:18:04AM -0300, Fabiano Rosas wrote:
Philippe Mathieu-Daudé writes:
The whole RDMA subsystem was deprecated in commit e9a54265f5
("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
released in v8.2.
Remove:
- RDMA h
On 28/03/2024 16.12, Mark Cave-Ayland wrote:
On 27/03/2024 16:54, Philippe Mathieu-Daudé wrote:
Per Daniel suggestion [*]:
> isapc could arguably be restricted to just 32-bit CPU models,
> because we should not need it to support any feature that didn't
> exist prior to circa 1995. eg re
On Thu, Mar 28, 2024 at 03:55 PM +0100, Ján Tomko wrote:
> On a Wednesday in 2024, Marc Hartmayer wrote:
>>Make sure the old value in `scsi_target->wwpn` is free'd before replacing it.
>>While at it, simplify the code.
>>
>
> "While at it" usually means it should have been a separate commit,
> esp
On Thu, Mar 28, 2024 at 04:00 PM +0100, Ján Tomko wrote:
> On a Wednesday in 2024, Marc Hartmayer wrote:
>>I'm not familiar with the code so I cannot decide if ignoring the return
>>values
>>is a bug or not. At least, it looks awkward and should be annotated.
>>
>
> Adding error reporting after y
On 28/03/2024 14.02, Philippe Mathieu-Daudé wrote:
The whole RDMA subsystem was deprecated in commit e9a54265f5
("hw/rdma: Deprecate the pvrdma device and the rdma subsystem")
released in v8.2.
Remove:
- PVRDMA device
- generated vmw_pvrdma/ directory from linux-headers
- rdmacm-mux tool f
On 28/03/2024 14.02, Philippe Mathieu-Daudé wrote:
GlusterFS+RDMA has been deprecated 8 years ago in commit
0552ff2465 ("block/gluster: deprecate rdma support"):
gluster volfile server fetch happens through unix and/or tcp,
it doesn't support volfile fetch over rdma. The rdma code may
a
On Thu, Mar 28, 2024 at 04:22:27PM +0100, Thomas Huth wrote:
> Since e9a54265f5 was not very clear about rdma migration code, should we
> maybe rather add a separate deprecation note for the migration part, and add
> a proper warning message to the migration code in case someone tries to use
> it t
On 3/27/24 1:14 PM, Marc Hartmayer wrote:
On Wed, Mar 27, 2024 at 10:53 AM -0500, Jonathon Jongsma
wrote:
On 3/20/24 10:46 AM, Boris Fiuczynski wrote:
When an udev add event occurs the mdev active config data requires an
update via mdevctl as the udev does not contain all config data.
This up
61 matches
Mail list logo
