Re: [PATCH RFC v2 01/12] config: Introduce ThrottleGroup and ThrottleFilter

2024-05-03 Thread Peter Krempa
On Thu, Apr 11, 2024 at 19:01:49 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > * Define new structs 'virDomainThrottleGroupDef' and > 'virDomainThrottleFilterDef' > * Update _virDomainDef to include virDomainThrottleGroupDef > * Update _virDomainDiskDef to include virDomainThrottleFi

Re: [PATCH RFC v2 02/12] qemu: monitor: Add support for ThrottleGroup operations

2024-05-03 Thread Peter Krempa
On Thu, Apr 11, 2024 at 19:01:50 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > * ThrottleGroup is updated through "qemuMonitorJSONUpdateThrottleGroup" > * ThrottleGroup is retrieved through "qemuMonitorJSONGetThrottleGroup" > * ThrottleGroup is deleted by reusing "qemuMonitorDelObject

Re: [PATCH RFC v2 02/12] qemu: monitor: Add support for ThrottleGroup operations

2024-05-03 Thread Peter Krempa
On Thu, Apr 11, 2024 at 19:01:50 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > * ThrottleGroup is updated through "qemuMonitorJSONUpdateThrottleGroup" > * ThrottleGroup is retrieved through "qemuMonitorJSONGetThrottleGroup" > * ThrottleGroup is deleted by reusing "qemuMonitorDelObject

Re: [PATCH RFC v2 09/12] tests: Test qemuMonitorJSONGetThrottleGroup and qemuMonitorJSONUpdateThrottleGroup

2024-05-03 Thread Peter Krempa
On Thu, Apr 11, 2024 at 19:01:57 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > Within "testQemuMonitorJSONqemuMonitorJSONUpdateThrottleGroup" > * Test qemuMonitorJSONGetThrottleGroup > * Test qemuMonitorJSONUpdateThrottleGroup, which updates limits through > "qom-set" > > Signed-off

Re: [PATCH RFC v2 03/12] remote: New APIs for ThrottleGroup lifecycle management

2024-05-03 Thread Peter Krempa
On Thu, Apr 11, 2024 at 19:01:51 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > Support throttlegroup lifecycle management by the following implementation: > * New methods defined in "include/libvirt/libvirt-domain.h" > * And they're exported in "src/libvirt_public.syms" > * Correspond

Re: [PATCH RFC v2 01/12] config: Introduce ThrottleGroup and ThrottleFilter

2024-05-03 Thread Peter Krempa
On Thu, Apr 11, 2024 at 19:01:49 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > * Define new structs 'virDomainThrottleGroupDef' and > 'virDomainThrottleFilterDef' > * Update _virDomainDef to include virDomainThrottleGroupDef > * Update _virDomainDiskDef to include virDomainThrottleFi

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-03 Thread Jinpu Wang via Devel
Hi Michael, Hi Peter, On Thu, May 2, 2024 at 3:23 PM Michael Galaxy wrote: > > Yu Zhang / Jinpu, > > Any possibility (at your lesiure, and within the disclosure rules of > your company, IONOS) if you could share any of your performance > information to educate the group? > > NICs have indeed cha

Re: [PATCH v3 3/6] migration: Remove 'blk/-b' option from migrate commands

2024-05-03 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Fabiano Rosas writes: > > > The block migration is considered obsolete and has been deprecated in > > 8.2. Remove the migrate command option that enables it. This only > > affects the QMP and HMP commands, the feature can still be accessed by > > s

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-03 Thread Jinpu Wang via Devel
Hi Peter On Thu, May 2, 2024 at 6:20 PM Peter Xu wrote: > > On Thu, May 02, 2024 at 03:30:58PM +0200, Jinpu Wang wrote: > > Hi Michael, Hi Peter, > > > > > > On Thu, May 2, 2024 at 3:23 PM Michael Galaxy wrote: > > > > > > Yu Zhang / Jinpu, > > > > > > Any possibility (at your lesiure, and withi

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-03 Thread Jinpu Wang via Devel
Hi Daniel, On Wed, May 1, 2024 at 6:00 PM Daniel P. Berrangé wrote: > > On Wed, May 01, 2024 at 11:31:13AM -0400, Peter Xu wrote: > > What I worry more is whether this is really what we want to keep rdma in > > qemu, and that's also why I was trying to request for some serious > > performance mea

[PATCH] hyperv: prevent potential NULL dereference

2024-05-03 Thread Oleg Sviridov
Return value of a function 'virDomainChrDefNew' is dereferenced at hyperv_driver.c without checking for NULL, which can lead to NULL dereference immediatly after. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Oleg Sviridov --- src/hyperv/hyperv_driver.c | 3 ++

[PATCH] NEWS: document qemu: ras as a new feature

2024-05-03 Thread Kristina Hanicova
Signed-off-by: Kristina Hanicova --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 5a771b4b2f..d72c15bf10 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,11 @@ v10.4.0 (unreleased) * **New features** + * qemu: Support for ras feature for virt

Re: [PATCH RFC v2 04/12] qemu: Implement qemu driver for throttle API

2024-05-03 Thread Peter Krempa
On Thu, Apr 11, 2024 at 19:01:52 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > Implement the following methods: > * virDomainSetThrottleGroup > * virDomainGetThrottleGroup > * virDomainDelThrottleGroup Similarly to previous patch, note how you've done this rather than what you've don

Re: [PATCH] hyperv: prevent potential NULL dereference

2024-05-03 Thread Kristina Hanicova
On Fri, May 3, 2024 at 11:43 AM Oleg Sviridov wrote: > Return value of a function 'virDomainChrDefNew' is dereferenced > at hyperv_driver.c without checking for NULL, which can lead to > NULL dereference immediatly after. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > S

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-03 Thread Peter Xu
On Fri, May 03, 2024 at 08:40:03AM +0200, Jinpu Wang wrote: > I had a brief check in the rsocket changelog, there seems some > improvement over time, > might be worth revisiting this. due to socket abstraction, we can't > use some feature like > ODP, it won't be a small and easy task. It'll be g

Re: [PATCH RFC v2 05/12] qemu: hotplug: Support hot attach block disk along with throttle filters

2024-05-03 Thread Peter Krempa
On Thu, Apr 11, 2024 at 19:01:53 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > When attaching disk along with specified throttle groups, those groups will > be chained up by parent node name, this change includes service side codes: > * Each filter references one throttle group by gr

Re: [PATCH RFC v2 06/12] qemu: command: Support throttle groups and filters during qemuProcessLaunch

2024-05-03 Thread Peter Krempa
On Thu, Apr 11, 2024 at 19:01:54 -0700, w...@linux.ibm.com wrote: > From: Chun Feng Wu > > * Add qemuBuildThrottleGroupCommandLine in qemuBuildCommandLine > * Add qemuBuildThrottleFiltersCommandLine in qemuBuildDiskCommandLine > * Make sure referenced throttle group exists > > Signed-off-by: Chu

The Raptors defeated the Warriors

2024-05-03 Thread n3x4pmgf--- via Devel
If The watch solutions feel mind-boggling, it may help to narrow your focus. Probably you merely want to know you’re finding something from a revered brand you could have faith in. https://www.newzealandescortspage.com ___ Devel mailing list -- devel@li

[PATCH] vsh: Don't init history in cmdComplete()

2024-05-03 Thread Michal Privoznik
Recent rework of virshtest uncovered a subtle bug that was dormant in now vsh but before that even in monolithic virsh. In vsh.c there's this vshReadlineInit() function that's supposed to initialize readline library, i.e. set those global rl_* pointers. But it also initializes history library. Th