Re: [libvirt PATCH 01/20] tests: json: relax some test cases

2024-08-15 Thread Peter Krempa
On Wed, Aug 14, 2024 at 23:40:16 +0200, Ján Tomko wrote: > Some JSON parsers do not like bare types outside of objects or arrays > or do validation of object key uniqueness. > > Signed-off-by: Ján Tomko > --- > tests/virjsontest.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-)

Re: [libvirt PATCH 02/20] ci: update OpenSUSE Leap to 15.6

2024-08-15 Thread Peter Krempa
On Wed, Aug 14, 2024 at 23:40:17 +0200, Ján Tomko wrote: > It was released on June 12, 2024. > > The update means we no longer have to care about json-c 0.13 > present in Leap 15.5, which solves some whitespace issues in > tests. > > Signed-off-by: Ján Tomko > --- > ci/containers/opensuse-leap-

Re: [libvirt PATCH 03/20] util: json: introduce virJSONStringPrettifyBlanks

2024-08-15 Thread Peter Krempa
On Wed, Aug 14, 2024 at 23:40:18 +0200, Ján Tomko wrote: > A horribly named function for unifying formatting when pretty-printing > empty JSON arrays and objects. Useful for having stable test output > even if different JSON libraries format these differently. > > Signed-off-by: Ján Tomko > --- >

Re: [libvirt PATCH 04/20] tests: switch to compact empty JSON object formatting

2024-08-15 Thread Peter Krempa
On Wed, Aug 14, 2024 at 23:40:19 +0200, Ján Tomko wrote: > Some earlier versions of json-c format empty elements differently. > Run the tests who use the pretty formatting for readability and > diffability through a function that unifies the output. Hmm so for test/output stability IMO it'd be bet

[PATCH 0/2] Add support for new hv enlightenments

2024-08-15 Thread Tim Wiederhake
Both were added in qemu 7.10. Add support for libvirt. Note that the feature names use dashes in qemu but underscores in libvirt domain conf xml to match other hv features, e.g. "vendor_id". Tim Wiederhake (2): hyperv: Support hv-emsr-bitmap enlightenment hyperv: Support hv-xmm-input enlighte

[PATCH 1/2] hyperv: Support hv-emsr-bitmap enlightenment

2024-08-15 Thread Tim Wiederhake
qemu supports this enlightenment since version 7.10. >From the qemu commit: The newly introduced enlightenment allow L0 (KVM) and L1 (Hyper-V) hypervisors to collaborate to avoid unnecessary updates to L2 MSR-Bitmap upon vmexits. Signed-off-by: Tim Wiederhake --- docs/formatdomain.r

[PATCH 2/2] hyperv: Support hv-xmm-input enlightenment

2024-08-15 Thread Tim Wiederhake
qemu supports this enlightenment since version 7.10. >From the qemu commit: Hyper-V specification allows to pass parameters for certain hypercalls using XMM registers ("XMM Fast Hypercall Input"). When the feature is in use, it allows for faster hypercalls processing as KVM can avoid

Re: [PATCH v2 1/4] qemu.conf changes to support multiple memory backend

2024-08-15 Thread Michael Galaxy via Devel
Hi Martin, On 8/7/24 10:10, Michael Galaxy wrote: Hi, Answers below On 8/7/24 08:23, Martin Kletzander wrote: On Tue, Aug 06, 2024 at 03:45:54PM -0500, Michael Galaxy wrote: Thank you so much for the detailed comments. I'll work on those. I believe you had a couple questions below on th

[PATCH v3 0/4] multiple memory backend support for CPR Live Updates

2024-08-15 Thread Michael Galaxy via Devel
From: Michael Galaxy CPR-based support for whole-hypervisor kexec-based live updates is now finally merged into QEMU. In support of this, we need NUMA to be supported in these kinds of environments. To do this we use a technology called PMEM (persistent memory) in Linux, which underpins the abili

[PATCH v3 3/4] Update configuration file documentation to support multiple memory backends

2024-08-15 Thread Michael Galaxy via Devel
From: Michael Galaxy Signed-off-by: Michael Galaxy --- docs/kbase/virtiofs.rst | 2 ++ src/qemu/qemu.conf.in | 4 2 files changed, 6 insertions(+) diff --git a/docs/kbase/virtiofs.rst b/docs/kbase/virtiofs.rst index 457c15da7f..931ba96104 100644 --- a/docs/kbase/virtiofs.rst +++ b/docs/

[PATCH v3 2/4] Support live migration between file-backed memory and anonymous memory.

2024-08-15 Thread Michael Galaxy via Devel
From: Michael Galaxy In our environment, we need to convert VMs into a live-update-comptabile configuration "on-the-fly" (via live migration). More specifically: We need to convert between anonymous memory-backed VMs and file-backed memory VMs. So, for this very specific case, this needs to work

[PATCH v3 1/4] qemu.conf changes to support multiple memory backend

2024-08-15 Thread Michael Galaxy via Devel
From: Michael Galaxy We start by introducing a backwards-compatible, comma-separated specification that will not break existing installations, such as in the following example: $ cat qemu.conf | grep memory_backing_dir memory_backing_dir = ["/path/to/pmem/0", "/path/to/pmem/1"] (The old syntax

[PATCH v3 4/4] Add NEWS item for multiple memory backend support

2024-08-15 Thread Michael Galaxy via Devel
From: Michael Galaxy Signed-off-by: Michael Galaxy --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index bbd30ab3b5..c546f0757a 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -25,6 +25,14 @@ v10.7.0 (unreleased) backed network devices. So, create new n

Re: [PATCH RFC v3 09/16] qemu: hotplug: Support hot attach and detach block disk along with throttle filters

2024-08-15 Thread Chun Feng Wu
On 2024/8/15 13:04, Chun Feng Wu wrote: On 2024/8/9 22:04, Peter Krempa wrote: On Wed, Jun 12, 2024 at 03:02:17 -0700,w...@linux.ibm.com  wrote: From: Chun Feng Wu When attaching disk along with specified throttle groups, those groups will be chained up by parent node name, this change inc