Re: [PATCH] NEWS: Mention documention improvements of image format settings

2024-10-10 Thread Martin Kletzander
On Wed, Oct 09, 2024 at 02:21:55PM -0600, Jim Fehlig via Devel wrote: Signed-off-by: Jim Fehlig Reviewed-by: Martin Kletzander --- Although small, the change seems NEWS noteworthy. NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 7f4f33c8f8..dd

Re: [PATCH V3] libxl: Reject VM config referencing nwfilters

2024-10-10 Thread Martin Kletzander
On Tue, Oct 08, 2024 at 03:49:00PM -0600, Jim Fehlig via Devel wrote: The Xen libxl driver does not support nwfilter. Introduce a deviceValidateCallback function with a check for nwfilters, returning VIR_ERR_CONFIG_UNSUPPORTED if any are found. Also fail to start any existing VMs referencing nwfi

Re: [PATCH] network: inhibit idle timeout of daemon if there are any active networks

2024-10-10 Thread Daniel P . Berrangé
On Tue, Oct 08, 2024 at 10:57:53AM -0400, Laine Stump wrote: > When the daemons were split out from the monolithic libvirtd, the > network driver didn't implement "inhibit idle timeout if there are any > active objects" as was done for other drivers, so virtnetworkd would > always exit after 120 se

Re: [PATCH 17/20] include: Define constants for parallel save/restore

2024-10-10 Thread Daniel P . Berrangé
On Thu, Aug 08, 2024 at 05:38:10PM -0600, Jim Fehlig via Devel wrote: > From: Claudio Fontana > > Add a new VIR_DOMAIN_SAVE_PARALLEL flag to the save and restore > APIs, which can be used to specify the use of multiple, parallel > channels for saving a domain. The number of parallel channels > ca

Re: [PATCH 10/20] qemu: Add support for mapped-ram on save

2024-10-10 Thread Daniel P . Berrangé
On Thu, Aug 08, 2024 at 05:38:03PM -0600, Jim Fehlig via Devel wrote: > Introduce support for QEMU's new mapped-ram stream format [1]. > mapped-ram is enabled by default if the underlying QEMU advertises > the mapped-ram migration capability. It can be disabled by changing > the 'save_image_version

Re: [PATCH] network: inhibit idle timeout of daemon if there are any active networks

2024-10-10 Thread Martin Kletzander
On Tue, Oct 08, 2024 at 10:57:53AM -0400, Laine Stump wrote: When the daemons were split out from the monolithic libvirtd, the network driver didn't implement "inhibit idle timeout if there are any active objects" as was done for other drivers, so virtnetworkd would always exit after 120 seconds

Re: [PATCH 07/20] qemu: QEMU_SAVE_VERSION: Bump to version 3

2024-10-10 Thread Daniel P . Berrangé
On Thu, Aug 08, 2024 at 05:38:00PM -0600, Jim Fehlig via Devel wrote: > QEMU's new mapped-ram stream format [1] is incompatible with the existing > sequential stream format. An older libvirt+QEMU that does not support > mapped-ram must not attempt to restore a mapped-ram saved image. Currently > th

Re: [PATCH 08/20] qemu: conf: Add setting for save image version

2024-10-10 Thread Daniel P . Berrangé
On Thu, Aug 08, 2024 at 05:38:01PM -0600, Jim Fehlig via Devel wrote: > Add a 'save_image_version' setting to qemu.conf to control the image > version when saving a VM with 'virsh save' or 'virsh managedsave'. > Default to the new version 3. > > Signed-off-by: Jim Fehlig > --- > src/qemu/libvirt

Re: [PATCH 07/20] qemu: QEMU_SAVE_VERSION: Bump to version 3

2024-10-10 Thread Daniel P . Berrangé
On Thu, Oct 10, 2024 at 02:06:47PM +0100, Daniel P. Berrangé wrote: > On Thu, Aug 08, 2024 at 05:38:00PM -0600, Jim Fehlig via Devel wrote: > > QEMU's new mapped-ram stream format [1] is incompatible with the existing > > sequential stream format. An older libvirt+QEMU that does not support > > map

Re: [PATCH V2 1/2] qemu: conf: Improve the foo_image_format setting descriptions

2024-10-10 Thread Martin Kletzander
On Tue, Oct 08, 2024 at 11:25:29AM -0600, Jim Fehlig wrote: On 10/2/24 02:37, Martin Kletzander wrote: On Fri, Aug 16, 2024 at 04:25:25PM -0600, Jim Fehlig via Devel wrote: The current description of the various foo_image_format settings can be construded to imply the setting is only used to co

Re: [PATCH 01/20] lib: virDomainSaveParams: Ensure absolute save path

2024-10-10 Thread Daniel P . Berrangé
On Thu, Aug 08, 2024 at 05:37:54PM -0600, Jim Fehlig via Devel wrote: > When invoking virDomainSaveParams with a relative path, the image > is saved to the daemon's CWD, which in most cases is '/'. Ensure > a relative path is converted to absolute before invoking the > driver 'domainSaveParams' fun

Re: [PATCH 02/20] qemu_fd: Add function to retrieve fdset ID

2024-10-10 Thread Daniel P . Berrangé
On Thu, Aug 08, 2024 at 05:37:55PM -0600, Jim Fehlig via Devel wrote: > Add new function qemuFDPassGetId() for retrieving the fdset ID > of provided qemuFDPass object. > > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_fd.c | 18 ++ > src/qemu/qemu_fd.h | 3 +++ > 2 files chang

Re: [PATCH 03/20] qemu: Add function to check capability in migration params

2024-10-10 Thread Daniel P . Berrangé
On Thu, Aug 08, 2024 at 05:37:56PM -0600, Jim Fehlig via Devel wrote: > Add new function qemuMigrationParamsCapEnabled() to check if a > capability is set in the caller-provided migration parameters. > > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_migration_params.c | 16 >

Re: [PATCH 04/20] qemu: Add function to get bool value from migration params

2024-10-10 Thread Daniel P . Berrangé
On Thu, Aug 08, 2024 at 05:37:57PM -0600, Jim Fehlig via Devel wrote: > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_migration_params.c | 18 ++ > src/qemu/qemu_migration_params.h | 5 + > 2 files changed, 23 insertions(+) Reviewed-by: Daniel P. Berrangé With regards,

Re: [PATCH 05/20] qemu: Add mapped-ram migration capability

2024-10-10 Thread Daniel P . Berrangé
On Thu, Aug 08, 2024 at 05:37:58PM -0600, Jim Fehlig via Devel wrote: > Add the mapped-ram migration capability introduced in QEMU 9.0. > > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_migration_params.c | 1 + > src/qemu/qemu_migration_params.h | 1 + > 2 files changed, 2 insertions(+) Revi

Re: [PATCH 06/20] qemu: Add function to get migration params for save

2024-10-10 Thread Daniel P . Berrangé
On Thu, Aug 08, 2024 at 05:37:59PM -0600, Jim Fehlig via Devel wrote: > Introduce qemuMigrationParamsForSave() to create a > qemuMigrationParams object initialized with appropriate migration > capabilities and parameters for a save operation. > > Note that mapped-ram capability also requires the m

Re: [PATCH 19/20] tools: add parallel parameter to virsh save command

2024-10-10 Thread Daniel P . Berrangé
On Thu, Aug 08, 2024 at 05:38:12PM -0600, Jim Fehlig via Devel wrote: > From: Li Zhang > > Signed-off-by: Claudio Fontana > Signed-off-by: Jim Fehlig > --- > tools/virsh-domain.c | 41 + > 1 file changed, 37 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH 18/20] qemu: Add support for parallel save and restore

2024-10-10 Thread Daniel P . Berrangé
On Thu, Aug 08, 2024 at 05:38:11PM -0600, Jim Fehlig via Devel wrote: > Add support for parallel save and restore by mapping libvirt's > "parallel-connections" parameter to QEMU's "multifd-channels" > migration parameter. > > Signed-off-by: Jim Fehlig > --- > src/qemu/qemu_driver.c | 3

Re: [PATCH] lxc: fix variable storage order before call

2024-10-10 Thread Jiri Denemark
On Thu, Oct 10, 2024 at 11:18:50 +0200, Adam Julis wrote: > virDomainConfNWFilterInstantiate() was called without updated > net->ifname, it caused in some cases throwing error message. If > function failed, change is reverted. > > Resolves: https://gitlab.com/libvirt/libvirt/-/issues/658 > Signed-

[PATCH] lxc: fix variable storage order before call

2024-10-10 Thread Adam Julis
virDomainConfNWFilterInstantiate() was called without updated net->ifname, it caused in some cases throwing error message. If function failed, change is reverted. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/658 Signed-off-by: Adam Julis --- src/lxc/lxc_process.c | 15 ++- 1

Re: [PATCH 2/2] NEWS: mention zero detection for non-shared-storage migration

2024-10-10 Thread Ján Tomko
On a Thursday in 2024, Peter Krempa wrote: Signed-off-by: Peter Krempa --- NEWS.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 7f4f33c8f8..7a4a0e1d1f 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,17 @@ v10.9.0 (unreleased) * **New features** +

Re: [PATCH 10/20] qemu: Add support for mapped-ram on save

2024-10-10 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Thu, Aug 08, 2024 at 05:38:03PM -0600, Jim Fehlig via Devel wrote: >> Introduce support for QEMU's new mapped-ram stream format [1]. >> mapped-ram is enabled by default if the underlying QEMU advertises >> the mapped-ram migration capability. It can be disabled by

Re: [PATCH 10/20] qemu: Add support for mapped-ram on save

2024-10-10 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Thu, Oct 10, 2024 at 12:06:51PM -0300, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Aug 08, 2024 at 05:38:03PM -0600, Jim Fehlig via Devel wrote: >> >> Introduce support for QEMU's new mapped-ram stream format [1]. >> >> mapped-ram is enable

Re: [PATCH v2] chardev: introduce 'reconnect-ms' and deprecate 'reconnect'

2024-10-10 Thread Marc-André Lureau
Hi Vladimir On Mon, Sep 30, 2024 at 5:17 PM Vladimir Sementsov-Ogievskiy < vsement...@yandex-team.ru> wrote: > Hi Mark-Andre! > > Could you please take a look? We have collected acks for QAPI changes, > could this be queued? > > While writing to 9.2 changelog, I realize that we should probably ha

[PATCH 1/2] docs: Add warning about using a cleared image with VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES_ZEROES

2024-10-10 Thread Peter Krempa
The migration parameter causes zero detection to be enabled and zero blocks are *not* transferred to the destination. This means that users must provide pre-cleared images that read all zero, otherwise the non-zero blocks on destination which reside in places where the source has zero blocks would

[PATCH 2/2] NEWS: mention zero detection for non-shared-storage migration

2024-10-10 Thread Peter Krempa
Signed-off-by: Peter Krempa --- NEWS.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 7f4f33c8f8..7a4a0e1d1f 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,17 @@ v10.9.0 (unreleased) * **New features** + * qemu: zero block detection for non-sha

[PATCH 0/2] qemu: mention caveat with zero detection during migration and add NEWS

2024-10-10 Thread Peter Krempa
Peter Krempa (2): docs: Add warning about using a cleared image with VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES_ZEROES NEWS: mention zero detection for non-shared-storage migration NEWS.rst | 11 +++ docs/manpages/virsh.rst | 4 +++- include/li

Re: [PATCH 0/2] qemu: mention caveat with zero detection during migration and add NEWS

2024-10-10 Thread Jiri Denemark
On Thu, Oct 10, 2024 at 10:38:42 +0200, Peter Krempa wrote: > Peter Krempa (2): > docs: Add warning about using a cleared image with > VIR_MIGRATE_PARAM_MIGRATE_DISKS_DETECT_ZEROES_ZEROES > NEWS: mention zero detection for non-shared-storage migration > > NEWS.rst

Re: [PATCH 10/20] qemu: Add support for mapped-ram on save

2024-10-10 Thread Daniel P . Berrangé
On Thu, Oct 10, 2024 at 12:06:51PM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Thu, Aug 08, 2024 at 05:38:03PM -0600, Jim Fehlig via Devel wrote: > >> Introduce support for QEMU's new mapped-ram stream format [1]. > >> mapped-ram is enabled by default if the underlying QEMU

Re: [PATCH] network: inhibit idle timeout of daemon if there are any active networks

2024-10-10 Thread Laine Stump
On 10/10/24 7:48 AM, Martin Kletzander wrote: On Tue, Oct 08, 2024 at 10:57:53AM -0400, Laine Stump wrote: When the daemons were split out from the monolithic libvirtd, the network driver didn't implement "inhibit idle timeout if there are any active objects" as was done for other drivers, so vi

Re: [PATCH 07/20] qemu: QEMU_SAVE_VERSION: Bump to version 3

2024-10-10 Thread Jim Fehlig via Devel
On 10/10/24 07:06, Daniel P. Berrangé wrote: On Thu, Aug 08, 2024 at 05:38:00PM -0600, Jim Fehlig via Devel wrote: QEMU's new mapped-ram stream format [1] is incompatible with the existing sequential stream format. An older libvirt+QEMU that does not support mapped-ram must not attempt to restor