Re: [libvirt PATCH] ci: refresh with latest 'lcitool manifest'

2025-02-03 Thread Andrea Bolognani
On Mon, Feb 03, 2025 at 07:07:36PM +0100, Pavel Hrdina wrote: > Fedora and Alpine updated to latest versions. Technically the latest version of Alpine is 3.21, we just haven't updated lcitool to support it yet ;) > -.fedora-39-upstream-qemu-tests: > +.fedora-41-upstream-qemu-tests: >extends:

Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

2025-02-03 Thread Philippe Mathieu-Daudé
On 3/2/25 15:50, Daniel P. Berrangé wrote: On Mon, Feb 03, 2025 at 02:45:06PM +, Peter Maydell wrote: On Mon, 3 Feb 2025 at 14:33, Daniel P. Berrangé wrote: On Mon, Feb 03, 2025 at 02:29:49PM +, Alex Bennée wrote: Peter Maydell writes: On Sat, 1 Feb 2025 at 12:57, BALATON Zoltan

[PATCH v2 00/12] hw/arm/raspi: Allow creating any Raspberry Pi machine

2025-02-03 Thread Philippe Mathieu-Daudé
Full rewrite of v1 [1], addressing Zoltan & Peter suggestion. Introduce a generic 'raspi' machine, which takes a 'model' and 'revision' properties, and any memory size. The 'board_rev' register is filled appropriately. Before, merge raspi4b.c within raspi.c (more is planned here with the MPCore r

[PATCH v2 02/12] hw/arm/raspi: Merge model 4B with other models

2025-02-03 Thread Philippe Mathieu-Daudé
Except we alter the device tree blob, the 4B is just another raspi model. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 114 - hw/arm/raspi4b.c | 136 - hw/arm/meson.build | 2 +- 3 files changed

[PATCH v2 01/12] hw/arm/raspi: Access SoC parent object using BCM283X_BASE() macro

2025-02-03 Thread Philippe Mathieu-Daudé
We shouldn't access a QOM parent object directly. Use the appropriate type-cast macro. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 2 +- hw/arm/raspi4b.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index a7a662f40db..508

[PATCH v2 03/12] hw/arm/raspi: Unify RASPI_MACHINE types

2025-02-03 Thread Philippe Mathieu-Daudé
Merge Raspi4bMachineState within RaspiMachineState by using an unnamed union. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index 3fa382d62ce..ef94d57dab5 100644

[PATCH v2 06/12] hw/arm/raspi: Consider network interface for B models

2025-02-03 Thread Philippe Mathieu-Daudé
Raspberry Pi 'B' models have an ethernet chipset (the LAN9512). Since we don't yet model it, add a /* TODO */ comment. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index 1a6a1f8ff22..6

[PATCH v2 05/12] hw/arm/raspi: Consider processor id in types[] array

2025-02-03 Thread Philippe Mathieu-Daudé
Expand the current type2model array to include the processor id. Since the BCM2838 is indistinctly used as BCM2711 (within the Linux community), add it as alias in RaspiProcessorId. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 33 +++-- 1 file changed,

[PATCH v2 04/12] hw/arm/raspi: Pass board_rev as argument to raspi_base_machine_init()

2025-02-03 Thread Philippe Mathieu-Daudé
Since callers already have reference to the RaspiBaseMachineClass, directly pass 'board_rev' as argument to raspi_base_machine_init(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/raspi_platform.h | 2 +- hw/arm/raspi.c | 8 +++- 2 files changed, 4 insertions(+),

[PATCH v2 08/12] hw/arm/raspi: Introduce generic Raspberry Pi machine

2025-02-03 Thread Philippe Mathieu-Daudé
The generic 'raspi' machine takes a 'model' argument and create the machine associated with the model, with the RAM size requested (or default to the minimum of 256MB if not precised). Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2797 Signed-off-by: Philippe Mathieu-Daudé --- include/

[PATCH v2 09/12] hw/arm/raspi: Have the generic machine take a 'revision' property

2025-02-03 Thread Philippe Mathieu-Daudé
Add a property to specify the board revision. This allows to create a Raspberry Pi 2B with BCM2836 SoC (rev 1.0 and 1.1) or BCM2837 (rev 1.2 up to 1.5). Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 39 +++ 1 file changed, 39 insertions(+) diff -

[PATCH v2 10/12] hw/arm/raspi: List models creatable by the generic 'raspi' machine

2025-02-03 Thread Philippe Mathieu-Daudé
All the following models can be created (with different RAM size): $ qemu-system-aarch64 -M raspi qemu-system-aarch64: Missing model, try -M raspi,model=help $ qemu-system-aarch64 -M raspi,model=help Available models (processor): - A (BCM2835) - B (BCM2835) - A+

[PATCH v2 11/12] hw/arm/raspi: Deprecate old raspiX machine names

2025-02-03 Thread Philippe Mathieu-Daudé
All previous raspi machines can be created using the generic machine. Deprecate the old names to maintain a single one. Update the tests. Signed-off-by: Philippe Mathieu-Daudé --- QOM HMP introspection test fails because without the 'model' argument set, no machine is created... $ qemu-system-

[PATCH v2 12/12] hw/arm/raspi: Support more models

2025-02-03 Thread Philippe Mathieu-Daudé
Allow to create the following machines: - Zero2W - 400 - CM4 and CM4S Fill the arrays with the BCM2712-based machines (raspi5), but since we don't model the SoC, these machines can't be created (and aren't listed in the 'help' output). List taken from: https://github.com/raspberrypi/docume

[PATCH v2 07/12] hw/arm/raspi: Check ramsize is within chipset aperture

2025-02-03 Thread Philippe Mathieu-Daudé
Add the 'max_ramsize' field to the soc_property[] array, corresponding to the maximum DRAM size a SoC can map. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index

Re: [libvirt PATCH] ci: refresh with latest 'lcitool manifest'

2025-02-03 Thread Pavel Hrdina
On Mon, Feb 03, 2025 at 01:26:26PM -0600, Andrea Bolognani wrote: > On Mon, Feb 03, 2025 at 07:07:36PM +0100, Pavel Hrdina wrote: > > Fedora and Alpine updated to latest versions. > > Technically the latest version of Alpine is 3.21, we just haven't > updated lcitool to support it yet ;) Oh well

Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

2025-02-03 Thread BALATON Zoltan
On Mon, 3 Feb 2025, Philippe Mathieu-Daudé wrote: On 3/2/25 15:50, Daniel P. Berrangé wrote: On Mon, Feb 03, 2025 at 02:45:06PM +, Peter Maydell wrote: On Mon, 3 Feb 2025 at 14:33, Daniel P. Berrangé wrote: On Mon, Feb 03, 2025 at 02:29:49PM +, Alex Bennée wrote: Peter Maydell writ

Re: [libvirt PATCH] ci: refresh with latest 'lcitool manifest'

2025-02-03 Thread Andrea Bolognani
On Mon, Feb 03, 2025 at 09:07:59PM +0100, Pavel Hrdina wrote: > On Mon, Feb 03, 2025 at 01:26:26PM -0600, Andrea Bolognani wrote: > > Has the Fedora 41 environment for integration tests actually been > > created? Because this won't work otherwise. > > Most likely not, still don't have access to the

Re: [PATCH 2/3] [bhyve] add command line argument "passthru"

2025-02-03 Thread Roman Bogorodskiy
Alexander Shursha wrote: > Sponsored by: Future Crew, LLC > Signed-off-by: Alexander Shursha > --- > src/bhyve/bhyve_command.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c > index bc287307c8..16986c9d53

[PATCH v2 5/8] qemu: Validate virtio-mem-ccw

2025-02-03 Thread Michal Privoznik
There are basically two differences between virtio-mem-ccw and virtio-mem-pci. s390 doesn't allow mixing different page sizes and there's no NUMA support in QEMU. Signed-off-by: Michal Privoznik Reviewed-by: Boris Fiuczynski --- src/qemu/qemu_validate.c | 35 ---

[PATCH v2 6/8] qemu: Allow virtio-mem on CCW

2025-02-03 Thread Michal Privoznik
After previous commits, we can allow virtio-mem to live on CCW channel. Signed-off-by: Michal Privoznik Reviewed-by: Boris Fiuczynski --- src/qemu/qemu_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 6554b992f0

[PATCH v2 7/8] qemuxmlconftest: Introduce memory-hotplug-virtio-mem-ccw-s390x.xml

2025-02-03 Thread Michal Privoznik
This is similar to emuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.xml except the explicit placement of virtio-mem onto a PCI bus is removed. This results in virtio-mem being placed onto CCW "bus" this demonstrating previous commits working as expected. Signed-off-by: Michal Privoznik --- ...

[PATCH v2 3/8] qemuxmlconftest: Introduce memory-hotplug-virtio-mem-pci-s390x.xml

2025-02-03 Thread Michal Privoznik
As of v9.2.0-1413-gd77ae821e8 QEMU supports virtio-mem-pci on s390 too. Let's add a test case for that. Signed-off-by: Michal Privoznik --- ...lug-virtio-mem-pci-s390x.s390x-latest.args | 41 +++ ...plug-virtio-mem-pci-s390x.s390x-latest.xml | 71 +++ .../memory-hotplug-v

[PATCH v2 4/8] qemu_caps: Introduce QEMU_CAPS_DEVICE_VIRTIO_MEM_CCW

2025-02-03 Thread Michal Privoznik
This capability tracks whether QEMU supports virtio-mem-ccw device. Introduced in QEMU commit v9.2.0-492-gaa910c20ec only upcoming release of QEMU supports the device. Signed-off-by: Michal Privoznik Reviewed-by: Boris Fiuczynski --- src/qemu/qemu_capabilities.c | 2 ++ src/

[PATCH v2 1/8] qemu: Do NOT autoadd NUMA node for s390

2025-02-03 Thread Michal Privoznik
In some cases, we might automatically add a NUMA node. But this doesn't work for s390 really, because in its commit v2.12.0-rc0~41^2~6 QEMU forbade specifying NUMA nodes for s390. Suppress automatic adding of NUMA node on our side. Signed-off-by: Michal Privoznik Reviewed-by: David Hildenbrand R

[PATCH v2 2/8] qemu_command: Use qemuBuildVirtioDevProps() to build cmd line for virtio-mem and virtio-pmem

2025-02-03 Thread Michal Privoznik
Both, virtio-mem and virtio-pmem devices follow traditional QEMU naming convention: their suffix determines what bus they live on. For instance, virtio-mem-pci, virtio-mem-ccw, virtio-pmem-pci. We already have a function that constructs device name following this convention: qemuBuildVirtioDevGetCo

Re: [PATCH 21/26] rpc: move state stop into virNetDaemon class

2025-02-03 Thread Peter Krempa
On Mon, Feb 03, 2025 at 10:52:23 +0100, Peter Krempa wrote: > On Wed, Jan 08, 2025 at 19:42:54 +, Daniel P. Berrangé wrote: > > Currently the remote daemon code is responsible for calling virStateStop > > in a background thread. The virNetDaemon code wants to synchronize with > > this during sh

Re: [PATCH 22/26] rpc: don't unconditionally quit after preserving state

2025-02-03 Thread Peter Krempa
On Wed, Jan 08, 2025 at 19:42:55 +, Daniel P. Berrangé wrote: > The call to preserve state (ie running VMs) is triggered in response to > the desktop session dbus terminating (session daemon), or logind sending > a "PrepareForShutdown" signal. In the case of the latter, daemons > should only sa

Re: [PATCH 21/26] rpc: move state stop into virNetDaemon class

2025-02-03 Thread Peter Krempa
On Wed, Jan 08, 2025 at 19:42:54 +, Daniel P. Berrangé wrote: > Currently the remote daemon code is responsible for calling virStateStop > in a background thread. The virNetDaemon code wants to synchronize with > this during shutdown, however, so the virThreadPtr must be passed over. > > Even

[PATCH v2 0/8] Enable virtio-mem-ccw

2025-02-03 Thread Michal Privoznik
v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/KA2DGRIY7DAMNMYM4MBKLOJCB7YYEUKU/ diff to v1: - Previously, virtio-mem-pci wasn't supported (in fact QEMU errored out), but this changed in QEMU upstream, so this limitation is lifted. - Added a test case for virtio-m

[PATCH v2 8/8] NEWS: Document virtio-mem-ccw

2025-02-03 Thread Michal Privoznik
Signed-off-by: Michal Privoznik Reviewed-by: Boris Fiuczynski --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 20bf01c8d7..4b60cf0060 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -38,6 +38,11 @@ v11.1.0 (unreleased) etc. Libvirt will now read these

Re: [PATCH v5 16/18] virsh: Add support for throttle group operations

2025-02-03 Thread Peter Krempa
On Mon, Feb 03, 2025 at 09:29:52 -, Harikumar Rajkumar wrote: > > On Mon, Nov 18, 2024 at 19:24:24 +0530, Harikumar R wrote: > > This will most likely need to be reimplemented by querying the data from > > the XML as the API itself IMO doesn't make too much sense to exist as it > > simply queri

Re: [PATCH 23/26] rpc: fix shutdown sequence when preserving state

2025-02-03 Thread Peter Krempa
On Wed, Jan 08, 2025 at 19:42:56 +, Daniel P. Berrangé wrote: > The preserving of state (ie running VMs) requires a fully functional > daemon and hypervisor driver. If any part has started shutting down > then saving state may fail, or worse, hang. > > The current shutdown sequence does not gu

Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

2025-02-03 Thread Alex Bennée
Peter Maydell writes: > On Sat, 1 Feb 2025 at 12:57, BALATON Zoltan wrote: >> >> On Sat, 1 Feb 2025, Philippe Mathieu-Daudé wrote: >> > - Deprecate the 'raspi4b' machine name, renaming it as >> > 'raspi4b-1g' on 32-bit hosts, 'raspi4b-2g' otherwise. >> > - Add the 'raspi4b-4g' and 'raspi4b-8g'

Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

2025-02-03 Thread Daniel P . Berrangé
On Mon, Feb 03, 2025 at 02:29:49PM +, Alex Bennée wrote: > Peter Maydell writes: > > > On Sat, 1 Feb 2025 at 12:57, BALATON Zoltan wrote: > >> > >> On Sat, 1 Feb 2025, Philippe Mathieu-Daudé wrote: > >> > - Deprecate the 'raspi4b' machine name, renaming it as > >> > 'raspi4b-1g' on 32-bit h

Re: Investigating MAC Address Conflict Resolution in libvirt: Log Analysis and Code Location Inquiry

2025-02-03 Thread Laine Stump
(Somehow I never received the original of this message into my libvirt folder. Possibly my email client mistakenly decided it was spam...) On 2/3/25 8:36 AM, Martin Kletzander wrote: On Tue, Dec 24, 2024 at 05:26:29PM +0800, Xuda Zhang wrote: Dear Team, Hi, not sure if this is still relevan

Re: [PATCH 24/26] admin: add 'daemon-shutdown' command

2025-02-03 Thread Peter Krempa
On Wed, Jan 08, 2025 at 19:42:57 +, Daniel P. Berrangé wrote: > The daemons are wired up to shutdown in responsible to UNIX process > signals, as well as in response to login1 dbus signals, or loss of > desktop session. The latter two options can optionally preserve state > (ie running VMs). >

Re: [PATCH 25/26] rpc: don't let systemd shutdown daemon while saving VMs

2025-02-03 Thread Peter Krempa
On Wed, Jan 08, 2025 at 19:42:58 +, Daniel P. Berrangé wrote: > The service unit "TimeoutStopSec" setting controls how long systemd > waits for a service to stop before aggressively killing it, defaulting > to 30 seconds if not set. > > When we're processing shutdown of VMs in response to OS s

[PATCH 1/3] qemuSnapshotForEachQcow2: Don't initialize 'nrollback'

2025-02-03 Thread Peter Krempa
The variable holds the amount of disks to roll back the snapshot for. The value must be set before the code jumps to the 'rollback:' label so the best situation is to not initialize it and let the compiler catch errors rather than initialize the unsigned variable to -1 and let it crash. Signed-off

[PATCH 0/3] qemu: Fix corner case in internal inactive snapshots

2025-02-03 Thread Peter Krempa
Peter Krempa (3): qemuSnapshotForEachQcow2: Don't initialize 'nrollback' qemu: process: Export qemuPrepareNVRAM for use in snapshot code qemu: snapshot: Ensure that NVRAM image exists when taking inactive internal snapshot src/qemu/qemu_process.c | 26 ++ src/qe

[PATCH 2/3] qemu: process: Export qemuPrepareNVRAM for use in snapshot code

2025-02-03 Thread Peter Krempa
Export qemuPrepareNVRAM so that it doesn't require the VM object. The snapshot code needs in the corner case of creating a snapshot of a freshly defined VM ensure that the nvram image exists in order to snapshot it. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 26 ++-

[PATCH 3/3] qemu: snapshot: Ensure that NVRAM image exists when taking inactive internal snapshot

2025-02-03 Thread Peter Krempa
Attempting to take an internal snapshot of a freshly defined VM with qcow2 backed NVRAM results in failure as the NVRAM image doesn't get populated until the VM is started for the first time. Fix this by invoking qemuPrepareNVRAM() when qcow2 nvram is defined. Resolves: https://issues.redhat.com/

Re: [PATCH v2 7/8] qemuxmlconftest: Introduce memory-hotplug-virtio-mem-ccw-s390x.xml

2025-02-03 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 2/3/25 10:55, Michal Privoznik wrote: This is similar to emuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.xml except the explicit placement of virtio-mem onto a PCI bus is removed. This results in virtio-mem being placed onto CCW "bus" this demonstrating previ

Re: [PATCH v2 3/8] qemuxmlconftest: Introduce memory-hotplug-virtio-mem-pci-s390x.xml

2025-02-03 Thread Boris Fiuczynski
Reviewed-by: Boris Fiuczynski On 2/3/25 10:55, Michal Privoznik wrote: As of v9.2.0-1413-gd77ae821e8 QEMU supports virtio-mem-pci on s390 too. Let's add a test case for that. Signed-off-by: Michal Privoznik --- ...lug-virtio-mem-pci-s390x.s390x-latest.args | 41 +++ ...plug-virtio-m

Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

2025-02-03 Thread Peter Maydell
On Mon, 3 Feb 2025 at 14:33, Daniel P. Berrangé wrote: > > On Mon, Feb 03, 2025 at 02:29:49PM +, Alex Bennée wrote: > > Peter Maydell writes: > > > > > On Sat, 1 Feb 2025 at 12:57, BALATON Zoltan wrote: > > >> > > >> On Sat, 1 Feb 2025, Philippe Mathieu-Daudé wrote: > > >> > - Deprecate the

Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

2025-02-03 Thread Daniel P . Berrangé
On Mon, Feb 03, 2025 at 02:45:06PM +, Peter Maydell wrote: > On Mon, 3 Feb 2025 at 14:33, Daniel P. Berrangé wrote: > > > > On Mon, Feb 03, 2025 at 02:29:49PM +, Alex Bennée wrote: > > > Peter Maydell writes: > > > > > > > On Sat, 1 Feb 2025 at 12:57, BALATON Zoltan wrote: > > > >> > > >

[PATCH] qemu: snapshot: Limit scope of checkpoint-snapshot interlock

2025-02-03 Thread Peter Krempa
'qemuDomainSupportsCheckpointsBlockjobs()' should really be used only with active VMs based on the scope of interlocking it does. This means that the inactive snapshot code path needs to do the interlocking based on what's supported: - external snapshot support was not implemented yet (bitmap

[libvirt PATCH] libvirt.spec.in: fix indentation

2025-02-03 Thread Pavel Hrdina
Fixes: cf32953f5b6ec30386f71b40cf458467752a6dca Signed-off-by: Pavel Hrdina --- Pushed libvirt.spec.in | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index be91fa6bb4..cb41ea1de1 100644 --- a/libvirt.spec.in +++ b/lib

[libvirt PATCH] ci: refresh with latest 'lcitool manifest'

2025-02-03 Thread Pavel Hrdina
Fedora and Alpine updated to latest versions. Signed-off-by: Pavel Hrdina --- ci/buildenv/{alpine-319.sh => alpine-320.sh} | 0 ci/buildenv/debian-11-cross-aarch64.sh| 2 +- ci/buildenv/debian-11-cross-armv6l.sh | 2 +- ci/buildenv/debian-11-cross-armv7l.sh | 2 +- c

Re: [PATCH 00/26] integrate auto-shutdown of VMs with daemons

2025-02-03 Thread Peter Krempa
On Wed, Jan 08, 2025 at 19:42:33 +, Daniel P. Berrangé wrote: This series really deserves a NEWS entry where you can explain how to use this instead of libvirt-guests so that users are motivated to switch.

Re: [PATCH 26/26] hypervisor: send systemd status messages while saving

2025-02-03 Thread Peter Krempa
On Wed, Jan 08, 2025 at 19:42:59 +, Daniel P. Berrangé wrote: > Since processing running VMs on OS shutdown can take a while, it is > beneficial to send systemd status messages about the progress. > > Signed-off-by: Daniel P. Berrangé > --- > src/hypervisor/domain_driver.c | 15 +

Re: Investigating MAC Address Conflict Resolution in libvirt: Log Analysis and Code Location Inquiry

2025-02-03 Thread Martin Kletzander
On Tue, Dec 24, 2024 at 05:26:29PM +0800, Xuda Zhang wrote: Dear Team, Hi, not sure if this is still relevant, but ... I am reaching out regarding an issue I encountered with libvirt and MAC address conflicts. Below is a summary of the situation: 1. Initially, the vNIC's MAC address was d

Re: [PATCH 11/26] qemu: support automatic VM managed save in system daemon

2025-02-03 Thread Daniel P . Berrangé
On Thu, Jan 30, 2025 at 06:21:07PM +0100, Peter Krempa wrote: > On Wed, Jan 08, 2025 at 19:42:44 +, Daniel P. Berrangé wrote: > > Currently automatic VM managed save is only performed in session > > daemons, on desktop session close, or host OS shutdown request. > > > > With this change it is

Re: [PATCH 12/26] qemu: improve shutdown defaults for session daemon

2025-02-03 Thread Daniel P . Berrangé
On Fri, Jan 31, 2025 at 10:20:23AM +0100, Peter Krempa wrote: > On Wed, Jan 08, 2025 at 19:42:45 +, Daniel P. Berrangé wrote: > > Currently the session daemon will try a managed save on all VMs, > > leaving them running if that fails. > > > > This limits the managed save just to persistent VMs

Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

2025-02-03 Thread Peter Maydell
On Mon, 3 Feb 2025 at 14:50, Daniel P. Berrangé wrote: > > On Mon, Feb 03, 2025 at 02:45:06PM +, Peter Maydell wrote: > > For Arm embedded boards we mostly tend to "restrict the user > > to what you can actually do", except for older boards where > > we tended not to write any kind of sanity c

Re: [PATCH 09/26] hypervisor: expand available shutdown actions

2025-02-03 Thread Peter Krempa
On Wed, Jan 08, 2025 at 19:42:42 +, Daniel P. Berrangé wrote: > The auto shutdown code can currently only perform managed save, > which may fail in some cases, for example when PCI devices are > assigned. On failure, shutdown inhibitors remain in place which > may be undesirable. > > This expa

Re: [PATCH v5 16/18] virsh: Add support for throttle group operations

2025-02-03 Thread Harikumar Rajkumar
> On Mon, Nov 18, 2024 at 19:24:24 +0530, Harikumar R wrote: > This will most likely need to be reimplemented by querying the data from > the XML as the API itself IMO doesn't make too much sense to exist as it > simply queries what we've set. are you suggesting to use qemuDomainGetXMLDesc() to ge

Re: [PATCH 21/26] rpc: move state stop into virNetDaemon class

2025-02-03 Thread Peter Krempa
On Wed, Jan 08, 2025 at 19:42:54 +, Daniel P. Berrangé wrote: > Currently the remote daemon code is responsible for calling virStateStop > in a background thread. The virNetDaemon code wants to synchronize with > this during shutdown, however, so the virThreadPtr must be passed over. > > Even

Re: [PATCH 1/3] [bhyve] list pci devices on host

2025-02-03 Thread Roman Bogorodskiy
Alexander Shursha wrote: > Linux gets the list via sysfs. FreeBSD can get the list through > ioctl > > Sponsored by: Future Crew, LLC > Signed-off-by: Alexander Shursha > --- > src/bhyve/bhyve_capabilities.c | 2 +- > src/conf/node_device_conf.c | 2 +- > src/node_device/no