On Wed, Apr 02, 2025 at 06:56:17 +, Duan, Zhenzhong wrote:
> Hi,
>
> When -Dlibnl=disabled, build failed as below:
>
> ../src/util/virnetdevbridge.c: In function 'virNetDevBridgeSetupVlans':
> ../src/util/virnetdevbridge.c:326:9: error: implicit declaration of function
> 'virNetlinkBridgeVla
>-Original Message-
>From: Peter Krempa
>Subject: Re: Report a build issue
>
>On Wed, Apr 02, 2025 at 06:56:17 +, Duan, Zhenzhong wrote:
>> Hi,
>>
>> When -Dlibnl=disabled, build failed as below:
>>
>> ../src/util/virnetdevbridge.c: In function 'virNetDevBridgeSetupVlans':
>> ../src
Currently libvirt favors /run instead of /var/run, but for local build
run test, a prefix path is still needed to avoid interoperating with OS
vendor provided binaries.
Signed-off-by: Zhenzhong Duan
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b
RIP HMP use in libvirt:
2007-02-14 [1] - 2025-04-02
[1] 23ad665cb05ef9ce7d298cc34bff5efb95ef6948
Peter Krempa (6):
qemu: domain: Don't check return value of 'virCPUDefCopy'
qemuSnapshotCreateActiveInternal: Fix error logic
qemu: snapshot: Always assume support for
QEMU_CAPS_SNAPSHOT_I
From: Peter Krempa
As 'virCPUDefCopy' can't fail any more (without aborting) remove the
last two return value checks.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_domain.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.
From: Peter Krempa
Now that we've replaced the final two HMP commands used by libvirt we
can fully drop the 'text' monitor support.
The only thing we keep is the HMP passtrhough with
'virsh qemu-monitor-command'.
Signed-off-by: Peter Krempa
---
po/POTFILES | 1 -
src/qemu/me
From: Peter Krempa
The code now always assumes support for the QMP internal snapshot
commands so the capability is no longer needed.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
On Wed, Apr 02, 2025 at 15:58:28 +0800, Zhenzhong Duan wrote:
> Currently libvirt favors /run instead of /var/run, but for local build
> run test, a prefix path is still needed to avoid interoperating with OS
> vendor provided binaries.
Could you please elaborate?
>
> Signed-off-by: Zhenzhong Du
Roman Bogorodskiy writes:
> Anyway, my question is the following:
>
> Should we split this series into two: the virpci part and the bhyve
> part?
> If I'm not mistaken, they are not tied to each other, and splitting
> them would make review easier as the bhyve part is almost ready
> to get it.
I
From: Peter Krempa
The 'snapshot-save' QMP command was introduced in 'qemu-6.0' and libvirt
now requires at least 'qemu-6.2'. Thus we can assume that the QMP
command can be used always.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_snapshot.c | 46 ++--
1 fi
On Tue, Apr 01, 2025 at 02:49:11PM +0200, Peter Krempa via Devel wrote:
> On Fri, Feb 21, 2025 at 14:36:50 +0100, Michal Prívozník wrote:
> > On 2/20/25 23:26, Ján Tomko wrote:
> > > Similarly to `desc` and `net-desc`, return an empty string if
> > > there is no metadata to be returned.
> > >
> >
The 'plain' optimization type also triggers the clang stack frame size
issues, so increase limit for it as well.
Signed-off-by: Roman Bogorodskiy
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 56823ca25b..0a402a19a2 100644
---
Add support for interface type 'network'. While bridge remains the only
supported options for networks in bhyve, supporting interface type
'network' allows easier configuration and makes domain XMLs more
compatible with the other drivers.
While here, update the error message for the unsupported in
On a Wednesday in 2025, Peter Krempa via Devel wrote:
RIP HMP use in libvirt:
2007-02-14 [1] - 2025-04-02
[1] 23ad665cb05ef9ce7d298cc34bff5efb95ef6948
Peter Krempa (6):
qemu: domain: Don't check return value of 'virCPUDefCopy'
qemuSnapshotCreateActiveInternal: Fix error logic
qemu: snapshot
From: Peter Krempa
Swap the order of links to XML schema docs and to the other language
docs. The XML schema is usually accessed more.
Signed-off-by: Peter Krempa
---
docs/docs.rst | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/docs/docs.rst b/
On 2/20/25 23:26, Ján Tomko wrote:
> Similarly to `desc` and `net-desc`, return an empty string if
> there is no metadata to be returned.
>
> https://issues.redhat.com/browse/RHEL-27172
>
> Signed-off-by: Ján Tomko
> ---
> tools/virsh-domain.c | 10 --
> tools/virsh-network.c | 10
Currently libvirt favors /run instead of /var/run, but for local build
run test, a prefix path is still needed to avoid interoperating with OS
vendor provided binaries.
When 'system' option is specified, fixed path /run is honored.
Fixes: e5299ddf86121d3c792ca271ffcb54900eb19dc3
Signed-off-by: Zh
On a Tuesday in 2025, Kirill Shchetiniuk via Devel wrote:
When the new CH monitor was started, it ran as a non-daemonized
process and was a child of the CH driver process. This led to a
situation where if the CH driver died, the monitor process were
killed too, terminating the running VM under th
Thanks Jan,
Didn’t noticed the issue with the white symbols when submitted a patch, next
time will keep it in mind and be careful. Btw, do we have some tools to check
and warn such possible issues?
Kirill
> 2. 4. 2025 v 18:36, Ján Tomko :
>
> On a Tuesday in 2025, Kirill Shchetiniuk via Dev
From: Peter Krempa
Finding the correct link to a XML description or API reference section
in a big blob of links concatenated in a paragraph is unpleasand and
especially for 'capabilities' and 'domain capabilities' following each
other.
Turn the API and XML reference sections into a list in RST
Implement a sub-test in qemuxmlconftest that uses acpi-generic-initiator
to link a PCI device with multiple NUMA node definitions (without any
memory/cpu resource assigned).
Then translate the VM definition to the corresponding qemu command line
that associates the hostdev with the NUMA nodes.
Si
Add support to the qemu driver to generate the proper command line for
the acpi-generic-initiator definitions.
Signed-off-by: Andrea Righi
---
src/qemu/qemu_command.c | 28
1 file changed, 28 insertions(+)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command
Allow to define NUMA nodes without memory or CPUs assigned to properly
support the new acpi-generic-initiator device.
This is required because the NUMA nodes passed to the
acpi-generic-initiator object must be independent and not be shared with
other resources, such as CPU or memory.
Signed-off-b
This capability tracks whether QEMU supports the acpi-generic-initiator
object type.
This object has been introduced in QEMU with the commit:
b64b7ed8bb ("qom: new object to associate device to NUMA node").
Signed-off-by: Andrea Righi
---
src/qemu/qemu_capabilities.c
>-Original Message-
>From: Peter Krempa
>Subject: Re: [PATCH] meson: Add back prefix path for runstatedir
>
>On Wed, Apr 02, 2025 at 15:58:28 +0800, Zhenzhong Duan wrote:
>> Currently libvirt favors /run instead of /var/run, but for local build
>> run test, a prefix path is still needed
On Wed, Apr 02, 2025 at 10:08:23AM +0200, Peter Krempa via Devel wrote:
> RIP HMP use in libvirt:
>
> 2007-02-14 [1] - 2025-04-02
>
> [1] 23ad665cb05ef9ce7d298cc34bff5efb95ef6948
>
> Peter Krempa (6):
> qemu: domain: Don't check return value of 'virCPUDefCopy'
> qemuSnapshotCreateActiveInte
Hi,
When -Dlibnl=disabled, build failed as below:
../src/util/virnetdevbridge.c: In function 'virNetDevBridgeSetupVlans':
../src/util/virnetdevbridge.c:326:9: error: implicit declaration of function
'virNetlinkBridgeVlanFilterSet'; did you mean
'virNetDevBridgeGetVlanFiltering'? [-Werror=implic
On Wed, Apr 02, 2025 at 08:33:23AM +, Duan, Zhenzhong wrote:
>
>
> >-Original Message-
> >From: Peter Krempa
> >Subject: Re: [PATCH] meson: Add back prefix path for runstatedir
> >
> >On Wed, Apr 02, 2025 at 15:58:28 +0800, Zhenzhong Duan wrote:
> >> Currently libvirt favors /run ins
On 3/25/25 15:11, Kirill Shchetiniuk via Devel wrote:
> 1. Run CH monitor as a daemon
> Made the monitor process daemonized to prevent VM termination if
> the CH driver crashes. Added pidfile for daemon's pid aquiring and tracking
> as well as its init.
>
> 2. Update domain info after reboot
> Fix
On 3/25/25 15:11, Kirill Shchetiniuk via Devel wrote:
> When the new CH monitor was started, it ran as a non-daemonized
> process and was a child of the CH driver process. This led to a
> situation where if the CH driver died, the monitor process were
> killed too, terminating the running VM under
30 matches
Mail list logo
