[PATCH 1/2] util: Avoid statfs in virFileGetExistingParent

From: Jiri Denemark The code was separated from virFileIsSharedFSType which is Linux-only, but virFileGetExistingParent is also called from virFileIsSharedFSOverride which is OS independent. Thus we can't use statfs. Let's use virFileExists (access) instead, we were not interested in anything but

[PATCH 2/2] util: Move virFileGetExistingParent out of ifdef __linux__

From: Jiri Denemark The function is called by virFileIsSharedFSOverride which is not Linux specific and thus building on anything but Linux failes. Fixes: 94fb348d670f612c0b58901c9829b4eec81faa50 Signed-off-by: Jiri Denemark --- src/util/virfile.c | 55 +++--

[PATCH 0/2] Fix build on non-Linux

Jiri Denemark (2): util: Avoid statfs in virFileGetExistingParent util: Move virFileGetExistingParent out of ifdef __linux__ src/util/virfile.c | 56 ++--- tests/virfilemock.c | 28 +++ 2 files changed, 56 insertions(+), 28 deletion

Re: [PATCH 1/2] util: Avoid statfs in virFileGetExistingParent

On Tue, Jun 03, 2025 at 11:07:43AM +0200, Jiri Denemark via Devel wrote: From: Jiri Denemark The code was separated from virFileIsSharedFSType which is Linux-only, but virFileGetExistingParent is also called from virFileIsSharedFSOverride which is OS independent. Thus we can't use statfs. Let's

Re: [PATCH] qemu: command: Don't attempt to set backend MTU for networks which don't use host backend directly

On a Monday in 2025, Peter Krempa via Devel wrote: From: Peter Krempa Attempting to set MTU for network types which don't actually use the network device on the host results in a failure. The 'mtu' property is also used e.g. for the 'host_mtu' property of e.g. 'virtio-net-pci' which is applied

Re: [PATCH v2 1/2] qemu: Don't accept VIR_DUMP_LIVE flag in qemuDomainCoreDumpWithFormat()

On Tue, Jun 03, 2025 at 10:03:12AM +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > QEMU can't really do live dumps of guest memory. It's because > inside of dump_init() the vm_stop() is called basically > unconditionally (the only condition is whether vCPUs are > running). H

Re: [PATCH 0/4] conf: graphics def and parse refactor

On a Monday in 2025, Kirill Shchetiniuk via Devel wrote: This series is supposed to refactor the existing parse logic by using the proper utility function and some parameters type change. 1. VNC graphics pasing were refactored to use the vitXMLProp* utility functions. 'autoport' and 'websocketGe

Re: [PATCH] qemu: command: Don't attempt to set backend MTU for networks which don't use host backend directly

On 6/2/25 11:00 AM, Peter Krempa via Devel wrote: From: Peter Krempa Attempting to set MTU for network types which don't actually use the network device on the host results in a failure. The 'mtu' property is also used e.g. for the 'host_mtu' property of e.g. 'virtio-net-pci' which is applied e

[PATCH v2 0/2] qemu: Don't accept VIR_DUMP_LIVE flag in qemuDomainCoreDumpWithFormat()

This is a v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/PP7KRRWN3PPIDDYW5ZC3NFH7C5UI2TBA/ Instead of documenting the flag quirks, let's just error out if specified. Michal Prívozník (2): qemu: Don't accept VIR_DUMP_LIVE flag in qemuDomainCoreDumpWithFormat()

[PATCH v2 1/2] qemu: Don't accept VIR_DUMP_LIVE flag in qemuDomainCoreDumpWithFormat()

From: Michal Privoznik QEMU can't really do live dumps of guest memory. It's because inside of dump_init() the vm_stop() is called basically unconditionally (the only condition is whether vCPUs are running). Hence, there is no way for us to do live dumps and thus honor VIR_DUMP_LIVE flag. Instead

Re: [PATCH v2 2/2] NEWS: Document removal of support of VIR_DUMP_LIVE flag from QEMU driver

On Tue, Jun 03, 2025 at 10:03:13AM +0200, Michal Privoznik via Devel wrote: > From: Michal Privoznik > > Signed-off-by: Michal Privoznik > --- > NEWS.rst | 7 +++ > 1 file changed, 7 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH] lib: Document VIR_DUMP_LIVE flag quirk

On 6/2/25 16:18, Daniel P. Berrangé wrote: > On Mon, Jun 02, 2025 at 03:27:32PM +0200, Michal Privoznik via Devel wrote: >> From: Michal Privoznik >> >> The virDomainCoreDump() API has VIR_DUMP_LIVE flag which is >> documented to leave vCPUs running throughout making of the dump >> of guest memory

[PATCH v2 2/2] NEWS: Document removal of support of VIR_DUMP_LIVE flag from QEMU driver

From: Michal Privoznik Signed-off-by: Michal Privoznik --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 160aac0b31..b97f86ffb6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,13 @@ v11.5.0 (unreleased) * **Removed features** + * qemu: Don

Re: [PATCH 0/2] Fix build on non-Linux

On Tue, Jun 03, 2025 at 11:07:42AM +0200, Jiri Denemark via Devel wrote: Jiri Denemark (2): util: Avoid statfs in virFileGetExistingParent util: Move virFileGetExistingParent out of ifdef __linux__ Let's hope this fixes everything O:-) Reviewed-by: Martin Kletzander src/util/virfile.c |