On Mon, Jun 23, 2025 at 5:39 PM Han Han wrote:
>
>
> On Fri, May 30, 2025 at 8:22 PM Enrique Llorente via Devel <
> devel@lists.libvirt.org> wrote:
>
>> This commit introduces a feature enhancement for configuring hostnames in
>> virtual machines (VMs) using DHCP. It adds new options to the "pass
On Fri, May 30, 2025 at 8:22 PM Enrique Llorente via Devel <
devel@lists.libvirt.org> wrote:
> This commit introduces a feature enhancement for configuring hostnames in
> virtual machines (VMs) using DHCP. It adds new options to the "passt" tool
> to set the hostname and fully qualified domain nam
On 6/8/25 22:44, Andrea Righi via Devel wrote:
> = Overview =
>
> This patch set introduces support for acpi-generic-initiator devices,
> supported by QEMU [1].
>
> The acpi-generic-initiator object is required to support Multi-Instance GPU
> (MIG) configurations on NVIDIA GPUs [2]. MIG enables p
On 6/8/25 22:44, Andrea Righi via Devel wrote:
> Add support to the qemu driver to generate the proper command line for
> the acpi-generic-initiator definitions.
>
> Signed-off-by: Andrea Righi
> ---
> src/qemu/qemu_command.c | 28
> 1 file changed, 28 insertions(+)
On 6/8/25 22:44, Andrea Righi via Devel wrote:
> This capability tracks whether QEMU supports the acpi-generic-initiator
> object type.
>
> This object has been introduced in QEMU with the commit:
> b64b7ed8bb ("qom: new object to associate device to NUMA node").
>
> Signed-off-by: Andrea Righi
On 6/8/25 22:44, Andrea Righi via Devel wrote:
> Introduce apci-generic-initiator device to the domain XML.
>
> Example definition:
>
>
> dev0
> 1
>
>
> This enables partitioning of PCI resources into multiple isolated
> instances, each requiring a dedicated NUMA node definition, t
On 6/8/25 22:44, Andrea Righi via Devel wrote:
> Introduce the definition of a new acpi-generic-initiator object that can
> be used to link a PCI device with multiple NUMA nodes.
>
> Link: https://mail.gnu.org/archive/html/qemu-arm/2024-03/msg00358.html
>
> Signed-off-by: Andrea Righi
> ---
> s
On Mon, Jun 23, 2025 at 01:16:01PM +0200, Peter Krempa wrote:
> On Mon, Jun 23, 2025 at 12:02:31 +0100, Daniel P. Berrangé via Devel wrote:
> > From: Daniel P. Berrangé
> >
> > The main XML parser code global initializer historically had a mutex
> > protecting it, and more recently uses a pthread
On Mon, Jun 23, 2025 at 04:11:25PM +0200, Michal Prívozník via Devel wrote:
> On 4/21/25 21:38, Maximilian Martin via Devel wrote:
> > This resubmission splits up the previous patch into multiple patches and
> > incorporates review comments from Michal Prívozník.
> >
> > Currently, only vendor/pro
On Mon, Jun 23, 2025 at 12:02:31 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> The main XML parser code global initializer historically had a mutex
> protecting it, and more recently uses a pthread_once. The RelaxNG
> code, however, relies on three other global initial
On Mon, Jun 23, 2025 at 12:02:31PM +0100, Daniel P. Berrangé wrote:
> From: Daniel P. Berrangé
>
> The main XML parser code global initializer historically had a mutex
> protecting it, and more recently uses a pthread_once. The RelaxNG
> code, however, relies on three other global initializers th
On 4/21/25 21:38, Maximilian Martin via Devel wrote:
> From: Maximilian Martin
>
> This patch implements USB bus/port matching. In addition
> to vendor/product and bus/device matching, bus/port
> matching is implemented. This involves additions and
> refactorings in the domain configuration, host
On 4/21/25 21:38, Maximilian Martin via Devel wrote:
> This resubmission splits up the previous patch into multiple patches and
> incorporates review comments from Michal Prívozník.
>
> Currently, only vendor/product and bus/device matching are supported for USB
> host
> devices. Neither of these
On Wed, Jun 18, 2025 at 12:46:19 +0200, Ján Tomko via Devel wrote:
> From: Ján Tomko
>
> Introduce a new IOMMU device model 'amd', both the parser
> and the formatter for QEMU because of our enum warnings.
>
> https://issues.redhat.com/browse/RHEL-50560
>
> Signed-off-by: Ján Tomko
> ---
> do
On Wed, Jun 18, 2025 at 12:46:22 +0200, Ján Tomko via Devel wrote:
> From: Ján Tomko
>
> Signed-off-by: Ján Tomko
> ---
> src/conf/domain_validate.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c
> index b9a6740437..b28
On Wed, Jun 18, 2025 at 12:46:23 +0200, Ján Tomko via Devel wrote:
> From: Ján Tomko
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c| 2 ++
> tests/qemuxmlconfdata/amd-iommu.x86_64-latest.args | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
On Wed, Jun 18, 2025 at 12:46:20 +0200, Ján Tomko via Devel wrote:
> From: Ján Tomko
>
> Signed-off-by: Ján Tomko
> ---
> docs/formatdomain.rst | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
IMO this patch should come before 3/7.
Reviewed-by: Peter Krempa
On Wed, Jun 18, 2025 at 12:46:21 +0200, Ján Tomko via Devel wrote:
> From: Ján Tomko
>
> For the newly supported AMD device.
>
> Signed-off-by: Ján Tomko
> ---
> docs/formatdomain.rst | 8
> src/conf/domain_conf.c | 30 +
> src/c
Version 2 of this series includes changes I've requested in the review
and much more that I've learned during adaptation and testing:
- 'usb-bot' and 'usb-storage' are not ABI compatible for CDROMs
Migrating a guest from 'usb-bot'(with cdrom) to 'usb-storage' results
in I/O errors on reads
From: Daniel P. Berrangé
The main XML parser code global initializer historically had a mutex
protecting it, and more recently uses a pthread_once. The RelaxNG
code, however, relies on three other global initializers that are
not thread safe, just relying on setting an integer "initialized"
flag.
On Mon, Jun 23, 2025 at 04:11:30PM +0200, Michal Prívozník via Devel wrote:
> On 4/21/25 21:38, Maximilian Martin via Devel wrote:
> > From: Maximilian Martin
> >
> > This patch implements USB bus/port matching. In addition
> > to vendor/product and bus/device matching, bus/port
> > matching is i
On Mon, Apr 21, 2025 at 09:38:34PM +0200, Maximilian Martin via Devel wrote:
> This resubmission splits up the previous patch into multiple patches and
> incorporates review comments from Michal Prívozník.
>
> Currently, only vendor/product and bus/device matching are supported for USB
> host
> d
On Wed, Jun 18, 2025 at 12:46:18 +0200, Ján Tomko via Devel wrote:
> From: Ján Tomko
>
> Introduced by QEMU commit f864a3235ea1d1d714b3cde2d9a810ea6344a7b5
> the presence of this attribute allows libvirt to specify the alias
> of the AMDVI-PCI device explicitly.
>
> (It was implicit before the i
On Wed, Jun 18, 2025 at 12:46:17 +0200, Ján Tomko via Devel wrote:
> From: Ján Tomko
>
> Check for the presence of the amd-iommu device, so we can conditionalize
> probing for its properties.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_capabilities.c | 4
From: Peter Krempa
While 'usb-bot' and 'usb-storage' are ABI and migration compatible for
disks it's not the case for cdroms. When migrating from a new config
using 'usb-bot' to an older daemon which would use 'usb-storage' the
guest os will get I/O errors.
Thus we must properly fill in models f
From: Peter Krempa
The 'removable' property is tested for 'usb' and 'scsi' disks. The test
case for 'usb' disks already has another test case for this, so add
testing of 'removable' SCSI disks into the 'disk-scsi' case and remove
the 'disk-device-removable' case completely.
Signed-off-by: Peter
From: Peter Krempa
Add multiple USB disks to the definition testing a matrix of 'disk' and
'cdrom' elements with user-aliases, 'serial' and 'removable'
properties configured.
This patch also removes the 'ide' disk which is not related to what
we're testing here.
Signed-off-by: Peter Krempa
--
From: Akihiko Odaki
usb-bot is supported by all supported QEMU versions; it is present since
1.4.0 and libvirt supports 4.2.0 or later.
Add a capability just in case USB_STORAGE_BOT is disabled when building
QEMU.
Signed-off-by: Akihiko Odaki
Signed-off-by: Peter Krempa
---
src/qemu/qemu_cap
From: Peter Krempa
Modify the validation of empty cdroms to trigger only for
VIR_DOMAIN_DISK_MODEL_USB_STORAGE as with 'usb-bot' we can properly
emulate a cdrom.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_validate.c | 3 +-
...om-usb-empty.x86_64-latest.abi-update.args
From: Peter Krempa
While the 'usb-storage' based disks use the USB address directly, with
'usb-bot' the USB address is on the "controller" part of the device and
the 'scsi-hd/cd' device will use a 'drive' address from qemu's PoV.
Since we do not want to expose the 'usb-bot' as explicit controlle
From: Daniel P. Berrangé
The main XML parser code global initializer historically had a mutex
protecting it, and more recently uses a pthread_once. The RelaxNG
code, however, relies on two other global initializers that are
not thread safe, just relying on setting an integer "initialized"
flag.
From: Peter Krempa
Historically libvirt specified 'usb-storage' as driver for USB disks.
This though combined with '-blockdev' doesn't properly configure the
device to look like CDROM for .
'usb-bot' acts like a controler and allows explicitly connecting a
-device to it.
In qemu the devices sha
From: Akihiko Odaki
usb-storage is a compound device that automatically creates a USB mass
storage device and a SCSI device as its backend. Unfortunately it lacks
some configuration options that are usually present with a SCSI device,
and cannot represent CD-ROM in particular.
Replace usb-storag
From: Peter Krempa
The test case is now redundant since 'disk-usb-device' case also tests
all cdrom configurations. Remove it.
Signed-off-by: Peter Krempa
---
.../disk-cdrom-bus-other.x86_64-latest.args | 34 -
.../disk-cdrom-bus-other.x86_64-latest.xml| 38 --
On Mon, Jun 23, 2025 at 23:25:28 +0530, Anushree Mathur wrote:
> CC: libvirt devel list
>
> Hi Kevin/Peter,
>
> Thank you so much for addressing this issue. I tried out few more things and
> here is my analysis:
>
> Even when I removed the readonly option from guest xml I was still seeing the
>
On Mon, Jun 23, 2025 at 17:17:06 +0100, Daniel P. Berrangé via Devel wrote:
> From: Daniel P. Berrangé
>
> The main XML parser code global initializer historically had a mutex
> protecting it, and more recently uses a pthread_once. The RelaxNG
> code, however, relies on two other global initializ
From: Peter Krempa
The QEMU_CAPS_DEVICE_USB_BOT device can be compiled out but
realistically it makes no sense to do it thus also makes no sense to
have another variant of input data for it.
Add another invocation of "disk-usb-device" clearing QEMU_CAPS_DEVICE_USB_BOT
to show the fallback code p
From: Peter Krempa
The helper sets the 'attached' property of the 'usb-bot' device to true,
which will be used on the hotplug code path.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_monitor.c | 12
src/qemu/qemu_monitor.h | 3 +++
src/qemu/qemu_monitor_json.c | 20
From: Peter Krempa
Signed-off-by: Peter Krempa
---
tests/qemusecuritytest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemusecuritytest.c b/tests/qemusecuritytest.c
index 88c8617d69..ba9506d0a0 100644
--- a/tests/qemusecuritytest.c
+++ b/tests/qemusecuritytest.c
@
From: Peter Krempa
The qemu hotplug code parses the device with ABI updates enabled so
qemuhotplugtest ought to do the same.
Signed-off-by: Peter Krempa
---
tests/qemuhotplugtest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotpl
40 matches
Mail list logo
