[PATCH pushed] qemuxmlconfdata: Regenerate outputs after last commit

2025-07-29 Thread Peter Krempa via Devel
From: Peter Krempa Commit 4efea21ae8709c6741a1800bd26ae6b49c8a77f5 modified how the EFI paths are detected but didn't update the outputs. Fixes: 4efea21ae8709c6741a1800bd26ae6b49c8a77f5 Signed-off-by: Peter Krempa --- Pushed as build fix. ...manual-efi-aarch64-legacy-paths.aarch64-latest.arg

Re: [PATCH 0/2] qemu: Match firmware with fully resolved and canonicalized paths

2025-07-29 Thread Michal Prívozník via Devel
On 7/24/25 15:49, James Le Cuirot wrote: > From: James Le Cuirot > > Distros may provide compatibility symlinks after moving firmware files > around, but they won't work for existing VMs when doing a straight > string comparison. > > virFileComparePaths has been used to do this, but it was previ

Re: [PATCH 0/2] qemu: Match firmware with fully resolved and canonicalized paths

2025-07-29 Thread Michal Prívozník via Devel
On 7/29/25 13:08, Daniel P. Berrangé wrote: > On Tue, Jul 29, 2025 at 01:02:18PM +0200, Peter Krempa via Devel wrote: >> On Tue, Jul 29, 2025 at 10:42:09 +0200, Michal Prívozník via Devel wrote: >>> On 7/24/25 15:49, James Le Cuirot wrote: From: James Le Cuirot Distros may provide c

Re: [PATCH 0/2] Revert recent patches causing test dependance on host state

2025-07-29 Thread Pavel Hrdina via Devel
On Tue, Jul 29, 2025 at 01:07:27PM +0200, Peter Krempa via Devel wrote: > Revert the patches as we're in code freeze. > > Peter Krempa (2): > Revert "qemuxmlconfdata: Regenerate outputs after last commit" > Revert "qemu: Match firmware with fully resolved and canonicalized > paths" Review

Re: Question about SEV* guests and automatic firmware selection

2025-07-29 Thread Jim Fehlig via Devel
On 5/13/25 14:25, Jim Fehlig wrote: On 4/24/25 14:18, Jim Fehlig wrote: On 4/24/25 04:59, Daniel P. Berrangé wrote: On Mon, Apr 21, 2025 at 01:38:35PM -0600, Jim Fehlig via Devel wrote: Hi All, While investigating an internal bug report, we noticed that a minimal firmware auto-selection confi

Re: [PATCH 0/2] qemu: Match firmware with fully resolved and canonicalized paths

2025-07-29 Thread Peter Krempa via Devel
On Tue, Jul 29, 2025 at 10:42:09 +0200, Michal Prívozník via Devel wrote: > On 7/24/25 15:49, James Le Cuirot wrote: > > From: James Le Cuirot > > > > Distros may provide compatibility symlinks after moving firmware files > > around, but they won't work for existing VMs when doing a straight > >

[PATCH 1/2] Revert "qemuxmlconfdata: Regenerate outputs after last commit"

2025-07-29 Thread Peter Krempa via Devel
From: Peter Krempa Turns out the test difference was not caused by forgotten hunks but rather that the test output depends on the system. For now both this wrong fix and the commit causing the failure will both be reverted as we're in code freeze for the upcoming release. This reverts commit 73

[PATCH 0/2] Revert recent patches causing test dependance on host state

2025-07-29 Thread Peter Krempa via Devel
Revert the patches as we're in code freeze. Peter Krempa (2): Revert "qemuxmlconfdata: Regenerate outputs after last commit" Revert "qemu: Match firmware with fully resolved and canonicalized paths" src/qemu/qemu_firmware.c | 11 +-- ...anual-efi-aarc

[PATCH 2/2] Revert "qemu: Match firmware with fully resolved and canonicalized paths"

2025-07-29 Thread Peter Krempa via Devel
From: Peter Krempa The canonicalization of the paths is not mocked properly and thus the tests depend on the host system. While the tests do pass on our CI they break on real deployments at least on Fedora 42. Since we're in code freeze for the upcoming release, revert the patch instead of attem

Re: [PATCH 0/2] qemu: Match firmware with fully resolved and canonicalized paths

2025-07-29 Thread Daniel P . Berrangé via Devel
On Tue, Jul 29, 2025 at 01:02:18PM +0200, Peter Krempa via Devel wrote: > On Tue, Jul 29, 2025 at 10:42:09 +0200, Michal Prívozník via Devel wrote: > > On 7/24/25 15:49, James Le Cuirot wrote: > > > From: James Le Cuirot > > > > > > Distros may provide compatibility symlinks after moving firmware