Re: [PATCH 04/14] qemu: Generalize filtering in qemuMonitorJSONParsePropsList

2025-09-08 Thread Peter Krempa via Devel
On Thu, Sep 04, 2025 at 16:46:52 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > qemuMonitorJSONParsePropsList supported filtering based on type. Let's > replace it with a callback supplied by the caller to allow for more > advanced filtering. > > Signed-off-by: Jiri Denemark >

Re: [PATCH 2/8] qemu: Allow to define NUMA nodes without memory or CPUs assigned

2025-09-08 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:08:57PM +0200, Andrea Righi wrote: > Allow to define NUMA nodes without memory or CPUs assigned to properly > support the new acpi-generic-initiator device. > > This is required because the NUMA nodes passed to the > acpi-generic-initiator object must be independent and

Re: [PATCH 8/8] NEWS: Mention new acpi-generic-initiator support

2025-09-08 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:09:03PM +0200, Andrea Righi wrote: > Signed-off-by: Andrea Righi > --- > NEWS.rst | 10 ++ > 1 file changed, 10 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange

Re: [PATCH v3 01/13] ch: add ch_hotplug.{h,c} files to CH build

2025-09-08 Thread Michal Prívozník via Devel
On 9/4/25 14:10, Stefan Kober wrote: > The files are meant to contain all device hotplug related code. The > first implementation will be live storage attach and detach. > > On-behalf-of: SAP stefan.ko...@sap.com > Signed-off-by: Stefan Kober > --- > src/ch/ch_hotplug.c | 35

Re: [libvirt PATCH] esx: pass 'long' to curl_easy_setopt when needed

2025-09-08 Thread Peter Krempa via Devel
On Tue, Sep 02, 2025 at 14:34:04 +0200, Ján Tomko via Devel wrote: > From: Ján Tomko > > The include header got its type checks fixed in curl 8.14: > https://github.com/curl/curl/commit/79b4e56b3f30dc1ac28a81128a07d27338e5219e > https://github.com/curl/curl/pull/17143 > > This causes a warning o

Re: [PATCH 10/14] qemu: Merge qemuMonitorJSONGetCPUData in qemuMonitorJSONGetGuestCPU

2025-09-08 Thread Peter Krempa via Devel
On Thu, Sep 04, 2025 at 16:46:58 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > The qemuMonitorJSONGetCPUData function is just a wrapper around two > function calls and it is only used by qemuMonitorJSONGetGuestCPU. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_monito

Re: [PATCH 12/14] qemu: Merge qemuMonitorJSONGetCPUDataDisabled in qemuMonitorJSONGetGuestCPU

2025-09-08 Thread Peter Krempa via Devel
On Thu, Sep 04, 2025 at 16:47:00 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > The qemuMonitorJSONGetCPUDataDisabled function is just a wrapper around > two function calls and it is only used by qemuMonitorJSONGetGuestCPU. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qem

Re: [PATCH 11/14] qemu: Always fetch disabled features in qemuMonitorJSONGetGuestCPU

2025-09-08 Thread Peter Krempa via Devel
On Thu, Sep 04, 2025 at 16:46:59 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > The function is always called with both enabled and disabled pointers > set. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_monitor_json.c | 6 ++ > 1 file changed, 2 insertions(+), 4 d

Re: [PATCH v3 1/3] qemu: support riscv-aia feature for RISC-V KVM

2025-09-08 Thread Peter Krempa via Devel
On Thu, Sep 04, 2025 at 17:04:49 +0800, BillXiang wrote: > From: xiangwencheng > > riscv-aia feature was introduced in qemu-8.2 to specify the > KVM AIA mode. The "riscv-aia" parameter is passed along with > -accel in QEMU command-line. > 1) "riscv-aia=emul": IMSIC is emulated by hypervisor > 2)

Re: [PATCH v3 3/3] docs: formatdomain: add doc for riscv-aia feature

2025-09-08 Thread Peter Krempa via Devel
On Thu, Sep 04, 2025 at 17:09:15 +0800, BillXiang wrote: > From: xiangwencheng > > Signed-off-by: BillXiang > --- > docs/formatdomain.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst > index 9f7311b6d5..a694eeb140 100644 > --- a/docs/

Re: [PATCH 07/14] qemu: Use qom-list-get for checking enabled CPU features

2025-09-08 Thread Peter Krempa via Devel
On Thu, Sep 04, 2025 at 16:46:55 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > qom-list-get is a new QMP command (since QEMU 10.1) that combines > qom-list for listing properties of a specified object with qom-get for > getting a value of a given property. The new command provid

Re: [PATCH 08/14] tests: Test qemuMonitorJSONGetGuestCPU with qom-get-list

2025-09-08 Thread Peter Krempa via Devel
On Thu, Sep 04, 2025 at 16:46:56 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > The test cases show both the legacy method and the new one produce > identical results. > > Signed-off-by: Jiri Denemark > --- > .../get-guest-cpu-SierraForest.json | 2985 +++

Re: [PATCH v3 10/13] ch: add virCHMonitorBuildKeyValueJson

2025-09-08 Thread Michal Prívozník via Devel
On 9/4/25 14:10, Stefan Kober wrote: > On-behalf-of: SAP stefan.ko...@sap.com > Signed-off-by: Stefan Kober > --- > src/ch/ch_monitor.c | 18 ++ > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c > index 710ba06d2d..6ed78

Re: [PATCH v3 08/13] ch: implement disk attach in public API

2025-09-08 Thread Michal Prívozník via Devel
On 9/4/25 14:10, Stefan Kober wrote: > On-behalf-of: SAP stefan.ko...@sap.com > Signed-off-by: Stefan Kober > --- > src/ch/ch_driver.c | 44 + > src/ch/ch_hotplug.c | 48 - > 2 files changed, 87 insertions(+), 5

Re: [PATCH v3 12/13] ch: implement disk device detach in public API

2025-09-08 Thread Michal Prívozník via Devel
On 9/4/25 14:10, Stefan Kober wrote: > On-behalf-of: SAP stefan.ko...@sap.com > Signed-off-by: Stefan Kober > --- > src/ch/ch_driver.c | 42 +++ > src/ch/ch_hotplug.c | 175 > src/ch/ch_hotplug.h | 6 ++ > 3 files changed, 223 insertions(+)

Re: [PATCH v3 07/13] ch: add disk attach helper functions

2025-09-08 Thread Michal Prívozník via Devel
On 9/4/25 14:10, Stefan Kober wrote: > On-behalf-of: SAP stefan.ko...@sap.com > Signed-off-by: Stefan Kober > --- > po/POTFILES | 1 + > src/ch/ch_hotplug.c | 85 + > 2 files changed, 86 insertions(+) > > diff --git a/po/POTFILES b/po/POTFILES

Re: [PATCH v3 04/13] ch: refactor virCHMonitorBuildDiskJson

2025-09-08 Thread Michal Prívozník via Devel
On 9/4/25 14:10, Stefan Kober wrote: > Refactor BuildDiskJson to return a virJSONValue instead of adding the > disk json to an json array. This makes the function reusable for > hotplugging disks. > > On-behalf-of: SAP stefan.ko...@sap.com > Signed-off-by: Stefan Kober > --- > src/ch/ch_monitor.

Re: [PATCH v3 05/13] ch: add/use virCHMonitorPut function

2025-09-08 Thread Michal Prívozník via Devel
On 9/4/25 14:10, Stefan Kober wrote: > This allows users to call API endpoints that require passing data in a > generic way. Previously, only virCHMonitorPutNoContent was offered. > > On-behalf-of: SAP stefan.ko...@sap.com > Signed-off-by: Stefan Kober > --- > src/ch/ch_monitor.c | 49 ++

Re: [PATCH v3 00/13] CH: Add disk hotplug support to Cloud Hypervisor domains

2025-09-08 Thread Michal Prívozník via Devel
On 9/4/25 14:10, Stefan Kober wrote: > This patchset adds the necessary functionality to support disk hotplugging in > the CH driver. > > Some alias handling that can be extended to other device types is added, in > order to allow detaching the devices via the Cloud Hypervisor API. > > Stefan K

Re: [PATCH 06/14] qemu: Parse properties list from any JSON array

2025-09-08 Thread Peter Krempa via Devel
On Thu, Sep 04, 2025 at 16:46:54 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > The qemuMonitorJSONParsePropsList API expected a QMP reply as an input. > By generalizing it to work on any JSON array, we can reuse the API even > for commands which return the array of properties ne

Re: [PATCH 09/14] qemu: Add qemuMonitorJSONCPUDataAddFeatures helper

2025-09-08 Thread Peter Krempa via Devel
On Thu, Sep 04, 2025 at 16:46:57 +0200, Jiri Denemark via Devel wrote: > From: Jiri Denemark > > The function translates a list of CPU feature names retrieved from QEMU > and adds them to virCPUData. > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_monitor_json.c | 43 +++

Re: [PATCH 0/3] A couple improvements when auto-adding PCI controllers

2025-09-08 Thread Ján Tomko via Devel
On a Wednesday in 2025, Laine Stump via Devel wrote: The 1st patch fixes a tiny omission from a feature added several years ago, which slightly improves the error message when you attempt to add a pcie-to-pci-bridge controller to a domain that has no PCIe bus. The 2nd improves that error message

Re: [PATCH 04/14] qemu: Generalize filtering in qemuMonitorJSONParsePropsList

2025-09-08 Thread Ján Tomko via Devel
On a Thursday in 2025, Jiri Denemark via Devel wrote: From: Jiri Denemark qemuMonitorJSONParsePropsList supported filtering based on type. Let's replace it with a callback supplied by the caller to allow for more advanced filtering. Signed-off-by: Jiri Denemark --- src/qemu/qemu_monitor_json.

Re: [PATCH 5/8] qemu: Generate acpi-generic-initiator command from acpi nodeset

2025-09-08 Thread Daniel P . Berrangé via Devel
On Mon, Sep 08, 2025 at 07:15:18PM +0200, Andrea Righi wrote: > Hi Daniel, > > On Mon, Sep 08, 2025 at 06:02:20PM +0100, Daniel P. Berrangé wrote: > > On Sat, Sep 06, 2025 at 03:09:00PM +0200, Andrea Righi wrote: > > > Signed-off-by: Andrea Righi > > > --- > > > src/qemu/qemu_command.c | 45

Re: [PATCH 7/8] docs: Document acpi nodeset in hostdev

2025-09-08 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:09:02PM +0200, Andrea Righi wrote: > Add documentation for the new element in hostdev, > which allows associating devices with ACPI Generic Initiator objects in > QEMU. > > A typical use case is NVIDIA Multi-Instance GPU (MIG), where a physical > GPU is partitioned into

[PATCH] esx: Satisfy curl type checks

2025-09-08 Thread Michal Privoznik via Devel
From: Michal Privoznik Since its commit [1] curl now performs type checks on curl_easy_setopt(). Some options expect long but we're passing an int. The fix consists mostly of specifying type of numbers passed to the function. Except for two cases: proxy_type and proxy_port which are stored in a s

Re: [PATCH 3/8] conf: Add nodeset attribute to the element

2025-09-08 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:08:58PM +0200, Andrea Righi wrote: > This enables partitioning of PCI devices into multiple isolated > instances, each requiring a dedicated virtual NUMA node definition. > > Link: https://mail.gnu.org/archive/html/qemu-arm/2024-03/msg00358.html > Signed-off-by: Andrea R

Re: [PATCH] qemu: block: Always enable discard forwarding for 'throttle' filter layer

2025-09-08 Thread Michal Prívozník via Devel
On 9/5/25 10:13, Peter Krempa via Devel wrote: > From: Peter Krempa > > Discards ought to be forwarded to the protocol nodes where we control > if discard actually happens. > > Unconditionally enable discard='unmap' for the intermediate layer. > > Closes: https://gitlab.com/libvirt/libvirt/-/is

Re: [PATCH 6/8] qemu: Add acpi-generic-initiator unit test

2025-09-08 Thread Daniel P . Berrangé via Devel
On Sat, Sep 06, 2025 at 03:09:01PM +0200, Andrea Righi wrote: > Signed-off-by: Andrea Righi > --- > .../acpi-generic-initiator.x86_64-latest.args | 55 > .../acpi-generic-initiator.x86_64-latest.xml | 63 +++ > .../acpi-generic-initiator.xml| 63 +

Re: [PATCH v2 00/10] qemu: Fixes to firmware selection

2025-09-08 Thread Jim Fehlig via Devel
Hi Andrea, Is there anything I can do to help move this series forward? I think 8/10 can now be considered for merging, correct? BTW, I'm fine with the patch order, based on your rational in 4/10 https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/PZEMOM474JUHWIIX3SOUITBHH