Re: [PATCH 06/31] tests: Rename usb-controller-implicit-*

2025-09-15 Thread Peter Krempa via Devel
On Tue, Aug 19, 2025 at 18:22:10 +0200, Andrea Bolognani via Devel wrote: > To usb-controller-automatic-*. > > This matches the existing q35 test, and in general makes more > sense as a name since these tests are providing coverage for > USB controllers getting automatically added by libvirt for n

[PATCH 1/4] virprocess: Report errno if virProcessAbort() fails

2025-09-15 Thread Michal Privoznik via Devel
From: Michal Privoznik The aim of virProcessAbort() is to reap a child process. It does so by waitpid()-ing and possibly sending SIGTERM/SIGKILL to the child process (and waitpid()-ing again). Nevertheless, if everything fails a debug message is printed. But the message mentions only the PID and

Re: [PATCH 01/31] tests: Fix typo in usb-controller-nec-xhci-autoassign

2025-09-15 Thread Peter Krempa via Devel
On Tue, Aug 19, 2025 at 18:22:05 +0200, Andrea Bolognani via Devel wrote: > Signed-off-by: Andrea Bolognani > --- > ...gs => usb-controller-nec-xhci-autoassign.x86_64-latest.args} | 0 > ...xml => usb-controller-nec-xhci-autoassign.x86_64-latest.xml} | 0 > ...ci-autoassign.xml => usb-controller-

Re: [PATCH 04/31] tests: Don't set PCI address in usb-controller-default tests

2025-09-15 Thread Peter Krempa via Devel
On Tue, Aug 19, 2025 at 18:22:08 +0200, Andrea Bolognani via Devel wrote: > We want to ensure that libvirt will automatically allocate the > PCI address, and setting it ourselves ahead of time will > prevent that from happening. > > In the case of q35, this change will cause additional PCI > contr

Re: [PATCH v4 07/10] qmp: add chardev-resize command

2025-09-15 Thread Filip Hejsek
On Fri, 2025-09-12 at 16:01 +0200, Markus Armbruster wrote: > Cc: libvirt > > Filip Hejsek writes: > > > From: Szymon Lukasz > > > > The managment software can use this command to notify QEMU about the > > size of the terminal connected to a chardev, QEMU can then forward this > > information

Re: [PATCH 09/31] qemu: Check for pci-ohci availability

2025-09-15 Thread Peter Krempa via Devel
On Tue, Aug 19, 2025 at 18:22:13 +0200, Andrea Bolognani via Devel wrote: > We assign the USB controller model without first checking > whether the corresponding QEMU device is available, and that > results in a late error instead of an early one. > > Be consistent with how we do things in all oth

Re: [PATCH 07/31] tests: Expand coverage for automatic/default USB controllers

2025-09-15 Thread Peter Krempa via Devel
On Tue, Aug 19, 2025 at 18:22:11 +0200, Andrea Bolognani via Devel wrote: > We're missing a significant number of scenarios, including > those involving fairly common machine types and architectures. > > Signed-off-by: Andrea Bolognani > --- Reviewed-by: Peter Krempa

Re: [PATCH 10/31] tests: Use realview-eb instead of realview-pbx-a9

2025-09-15 Thread Peter Krempa via Devel
On Tue, Aug 19, 2025 at 18:22:14 +0200, Andrea Bolognani via Devel wrote: > QEMU implements 4 different "realview" machine types: > > $ qemu-system-aarch64 -machine help 2>&1 | grep realview > realview-eb ARM RealView Emulation Baseboard (ARM926EJ-S) > realview-eb-mpcore ARM RealV

Re: [PATCH 02/31] tests: Drop coverage for versatilepb on aarch64

2025-09-15 Thread Peter Krempa via Devel
On Tue, Aug 19, 2025 at 18:22:06 +0200, Andrea Bolognani via Devel wrote: > We already test the machine type on armv7l and realview on > aarch64, so these handful of test cases can be dropped without > negatively impacting our coverage. > > Signed-off-by: Andrea Bolognani > --- Reviewed-by: Pete

Re: [PATCH 03/31] tests: Don't use memballoon=none for minimal tests

2025-09-15 Thread Peter Krempa via Devel
On Tue, Aug 19, 2025 at 18:22:07 +0200, Andrea Bolognani via Devel wrote: > It's redundant (these machine types don't get a memballoon added > automatically anyway), plus the test is supposed to show what > happens when a minimal configuration is fed to libvirt and > including additional elements g