Thank you Ján, I have fixed this in the next version
My apologies Peter, this is my first time upstream. The first two versions were
internally reviewed
> and merged. Congratulations on your first libvirt contribution!
Thank you Michal ! Glad to help :-)
> So while I agree that it needs to work properly with the reservation
> code, with the way the code is structured I don't think we should hide
> something which reserves ports into code that is not expected to do
> that.
Yeah, I see what you're saying. Given this, there are some options available
> On Tue, Jul 22, 2025 at 13:50:19 -0400, Aaron M. Brown wrote:
>
> One definition per line.
>
Okay I will remember that going forward!
>
> This is suspicious because this function until now just returned the
> next eligible port, but now it's also reserving it which doesn't seem to
> fit well
