Re: [OMPI devel] openmpi-3.1.0 cygwin patch

2018-06-18 Thread Marco Atzeri

On 6/16/2018 6:15 PM, Jeff Squyres (jsquyres) via devel wrote:

Thanks Macro.  I've filed https://github.com/open-mpi/ompi/pull/5277 here for 
master; will follow up with PR's to the release branches after that passes CI / 
is merged.



Hi Jeff,
please apply both patches

the current 3.1.0 package is built with the first one and libevent internal.
http://www.cygwin.com/ml/cygwin-announce/2018-06/msg00010.html


While both the internal and external build complete and pass the tests,
only the internal one is correctly working with examples and
osu bechmarks.

The build with external libevent frozes with no messages when trying the
examples.
For personal reason I have no much time to investigate; so it could take 
time to identify the root cause.

One possibility is that libevent package was built with gcc-6.3 and
now for openmpi I am using the gcc-7.3.

Same for 3.1.1rc1

Regards
Marco





___
devel mailing list
devel@lists.open-mpi.org
https://lists.open-mpi.org/mailman/listinfo/devel


Re: [OMPI devel] openmpi-3.1.0 cygwin patch

2018-06-16 Thread Jeff Squyres (jsquyres) via devel
Thanks Macro.  I've filed https://github.com/open-mpi/ompi/pull/5277 here for 
master; will follow up with PR's to the release branches after that passes CI / 
is merged.


> On Jun 11, 2018, at 10:43 AM, Marco Atzeri  wrote:
> 
> On 5/28/2018 11:58 AM, Marco Atzeri wrote:
>> On 5/24/2018 11:07 AM, Marco Atzeri wrote:
>>> On 5/23/2018 2:58 PM, Gilles Gouaillardet wrote:
 Marco,
 
 Have you tried to build Open MPI with an external (e.g. Cygwin provided) 
 libevent library ?
 If that works, I think that would be the preferred method.
 
 Cheers,
 
 Gilles
>>> 
>>> I will try.
>>> If I remember right there was an issue in the past as
>>> somewhere a WIN32 was defined an it was screwing the build.
>>> 
>>> Regards
>>> Marco
>>> 
>> I am validating a patch workaround to see if it works with both
>> internal and external libevent.
>> The build with external libevent passed all
>> osu-micro-benchmarks-5.4.2 MPI tests
> 
> attached patch allows build of 3.1.0 on cygwin 32 bit
> and 64 bit versions, configured with
> 
>--with-libevent=external \
>--disable-mca-dso \
>--disable-sysv-shmem \
>--enable-cxx-exceptions \
>--with-threads=posix \
>--without-cs-fs \
>--with-mpi-param_check=always \
>--enable-contrib-no-build=vt,libompitrace \
> --enable-mca-no-build=paffinity,installdirs-windows,timer-windows,shmem-sysv,patcher
> 
> the 64 bit version also use
>  --enable-builtin-atomics
> 
> Tested with libevent 2.0.22-1
> 
> Regards
> Marco
> 
> ___
> devel mailing list
> devel@lists.open-mpi.org
> https://lists.open-mpi.org/mailman/listinfo/devel


-- 
Jeff Squyres
jsquy...@cisco.com

___
devel mailing list
devel@lists.open-mpi.org
https://lists.open-mpi.org/mailman/listinfo/devel


Re: [OMPI devel] openmpi-3.1.0 cygwin patch

2018-06-11 Thread Marco Atzeri

On 5/28/2018 11:58 AM, Marco Atzeri wrote:

On 5/24/2018 11:07 AM, Marco Atzeri wrote:

On 5/23/2018 2:58 PM, Gilles Gouaillardet wrote:

Marco,

Have you tried to build Open MPI with an external (e.g. Cygwin 
provided) libevent library ?

If that works, I think that would be the preferred method.

Cheers,

Gilles


I will try.
If I remember right there was an issue in the past as
somewhere a WIN32 was defined an it was screwing the build.

Regards
Marco



I am validating a patch workaround to see if it works with both
internal and external libevent.

The build with external libevent passed all
osu-micro-benchmarks-5.4.2 MPI tests



attached patch allows build of 3.1.0 on cygwin 32 bit
and 64 bit versions, configured with

--with-libevent=external \
--disable-mca-dso \
--disable-sysv-shmem \
--enable-cxx-exceptions \
--with-threads=posix \
--without-cs-fs \
--with-mpi-param_check=always \
--enable-contrib-no-build=vt,libompitrace \

--enable-mca-no-build=paffinity,installdirs-windows,timer-windows,shmem-sysv,patcher

the 64 bit version also use
  --enable-builtin-atomics

Tested with libevent 2.0.22-1

Regards
Marco

--- origsrc/openmpi-3.1.0/opal/mca/event/external/external.h2018-05-07 
22:42:22.0 +0200
+++ src/openmpi-3.1.0/opal/mca/event/external/external.h2018-05-25 
19:54:58.710800500 +0200
@@ -22,6 +22,10 @@
 
 #include "opal_config.h"
 
+#if defined(__CYGWIN__) && defined(WIN32)
+#undef WIN32
+#endif 
+
 #include "event.h"
 #include "event2/event.h"
 #include "event2/thread.h"
___
devel mailing list
devel@lists.open-mpi.org
https://lists.open-mpi.org/mailman/listinfo/devel

Re: [OMPI devel] openmpi-3.1.0 cygwin patch

2018-05-28 Thread Marco Atzeri

On 5/24/2018 11:07 AM, Marco Atzeri wrote:

On 5/23/2018 2:58 PM, Gilles Gouaillardet wrote:

Marco,

Have you tried to build Open MPI with an external (e.g. Cygwin 
provided) libevent library ?

If that works, I think that would be the preferred method.

Cheers,

Gilles


I will try.
If I remember right there was an issue in the past as
somewhere a WIN32 was defined an it was screwing the build.

Regards
Marco



I am validating a patch workaround to see if it works with both
internal and external libevent.

The build with external libevent passed all
osu-micro-benchmarks-5.4.2 MPI tests



Regards
Marco

___
devel mailing list
devel@lists.open-mpi.org
https://lists.open-mpi.org/mailman/listinfo/devel


Re: [OMPI devel] openmpi-3.1.0 cygwin patch

2018-05-24 Thread Marco Atzeri

On 5/23/2018 2:58 PM, Gilles Gouaillardet wrote:

Marco,

Have you tried to build Open MPI with an external (e.g. Cygwin provided) 
libevent library ?

If that works, I think that would be the preferred method.

Cheers,

Gilles


I will try.
If I remember right there was an issue in the past as
somewhere a WIN32 was defined an it was screwing the build.

Regards
Marco



___
devel mailing list
devel@lists.open-mpi.org
https://lists.open-mpi.org/mailman/listinfo/devel


Re: [OMPI devel] openmpi-3.1.0 cygwin patch

2018-05-23 Thread Gilles Gouaillardet
Marco,

Have you tried to build Open MPI with an external (e.g. Cygwin provided)
libevent library ?
If that works, I think that would be the preferred method.

Cheers,

Gilles

On Wednesday, May 23, 2018, Marco Atzeri  wrote:

> The attached patch allows the compilation of openmpi-3.1.0
> on cygwin 32 and 64 bit with gcc 7.3
>
>
> It is basically the same already proposed in the past for 2.1.2
>
> I will release the cygwin package as soon we roll out
> the gcc 7.3 compiler
>
> Regards
> Marco
>
___
devel mailing list
devel@lists.open-mpi.org
https://lists.open-mpi.org/mailman/listinfo/devel

[OMPI devel] openmpi-3.1.0 cygwin patch

2018-05-23 Thread Marco Atzeri

The attached patch allows the compilation of openmpi-3.1.0
on cygwin 32 and 64 bit with gcc 7.3


It is basically the same already proposed in the past for 2.1.2

I will release the cygwin package as soon we roll out
the gcc 7.3 compiler

Regards
Marco
--- origsrc/openmpi-3.1.0/opal/mca/event/libevent2022/libevent/event.h  
2018-05-07 22:42:22.0 +0200
+++ src/openmpi-3.1.0/opal/mca/event/libevent2022/libevent/event.h  
2018-05-21 15:05:39.09000 +0200
@@ -56,7 +56,7 @@ extern "C" {
 /* For int types. */
 #include 
 
-#ifdef WIN32
+#if defined(WIN32) && !defined(__CYGWIN__)
 #ifndef WIN32_LEAN_AND_MEAN
 #define WIN32_LEAN_AND_MEAN
 #endif
___
devel mailing list
devel@lists.open-mpi.org
https://lists.open-mpi.org/mailman/listinfo/devel