Marco,

can you please give the attached patch a try ?


so far, it compiles for me.


btw, i faced some issues (conflicting definitions between windows.h and netdb.h),

did you need some patches in order to solve these issues ?


Cheers,


Gilles


On 10/31/2017 1:25 AM, Marco Atzeri wrote:
ping ?
It is a blocking issue for any effort to move on
further cygwin release after 1.10.7

https://github.com/open-mpi/ompi/issues/4282


On 28/09/2017 21:33, Marco Atzeri wrote:
Hi,
restarting the effort to build 2.1.2 on cygwin I hit:

make[2]: Entering directory '/cygdrive/e/cyg_pub/devel/openmpi/v2.1/openmpi-2.1.2-1.x86_64/build/opal/mca/memory/patcher'
   CC       memory_patcher_component.lo
/cygdrive/e/cyg_pub/devel/openmpi/v2.1/openmpi-2.1.2-1.x86_64/src/openmpi-2.1.2/opal/mca/memory/patcher/memory_patcher_component.c: In function ‘_intercept_munmap’: /cygdrive/e/cyg_pub/devel/openmpi/v2.1/openmpi-2.1.2-1.x86_64/src/openmpi-2.1.2/opal/mca/memory/patcher/memory_patcher_component.c:98:32: warning: implicit declaration of function ‘syscall’ [-Wimplicit-function-declaration]
  #define memory_patcher_syscall syscall

I tried with configuration

  --disable-mca-dso \
  --disable-sysv-shmem \
  --enable-cxx-exceptions \
  --with-threads=posix \
  --without-cs-fs \
  --with-mpi-param_check=always \
  --enable-contrib-no-build=vt,libompitrace \

--enable-mca-no-build=paffinity,installdirs-windows,timer-windows,shmem-sysv,patcher

but it is not effective.

I would expect that of directories

opal/mca/memory/base
opal/mca/memory/malloc_solaris
opal/mca/memory/patcher

only base is build and the other two : patcher and malloc_solaris,
  are skipped as the conditions are not met.

Suggestion/Workaround ?

Regards
Marco

_______________________________________________
devel mailing list
devel@lists.open-mpi.org
https://lists.open-mpi.org/mailman/listinfo/devel

diff -ruN orig/openmpi-2.1.2/opal/mca/memory/patcher/memory_patcher_component.c 
openmpi-2.1.2/opal/mca/memory/patcher/memory_patcher_component.c
--- orig/openmpi-2.1.2/opal/mca/memory/patcher/memory_patcher_component.c       
2017-08-11 01:15:56.000000000 +0900
+++ openmpi-2.1.2/opal/mca/memory/patcher/memory_patcher_component.c    
2017-10-31 16:36:21.266989000 +0900
@@ -152,6 +152,7 @@
 
 #endif
 
+#if defined (SYS_munmap)
 static int (*original_munmap) (void *, size_t);
 
 static int _intercept_munmap(void *start, size_t length)
@@ -177,6 +178,7 @@
     OPAL_PATCHER_END;
     return result;
 }
+#endif
 
 #if defined (SYS_mremap)
 
@@ -484,10 +486,12 @@
     }
 #endif
 
+#if defined (SYS_munmap)
     rc = opal_patcher->patch_symbol ("munmap", (uintptr_t)intercept_munmap, 
(uintptr_t *) &original_munmap);
     if (OPAL_SUCCESS != rc) {
         return rc;
     }
+#endif
 
 #if defined (SYS_mremap)
     rc = opal_patcher->patch_symbol ("mremap",(uintptr_t)intercept_mremap, 
(uintptr_t *) &original_mremap);
_______________________________________________
devel mailing list
devel@lists.open-mpi.org
https://lists.open-mpi.org/mailman/listinfo/devel

Reply via email to