The first variable can probably be moved to opal pretty easily. That is
used when we need to fully shutdown the BTLs and re-init them on continue.
We do not have to do that for tcp (since we leave the sockets open), but do
have to do that for IB, for example.
The second call is a bit tricky since
Josh,
I had a look at the code (e.g., opal/mca/btl/sm/btl_sm.c) and there are
two uses of orte code:
if (orte_cr_continue_like_restart)
and
/* On restart we need the old file names to exist (not necessarily
* contain content) so the CRS component does not fail when searching
* for these o
I have seen it. I am still waiting for things to settle down before I
start fixing the FT code ( again ;-)
Adrian
On Mon, Aug 11, 2014 at 01:40:33PM +, Jeff Squyres (jsquyres) wrote:
> Ah, I see.
>
> Ok -- add it to the list of
> FT-things-to-be-fixed-before-FT-can-be-suppor
Ah, I see.
Ok -- add it to the list of
FT-things-to-be-fixed-before-FT-can-be-supported-again (which I think Josh just
did :-) ).
Also: Adrian -- FYI. :-)
On Aug 11, 2014, at 9:05 AM, George Bosilca wrote:
> I just checked the code and noticed that all the usages of the sstore are
> prote
I just checked the code and noticed that all the usages of the sstore are
protected by an OPAL_ENABLE_FT_CR define. As we are not supporting FT, I
don't think this is something we should spend time fixing right now.
George.
On Sat, Aug 9, 2014 at 8:06 AM, Jeff Squyres (jsquyres)
wrote:
> I
Those calls should be protected with the CR FT #define - If I remember
correctly. We were using the sstore to track the shared memory file names
so we could clean them up on restart.
I'm not sure if the sstore framework is necessary in this location, since
we should be able to tell opal_crs and it
I think you're making a joke, right...?
I see direct calls to ORTE sstore functionality in all three.
On Aug 8, 2014, at 5:42 PM, George Bosilca wrote:
> These are harmless. They are only used when FT is enabled which should rarely
> be the case.
>
> George.
>
>
>
> On Fri, Aug 8, 201
These are harmless. They are only used when FT is enabled which should
rarely be the case.
George.
On Fri, Aug 8, 2014 at 4:36 PM, Jeff Squyres (jsquyres)
wrote:
> Here's a few ORTE headers in OPAL source -- can respective owners clean
> these up? Thanks.
>
> -
> mca/btl/smcuda/btl_smc
Here's a few ORTE headers in OPAL source -- can respective owners clean these
up? Thanks.
-
mca/btl/smcuda/btl_smcuda.c
63:#include "orte/mca/sstore/sstore.h"
mca/btl/sm/btl_sm.c
62:#include "orte/mca/sstore/sstore.h"
mca/mpool/sm/mpool_sm_module.c
34:#include "orte/mca/sstore/sstore.h"
--
