Re: [OMPI devel] opal/mca/dl/ opal_dl_open with NULL fname - assert?

2016-05-05 Thread Josh Hursey
Ok. I started a PR here: https://github.com/open-mpi/ompi/pull/1639 I want to do a bit of testing (building now), but this should be an easy fix. Thanks On Thu, May 5, 2016 at 3:07 PM, Jeff Squyres (jsquyres) wrote: > Agreed, this looks like an oversight. > > In dl.h, I even said that you c

Re: [OMPI devel] opal/mca/dl/ opal_dl_open with NULL fname - assert?

2016-05-05 Thread Jeff Squyres (jsquyres)
Agreed, this looks like an oversight. In dl.h, I even said that you could pass NULL as fname: https://github.com/open-mpi/ompi/blob/master/opal/mca/dl/dl.h#L67 These asserts can safely be removed. Thanks! > On May 5, 2016, at 3:40 PM, Josh Hursey wrote: > > We noticed that there is an a

[OMPI devel] opal/mca/dl/ opal_dl_open with NULL fname - assert?

2016-05-05 Thread Josh Hursey
We noticed that there is an assert(fname) in both of the dl components: * https://github.com/open-mpi/ompi/blob/master/opal/mca/dl/dlopen/dl_dlopen_module.c#L53 * https://github.com/open-mpi/ompi/blob/master/opal/mca/dl/libltdl/dl_libltdl_module.c#L21 But according to the dl.h, NULL should be