Re: [OMPI devel] return value of opal_compress_base_register() in opal/mca/compress/base/compress_base_open.c

I have commited fixes for opal/mca/compress/base/compress_base_open.c and opal/mca/crs/base/crs_base_open.c which return OPAL_SUCCESS but do not open the components if CR is disabled. Adrian On Tue, Jan 07, 2014 at 01:43:00PM -0600, Josh Hursey wrote: > Either would be fine

Re: [OMPI devel] return value of opal_compress_base_register() in opal/mca/compress/base/compress_base_open.c

Either would be fine with me. If you left in the verbose message then it might be a bit confusing to any user that might see it. On Fri, Jan 3, 2014 at 9:13 AM, Ralph Castain wrote: > That would work. Alternatively, you could try just returning OPAL_SUCCESS > in place of

Re: [OMPI devel] return value of opal_compress_base_register() in opal/mca/compress/base/compress_base_open.c

That would work. Alternatively, you could try just returning OPAL_SUCCESS in place of OPAL_ERR_NOT_AVAILABLE. This would still avoid opening the components for no reason (thus saving some memory) while not causing opal_init to abort. On Jan 3, 2014, at 3:19 AM, Adrian Reber

Re: [OMPI devel] return value of opal_compress_base_register() in opal/mca/compress/base/compress_base_open.c

So removing all output like in this patch would be ok? diff --git a/opal/mca/compress/base/compress_base_open.c b/opal/mca/compress/base/compress_base_open.c index a09fe59..f487752 100644 --- a/opal/mca/compress/base/compress_base_open.c +++ b/opal/mca/compress/base/compress_base_open.c @@

Re: [OMPI devel] return value of opal_compress_base_register() in opal/mca/compress/base/compress_base_open.c

I think the only reason I protected that framework is to reduce the overhead of an application using a build of Open MPI with CR support, but no enabling it at runtime. Nothing in the compress framework depends on the CR infrastructure (although the CR infrastructure can use the compress framework

[OMPI devel] return value of opal_compress_base_register() in opal/mca/compress/base/compress_base_open.c

Right now the C/R code fails because of a change introduced in opal/mca/compress/base/compress_base_open.c in 2013 with commit git 734c724ff76d9bf814f3ab0396bcd9ee6fddcd1b svn r28239 Update OPAL frameworks to use the MCA framework system. This commit changed a lot but also the return value