Re: [OMPI devel] Error message improvement

Bottom line is: just hardcode the function name. It isn't that hard, and it avoids confusion of sometimes getting function names, and sometimes getting file names...which is why you'll find everything (at least, that I have seen) hardcoded. On Sep 9, 2009, at 12:45 PM, Eugene Loh wrote:

Re: [OMPI devel] Error message improvement

N.M. Maclaren wrote: On Sep 9 2009, George Bosilca wrote: On Sep 9, 2009, at 14:16 , Lenny Verkhovsky wrote: does C99 complient compiler is something unusual or is there a policy among OMPI developers/users that prevent me f rom using __func__ instead of hardcoded strings in the code ?

Re: [OMPI devel] Error message improvement

fixed in r21956 __FUNCTION__ was replaced with __func__ thanks. Lenny. On Wed, Sep 9, 2009 at 2:59 PM, N.M. Maclaren wrote: > On Sep 9 2009, George Bosilca wrote: > >> On Sep 9, 2009, at 14:16 , Lenny Verkhovsky wrote: >> >> does C99 complient compiler is something unusual >>>

Re: [OMPI devel] Error message improvement

Hi All, does C99 complient compiler is something unusual or is there a policy among OMPI developers/users that prevent me f rom using __func__ instead of hardcoded strings in the code ? Thanks. Lenny. On Wed, Sep 9, 2009 at 1:48 PM, Nysal Jan wrote: > __FUNCTION__ is not

Re: [OMPI devel] Error message improvement

__FUNCTION__ is not portable. __func__ is but it needs a C99 compliant compiler. --Nysal On Tue, Sep 8, 2009 at 9:06 PM, Lenny Verkhovsky wrote: > fixed in r21952 > thanks. > > On Tue, Sep 8, 2009 at 5:08 PM, Arthur Huillet wrote: > >>

Re: [OMPI devel] Error message improvement

fixed in r21952 thanks. On Tue, Sep 8, 2009 at 5:08 PM, Arthur Huillet wrote: > Lenny Verkhovsky wrote: > >> Why not using __FUNCTION__ in all our error messages ??? >> > > Sounds good, this way the function names are always correct. > > -- > Greetings, A. Huillet > >

Re: [OMPI devel] Error message improvement

Lenny Verkhovsky wrote: Why not using __FUNCTION__ in all our error messages ??? Sounds good, this way the function names are always correct. -- Greetings, A. Huillet

Re: [OMPI devel] Error message improvement

Why not using __FUNCTION__ in all our error messages ??? diff -r 686ec286164a ompi/communicator/communicator.h --- a/ompi/communicator/communicator.h Tue Sep 08 14:39:03 2009 +0200 +++ b/ompi/communicator/communicator.h Tue Sep 08 15:48:06 2009 +0200 @@ -313,7 +313,7 @@ { #if OPAL_ENABLE_DEBUG