Re: [OMPI devel] Neighbor collectives with periodic Cartesian topologies of size one

2014-10-01 Thread Nathan Hjelm
I should have been clearer. This changes how the topo components are expected to work. With this change they now MUST provide the c_topo to the communicator before coll_select. The change is good but may be unexpected for any vendor topo components out there (which I doubt there are any). -Nathan

Re: [OMPI devel] Neighbor collectives with periodic Cartesian topologies of size one

2014-10-01 Thread George Bosilca
I see no change in the topo interface in any of the patches attached to this thread. Is there any other patch related to this discussion? George. > On Oct 1, 2014, at 14:52, Jeff Squyres (jsquyres) wrote: > >> On Oct 1, 2014, at 6:48 AM, Gilles Gouaillardet >>

Re: [OMPI devel] Neighbor collectives with periodic Cartesian topologies of size one

2014-10-01 Thread Jeff Squyres (jsquyres)
On Oct 1, 2014, at 6:48 AM, Gilles Gouaillardet wrote: > oops, i missed graph and dist graph :-( > > the attached patch fixes this > /* it was straightforward for graph and a bit more challenging for dist > graph */ > > i am fine for Nathan's patch for v1.8 > /*

Re: [OMPI devel] Neighbor collectives with periodic Cartesian topologies of size one

2014-10-01 Thread Gilles Gouaillardet
oops, i missed graph and dist graph :-( the attached patch fixes this /* it was straightforward for graph and a bit more challenging for dist graph */ i am fine for Nathan's patch for v1.8 /* v1.8 and trunk have already a different way to handle a memory leak */ /* the attached patch is vs v1.8

Re: [OMPI devel] Neighbor collectives with periodic Cartesian topologies of size one

2014-09-30 Thread Nathan Hjelm
Not quite right. There still is no topology information at collective selection time for either graph or dist graph. -Nathan On Tue, Sep 30, 2014 at 02:03:27PM +0900, Gilles Gouaillardet wrote: >Nathan, > >here is a revision of the previously attached patch, and that supports >

Re: [OMPI devel] Neighbor collectives with periodic Cartesian topologies of size one

2014-09-30 Thread Gilles Gouaillardet
Nathan, here is a revision of the previously attached patch, and that supports graph and dist graph. Cheers, Gilles On 2014/09/30 0:05, Nathan Hjelm wrote: > An equivalent change would need to be made for graph and dist graph as > well. That will take a little more work. Also, I was avoiding

Re: [OMPI devel] Neighbor collectives with periodic Cartesian topologies of size one

2014-09-29 Thread Nathan Hjelm
An equivalent change would need to be made for graph and dist graph as well. That will take a little more work. Also, I was avoiding changing anything in topo for 1.8. -Nathan On Mon, Sep 29, 2014 at 08:02:41PM +0900, Gilles Gouaillardet wrote: >Nathan, > >why not just make the topology

Re: [OMPI devel] Neighbor collectives with periodic Cartesian topologies of size one

2014-09-29 Thread Gilles Gouaillardet
Nathan, why not just make the topology information available at that point as you described it ? the attached patch does this, could you please review it ? Cheers, Gilles On 2014/09/26 2:50, Nathan Hjelm wrote: > On Tue, Aug 26, 2014 at 07:03:24PM +0300, Lisandro Dalcin wrote: >> I finally

Re: [OMPI devel] Neighbor collectives with periodic Cartesian topologies of size one

2014-09-28 Thread Lisandro Dalcin
On 25 September 2014 20:50, Nathan Hjelm wrote: > On Tue, Aug 26, 2014 at 07:03:24PM +0300, Lisandro Dalcin wrote: >> I finally managed to track down some issues in mpi4py's test suite >> using Open MPI 1.8+. The code below should be enough to reproduce the >> problem. Run it

Re: [OMPI devel] Neighbor collectives with periodic Cartesian topologies of size one

2014-08-26 Thread Nathan Hjelm
Good catch. I will take a look and see how best to fix this. -Nathan On Tue, Aug 26, 2014 at 07:03:24PM +0300, Lisandro Dalcin wrote: > I finally managed to track down some issues in mpi4py's test suite > using Open MPI 1.8+. The code below should be enough to reproduce the > problem. Run it