Re: [OMPI devel] new CRS component added (criu)

2014-02-14 Thread Jeff Squyres (jsquyres)
Can I clone your git tree and send you a patch? On Feb 11, 2014, at 4:45 PM, Adrian Reber wrote: > On Tue, Feb 11, 2014 at 08:09:35PM +, Jeff Squyres (jsquyres) wrote: >> On Feb 8, 2014, at 4:49 PM, Adrian Reber wrote: >> I note you have a stray $3 at the end of your configure.m4, too

[OMPI devel] mca_base_component_var_register() MCA_BASE_VAR_TYPE_STRING

2014-02-14 Thread Adrian Reber
I am trying to find out how to deal with string variables. Do I have to allocate the memory before calling mca_base_component_var_register() or not? It seems it does a strdup() meaning it has to be free()'d while closing the component. Looking at other occurrences of string variables I see differen

Re: [OMPI devel] new CRS component added (criu)

2014-02-14 Thread Adrian Reber
Sure. I added the cloneurl information: https://lisas.de/~adrian/open-mpi.git On Fri, Feb 14, 2014 at 04:30:05PM +, Jeff Squyres (jsquyres) wrote: > Can I clone your git tree and send you a patch? > > On Feb 11, 2014, at 4:45 PM, Adrian Reber wrote: > > > On Tue, Feb 11, 2014 at 08:09:35PM

Re: [OMPI devel] mca_base_component_var_register() MCA_BASE_VAR_TYPE_STRING

2014-02-14 Thread Jeff Squyres (jsquyres)
Believe it or not, this is actually one of the areas of the OMPI code base that is fairly well documented (gasp!). :-) Check out opal/mca/base/mca_var.h for MCA vars (i.e., MPI_T control variables), and mca_pvar.h for MPI_T performance variables. On Feb 14, 2014, at 11:31 AM, Adrian Reber w

Re: [OMPI devel] new CRS component added (criu)

2014-02-14 Thread Jeff Squyres (jsquyres)
Perfect; cloning now. Thanks! On Feb 14, 2014, at 11:34 AM, Adrian Reber wrote: > Sure. I added the cloneurl information: > > https://lisas.de/~adrian/open-mpi.git > > On Fri, Feb 14, 2014 at 04:30:05PM +, Jeff Squyres (jsquyres) wrote: >> Can I clone your git tree and send you a patch?

Re: [OMPI devel] mca_base_component_var_register() MCA_BASE_VAR_TYPE_STRING

2014-02-14 Thread Hjelm, Nathan T
On Friday, February 14, 2014 9:31 AM, devel [devel-boun...@open-mpi.org] on behalf of Adrian Reber [adr...@lisas.de] wrote: > To: de...@open-mpi.org > Subject: [OMPI devel] mca_base_component_var_register() > MCA_BASE_VAR_TYPE_STRING > > I am trying to find out how to deal with string variables.

Re: [OMPI devel] new CRS component added (criu)

2014-02-14 Thread Jeff Squyres (jsquyres)
Check out this patch: https://github.com/jsquyres/fork-from-adrian-ft/commit/f5962184f3ea6dffc182a18f7603c5e70e82ac99 On Feb 14, 2014, at 11:35 AM, "Jeff Squyres (jsquyres)" wrote: > Perfect; cloning now. Thanks! > > On Feb 14, 2014, at 11:34 AM, Adrian Reber > wrote: > >> Sure. I a

Re: [OMPI devel] new CRS component added (criu)

2014-02-14 Thread Adrian Reber
Thanks. That almost works. I need this additional change [check_crs_criu_good=yes]) # If we do not want CRIU, then do not compile this component -AS_IF([test "$with_criu" = "no"], +AS_IF([test "$with_criu" = "no" || test $check_crs_criu_good = no], [check_crs_cr

Re: [OMPI devel] new CRS component added (criu)

2014-02-14 Thread Jeff Squyres (jsquyres)
Yeah, I goofed that. Good catch. On Feb 14, 2014, at 3:40 PM, Adrian Reber wrote: > Thanks. That almost works. I need this additional change > > [check_crs_criu_good=yes]) > > # If we do not want CRIU, then do not compile this component > -AS_IF([test "$with_criu" = "no"],

Re: [OMPI devel] C/R and orte_oob

2014-02-14 Thread Ralph Castain
On Feb 13, 2014, at 11:26 AM, Adrian Reber wrote: > On Thu, Feb 06, 2014 at 02:45:07PM -0800, Ralph Castain wrote: >> On Feb 6, 2014, at 2:16 PM, Adrian Reber wrote: >> >>> Josh explained it to me a few days ago, that after a checkpoint has been >>> received TCP should no longer be used to not