Re: [OMPI devel] [OMPI svn] svn:open-mpi r15848

2007-08-14 Thread Jeff Squyres
Fixed in https://svn.open-mpi.org/trac/ompi/changeset/15850.  I also  
added much more descriptive error messages.  FWIW: I've refrained  
from adding text to the FAQ yet about the receive_queues MCA  
parameter because we will likely be changing some of the parameters  
due to changes in credit accounting in the not-distant future.


Thanks for pointing out the problem, Tim.

(Jeff kills all remaining MTTs still running from last night since  
all the openib testing will fail...)




On Aug 14, 2007, at 10:01 AM, Jeff Squyres wrote:


#$@#$  I see what happened.  The help string for the MCA parameter
said "colon" (and that's the string that I sent out last week and
pasted into the code yesterday), but the parser was actually checking
for semicolons.



On Aug 14, 2007, at 9:57 AM, Jeff Squyres wrote:


Looks like the parsing is wrong for the QP specification.

@#!@#$@!#$ I swear I checked this before I committed, but apparently
I must have goofed.  I'll go fix now...


On Aug 14, 2007, at 9:44 AM, Sven Stork wrote:


On Tuesday 14 August 2007 15:23, Tim Prins wrote:

This might be breaking things on odin. All our 64 bit openib mtt
tests
have the following output:

[odin003.cs.indiana.edu:30971] Wrong QP specification (QP 0
"P,128,256,128,16:S,1024,256,128,32:S,4096,256,128,32:S,
65536,256,128,32").
Point-to-point QP get 1-5 parameters

However, on my debug build I do not get any errors. Is anyone else
seeing this?


Just checked the mtt webpage for our viscluster which is 64. And It
shows the
same error message. By locking to the commit it looks like that the
first
triple has been extended to a quadruple ?

Cheers,
  Sven


Thanks,

Tim


jsquy...@osl.iu.edu wrote:

Author: jsquyres
Date: 2007-08-13 17:51:05 EDT (Mon, 13 Aug 2007)
New Revision: 15848
URL: https://svn.open-mpi.org/trac/ompi/changeset/15848

Log:
Change the default receive_queues value per
http://www.open-mpi.org/community/lists/devel/2007/08/2100.php.

Text files modified:
   trunk/ompi/mca/btl/openib/btl_openib_mca.c | 2 +-
   1 files changed, 1 insertions(+), 1 deletions(-)

Modified: trunk/ompi/mca/btl/openib/btl_openib_mca.c

 
=

=


--- trunk/ompi/mca/btl/openib/btl_openib_mca.c  (original)
+++ trunk/ompi/mca/btl/openib/btl_openib_mca.c  2007-08-13
17:51:05 EDT

(Mon, 13 Aug 2007)

@@ -477,7 +477,7 @@
 char *str;
 char **queues, **params = NULL;
 int num_pp_qps = 0, num_srq_qps = 0, qp = 0, ret =  
OMPI_ERROR;

-char *default_qps

= "P,128,16,4;S,1024,256,128,32;S,4096,256,128,32;S,
65536,256,128,32";

+char *default_qps

= "P,128,256,128,16:S,1024,256,128,32:S,4096,256,128,32:S,
65536,256,128,32";

 uint32_t max_qp_size, max_size_needed;

 reg_string("receive_queues",
___
svn mailing list
s...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/svn


___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel


___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel



--
Jeff Squyres
Cisco Systems

___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel



--
Jeff Squyres
Cisco Systems

___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel



--
Jeff Squyres
Cisco Systems



Re: [OMPI devel] [OMPI svn] svn:open-mpi r15848

2007-08-14 Thread Jeff Squyres
#$@#$  I see what happened.  The help string for the MCA parameter  
said "colon" (and that's the string that I sent out last week and  
pasted into the code yesterday), but the parser was actually checking  
for semicolons.




On Aug 14, 2007, at 9:57 AM, Jeff Squyres wrote:


Looks like the parsing is wrong for the QP specification.

@#!@#$@!#$ I swear I checked this before I committed, but apparently
I must have goofed.  I'll go fix now...


On Aug 14, 2007, at 9:44 AM, Sven Stork wrote:


On Tuesday 14 August 2007 15:23, Tim Prins wrote:

This might be breaking things on odin. All our 64 bit openib mtt
tests
have the following output:

[odin003.cs.indiana.edu:30971] Wrong QP specification (QP 0
"P,128,256,128,16:S,1024,256,128,32:S,4096,256,128,32:S,
65536,256,128,32").
Point-to-point QP get 1-5 parameters

However, on my debug build I do not get any errors. Is anyone else
seeing this?


Just checked the mtt webpage for our viscluster which is 64. And It
shows the
same error message. By locking to the commit it looks like that the
first
triple has been extended to a quadruple ?

Cheers,
  Sven


Thanks,

Tim


jsquy...@osl.iu.edu wrote:

Author: jsquyres
Date: 2007-08-13 17:51:05 EDT (Mon, 13 Aug 2007)
New Revision: 15848
URL: https://svn.open-mpi.org/trac/ompi/changeset/15848

Log:
Change the default receive_queues value per
http://www.open-mpi.org/community/lists/devel/2007/08/2100.php.

Text files modified:
   trunk/ompi/mca/btl/openib/btl_openib_mca.c | 2 +-
   1 files changed, 1 insertions(+), 1 deletions(-)

Modified: trunk/ompi/mca/btl/openib/btl_openib_mca.c

= 
=



--- trunk/ompi/mca/btl/openib/btl_openib_mca.c  (original)
+++ trunk/ompi/mca/btl/openib/btl_openib_mca.c  2007-08-13
17:51:05 EDT

(Mon, 13 Aug 2007)

@@ -477,7 +477,7 @@
 char *str;
 char **queues, **params = NULL;
 int num_pp_qps = 0, num_srq_qps = 0, qp = 0, ret = OMPI_ERROR;
-char *default_qps
= "P,128,16,4;S,1024,256,128,32;S,4096,256,128,32;S, 
65536,256,128,32";

+char *default_qps

= "P,128,256,128,16:S,1024,256,128,32:S,4096,256,128,32:S,
65536,256,128,32";

 uint32_t max_qp_size, max_size_needed;

 reg_string("receive_queues",
___
svn mailing list
s...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/svn


___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel


___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel



--
Jeff Squyres
Cisco Systems

___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel



--
Jeff Squyres
Cisco Systems



Re: [OMPI devel] [OMPI svn] svn:open-mpi r15848

2007-08-14 Thread Jeff Squyres

Looks like the parsing is wrong for the QP specification.

@#!@#$@!#$ I swear I checked this before I committed, but apparently  
I must have goofed.  I'll go fix now...



On Aug 14, 2007, at 9:44 AM, Sven Stork wrote:


On Tuesday 14 August 2007 15:23, Tim Prins wrote:
This might be breaking things on odin. All our 64 bit openib mtt  
tests

have the following output:

[odin003.cs.indiana.edu:30971] Wrong QP specification (QP 0
"P,128,256,128,16:S,1024,256,128,32:S,4096,256,128,32:S, 
65536,256,128,32").

Point-to-point QP get 1-5 parameters

However, on my debug build I do not get any errors. Is anyone else
seeing this?


Just checked the mtt webpage for our viscluster which is 64. And It  
shows the
same error message. By locking to the commit it looks like that the  
first

triple has been extended to a quadruple ?

Cheers,
  Sven


Thanks,

Tim


jsquy...@osl.iu.edu wrote:

Author: jsquyres
Date: 2007-08-13 17:51:05 EDT (Mon, 13 Aug 2007)
New Revision: 15848
URL: https://svn.open-mpi.org/trac/ompi/changeset/15848

Log:
Change the default receive_queues value per
http://www.open-mpi.org/community/lists/devel/2007/08/2100.php.

Text files modified:
   trunk/ompi/mca/btl/openib/btl_openib_mca.c | 2 +-
   1 files changed, 1 insertions(+), 1 deletions(-)

Modified: trunk/ompi/mca/btl/openib/btl_openib_mca.c

== 


--- trunk/ompi/mca/btl/openib/btl_openib_mca.c  (original)
+++ trunk/ompi/mca/btl/openib/btl_openib_mca.c	2007-08-13  
17:51:05 EDT

(Mon, 13 Aug 2007)

@@ -477,7 +477,7 @@
 char *str;
 char **queues, **params = NULL;
 int num_pp_qps = 0, num_srq_qps = 0, qp = 0, ret = OMPI_ERROR;
-char *default_qps

= "P,128,16,4;S,1024,256,128,32;S,4096,256,128,32;S,65536,256,128,32";

+char *default_qps
= "P,128,256,128,16:S,1024,256,128,32:S,4096,256,128,32:S, 
65536,256,128,32";

 uint32_t max_qp_size, max_size_needed;

 reg_string("receive_queues",
___
svn mailing list
s...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/svn


___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel


___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel



--
Jeff Squyres
Cisco Systems



Re: [OMPI devel] [OMPI svn] svn:open-mpi r15848

2007-08-14 Thread Sven Stork
On Tuesday 14 August 2007 15:23, Tim Prins wrote:
> This might be breaking things on odin. All our 64 bit openib mtt tests 
> have the following output:
> 
> [odin003.cs.indiana.edu:30971] Wrong QP specification (QP 0 
> "P,128,256,128,16:S,1024,256,128,32:S,4096,256,128,32:S,65536,256,128,32"). 
> Point-to-point QP get 1-5 parameters
> 
> However, on my debug build I do not get any errors. Is anyone else 
> seeing this?

Just checked the mtt webpage for our viscluster which is 64. And It shows the 
same error message. By locking to the commit it looks like that the first  
triple has been extended to a quadruple ?

Cheers,
  Sven 

> Thanks,
> 
> Tim
> 
> 
> jsquy...@osl.iu.edu wrote:
> > Author: jsquyres
> > Date: 2007-08-13 17:51:05 EDT (Mon, 13 Aug 2007)
> > New Revision: 15848
> > URL: https://svn.open-mpi.org/trac/ompi/changeset/15848
> > 
> > Log:
> > Change the default receive_queues value per
> > http://www.open-mpi.org/community/lists/devel/2007/08/2100.php.
> > 
> > Text files modified: 
> >trunk/ompi/mca/btl/openib/btl_openib_mca.c | 2 +-
> >   
> >1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > Modified: trunk/ompi/mca/btl/openib/btl_openib_mca.c
> > 
==
> > --- trunk/ompi/mca/btl/openib/btl_openib_mca.c  (original)
> > +++ trunk/ompi/mca/btl/openib/btl_openib_mca.c  2007-08-13 17:51:05 EDT 
(Mon, 13 Aug 2007)
> > @@ -477,7 +477,7 @@
> >  char *str;
> >  char **queues, **params = NULL;
> >  int num_pp_qps = 0, num_srq_qps = 0, qp = 0, ret = OMPI_ERROR;
> > -char *default_qps 
= "P,128,16,4;S,1024,256,128,32;S,4096,256,128,32;S,65536,256,128,32";
> > +char *default_qps 
= "P,128,256,128,16:S,1024,256,128,32:S,4096,256,128,32:S,65536,256,128,32";
> >  uint32_t max_qp_size, max_size_needed;
> >  
> >  reg_string("receive_queues",
> > ___
> > svn mailing list
> > s...@open-mpi.org
> > http://www.open-mpi.org/mailman/listinfo.cgi/svn
> 
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
> 


Re: [OMPI devel] [OMPI svn] svn:open-mpi r15848

2007-08-14 Thread Tim Prins
This might be breaking things on odin. All our 64 bit openib mtt tests 
have the following output:


[odin003.cs.indiana.edu:30971] Wrong QP specification (QP 0 
"P,128,256,128,16:S,1024,256,128,32:S,4096,256,128,32:S,65536,256,128,32"). 
Point-to-point QP get 1-5 parameters


However, on my debug build I do not get any errors. Is anyone else 
seeing this?


Thanks,

Tim


jsquy...@osl.iu.edu wrote:

Author: jsquyres
Date: 2007-08-13 17:51:05 EDT (Mon, 13 Aug 2007)
New Revision: 15848
URL: https://svn.open-mpi.org/trac/ompi/changeset/15848

Log:
Change the default receive_queues value per
http://www.open-mpi.org/community/lists/devel/2007/08/2100.php.

Text files modified: 
   trunk/ompi/mca/btl/openib/btl_openib_mca.c | 2 +-  
   1 files changed, 1 insertions(+), 1 deletions(-)


Modified: trunk/ompi/mca/btl/openib/btl_openib_mca.c
==
--- trunk/ompi/mca/btl/openib/btl_openib_mca.c  (original)
+++ trunk/ompi/mca/btl/openib/btl_openib_mca.c  2007-08-13 17:51:05 EDT (Mon, 
13 Aug 2007)
@@ -477,7 +477,7 @@
 char *str;
 char **queues, **params = NULL;
 int num_pp_qps = 0, num_srq_qps = 0, qp = 0, ret = OMPI_ERROR;
-char *default_qps = 
"P,128,16,4;S,1024,256,128,32;S,4096,256,128,32;S,65536,256,128,32";
+char *default_qps = 
"P,128,256,128,16:S,1024,256,128,32:S,4096,256,128,32:S,65536,256,128,32";
 uint32_t max_qp_size, max_size_needed;
 
 reg_string("receive_queues",

___
svn mailing list
s...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/svn