Re: [OMPI devel] [OMPI svn] svn:open-mpi r16723

2007-11-21 Thread Brad Penoff 
The change is in:
https://svn.open-mpi.org/trac/ompi/changeset/16764

Thanks for the heads-up,
brad

On Nov 20, 2007 9:48 AM, Brad Penoff <pen...@cs.ubc.ca> wrote:
> Sorry, saw this thread late.  We'll try to make the change later today
> after a few meetings!
>
> brad
>
>
>
> On Nov 14, 2007 8:16 AM, Jeff Squyres (jsquyres) <jsquy...@cisco.com> wrote:
> >
> >
> >
> > Tim - excellent catch!
> >
> >  I totally agree.  We must be very mindful of IP-related issues.
> >
> >  -jms
> >  Sent from my PDA
> >
> >
> >   -Original Message-
> >  From:   Tim Prins [mailto:tpr...@cs.indiana.edu]
> >  Sent:   Wednesday, November 14, 2007 09:44 AM Eastern Standard Time
> >  To: de...@open-mpi.org
> >  Subject:Re: [OMPI devel] [OMPI svn] svn:open-mpi r16723
> >
> >  Hi,
> >
> >  The following files bother me about this commit:
> >   trunk/ompi/mca/btl/sctp/sctp_writev.c
> >   trunk/ompi/mca/btl/sctp/sctp_writev.h
> >
> >  They bother me for 2 reasons:
> >  1. Their naming does not follow the prefix rule
> >  2. They are LGPL licensed. While I personally like the LGPL, I do not
> >  believe it is compatible with the BSD license that OMPI is distributed
> >  under. I think (though I could be wrong) that these files need to be
> >  removed from the repository and the functionality implemented in some
> >  other way.
> >
> >
> >  Tim
> >
> >
> >  pen...@osl.iu.edu wrote:
> >  > Author: penoff
> >  > Date: 2007-11-13 18:39:16 EST (Tue, 13 Nov 2007)
> >  > New Revision: 16723
> >  > URL: https://svn.open-mpi.org/trac/ompi/changeset/16723
> >  >
> >  > Log:
> >  > initial SCTP BTL commit
> >  > Added:
> >  >trunk/ompi/mca/btl/sctp/
> >  >trunk/ompi/mca/btl/sctp/.ompi_ignore
> >  >trunk/ompi/mca/btl/sctp/.ompi_unignore
> >  >trunk/ompi/mca/btl/sctp/Makefile.am
> >  >trunk/ompi/mca/btl/sctp/btl_sctp.c
> >  >trunk/ompi/mca/btl/sctp/btl_sctp.h
> >  >trunk/ompi/mca/btl/sctp/btl_sctp_addr.h
> >  >trunk/ompi/mca/btl/sctp/btl_sctp_component.c
> >  >trunk/ompi/mca/btl/sctp/btl_sctp_component.h
> >  >trunk/ompi/mca/btl/sctp/btl_sctp_endpoint.c
> >  >trunk/ompi/mca/btl/sctp/btl_sctp_endpoint.h
> >  >trunk/ompi/mca/btl/sctp/btl_sctp_frag.c
> >  >trunk/ompi/mca/btl/sctp/btl_sctp_frag.h
> >  >trunk/ompi/mca/btl/sctp/btl_sctp_hdr.h
> >  >trunk/ompi/mca/btl/sctp/btl_sctp_proc.c
> >  >trunk/ompi/mca/btl/sctp/btl_sctp_proc.h
> >  >trunk/ompi/mca/btl/sctp/btl_sctp_recv_handler.c
> >  >trunk/ompi/mca/btl/sctp/btl_sctp_recv_handler.h
> >  >trunk/ompi/mca/btl/sctp/btl_sctp_utils.c
> >  >trunk/ompi/mca/btl/sctp/btl_sctp_utils.h
> >  >trunk/ompi/mca/btl/sctp/configure.m4
> >  >trunk/ompi/mca/btl/sctp/configure.params
> >  >trunk/ompi/mca/btl/sctp/sctp_writev.c
> >  >trunk/ompi/mca/btl/sctp/sctp_writev.h
> >  >
> >  >
> >  > Diff not shown due to size (201438 bytes).
> >  > To see the diff, run the following command:
> >  >
> >  >   svn diff -r 16722:16723 --no-diff-deleted
> >  >
> >  > ___
> >  > svn mailing list
> >  > s...@open-mpi.org
> >  > http://www.open-mpi.org/mailman/listinfo.cgi/svn
> >  ___
> >  devel mailing list
> >  de...@open-mpi.org
> >  http://www.open-mpi.org/mailman/listinfo.cgi/devel
> >
> > ___
> > devel mailing list
> > de...@open-mpi.org
> > http://www.open-mpi.org/mailman/listinfo.cgi/devel
> >
>

Re: [OMPI devel] [OMPI svn] svn:open-mpi r16723

2007-11-20 Thread Brad Penoff 
Sorry, saw this thread late.  We'll try to make the change later today
after a few meetings!

brad


On Nov 14, 2007 8:16 AM, Jeff Squyres (jsquyres) <jsquy...@cisco.com> wrote:
>
>
>
> Tim - excellent catch!
>
>  I totally agree.  We must be very mindful of IP-related issues.
>
>  -jms
>  Sent from my PDA
>
>
>   -Original Message-
>  From:   Tim Prins [mailto:tpr...@cs.indiana.edu]
>  Sent:   Wednesday, November 14, 2007 09:44 AM Eastern Standard Time
>  To:     de...@open-mpi.org
>  Subject:    Re: [OMPI devel] [OMPI svn] svn:open-mpi r16723
>
>  Hi,
>
>  The following files bother me about this commit:
>   trunk/ompi/mca/btl/sctp/sctp_writev.c
>   trunk/ompi/mca/btl/sctp/sctp_writev.h
>
>  They bother me for 2 reasons:
>  1. Their naming does not follow the prefix rule
>  2. They are LGPL licensed. While I personally like the LGPL, I do not
>  believe it is compatible with the BSD license that OMPI is distributed
>  under. I think (though I could be wrong) that these files need to be
>  removed from the repository and the functionality implemented in some
>  other way.
>
>
>  Tim
>
>
>  pen...@osl.iu.edu wrote:
>  > Author: penoff
>  > Date: 2007-11-13 18:39:16 EST (Tue, 13 Nov 2007)
>  > New Revision: 16723
>  > URL: https://svn.open-mpi.org/trac/ompi/changeset/16723
>  >
>  > Log:
>  > initial SCTP BTL commit
>  > Added:
>  >trunk/ompi/mca/btl/sctp/
>  >trunk/ompi/mca/btl/sctp/.ompi_ignore
>  >trunk/ompi/mca/btl/sctp/.ompi_unignore
>  >trunk/ompi/mca/btl/sctp/Makefile.am
>  >trunk/ompi/mca/btl/sctp/btl_sctp.c
>  >trunk/ompi/mca/btl/sctp/btl_sctp.h
>  >trunk/ompi/mca/btl/sctp/btl_sctp_addr.h
>  >trunk/ompi/mca/btl/sctp/btl_sctp_component.c
>  >trunk/ompi/mca/btl/sctp/btl_sctp_component.h
>  >trunk/ompi/mca/btl/sctp/btl_sctp_endpoint.c
>  >trunk/ompi/mca/btl/sctp/btl_sctp_endpoint.h
>  >trunk/ompi/mca/btl/sctp/btl_sctp_frag.c
>  >trunk/ompi/mca/btl/sctp/btl_sctp_frag.h
>  >trunk/ompi/mca/btl/sctp/btl_sctp_hdr.h
>  >trunk/ompi/mca/btl/sctp/btl_sctp_proc.c
>  >trunk/ompi/mca/btl/sctp/btl_sctp_proc.h
>  >trunk/ompi/mca/btl/sctp/btl_sctp_recv_handler.c
>  >trunk/ompi/mca/btl/sctp/btl_sctp_recv_handler.h
>  >trunk/ompi/mca/btl/sctp/btl_sctp_utils.c
>  >trunk/ompi/mca/btl/sctp/btl_sctp_utils.h
>  >trunk/ompi/mca/btl/sctp/configure.m4
>  >trunk/ompi/mca/btl/sctp/configure.params
>  >trunk/ompi/mca/btl/sctp/sctp_writev.c
>  >trunk/ompi/mca/btl/sctp/sctp_writev.h
>  >
>  >
>  > Diff not shown due to size (201438 bytes).
>  > To see the diff, run the following command:
>  >
>  >   svn diff -r 16722:16723 --no-diff-deleted
>  >
>  > ___
>  > svn mailing list
>  > s...@open-mpi.org
>  > http://www.open-mpi.org/mailman/listinfo.cgi/svn
>  ___
>  devel mailing list
>  de...@open-mpi.org
>  http://www.open-mpi.org/mailman/listinfo.cgi/devel
>
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel
>

Re: [OMPI devel] [OMPI svn] svn:open-mpi r16723

2007-11-14 Thread Jeff Squyres (jsquyres) 
Tim - excellent catch!

I totally agree.  We must be very mindful of IP-related issues.

-jms
Sent from my PDA

 -Original Message-
From:   Tim Prins [mailto:tpr...@cs.indiana.edu]
Sent:   Wednesday, November 14, 2007 09:44 AM Eastern Standard Time
To: de...@open-mpi.org
Subject:Re: [OMPI devel] [OMPI svn] svn:open-mpi r16723

Hi,

The following files bother me about this commit:
 trunk/ompi/mca/btl/sctp/sctp_writev.c
 trunk/ompi/mca/btl/sctp/sctp_writev.h

They bother me for 2 reasons:
1. Their naming does not follow the prefix rule
2. They are LGPL licensed. While I personally like the LGPL, I do not 
believe it is compatible with the BSD license that OMPI is distributed 
under. I think (though I could be wrong) that these files need to be 
removed from the repository and the functionality implemented in some 
other way.

Tim


pen...@osl.iu.edu wrote:
> Author: penoff
> Date: 2007-11-13 18:39:16 EST (Tue, 13 Nov 2007)
> New Revision: 16723
> URL: https://svn.open-mpi.org/trac/ompi/changeset/16723
> 
> Log:
> initial SCTP BTL commit
> Added:
>trunk/ompi/mca/btl/sctp/
>trunk/ompi/mca/btl/sctp/.ompi_ignore
>trunk/ompi/mca/btl/sctp/.ompi_unignore
>trunk/ompi/mca/btl/sctp/Makefile.am
>trunk/ompi/mca/btl/sctp/btl_sctp.c
>trunk/ompi/mca/btl/sctp/btl_sctp.h
>trunk/ompi/mca/btl/sctp/btl_sctp_addr.h
>trunk/ompi/mca/btl/sctp/btl_sctp_component.c
>trunk/ompi/mca/btl/sctp/btl_sctp_component.h
>trunk/ompi/mca/btl/sctp/btl_sctp_endpoint.c
>trunk/ompi/mca/btl/sctp/btl_sctp_endpoint.h
>trunk/ompi/mca/btl/sctp/btl_sctp_frag.c
>trunk/ompi/mca/btl/sctp/btl_sctp_frag.h
>trunk/ompi/mca/btl/sctp/btl_sctp_hdr.h
>trunk/ompi/mca/btl/sctp/btl_sctp_proc.c
>trunk/ompi/mca/btl/sctp/btl_sctp_proc.h
>trunk/ompi/mca/btl/sctp/btl_sctp_recv_handler.c
>trunk/ompi/mca/btl/sctp/btl_sctp_recv_handler.h
>trunk/ompi/mca/btl/sctp/btl_sctp_utils.c
>trunk/ompi/mca/btl/sctp/btl_sctp_utils.h
>trunk/ompi/mca/btl/sctp/configure.m4
>trunk/ompi/mca/btl/sctp/configure.params
>trunk/ompi/mca/btl/sctp/sctp_writev.c
>trunk/ompi/mca/btl/sctp/sctp_writev.h
> 
> 
> Diff not shown due to size (201438 bytes).
> To see the diff, run the following command:
> 
>   svn diff -r 16722:16723 --no-diff-deleted
> 
> ___
> svn mailing list
> s...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/svn
___
devel mailing list
de...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/devel

Re: [OMPI devel] [OMPI svn] svn:open-mpi r16723

2007-11-14 Thread Gleb Natapov 
On Wed, Nov 14, 2007 at 06:44:06AM -0800, Tim Prins wrote:
> Hi,
> 
> The following files bother me about this commit:
>  trunk/ompi/mca/btl/sctp/sctp_writev.c
>  trunk/ompi/mca/btl/sctp/sctp_writev.h
> 
> They bother me for 2 reasons:
> 1. Their naming does not follow the prefix rule
> 2. They are LGPL licensed. While I personally like the LGPL, I do not 
> believe it is compatible with the BSD license that OMPI is distributed 
> under. I think (though I could be wrong) that these files need to be 
> removed from the repository and the functionality implemented in some 
> other way.

Is function that fills a couple of struct fields can be reimplemented in
any other way? :)

> 
> Tim
> 
> 
> pen...@osl.iu.edu wrote:
> > Author: penoff
> > Date: 2007-11-13 18:39:16 EST (Tue, 13 Nov 2007)
> > New Revision: 16723
> > URL: https://svn.open-mpi.org/trac/ompi/changeset/16723
> > 
> > Log:
> > initial SCTP BTL commit
> > Added:
> >trunk/ompi/mca/btl/sctp/
> >trunk/ompi/mca/btl/sctp/.ompi_ignore
> >trunk/ompi/mca/btl/sctp/.ompi_unignore
> >trunk/ompi/mca/btl/sctp/Makefile.am
> >trunk/ompi/mca/btl/sctp/btl_sctp.c
> >trunk/ompi/mca/btl/sctp/btl_sctp.h
> >trunk/ompi/mca/btl/sctp/btl_sctp_addr.h
> >trunk/ompi/mca/btl/sctp/btl_sctp_component.c
> >trunk/ompi/mca/btl/sctp/btl_sctp_component.h
> >trunk/ompi/mca/btl/sctp/btl_sctp_endpoint.c
> >trunk/ompi/mca/btl/sctp/btl_sctp_endpoint.h
> >trunk/ompi/mca/btl/sctp/btl_sctp_frag.c
> >trunk/ompi/mca/btl/sctp/btl_sctp_frag.h
> >trunk/ompi/mca/btl/sctp/btl_sctp_hdr.h
> >trunk/ompi/mca/btl/sctp/btl_sctp_proc.c
> >trunk/ompi/mca/btl/sctp/btl_sctp_proc.h
> >trunk/ompi/mca/btl/sctp/btl_sctp_recv_handler.c
> >trunk/ompi/mca/btl/sctp/btl_sctp_recv_handler.h
> >trunk/ompi/mca/btl/sctp/btl_sctp_utils.c
> >trunk/ompi/mca/btl/sctp/btl_sctp_utils.h
> >trunk/ompi/mca/btl/sctp/configure.m4
> >trunk/ompi/mca/btl/sctp/configure.params
> >trunk/ompi/mca/btl/sctp/sctp_writev.c
> >trunk/ompi/mca/btl/sctp/sctp_writev.h
> > 
> > 
> > Diff not shown due to size (201438 bytes).
> > To see the diff, run the following command:
> > 
> > svn diff -r 16722:16723 --no-diff-deleted
> > 
> > ___
> > svn mailing list
> > s...@open-mpi.org
> > http://www.open-mpi.org/mailman/listinfo.cgi/svn
> ___
> devel mailing list
> de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/devel

--
Gleb.

Re: [OMPI devel] [OMPI svn] svn:open-mpi r16723

2007-11-14 Thread Tim Prins 

Hi,

The following files bother me about this commit:
trunk/ompi/mca/btl/sctp/sctp_writev.c
trunk/ompi/mca/btl/sctp/sctp_writev.h

They bother me for 2 reasons:
1. Their naming does not follow the prefix rule
2. They are LGPL licensed. While I personally like the LGPL, I do not 
believe it is compatible with the BSD license that OMPI is distributed 
under. I think (though I could be wrong) that these files need to be 
removed from the repository and the functionality implemented in some 
other way.


Tim


pen...@osl.iu.edu wrote:

Author: penoff
Date: 2007-11-13 18:39:16 EST (Tue, 13 Nov 2007)
New Revision: 16723
URL: https://svn.open-mpi.org/trac/ompi/changeset/16723

Log:
initial SCTP BTL commit
Added:
   trunk/ompi/mca/btl/sctp/
   trunk/ompi/mca/btl/sctp/.ompi_ignore
   trunk/ompi/mca/btl/sctp/.ompi_unignore
   trunk/ompi/mca/btl/sctp/Makefile.am
   trunk/ompi/mca/btl/sctp/btl_sctp.c
   trunk/ompi/mca/btl/sctp/btl_sctp.h
   trunk/ompi/mca/btl/sctp/btl_sctp_addr.h
   trunk/ompi/mca/btl/sctp/btl_sctp_component.c
   trunk/ompi/mca/btl/sctp/btl_sctp_component.h
   trunk/ompi/mca/btl/sctp/btl_sctp_endpoint.c
   trunk/ompi/mca/btl/sctp/btl_sctp_endpoint.h
   trunk/ompi/mca/btl/sctp/btl_sctp_frag.c
   trunk/ompi/mca/btl/sctp/btl_sctp_frag.h
   trunk/ompi/mca/btl/sctp/btl_sctp_hdr.h
   trunk/ompi/mca/btl/sctp/btl_sctp_proc.c
   trunk/ompi/mca/btl/sctp/btl_sctp_proc.h
   trunk/ompi/mca/btl/sctp/btl_sctp_recv_handler.c
   trunk/ompi/mca/btl/sctp/btl_sctp_recv_handler.h
   trunk/ompi/mca/btl/sctp/btl_sctp_utils.c
   trunk/ompi/mca/btl/sctp/btl_sctp_utils.h
   trunk/ompi/mca/btl/sctp/configure.m4
   trunk/ompi/mca/btl/sctp/configure.params
   trunk/ompi/mca/btl/sctp/sctp_writev.c
   trunk/ompi/mca/btl/sctp/sctp_writev.h


Diff not shown due to size (201438 bytes).
To see the diff, run the following command:

svn diff -r 16722:16723 --no-diff-deleted

___
svn mailing list
s...@open-mpi.org
http://www.open-mpi.org/mailman/listinfo.cgi/svn