Re: [OMPI devel] RFC: fix leak of bml endpoints

2014-05-15 Thread Nathan Hjelm
Ok figured it out. There were three problems with the del_procs code: 1) ompi_mpi_finalize used ompi_proc_all to get the list of procs but never released the reference to them (ompi_proc_all called OBJ_RETAIN on all the procs returned). When calling del_procs at finalize it should

Re: [OMPI devel] RFC: fix leak of bml endpoints

2014-05-15 Thread Nathan Hjelm
On Thu, May 15, 2014 at 11:44:05AM -0600, Nathan Hjelm wrote: > On Thu, May 15, 2014 at 01:33:31PM -0400, George Bosilca wrote: > > The solution you propose here is definitively not OK. It is 1) ugly and 2) > > break the separation barrier that we hold dear. > > Which is why I asked :) > > >

Re: [OMPI devel] RFC: fix leak of bml endpoints

2014-05-15 Thread Nathan Hjelm
On Thu, May 15, 2014 at 01:33:31PM -0400, George Bosilca wrote: > The solution you propose here is definitively not OK. It is 1) ugly and 2) > break the separation barrier that we hold dear. Which is why I asked :) > Regarding your other suggestion I don’t see any reasons not to call the >

Re: [OMPI devel] RFC: fix leak of bml endpoints

2014-05-15 Thread George Bosilca
The solution you propose here is definitively not OK. It is 1) ugly and 2) break the separation barrier that we hold dear. Regarding your other suggestion I don’t see any reasons not to call the delete_proc on MPI_COMM_WORLD as the last action we do before tearing down everything else.

[OMPI devel] RFC: fix leak of bml endpoints

2014-05-15 Thread Nathan Hjelm
What: We never call del_procs in the procs in comm world. This leads us to leak the bml endpoints created by r2. The proposed solution is not idea but it avoids adding a call to del procs for comm world. Something I know would require more discussion since there is likely a reason for that. I