Re: [OpenSIPS-Devel] [OpenSIPS/opensips] a45d4d: nathelper: manual backport for 3c39167e333a8801772...

Yeah, starting this fire is on me - I tried to read local code without the global scope. Nevertheless, this raises again the issue of a better code commenting to avoid such future confusions. And thank you Ovidiu for your fast reaction. And to you Maxim for the fast testing and reporting.

Re: [OpenSIPS-Devel] [OpenSIPS/opensips] a45d4d: nathelper: manual backport for 3c39167e333a8801772...

Hello Maxim, All should be good now. Sorry for the trouble. I'm working on this part of the code, running tests and I would've caught the issue soon. We rushed with the backport based only on code inspection, so "mea culpa" here :) Thanks for the fast report, Ovidiu On Mon, Feb 5, 2018 at 3:40

Re: [OpenSIPS-Devel] [OpenSIPS/opensips] a45d4d: nathelper: manual backport for 3c39167e333a8801772...

Thanks, regardless I am glad somebody took care of refactoring that old code, but please be more careful with merging it down into stable branches. :) I've just made a change to request a daily build of the voiptests, so consider keeping an eye on it after making changes in master branch. It is

Re: [OpenSIPS-Devel] [OpenSIPS/opensips] a45d4d: nathelper: manual backport for 3c39167e333a8801772...

Hello Maxim, I think I know what the issue is. There was a confusion between variable naming: oldpf and newpf refers to protocol format and not the actual IP. I will revert the changes! -ovidiu On Mon, Feb 5, 2018 at 3:06 PM, Maxim Sobolev wrote: > That merge broke all

Re: [OpenSIPS-Devel] [OpenSIPS/opensips] a45d4d: nathelper: manual backport for 3c39167e333a8801772...

P.P.S. Our test case is quite simple you can see it here: https://github.com/sippy/voiptests/blob/master/opensips.cfg.in The failure observed here is that the IP and port in the SDP are not updated despite session has been established in the rtpproxy just fine. 245

Re: [OpenSIPS-Devel] [OpenSIPS/opensips] a45d4d: nathelper: manual backport for 3c39167e333a8801772...

P.S. Build logs are here: https://travis-ci.org/sippy/voiptests/builds/337694673 On Mon, Feb 5, 2018 at 12:06 PM, Maxim Sobolev wrote: > That merge broke all of our OpenSIPS test scenarous on voiptests. We are > investigating about the possible cause but I think this

Re: [OpenSIPS-Devel] [OpenSIPS/opensips] a45d4d: nathelper: manual backport for 3c39167e333a8801772...

That merge broke all of our OpenSIPS test scenarous on voiptests. We are investigating about the possible cause but I think this change may need to be reverted from the stable branches until it's clear what's going on. -Maxim On Mon, Feb 5, 2018 at 10:04 AM, Ovidiu Sas

[OpenSIPS-Devel] [OpenSIPS/opensips] a45d4d: nathelper: manual backport for 3c39167e333a8801772...

Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: a45d4dcaf046bb273cfe5905ac035845a6867945 https://github.com/OpenSIPS/opensips/commit/a45d4dcaf046bb273cfe5905ac035845a6867945 Author: Ovidiu Sas Date: 2018-02-05 (Mon, 05 Feb