Re: [OpenSIPS-Devel] [opensips] Error in the logs while looking for contact param when param missing (#228)

2014-05-29 Thread Bogdan Andrei IANCU
It was a different case, when the last parameter has no value. It is fixed now. Thanks, Bogdan --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/228#issuecomment-44550665___ Devel mailing list Devel@lists

Re: [OpenSIPS-Devel] [opensips] Error in the logs while looking for contact param when param missing (#228)

2014-05-29 Thread Bogdan Andrei IANCU
Closed #228. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/228#event-126057593___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] Error in the logs while looking for contact param when param missing (#228)

2014-05-28 Thread Ovidiu Sas
Something is not right again (latest 1.11). ``` xlog("L_NOTICE", "$$ct=[$ct]\n"); xlog("L_NOTICE", "$$ct.fields(params)=[$ct.fields(params)]\n"); xlog("L_NOTICE", "$$(ct{nameaddr.params})=[$(ct{nameaddr.params})]\n"); ``` generates: ``` $ct=["test" ;+sip.ice] $ct.fields(para

Re: [OpenSIPS-Devel] [opensips] Error in the logs while looking for contact param when param missing (#228)

2014-05-28 Thread Ovidiu Sas
Reopened #228. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/228#event-125689836___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] Error in the logs while looking for contact param when param missing (#228)

2014-05-14 Thread Bogdan Andrei IANCU
@ovidiusas , thanks for the hints, I found and fix the bug - it was related to having a quoted value in the last hdr param (problem was in the nameaddr transformation, for "params"). Btw, instead of $(ct{nameaddr.params}{param.value,blah}) you can simpler do: $(ct{nameaddr.param,blah}

Re: [OpenSIPS-Devel] [opensips] Error in the logs while looking for contact param when param missing (#228)

2014-05-14 Thread Bogdan Andrei IANCU
Closed #228. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/228#event-120993369___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] Error in the logs while looking for contact param when param missing (#228)

2014-05-09 Thread Ovidiu Sas
The formatting was messed up by github :( Here's the correct header that failed to be parsed $ct=["test" ;reg-id=1;+sip.instance=""] $var(ct_nameaddr_params)=[reg-id=1;+sip.instance="] The header is properly formated: Contact:"test" ;reg-id=1;+sip.instance="" --- Reply to th

Re: [OpenSIPS-Devel] [opensips] Error in the logs while looking for contact param when param missing (#228)

2014-05-09 Thread Bogdan Andrei IANCU
@ovidiusas , according to the RFC3261 grammar , the contact body ["test" sip:test@192.168.2.113:53814;ob;reg-id=1;+sip.instance="urn:uuid:ed409b05-1872-36ee-8ba0-865cb642250b"] is not valid. If display name is present, the URI must be enclosed between angle brackets (see page 227 in the RFC): C

Re: [OpenSIPS-Devel] [opensips] Error in the logs while looking for contact param when param missing (#228)

2014-05-08 Thread Ovidiu Sas
The problem is depicted more clearly here: xlog("L_NOTICE", "$$ct=[$ct]\n"); $var(ct_nameaddr_params) = $(ct{nameaddr.params}); xlog("L_NOTICE", "$$var(ct_nameaddr_params)=[$var(ct_nameaddr_params)]\n"); Leads to the following output: $ct=["test" ;reg-id=1;+sip.instance=""] $var(ct_namea

Re: [OpenSIPS-Devel] [opensips] Error in the logs while looking for contact param when param missing (#228)

2014-05-08 Thread Ovidiu Sas
xlog("L_NOTICE", "$(ct{nameaddr.params}{param.value,blah})\n"); leads to: ERROR:core:parse_param_body: failed to parse quoted string ERROR:core:parse_params: failed to parse param body --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/228#iss

Re: [OpenSIPS-Devel] [opensips] Error in the logs while looking for contact param when param missing (#228)

2014-05-08 Thread Liviu Chircu
Ovidiu, That's because "param.value" requires formatted input. Try using $(ct{nameaddr.params}{param.value,blah}) --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/228#issuecomment-42583596___ Devel mail

[OpenSIPS-Devel] [opensips] Error in the logs while looking for contact param when param missing (#228)

2014-05-08 Thread Ovidiu Sas
Easy to reproduce with the following probe: xlog("L_NOTICE", "$(ct{param.value,blah})\n"); ERROR:core:parse_params: invalid character, ; expected, found < This is specific to Contact header only. Trying to retrieve a bogus param from to or from header does not produce an error in the logs.