[OpenSIPS-Devel] SF.net SVN: opensips:[9258] trunk/parser/parse_multipart.c
Revision: 9258 http://opensips.svn.sourceforge.net/opensips/?rev=9258view=rev Author: bogdan_iancu Date: 2012-09-17 07:38:44 + (Mon, 17 Sep 2012) Log Message: --- - fixed crash in multi-body parsing if delimiter not present Reported and fix by Ryan Bullock Closes bug 3566409 Modified Paths: -- trunk/parser/parse_multipart.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3563203 ] do_routing function crash without group id parameter
Bugs item #3563203, was opened at 2012-08-30 01:34
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3563203group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.7.x
Status: Open
Resolution: Works For Me
Priority: 3
Private: No
Submitted By: piero ferraresso (red02)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: do_routing function crash without group id parameter
Initial Comment:
I\'m using opensips v. 1.7.2-TLS on a Debian 6.04 machine.
If I call the function do_routing without specifing the group id parameter -
do_routing(\\,\1\) for example - opensips crah (segfault at 0 ip 081399d8
sp bfed0480 error 4 in opensips[8048000+15]).
If I insert the group id - do_routing(\0\,\1\) for example - all works fine.
Where do I wrong?
Thanks in advance
Piero Ferraresso
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-09-17 01:39
Message:
I tried to reproduce this, using 1.7 :
if (!do_routing(,1)) {
xlog(DR failed !!\n);
exit;
}
But with no success - I get error messages with no crash:
Sep 17 12:34:54 [6354] DBG:core:parse_to_param: tag=fuzyi
Sep 17 12:34:54 [6354] DBG:core:parse_to: end of header reached, state=29
Sep 17 12:34:54 [6354] DBG:core:parse_to: display={bogdan},
ruri={sip:bog...@opensips.org}
Sep 17 12:34:54 [6354] DBG:core:db_new_result: allocate 48 bytes for result
set at 0x7cc598
Sep 17 12:34:54 [6354] DBG:db_mysql:db_mysql_get_columns: 1 columns
returned from the query
Sep 17 12:34:54 [6354] DBG:core:db_allocate_columns: allocate 28 bytes for
result columns at 0x7cc5e0
Sep 17 12:34:54 [6354] DBG:db_mysql:db_mysql_get_columns:
RES_NAMES(0x7cc5e8)[0]=[groupid]
Sep 17 12:34:54 [6354] DBG:db_mysql:db_mysql_get_columns: use DB_INT result
type
Sep 17 12:34:54 [6354] DBG:db_mysql:db_mysql_convert_rows: no rows returned
from the query
Sep 17 12:34:54 [6354] ERROR:drouting:get_group_id: no group for user
bogdan@opensips.org
Sep 17 12:34:54 [6354] DBG:core:db_free_columns: freeing result columns at
0x7cc5e0
Sep 17 12:34:54 [6354] DBG:core:db_free_rows: freeing 0 rows
Sep 17 12:34:54 [6354] DBG:core:db_free_result: freeing result set at
0x7cc598
Sep 17 12:34:54 [6354] ERROR:drouting:do_routing: failed to get group id
Sep 17 12:34:54 [6354] DBG:core:buf_init: initializing...
DR failed !!
Maybe it is something particular to your case, so please provide an
backtrace.
Regards,
Bogdan
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-09-11 02:51
Message:
Hi Piero,
Could you try without the db_virtual module (direct query to mysql) to see
if you still have this issue ?
Thanks and regards,
Bogdan
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3563203group_id=232389
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3557901 ] dialplan results not consistent
Bugs item #3557901, was opened at 2012-08-15 06:01
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3557901group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: trunk
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Richard Revels (rrevels)
Assigned to: Liviu Chircu (liviuchircu)
Summary: dialplan results not consistent
Initial Comment:
When opensips is first loaded and a dialplan lookup function is called the
result is different than after a MI dialplan reload command is issued and the
same lookup is done. The results also don't match my expectations in either
case but that may be me not keeping up with changes in the regex parser. So,
anyway, this is what I'm seeing in my logs when calling +19198788990
On initial proxy load:
Aug 15 12:45:49 trunking1 /usr/local/sbin/opensips[15244]: Doing dialplan
lookup in route fix ruri
Aug 15 12:45:49 trunking1 /usr/local/sbin/opensips[15244]:
DBG:dialplan:dp_translate_f: dpid is 30
Aug 15 12:45:49 trunking1 /usr/local/sbin/opensips[15244]:
DBG:dialplan:dp_get_svalue: searching 14
Aug 15 12:45:49 trunking1 /usr/local/sbin/opensips[15244]:
DBG:dialplan:dp_translate_f: input is sip:+19198788...@x.xx.xx.xx
Aug 15 12:45:49 trunking1 /usr/local/sbin/opensips[15244]:
DBG:dialplan:translate: regex operator testing
Aug 15 12:45:49 trunking1 /usr/local/sbin/opensips[15244]:
DBG:dialplan:test_match: test_match:[0] sip:+19198788...@x.xx.xx.xx
Aug 15 12:45:49 trunking1 /usr/local/sbin/opensips[15244]:
DBG:dialplan:translate: found a matching rule 0x2b0c6e160b80: pr 100, match_exp
.*
Aug 15 12:45:49 trunking1 /usr/local/sbin/opensips[15244]:
DBG:dialplan:translate: the rule's attrs are restrc
Aug 15 12:45:49 trunking1 /usr/local/sbin/opensips[15244]:
DBG:dialplan:translate: the copied attributes are: restrc
Aug 15 12:45:49 trunking1 /usr/local/sbin/opensips[15244]:
DBG:dialplan:test_match: test_match:[0] sip:+19198788...@x.xx.xx.xx
Aug 15 12:45:49 trunking1 /usr/local/sbin/opensips[15244]:
DBG:dialplan:rule_translate: simply replace the string, subst_comp
0x2b0c6e160a50, n_escapes 0
Aug 15 12:45:49 trunking1 /usr/local/sbin/opensips[15244]:
DBG:dialplan:dp_translate_f: input sip:+19198788...@x.xx.xx.xx with dpid 30 =
output invalid
Aug 15 12:45:49 trunking1 /usr/local/sbin/opensips[15244]: Got destination type
of restrc from dialplan and set destination to invalid
After MI reload dialplan issued:
Aug 15 12:48:18 trunking1 /usr/local/sbin/opensips[15247]: Doing dialplan
lookup in route fix ruri
Aug 15 12:48:18 trunking1 /usr/local/sbin/opensips[15247]:
DBG:dialplan:dp_translate_f: dpid is 30
Aug 15 12:48:18 trunking1 /usr/local/sbin/opensips[15247]:
DBG:dialplan:dp_get_svalue: searching 14
Aug 15 12:48:18 trunking1 /usr/local/sbin/opensips[15247]:
DBG:dialplan:dp_translate_f: input is sip:+19198788...@x.xx.xx.xx
Aug 15 12:48:18 trunking1 /usr/local/sbin/opensips[15247]:
DBG:dialplan:dp_translate_f: no information available for dpid 30
Aug 15 12:48:18 trunking1 /usr/local/sbin/opensips[15247]: Did not get
indication of match in dialplan call with sip:+19198788...@x.xx.xx.xx
I'm sure this will paste badly but here are the rules I'm using for this lookup:
++--+-+--+--+---+--+--+--+-+
| id | dpid | pr | match_op | match_exp| match_len |
subst_exp| repl_exp | disabled | attrs |
++--+-+--+--+---+--+--+--+-+
| 31 | 30 | 40 |1 | sip:011.*| 0 |
(011)(.*)@.* | +\2 |0 | intl|
| 19 | 30 | 49 |1 | sip:([1]?...5551212|411|1411)@.* | 0 |
.* | +1411|0 | information |
| 10 | 30 | 50 |1 | sip:(\+1888|1888|888)[0-9]{7}@.* | 0 |
(\+?[1]?)([2-9][0-9]{9}) | +1\2 |0 | tollfree|
| 18 | 30 | 50 |1 | sip:(\+1800|1800|800)[0-9]{7}@.* | 0 |
(\+?[1]?)([2-9][0-9]{9}) | +1\2 |0 | tollfree|
| 13 | 30 | 50 |1 | sip:(\+1866|1866|866)[0-9]{7}@.* | 0 |
(\+?[1]?)([2-9][0-9]{9}) | +1\2 |0 | tollfree|
| 14 | 30 | 50 |1 | sip:(\+1877|1877|877)[0-9]{7}@.* | 0 |
(\+?[1]?)([2-9][0-9]{9}) | +1\2 |0 | tollfree|
| 42 | 30 | 50 |1 | sip:(\+1911|1911|911)@.* | 0 |
(\+?[1]?)(911) | +1\2 |0 | emergency |
| 17 | 30 | 99 |1 | sip:\+1[2-9][0-9]{9}@.* | 0 |
(\+?[1]?)([2-9][0-9]{9}) | +1\2 |
[OpenSIPS-Devel] SF.net SVN: opensips:[9260] trunk/modules/dispatcher/dispatch.c
Revision: 9260 http://opensips.svn.sourceforge.net/opensips/?rev=9260view=rev Author: bogdan_iancu Date: 2012-09-17 09:38:10 + (Mon, 17 Sep 2012) Log Message: --- fixed load/reload behaviour - if a destination is bogus (bad URI, cannot be resolved, etc), it is simply skipped, but do not fail the entire loading. Modified Paths: -- trunk/modules/dispatcher/dispatch.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9261] branches/1.8/modules/dispatcher/dispatch.c
Revision: 9261 http://opensips.svn.sourceforge.net/opensips/?rev=9261view=rev Author: bogdan_iancu Date: 2012-09-17 09:39:23 + (Mon, 17 Sep 2012) Log Message: --- backport from trunk (rev #9260): fixed load/reload behaviour - if a destination is bogus (bad URI, cannot be resolved, etc), it is simply skipped, but do not fail the entire loading. Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=9260view=rev Modified Paths: -- branches/1.8/modules/dispatcher/dispatch.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] Patch: BNF-compliant {s.escape.param} and {s.escape.user}
Hello,
When packing a SIP URI into a parameter, I noticed that the contained
@ was not escaped by {s.escape.param}. Chasing this to strcommon.c I
found that it deviates from the -unreserved specifications in the BNF
of RFC 3261. Attached is a patch relative to 1.8.0 that corrects the
user and parameter escapes to the RFC-prescribed BNF-based escapes.
Note well:
- The in parameters was escaped, which this patch removes.
- The / in user parts was escaped, which this patch removes.
If these were added for pragmatic reasons (dealing with devices that
do not adhere to the RFC) then please overrule that part of my patch!
Other than this, changes to become RFC3621-compliant are:
- Additional parameter escaping for # % @ \ ^ ` { | }
- Additional user part escaping was not needed
I hope this is useful. Just consider it a thank you for all the
wonderful work that the OpenSIPS developers are doing.
Best wishes,
Rick van Rein
OpenFortress
--- opensips-1.8.0-tls/strcommon.c.orig 2012-03-23 10:48:28.0 +
+++ opensips-1.8.0-tls/strcommon.c 2012-09-17 09:53:53.0 +
@@ -275,8 +275,9 @@
case ',':
case ';':
case '?':
+case '/':
*at = *p;
-break;
+break;
default:
*at++ = '%';
x = (*p) 4;
@@ -312,7 +313,8 @@
/*! \brief
* Escape all printable characters that are not valid in
- * a param part of request uri: = | ; | , | | | ? |
+ * a param part of request uri: space | | # | % | , | ; | | = |
+ * | ? | @ | backslash | ^ | ` | { | vertical bar | }
*/
int escape_param(str *sin, str *sout)
{
@@ -332,12 +334,22 @@
}
switch (*p) {
case ' ':
-case '?':
-case '':
-case '=':
+case '':
+case '#':
+case '%':
case ',':
case ';':
-case '':
+case '':
+case '=':
+case '':
+case '?':
+case '@':
+case '\\':
+case '^':
+case '`':
+case '{':
+case '|':
+case '}':
*at++ = '%';
x = (*p) 4;
if (x 10)
signature.asc
Description: Digital signature
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9262] trunk/modules/db_postgres/dbase.c
Revision: 9262 http://opensips.svn.sourceforge.net/opensips/?rev=9262view=rev Author: liviuchircu Date: 2012-09-17 11:55:05 + (Mon, 17 Sep 2012) Log Message: --- Fixed a bad return code in the db_do_insert function. Modified Paths: -- trunk/modules/db_postgres/dbase.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Bugs-3563203 ] do_routing function crash without group id parameter
Bugs item #3563203, was opened at 2012-08-30 01:34
Message generated for change (Comment added) made by red02
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3563203group_id=232389
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: 1.7.x
Status: Open
Resolution: Works For Me
Priority: 3
Private: No
Submitted By: piero ferraresso (red02)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: do_routing function crash without group id parameter
Initial Comment:
I\'m using opensips v. 1.7.2-TLS on a Debian 6.04 machine.
If I call the function do_routing without specifing the group id parameter -
do_routing(\\,\1\) for example - opensips crah (segfault at 0 ip 081399d8
sp bfed0480 error 4 in opensips[8048000+15]).
If I insert the group id - do_routing(\0\,\1\) for example - all works fine.
Where do I wrong?
Thanks in advance
Piero Ferraresso
--
Comment By: piero ferraresso (red02)
Date: 2012-09-17 05:14
Message:
Yes, It seems to depend on using the virtual db module.
Piero
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-09-17 01:39
Message:
I tried to reproduce this, using 1.7 :
if (!do_routing(,1)) {
xlog(DR failed !!\n);
exit;
}
But with no success - I get error messages with no crash:
Sep 17 12:34:54 [6354] DBG:core:parse_to_param: tag=fuzyi
Sep 17 12:34:54 [6354] DBG:core:parse_to: end of header reached, state=29
Sep 17 12:34:54 [6354] DBG:core:parse_to: display={bogdan},
ruri={sip:bog...@opensips.org}
Sep 17 12:34:54 [6354] DBG:core:db_new_result: allocate 48 bytes for result
set at 0x7cc598
Sep 17 12:34:54 [6354] DBG:db_mysql:db_mysql_get_columns: 1 columns
returned from the query
Sep 17 12:34:54 [6354] DBG:core:db_allocate_columns: allocate 28 bytes for
result columns at 0x7cc5e0
Sep 17 12:34:54 [6354] DBG:db_mysql:db_mysql_get_columns:
RES_NAMES(0x7cc5e8)[0]=[groupid]
Sep 17 12:34:54 [6354] DBG:db_mysql:db_mysql_get_columns: use DB_INT result
type
Sep 17 12:34:54 [6354] DBG:db_mysql:db_mysql_convert_rows: no rows returned
from the query
Sep 17 12:34:54 [6354] ERROR:drouting:get_group_id: no group for user
bogdan@opensips.org
Sep 17 12:34:54 [6354] DBG:core:db_free_columns: freeing result columns at
0x7cc5e0
Sep 17 12:34:54 [6354] DBG:core:db_free_rows: freeing 0 rows
Sep 17 12:34:54 [6354] DBG:core:db_free_result: freeing result set at
0x7cc598
Sep 17 12:34:54 [6354] ERROR:drouting:do_routing: failed to get group id
Sep 17 12:34:54 [6354] DBG:core:buf_init: initializing...
DR failed !!
Maybe it is something particular to your case, so please provide an
backtrace.
Regards,
Bogdan
--
Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2012-09-11 02:51
Message:
Hi Piero,
Could you try without the db_virtual module (direct query to mysql) to see
if you still have this issue ?
Thanks and regards,
Bogdan
--
You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=1086410aid=3563203group_id=232389
___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9263] branches/1.8/modules/db_postgres/dbase.c
Revision: 9263 http://opensips.svn.sourceforge.net/opensips/?rev=9263view=rev Author: liviuchircu Date: 2012-09-17 12:58:32 + (Mon, 17 Sep 2012) Log Message: --- Backport from trunk (rev #9262) Fixed a bad return code in the db_do_insert function. Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=9262view=rev Modified Paths: -- branches/1.8/modules/db_postgres/dbase.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] SF.net SVN: opensips:[9264] branches/1.7/modules/db_postgres/dbase.c
Revision: 9264 http://opensips.svn.sourceforge.net/opensips/?rev=9264view=rev Author: liviuchircu Date: 2012-09-17 13:14:26 + (Mon, 17 Sep 2012) Log Message: --- Backport from trunk (rev #9262) Fixed a bad return code in the db_do_insert function. Revision Links: -- http://opensips.svn.sourceforge.net/opensips/?rev=9262view=rev Modified Paths: -- branches/1.7/modules/db_postgres/dbase.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-3568579 ] Use insert buffer for acc_db_request()
Patches item #3568579, was opened at 2012-09-17 13:47 Message generated for change (Tracker Item Submitted) made by rrb3942 You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3568579group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Ryan Bullock (rrb3942) Assigned to: Nobody/Anonymous (nobody) Summary: Use insert buffer for acc_db_request() Initial Comment: This patch takes advantage of insert buffers when acc_db_request() is called from the script and the table is set to the currently configured acc or missed_calls table. We manually call acc_db_request for failed calls so that we may update accounting variables before saving the call record. This gave us a big boost in performance. -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3568579group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
[OpenSIPS-Devel] [ opensips-Patches-3520528 ] B2B_LOGIC - choose method how to generate To: header
Patches item #3520528, was opened at 2012-04-23 00:56 Message generated for change (Settings changed) made by nikbyte You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3520528group_id=232389 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: trunk Status: Closed Resolution: None Priority: 5 Private: No Submitted By: Nick Altmann (nikbyte) Assigned to: Bogdan-Andrei Iancu (bogdan_iancu) Summary: B2B_LOGIC - choose method how to generate To: header Initial Comment: It depends on #3516387 patch, that provides b2b_logic per session flags. It adds new flag t. When it enabled, To: header generates from To: header of source INVITE, when it disabled To header generates from request uri (old behavior). I need it for balance b2b sessions to multidomain proxy, when To: header should not be changed. -- Comment By: Nick Altmann (nikbyte) Date: 2012-09-17 21:12 Message: As Anca Vamanu has written to the opensips mailing list, this behavior can be achieved with this script: $var(orig-to) = $hdr(To); b2b_init_request(top hiding); In local route: remove_hf(To); append_hf(To: $var(orig-to)\r\n, From); -- Comment By: Nick Altmann (nikbyte) Date: 2012-09-03 22:06 Message: needs rewrite (I'll do it later) -- You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=3520528group_id=232389 ___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
