Yeah, starting this fire is on me - I tried to read local code without
the global scope. Nevertheless, this raises again the issue of a better
code commenting to avoid such future confusions.
And thank you Ovidiu for your fast reaction. And to you Maxim for the
fast testing and reporting.
Be
Hello Maxim,
All should be good now.
Sorry for the trouble. I'm working on this part of the code, running
tests and I would've caught the issue soon.
We rushed with the backport based only on code inspection, so "mea
culpa" here :)
Thanks for the fast report,
Ovidiu
On Mon, Feb 5, 2018 at 3:40
Branch: refs/heads/2.2
Home: https://github.com/OpenSIPS/opensips
Commit: 926efd43d099385040024b1ee1dedfb0bfe138d9
https://github.com/OpenSIPS/opensips/commit/926efd43d099385040024b1ee1dedfb0bfe138d9
Author: Ovidiu Sas
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
Branch: refs/heads/2.3
Home: https://github.com/OpenSIPS/opensips
Commit: 1f5ead7234bd7013e0725ca3114f51e901da1cfb
https://github.com/OpenSIPS/opensips/commit/1f5ead7234bd7013e0725ca3114f51e901da1cfb
Author: Ovidiu Sas
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
Branch: refs/heads/master
Home: https://github.com/OpenSIPS/opensips
Commit: ebbe49c50ce045a41b390198e3ee731450aaf600
https://github.com/OpenSIPS/opensips/commit/ebbe49c50ce045a41b390198e3ee731450aaf600
Author: Ovidiu Sas
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
Thanks, regardless I am glad somebody took care of refactoring that old
code, but please be more careful with merging it down into stable branches.
:) I've just made a change to request a daily build of the voiptests, so
consider keeping an eye on it after making changes in master branch.
It is ju
Branch: refs/heads/master
Home: https://github.com/OpenSIPS/opensips
Commit: ee2731212303eb7055b3bd165464fe44fae05e7b
https://github.com/OpenSIPS/opensips/commit/ee2731212303eb7055b3bd165464fe44fae05e7b
Author: Ovidiu Sas
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
Branch: refs/heads/2.2
Home: https://github.com/OpenSIPS/opensips
Commit: 6a312d48c624be7ab15c21ab36351c6c6a2a6387
https://github.com/OpenSIPS/opensips/commit/6a312d48c624be7ab15c21ab36351c6c6a2a6387
Author: Ovidiu Sas
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
Branch: refs/heads/2.3
Home: https://github.com/OpenSIPS/opensips
Commit: 1e36fa1afafb90fcffcd88fdecc5c74e24ceb990
https://github.com/OpenSIPS/opensips/commit/1e36fa1afafb90fcffcd88fdecc5c74e24ceb990
Author: Ovidiu Sas
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
Branch: refs/heads/master
Home: https://github.com/OpenSIPS/opensips
Commit: 06c6fa179531475427284da645604ad8d73c55d0
https://github.com/OpenSIPS/opensips/commit/06c6fa179531475427284da645604ad8d73c55d0
Author: Ovidiu Sas
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
Hello Maxim,
I think I know what the issue is. There was a confusion between
variable naming: oldpf and newpf refers to protocol format and not the
actual IP.
I will revert the changes!
-ovidiu
On Mon, Feb 5, 2018 at 3:06 PM, Maxim Sobolev wrote:
> That merge broke all of our OpenSIPS test scen
P.P.S. Our test case is quite simple you can see it here:
https://github.com/sippy/voiptests/blob/master/opensips.cfg.in
The failure observed here is that the IP and port in the SDP are not
updated despite session has been established in the rtpproxy just fine.
245 00:00:02.433/DBUG:GLOBAL:get_c
P.S. Build logs are here:
https://travis-ci.org/sippy/voiptests/builds/337694673
On Mon, Feb 5, 2018 at 12:06 PM, Maxim Sobolev
wrote:
> That merge broke all of our OpenSIPS test scenarous on voiptests. We are
> investigating about the possible cause but I think this change may need to
> be rev
That merge broke all of our OpenSIPS test scenarous on voiptests. We are
investigating about the possible cause but I think this change may need to
be reverted from the stable branches until it's clear what's going on.
-Maxim
On Mon, Feb 5, 2018 at 10:04 AM, Ovidiu Sas wrote:
> Branch: refs/h
Branch: refs/heads/master
Home: https://github.com/OpenSIPS/opensips
Commit: 1177d975fbe16fd0e20e0a251c9fa1d62aeb1191
https://github.com/OpenSIPS/opensips/commit/1177d975fbe16fd0e20e0a251c9fa1d62aeb1191
Author: Bogdan-Andrei Iancu
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed
Branch: refs/heads/2.2
Home: https://github.com/OpenSIPS/opensips
Commit: dc258b09da9dcbc654f30365c6a0e8d4be015e6f
https://github.com/OpenSIPS/opensips/commit/dc258b09da9dcbc654f30365c6a0e8d4be015e6f
Author: Ovidiu Sas
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
Branch: refs/heads/2.3
Home: https://github.com/OpenSIPS/opensips
Commit: a45d4dcaf046bb273cfe5905ac035845a6867945
https://github.com/OpenSIPS/opensips/commit/a45d4dcaf046bb273cfe5905ac035845a6867945
Author: Ovidiu Sas
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
Branch: refs/heads/2.2
Home: https://github.com/OpenSIPS/opensips
Commit: fda88d51de728059af93fcbfe656520acddc2e50
https://github.com/OpenSIPS/opensips/commit/fda88d51de728059af93fcbfe656520acddc2e50
Author: Ovidiu Sas
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
Branch: refs/heads/2.3
Home: https://github.com/OpenSIPS/opensips
Commit: 7eeb83e29151f7625504624eab941a1df0cf8ec0
https://github.com/OpenSIPS/opensips/commit/7eeb83e29151f7625504624eab941a1df0cf8ec0
Author: Ovidiu Sas
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
Branch: refs/heads/2.3
Home: https://github.com/OpenSIPS/opensips
Commit: a71c679a583cfa9d99caea1cf3168eca775b2c49
https://github.com/OpenSIPS/opensips/commit/a71c679a583cfa9d99caea1cf3168eca775b2c49
Author: Bogdan-Andrei Iancu
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed pa
Branch: refs/heads/master
Home: https://github.com/OpenSIPS/opensips
Commit: a2e4e73ff7ea04a4a451a3425613e9612da57749
https://github.com/OpenSIPS/opensips/commit/a2e4e73ff7ea04a4a451a3425613e9612da57749
Author: Bogdan-Andrei Iancu
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed
Branch: refs/heads/master
Home: https://github.com/OpenSIPS/opensips
Commit: 55e9479b32c2d01a12a3278afb75b0fa520605c4
https://github.com/OpenSIPS/opensips/commit/55e9479b32c2d01a12a3278afb75b0fa520605c4
Author: Ovidiu Sas
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
Branch: refs/heads/master
Home: https://github.com/OpenSIPS/opensips
Commit: 3c39167e333a8801772f49f8561a015bfa1836f1
https://github.com/OpenSIPS/opensips/commit/3c39167e333a8801772f49f8561a015bfa1836f1
Author: Ovidiu Sas
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed paths:
Hi Daniel,
The issue was fixed and backported to the maintained versions too. See
the fixes on the master branch:
https://github.com/OpenSIPS/opensips/commit/095dc57300b9665b090e999a540db8b391f8d22e
https://github.com/OpenSIPS/opensips/commit/a61fa8646e6f865b347b3e725c6362dc15d4e57b
https://git
Branch: refs/heads/2.2
Home: https://github.com/OpenSIPS/opensips
Commit: c584715b5de30fd975e34f20939ba34e21dff228
https://github.com/OpenSIPS/opensips/commit/c584715b5de30fd975e34f20939ba34e21dff228
Author: Bogdan-Andrei Iancu
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed pa
Branch: refs/heads/2.3
Home: https://github.com/OpenSIPS/opensips
Commit: bf0cbd05cffbce775e7676f12b0eb3f5e9443cb8
https://github.com/OpenSIPS/opensips/commit/bf0cbd05cffbce775e7676f12b0eb3f5e9443cb8
Author: Bogdan-Andrei Iancu
Date: 2018-02-05 (Mon, 05 Feb 2018)
Changed pa
26 matches
Mail list logo