Branch: refs/heads/1.9
Home: https://github.com/OpenSIPS/opensips
Commit: c94887a5f5e950ee59e699f1bcfb3118d7cc78fb
https://github.com/OpenSIPS/opensips/commit/c94887a5f5e950ee59e699f1bcfb3118d7cc78fb
Author: Walter Doekes walter+git...@wjd.nu
Date: 2014-02-05 (Wed, 05 Feb 2014
Branch: refs/heads/1.10
Home: https://github.com/OpenSIPS/opensips
Commit: 26044bfee42c28d3d53516fbe54080a3a9420a87
https://github.com/OpenSIPS/opensips/commit/26044bfee42c28d3d53516fbe54080a3a9420a87
Author: Walter Doekes walter+git...@wjd.nu
Date: 2014-02-05 (Wed, 05 Feb
Better yet!
z A following integer conversion corresponds to a size_t or ssize_t
argument.
---
Reply to this email directly or view it on GitHub:
(I squashes the two commits into one, just now.)
---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/174#issuecomment-36837723___
Devel mailing list
Devel@lists.opensips.org
See the two commits:
- in both cases the first item of the linked list is not freed,
- the freed memory is read
- lastly a NULL is freed (or in the second case, a NULL-dereference)
You can merge this Pull Request by running:
git pull https://github.com/wdoekes/opensips
Reported by: dsandras
gt; About the bound checking error, the code was cutamp;pasted from another
gt; place in the same file where the same error is still present:
gt; ...
Also I replaced a heap str with a stack one in build_dialoginfo. This
one wasn#39;t freed either unless an error condition
return NULL;
- }
- memcpy(buf, sip:, 4);
- memcpy(buf+4, pres_user-s, pres_user-len);
- buf[pres_user-len+4] = '@';
- memcpy(buf + pres_user-len + 5, pres_domain-s, pres_domain-len);
- buf[pres_user-len + 5 + pres_domain-len]= '\0';
-
- pres_uri =
@@ -444,10 +429,6 @@ str* build_dialoginfo(str* pres_user, str* pres_domain)
xmlCleanupParser();
return body;
error:
- if ( pres_uri )
- {
- pkg_free(pres_uri);
Here it was freed, but it wasn't when the function returned succesfully.
---
Reply to this
Branch: refs/heads/1.8
Home: https://github.com/OpenSIPS/opensips
Commit: 2d1e4a8706cf256b2f0883e457d9598d2420399e
https://github.com/OpenSIPS/opensips/commit/2d1e4a8706cf256b2f0883e457d9598d2420399e
Author: Walter Doekes walter+git...@wjd.nu
Date: 2014-03-26 (Wed, 26 Mar 2014
Branch: refs/heads/1.10
Home: https://github.com/OpenSIPS/opensips
Commit: 3972d266958e6e49110a881e1c9733fa066873ff
https://github.com/OpenSIPS/opensips/commit/3972d266958e6e49110a881e1c9733fa066873ff
Author: Walter Doekes walter+git...@wjd.nu
Date: 2014-03-26 (Wed, 26 Mar
Branch: refs/heads/1.10
Home: https://github.com/OpenSIPS/opensips
Commit: 38dc20be0c20576510a8c57e296741c24a743a80
https://github.com/OpenSIPS/opensips/commit/38dc20be0c20576510a8c57e296741c24a743a80
Author: Walter Doekes walter+git...@wjd.nu
Date: 2014-03-26 (Wed, 26 Mar
Branch: refs/heads/1.8
Home: https://github.com/OpenSIPS/opensips
Commit: 9c3fdda8073fec5e67dcd55bd627c201a72d6d5b
https://github.com/OpenSIPS/opensips/commit/9c3fdda8073fec5e67dcd55bd627c201a72d6d5b
Author: Walter Doekes walter+git...@wjd.nu
Date: 2014-03-26 (Wed, 26 Mar 2014
@@ -130,6 +131,18 @@ static int get_all_db_ucontacts(void *buf, int len,
unsigned int flags,
LM_DBG(buf: %p. flags: %d\n, buf, flags);
+ if (sockaddr_list_str.s) {
+ i = snprintf(query_socket, sizeof(query_socket), and socket
in (%.*s),
I can't find the spec
You can merge this Pull Request by running:
git pull https://github.com/wdoekes/opensips wjd-misc_typos
Or you can view, comment on it, or merge it online at:
https://github.com/OpenSIPS/opensips/pull/232
-- Commit Summary --
* s/interger/integer/
* s/sever=/server=/
*
Drat. Didn't mean to make 4 commits out of that. I'll squash 'm next time.
Sorry :)
---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/232#issuecomment-43497369___
Devel mailing list
} else {
- LM_ERR(can't extract 2nd via
found reply\n);
+ if (parse_headers(msg,
HDR_VIA2_F, 0) != -1
You could make the `} else {` above an `} else if {`, that
@@ -3229,6 +3229,8 @@ force_rtp_proxy(struct sip_msg* msg, char* str1, char*
str2, char *setid, char *
struct force_rtpp_args args;
struct force_rtpp_args *ap;
union sockaddr_union to;
+ struct socket_info *si;
+ struct dlg_cell * dlg;
Please stay consistent with
} else {
- LM_ERR(can't extract 2nd via
found reply\n);
+ if (parse_headers(msg,
HDR_VIA2_F, 0) != -1
Hi! I believe I did suggest moving this `if` into the `else`
For the record. This should probably be improved to handle in-memory contacts
as well, since this can now be binary-replicated (right?)
16:28 lirakis bogdan_vs, if there was a smart nat ping ... then i think
you could do distributed usrloc out of the box with replication, path headers,
and a
If callid is shorter than topo_hiding_prefix.len, you'll be comparing random
memory. In the worst case resulting in a segfault. Suggestion: add an `if
(msg-callid-body.len topo_hiding_prefix.len ...`
---
Reply to this email directly or view it on GitHub:
The patch speaks for itself.
Mainly it adds the `-z quot;$(DBHTMLXSL)quot;` check, so I don#39;t get
unexplainable errors.
You can merge this Pull Request by running:
git pull https://github.com/wdoekes/opensips wjd-warn-if-no-docbook
Or you can view, comment on it, or merge it online at:
See the three commits. The changes were trivial.
I don#39;t know about copyright and stuff though.
You can merge this Pull Request by running:
git pull https://github.com/wdoekes/opensips wjd-topoh-from-kamailio
Or you can view, comment on it, or merge it online at:
@@ -206,17 +206,35 @@ modparam(siptrace, duplicate_uri,
sip:10.1.1.1:5888)
1.3.8. trace_local_ip (str)
- The address to be used in fromip field for local generated
- messages. If not set, the module sets it to the address of the
- socket that will be used to send the message.
@@ -206,17 +206,35 @@ modparam(siptrace, duplicate_uri,
sip:10.1.1.1:5888)
1.3.8. trace_local_ip (str)
- The address to be used in fromip field for local generated
- messages. If not set, the module sets it to the address of the
- socket that will be used to send the message.
- Fix a few typo#39;s (*global, *allocate and a few others).
- Alter makefile so the docs are all touched when doing `make modules-readme`.
- Run `make modules-readme` to regenerate text readme#39;s.
You can merge this Pull Request by running:
git pull https://github.com/wdoekes/opensips
Add the quot;spiralquot; module that mangles the call-id without requiring
the dialog state to be kept.
The `topoh` module pull request does the same, but more. This is limited to
only altering the call-id header.
You can merge this Pull Request by running:
git pull
That's the flip side of the coin.
The other side is that I don't need to alter the modules-filter when I *do*
want to regenerate all.
My problem with the current situation was that:
- I needed to generate one README
- I got 40% of the READMEs (because of the default selected modules)
I changed
See #258.
You can merge this Pull Request by running:
git pull https://github.com/wdoekes/opensips wjd-unbreak_modules_readme
Or you can view, comment on it, or merge it online at:
https://github.com/OpenSIPS/opensips/pull/263
-- Commit Summary --
* make: Let `make modules-readme
- return 1;
+return 1;
You're reindenting huge bits of file here.
Looks like your replacing tabs with four spaces. That doesn't help the review,
nor the code base. Please use tabs for every 4 spaces and force-push over this.
---
Reply to this email directly or view it on GitHub:
+if ((hdrs_len+2=msg-len)
(strncmp(CRLF,msg-unparsed,CRLF_LEN)==0) )
+body.s = msg-unparsed + CRLF_LEN;
+else if ( (hdrs_len+1=msg-len)
+(*(msg-unparsed)=='\n' || *(msg-unparsed)=='\r' ) )
+body.s = msg-unparsed + 1;
+else {
- goto failed;
- }
-
- if (body.len body.s) {
- /* if it really has body, check for content type */
- ret = SV_NO_CONTENT_TYPE;
- CHECK_HEADER(, content_type);
- }
- }
Before this, if you passed the MSG_TRANS_NOVIA_FLAG flag to
build_res_buf_from_sip_res, the msg-gt;via1-gt;next would get checked but
not used. Now it#39;s not touched at all.
You can merge this Pull Request by running:
git pull https://github.com/wdoekes/opensips wjd-msg_trans_no_via-no_crash
Nice! I always wanted something like that.
Does the string-part get it's pv's expanded? I'd want to put var(foo) is
$var(foo) and not 42 in there.
(And I'd prefer a few more spaces between every operator in the code.)
---
Reply to this email directly or view it on GitHub:
Yes. That sounds reasonable. Thanks for looking into this :)
---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/249#issuecomment-53405415___
Devel mailing list
Devel@lists.opensips.org
Closed #249.
---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/249#event-157244587___
Devel mailing list
Devel@lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
You can merge this Pull Request by running:
git pull https://github.com/wdoekes/opensips wjd-dialog-modparam-columns
Or you can view, comment on it, or merge it online at:
https://github.com/OpenSIPS/opensips/pull/351
-- Commit Summary --
* dialog: Fix dialog_admin documentation
I would think so. This is a very old bug. It's in kamailio as well.
---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/351#issuecomment-58351675___
Devel mailing list
Devel@lists.opensips.org
(backport from b519d6997e6faa654ff4a513843359008f8cb66e)
You can merge this Pull Request by running:
git pull https://github.com/wdoekes/opensips wjd-dialog-modparam-columns-1.8
Or you can view, comment on it, or merge it online at:
https://github.com/OpenSIPS/opensips/pull/352
-- Commit
(backport from b519d6997e6faa654ff4a513843359008f8cb66e)
You can merge this Pull Request by running:
git pull https://github.com/wdoekes/opensips wjd-dialog-modparam-columns-1.9
Or you can view, comment on it, or merge it online at:
https://github.com/OpenSIPS/opensips/pull/353
-- Commit
(backport from b519d6997e6faa654ff4a513843359008f8cb66e)
You can merge this Pull Request by running:
git pull https://github.com/wdoekes/opensips wjd-dialog-modparam-columns-1.10
Or you can view, comment on it, or merge it online at:
https://github.com/OpenSIPS/opensips/pull/354
-- Commit
(backport from b519d6997e6faa654ff4a513843359008f8cb66e)
You can merge this Pull Request by running:
git pull https://github.com/wdoekes/opensips wjd-dialog-modparam-columns-1.11
Or you can view, comment on it, or merge it online at:
https://github.com/OpenSIPS/opensips/pull/355
-- Commit
There you go. A bunch of pull request.
Only conflicts were between master-1.8 (no mflags yet).
1.8 upwards to 1.11 was conflict-free.
---
Reply to this email directly or view it on GitHub:
+ * output - pseudovariable where to store the output from the
+ standard output of the command. Keep in mind that if this
+ parameter is set, the async paramater will not be taken in
+ consideration.
+ * input - String to be passed to the standard input of the
+
+ } else if (outvar) {
+ pid = __popen(command-s, r, pout);
+ } else {
+ pid = fork();
+ if (pid == 0) {
+ execl(/bin/sh, /bin/sh, -c, command-s, NULL);
+ exit(-1);
+ }
+ }
+
+ if
+
+ if (ferror(pin)) {
+ LM_ERR(writing pipe: %s\n, strerror(errno));
+ ser_error=E_EXEC;
+ goto error;
+ }
+ pclose(pin);
+ }
+
+ schedule_to_kill(pid);
+ wait(exit_status);
+
@@ -243,6 +246,48 @@ exec_getenv(HOSTNAME);
exec_getenv(HOSTNAME, $avp(localhost));
...
+1.4.5. exec(command, [output], [input], [envavp])
+
+ Executes an external command. The input is passed to the
+ standard input of the new process, if specified, and the output
+ is saved
@@ -142,6 +142,7 @@ struct action{
int type; /* forward, drop, log, send ...*/
action_elem_t elem[MAX_ACTION_ELEMS];
int line;
+ char *file;
Shouln't this be `const char *` ?
It's not like someone is allowed to alter it along the way, right?
---
Reply to this email
@@ -332,6 +332,76 @@ exec_getenv(HOSTNAME, $avp(localhost));
/example
/section
+ section
+ title
+ function moreinfo=noneexec(command, [output], [input],
[error],[envavp])/function
Could you change that to [input], [output], [error] ?
+ paraemphasiserror/emphasis - pseudovariable where
to store the error from
+ the standard error of the process.
+ /para
+ /listitem
+ listitem
+ paraemphasisenvavp/emphasis - Avp where
+ para
+ WARNING: input/output/error parameters are not designed
for a large amount of
+ data so one should be careful when using them because server
could considerably be
+ slowed down.
+ /para
+ para
+
+ /para
+ para
+ This function can be used from REQUEST_ROUTE, FAILURE_ROUTE,
+ LOCAL_ROUTE, STARTUP_ROUTE, TIMER_ROUTE, EVENT_ROUTE,
ONREPLY_ROUTE.
+ /para
+ example
+ titlefunction
@@ -51,6 +51,7 @@ int schedule_to_kill( int pid );
* @stream: stream to be returned to the caller
*/
pid_t __popen(const char *cmd, const char *type, FILE **stream);
+pid_t ___popen(const char *cmd, FILE **, FILE**, FILE**);
That's not very inventively named, is it? :-D
Python popen2
+ if ((buflen + tmplen) = MAX_BUF_SIZE) {
+ LM_WARN(no more space in output buffer\n);
+ break;
+ }
+ memcpy(buf+buflen, tmpbuf, tmplen);
+ buflen += tmplen;
+
+ outval.flags = PV_VAL_STR;
+ goto error;
+ }
+
+ if (ferror(pin)) {
+ ser_error=E_EXEC;
+ goto error;
+ }
+ pclose(pin);
+ }
+
+ schedule_to_kill(pid);
+ wait(exit_status);
+
+ if
+ return -1;
+ }
+ }
+
+ if (errvar) {
+ if (read_and_write2var(msg, perr, errvar) 0) {
+ LM_ERR(failed reading stderr from pipe\n);
+ return -1;
+ }
+ }
+
+ ret=1;
+
+ }
+ return 0;
+}
+
+static inline int setenvvar(struct hf_wrapper** hf, int_str* value, int idx)
+{
+ #define OSIPS_EXEC OSIPS_EXEC_
+
+
+ int len=0;
+ str sidx;
+
+ sidx.s = int2str((unsigned long)idx, sidx.len);
+
+
Thanks for fixing the other issues :)
---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/pull/375#issuecomment-60891337___
Devel mailing list
Devel@lists.opensips.org
That would suit my needs indeed; and make more sense than the awkward query
that we do now.
Thinking out loud here: where do we get this ID from? Do we add a `server_id`
integer parameter to `usrloc`? Or should we generate one automatically? If we
use a parameter and default it to `1`, we get
You can view, comment on, or merge this pull request online at:
https://github.com/OpenSIPS/opensips/pull/404
-- Commit Summary --
* cfgutils: Clarify shvset/varset error message.
-- File Changes --
M modules/cfgutils/shvar.c (3)
-- Patch Links --
Shouldn't you fix the caller that pkg_free's without checking for NULL instead?
If you allow it, then you might as well drop all the `if(buf)` before every
`pkg_free(buf)`. Allowing both makes the code inconsistent.
Right?
---
Reply to this email directly or view it on GitHub:
You do know that `-j` does not restrict the number of processes?
```
-j [jobs], --jobs[=jobs]
Specifies the number of jobs (commands) to run simultaneously.
If there is more than
one -j option, the last one is effective. If the -j option is
given without an
This has been possible since 23f2322d in 1.8 and higher.
You can view, comment on, or merge this pull request online at:
https://github.com/OpenSIPS/opensips/pull/664
-- Commit Summary --
* dialog: Document that unset_dlg_profile can be used from request_route.
-- File Changes --
M
Compile error? And another one below..
---
Reply to this email directly or view it on GitHub:
https://github.com/OpenSIPS/opensips/commit/d6d3dd5bfe1636ad420af2a1fe3492fb22507944#commitcomment-14655312___
Devel mailing list
Devel@lists.opensips.org
Branch: refs/heads/3.0
Home: https://github.com/OpenSIPS/opensips
Commit: 21dae83c2659edfa0b2a10ed3ebe616084cf0b6b
https://github.com/OpenSIPS/opensips/commit/21dae83c2659edfa0b2a10ed3ebe616084cf0b6b
Author: Walter Doekes
Date: 2019-04-24 (Wed, 24 Apr 2019)
Changed paths
Branch: refs/heads/3.0
Home: https://github.com/OpenSIPS/opensips
Commit: 8f7f8f38c53ab240e8eaff9f894b35e045d84614
https://github.com/OpenSIPS/opensips/commit/8f7f8f38c53ab240e8eaff9f894b35e045d84614
Author: Walter Doekes
Date: 2019-04-24 (Wed, 24 Apr 2019)
Changed paths
Branch: refs/heads/2.4
Home: https://github.com/OpenSIPS/opensips
Commit: a9b4c1927ba71358630ed28b842477ee57dc146e
https://github.com/OpenSIPS/opensips/commit/a9b4c1927ba71358630ed28b842477ee57dc146e
Author: Walter Doekes
Date: 2020-05-11 (Mon, 11 May 2020)
Changed paths
Branch: refs/heads/3.0
Home: https://github.com/OpenSIPS/opensips
Commit: 46ee34b30159d16fcd5aaa234654fdb71db0daec
https://github.com/OpenSIPS/opensips/commit/46ee34b30159d16fcd5aaa234654fdb71db0daec
Author: Walter Doekes
Date: 2020-05-11 (Mon, 11 May 2020)
Changed paths
Branch: refs/heads/3.0
Home: https://github.com/OpenSIPS/opensips
Commit: d3d160bab47962520f6b013ace29ef5f5247657c
https://github.com/OpenSIPS/opensips/commit/d3d160bab47962520f6b013ace29ef5f5247657c
Author: Walter Doekes
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths
Branch: refs/heads/2.4
Home: https://github.com/OpenSIPS/opensips
Commit: dd3db539bbe0ff98d53ece86a0f06eb1c427f8f1
https://github.com/OpenSIPS/opensips/commit/dd3db539bbe0ff98d53ece86a0f06eb1c427f8f1
Author: Walter Doekes
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths
Branch: refs/heads/3.1
Home: https://github.com/OpenSIPS/opensips
Commit: c2e8248de7cedec8a8542abd20762cb46a0a8711
https://github.com/OpenSIPS/opensips/commit/c2e8248de7cedec8a8542abd20762cb46a0a8711
Author: Walter Doekes
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths
Branch: refs/heads/3.1
Home: https://github.com/OpenSIPS/opensips
Commit: df67bac58b260ec426c945c58859978a78c6b67d
https://github.com/OpenSIPS/opensips/commit/df67bac58b260ec426c945c58859978a78c6b67d
Author: Walter Doekes
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths
Branch: refs/heads/2.4
Home: https://github.com/OpenSIPS/opensips
Commit: b261b675bffebf0fd3b77503d53da13ce3b6a2c8
https://github.com/OpenSIPS/opensips/commit/b261b675bffebf0fd3b77503d53da13ce3b6a2c8
Author: Walter Doekes
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths
Branch: refs/heads/3.0
Home: https://github.com/OpenSIPS/opensips
Commit: da488403c71b3effb994c7e95310f059fa36ff2c
https://github.com/OpenSIPS/opensips/commit/da488403c71b3effb994c7e95310f059fa36ff2c
Author: Walter Doekes
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths
Branch: refs/heads/3.2
Home: https://github.com/OpenSIPS/opensips
Commit: da98caf62251d1e5e72ff22b8c9a2d98f5b64eaf
https://github.com/OpenSIPS/opensips/commit/da98caf62251d1e5e72ff22b8c9a2d98f5b64eaf
Author: Walter Doekes
Date: 2021-06-09 (Wed, 09 Jun 2021)
Changed paths
Branch: refs/heads/3.2
Home: https://github.com/OpenSIPS/opensips
Commit: 8da4b56eb89fd304b92626a79526bf860c98f326
https://github.com/OpenSIPS/opensips/commit/8da4b56eb89fd304b92626a79526bf860c98f326
Author: Walter Doekes
Date: 2021-07-01 (Thu, 01 Jul 2021)
Changed paths
Branch: refs/heads/3.1
Home: https://github.com/OpenSIPS/opensips
Commit: fddb7eafb586a104203cf194a71b2bbc0e90655f
https://github.com/OpenSIPS/opensips/commit/fddb7eafb586a104203cf194a71b2bbc0e90655f
Author: Walter Doekes
Date: 2021-04-26 (Mon, 26 Apr 2021)
Changed paths
Branch: refs/heads/2.4
Home: https://github.com/OpenSIPS/opensips
Commit: 71d7801e6e64c9061580fc7186d26e3f2b97c599
https://github.com/OpenSIPS/opensips/commit/71d7801e6e64c9061580fc7186d26e3f2b97c599
Author: Walter Doekes
Date: 2021-04-26 (Mon, 26 Apr 2021)
Changed paths
Branch: refs/heads/3.1
Home: https://github.com/OpenSIPS/opensips
Commit: ec0a7e6fcabc04463637a20a9919b3c6a429d441
https://github.com/OpenSIPS/opensips/commit/ec0a7e6fcabc04463637a20a9919b3c6a429d441
Author: Walter Doekes
Date: 2021-04-27 (Tue, 27 Apr 2021)
Changed paths
Branch: refs/heads/3.1
Home: https://github.com/OpenSIPS/opensips
Commit: ba7d6a7b21a2450b0d8b1f93125974b685c00f51
https://github.com/OpenSIPS/opensips/commit/ba7d6a7b21a2450b0d8b1f93125974b685c00f51
Author: Walter Doekes
Date: 2021-03-24 (Wed, 24 Mar 2021)
Changed paths
79 matches
Mail list logo
