Personally, I consider that *fixup_get_isvalue* would have a lot more value if
it did had the option to do conversions internally, thus masking the whole flag
pvar logic behind it. It should have a prototype such as:
int fixup_get_isvalue(struct sip_msg* msg, gparam_p gp, int_str *out, enum
The purpose of the fixup function is to get both int and str (if possible).
Since in_str is a union, that would not work.
However, doing the conversion from str to int internally is a good idea.
Thanks for reviewing the commit!
---
Reply to this email directly or view it on GitHub:
