Re: check_ping: Add support for showing name (DNS) resolution in the plugin output (STDOUT). (#1284)

2014-11-28 Thread Mark A. Ziesemer
@sni / @waja - Could we please have some opportunity for review / discussion here before immediately squashing this as closed? I would be more than happy to provide additional / alternate revisions here, if/as required for inclusion. I think we'd all hate to have an additional fork here for some

Re: [PATCH] update .gitignore

2014-11-28 Thread Sebastian Herbszt
Holger Weiß wrote: > * Sebastian Herbszt [2014-11-27 00:05]: > > Add build-aux/test-driver to .gitignore. > > I'm not sure how you ended up with a build-aux/test-driver file(?) ... > > Holger $ git describe v2.1-23-gf3b789a $ tools/setup which: no gnumake in (/usr/lib64/mpi/gcc/openmpi/bin:/s

check_http.c: fix Host header if explicitly set with -k (#1305)

2014-11-28 Thread waja
taken from https://github.com/llicour/nagios-plugins/commit/911c3c34755c65046fe73ce051ec9dc3b76b324a You can merge this Pull Request by running: git pull https://github.com/waja/monitoring-plugins check_http_hostheader Or you can view, comment on it, or merge it online at: https://github.com

[monitoring-plugins] NEWS: Mention HP-UX fixes for check_procs

2014-11-28 Thread Holger Weiss
Module: monitoring-plugins Branch: master Commit: f3b789a526af04434813c3d49dfb28b106ad691c Author: Holger Weiss Date: Fri Nov 28 17:09:54 2014 +0100 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=f3b789a NEWS: Mention HP-UX fixes for check_procs Cl

[monitoring-plugins] Added particular ps command for HP-UX ...

2014-11-28 Thread Holger Weiss
Module: monitoring-plugins Branch: master Commit: 366e6cdcf3884d9c62babb8e57e49d2fcd1be420 Author: Yannick Charton Committer: Holger Weiss Date: Tue Aug 26 14:42:14 2014 +0200 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=366e6cd

Re: check_procs: added working HP-UX support (#1288)

2014-11-28 Thread Holger Weiß
Closed #1288 via f3b789a526af04434813c3d49dfb28b106ad691c. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1288#event-199987676

Re: check_nwstat: adds percentage used space (#1183)

2014-11-28 Thread waja
Just some stats for fun: $ grep "result=" plugins/check_nwstat.c | wc -l 157 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1183#issuecomment-64907997

Re: check_nwstat: adds percentage used space (#1183)

2014-11-28 Thread waja
Okay, I fixed those whitespace stuff. But about this operator formating ... the whole plugins is full of them. It would be better to fix that for the whole plugin (maybe after merging this or not, what ever we decide) afterwards. -- Reply to this email on GitHub: https://github.com/monitoring-plu

[monitoring-plugins] Added missing CR in DESCRIBE request.

2014-11-28 Thread Holger Weiss
Module: monitoring-plugins Branch: master Commit: 94c1a4a433a4c657532a9bc180046963edf6d954 Author: Andrew Berglund Committer: Holger Weiss Date: Fri Sep 5 09:44:09 2014 -0400 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=94c1a4a

[monitoring-plugins] Don't mix variable declarations and code

2014-11-28 Thread Holger Weiss
Module: monitoring-plugins Branch: master Commit: 8e5118e0cba939a3a2854204ee3169466190018f Author: Holger Weiss Date: Fri Nov 28 15:35:38 2014 +0100 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=8e5118e Don't mix variable declarations and code We

[monitoring-plugins] check_icmp: Fix a few type errors

2014-11-28 Thread Holger Weiss
Module: monitoring-plugins Branch: master Commit: 9c289ec74498e236d3b32abc15e789a653a3c586 Author: Holger Weiss Date: Fri Nov 28 16:20:55 2014 +0100 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=9c289ec check_icmp: Fix a few type errors --- plug

[monitoring-plugins] NEWS: Mention the check_real fix

2014-11-28 Thread Holger Weiss
Module: monitoring-plugins Branch: master Commit: 3aea6f8fa161836b18802c1a9791ec0c6e728799 Author: Holger Weiss Date: Fri Nov 28 16:28:08 2014 +0100 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=3aea6f8 NEWS: Mention the check_real fix Closes #129

[monitoring-plugins] Use kernel reception time on ICMP packets to ...

2014-11-28 Thread Holger Weiss
Module: monitoring-plugins Branch: master Commit: 5265fabeb98dc2af702a56f1a4b45627c3d4d93f Author: Matthieu Kermagoret Committer: Holger Weiss Date: Mon Feb 3 16:49:21 2014 +0100 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=526

Re: check_real: Fixed read timeout when passing url parameter. (#1290)

2014-11-28 Thread Holger Weiß
Closed #1290 via 3aea6f8fa161836b18802c1a9791ec0c6e728799. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1290#event-199971374

Re: check_by_ssh: added option to exit with an warning, if there is output on STDERR (#1301)

2014-11-28 Thread Sven Nierlein
instead of adding a negate like option for each plugin, i'd prefer to enhance the negate plugin to maybe change states only for certain pattern. Ex.: negate -w WARNING -r 'Remote command execution failed' ... -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugi

[monitoring-plugins] Merge pull request #1304 from ...

2014-11-28 Thread Sven Nierlein
Module: monitoring-plugins Branch: master Commit: 8b272a7f7baa7d743841da713a27284b0479d0e1 Author: Sven Nierlein Date: Fri Nov 28 15:48:26 2014 +0100 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=8b272a7 Merge pull request #1304 from monitoring-plu

Re: avoid a segfault, if ulimit is set to unlimited (#1300)

2014-11-28 Thread Sven Nierlein
thanks, i merged your changes with #1304 -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1300#issuecomment-64901137

Re: Pr 1183 enhanced (#1304)

2014-11-28 Thread Sven Nierlein
Merged #1304. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1304#event-199956246

[monitoring-plugins] make constants from maxfd values (#1300)

2014-11-28 Thread Sven Nierlein
Module: monitoring-plugins Branch: pr-1183-enhanced Commit: 7660540c31342eb7ea2f2ac24950094bf74f0a6f Author: Sven Nierlein Date: Fri Nov 28 15:25:43 2014 +0100 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=7660540 make constants from maxfd values (

[monitoring-plugins] avoid a segfault, if ulimit is set to unlimited

2014-11-28 Thread Sven Nierlein
Module: monitoring-plugins Branch: pr-1183-enhanced Commit: 6bb5e1db525f44a7ab40e9391244dbe65daa08cc Author: nafets Committer: Sven Nierlein Date: Wed Nov 19 22:34:23 2014 +0100 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=6bb5e

[monitoring-plugins] pr-1183-enhanced branch created

2014-11-28 Thread Git Repository
Module: monitoring-plugins Branch: pr-1183-enhanced SHA1: 7660540c31342eb7ea2f2ac24950094bf74f0a6f URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/log/?id=refs/heads/pr-1183-enhanced The pr-1183-enhanced branch has been created.

Pr 1183 enhanced (#1304)

2014-11-28 Thread Sven Nierlein
You can merge this Pull Request by running: git pull https://github.com/monitoring-plugins/monitoring-plugins pr-1183-enhanced Or you can view, comment on it, or merge it online at: https://github.com/monitoring-plugins/monitoring-plugins/pull/1304 -- Commit Summary -- * avoid a segfa

Re: check_icmp: use packet reception time to compute rtt (#1232)

2014-11-28 Thread Holger Weiß
As we support pre-C99 compilers, we can't apply patches that mix code and variable declarations. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1232#issuecomment-64898318

[monitoring-plugins] check_ssh: change warning to critical for ...

2014-11-28 Thread Jan Wagner
Module: monitoring-plugins Branch: master Commit: a7d7992777963bd192cfef21988d281bc371c794 Author: Sven Nierlein Committer: Jan Wagner Date: Mon Jun 30 14:52:10 2014 +0200 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=a7d7992 ch

[monitoring-plugins] Adding a warning for raising to CRITICAL for ...

2014-11-28 Thread Jan Wagner
Module: monitoring-plugins Branch: master Commit: 054bfc992239e531ab6c9bb7e3a5d777f3c8a009 Author: Jan Wagner Date: Fri Nov 28 14:39:33 2014 +0100 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=054bfc9 Adding a warning for raising to CRITICAL for pr

Re: check_ssh: change warning to critical for protocal/version errors (#1268)

2014-11-28 Thread Sven Nierlein
Closed #1268 via a7d7992777963bd192cfef21988d281bc371c794. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1268#event-199928927

Re: check_by_ssh: Add option to force pseudo tty allocation (#1303)

2014-11-28 Thread Sven Nierlein
Shouldn't this be possible by using the "-o RequestTTY=force" option. I am usually not a fan of just passing through options, especially when using a different character. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1303#issuecomment-64894466

Re: check_ping: Add support for showing name (DNS) resolution in the plugin output (STDOUT). (#1284)

2014-11-28 Thread Sven Nierlein
Closed #1284. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1284#event-199921004

Re: check_ping: Add support for showing name (DNS) resolution in the plugin output (STDOUT). (#1284)

2014-11-28 Thread Sven Nierlein
Thanks for your patch. We decided to not include it since you almost always have the hostname in your interface or notification already and we'd like to avoid duplicate information. You might say it's optional, but then it still makes the code more complicated and less maintable and reduces the num

Re: check_ping output perfdata in seconds [sf#3438264] (#1025)

2014-11-28 Thread Holger Weiß
> It is very useful for systems which scale the perfdata, i.e. Centreon. I think those systems should be fixed to cope with other UOMs. If you think otherwise, please reopen the issue. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/issues/1025#issueco

[monitoring-plugins] Added perfdata to check_nt. New -l options - ...

2014-11-28 Thread Holger Weiss
Module: monitoring-plugins Branch: master Commit: c59ee0036f3c6e699b5c3064026ffa34dc264da1 Author: Andy Brist Committer: Holger Weiss Date: Fri Apr 4 12:59:19 2014 +0600 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=c59ee00 Add

[monitoring-plugins] NEWS: Mention new "check_nt -l" parameters

2014-11-28 Thread Holger Weiss
Module: monitoring-plugins Branch: master Commit: 7ef100a3ebd8195d9ad19e6c0cd8efd9c0284ee6 Author: Holger Weiss Date: Fri Nov 28 13:25:19 2014 +0100 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=7ef100a NEWS: Mention new "check_nt -l" parameters C

Re: check_nt: Added perfdata. New -l options - seconds|minutes|hours|days. (#1253)

2014-11-28 Thread Holger Weiß
Closed #1253 via 7ef100a3ebd8195d9ad19e6c0cd8efd9c0284ee6. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1253#event-199902569

[monitoring-plugins] NEWS: Mention new check_snmp option

2014-11-28 Thread Holger Weiss
Module: monitoring-plugins Branch: master Commit: 7906d27bfad7a2dfc1ee1964ba82e47b419df2d1 Author: Holger Weiss Date: Fri Nov 28 13:09:22 2014 +0100 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=7906d27 NEWS: Mention new check_snmp option Closes #

[monitoring-plugins] Introduce support for SNMPv3 context in check_snmp

2014-11-28 Thread Holger Weiss
Module: monitoring-plugins Branch: master Commit: 7a33e28e4e104c6121e6c209d504141f4a876015 Author: Johannes Engel Committer: Holger Weiss Date: Thu Dec 26 20:13:26 2013 +0100 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=7a33e28

Re: check_snmp: Added warning and critical thresholds to the performance data (#1235)

2014-11-28 Thread Holger Weiß
Closed #1235. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1235#event-199894115

Re: check_snmp: Added warning and critical thresholds to the performance data (#1235)

2014-11-28 Thread Holger Weiß
I've squashed the two commits, applied cosmetic changes, added a NEWS entry, and merged the changes. Thanks! -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1235#issuecomment-64886894

[monitoring-plugins] NEWS: Mention check_snmp's perfdata thresholds

2014-11-28 Thread Holger Weiss
Module: monitoring-plugins Branch: master Commit: 5a75f0b332fd569843c2abfae9f1ab8fcbd86b25 Author: Holger Weiss Date: Fri Nov 28 12:57:17 2014 +0100 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=5a75f0b NEWS: Mention check_snmp's perfdata threshold

[monitoring-plugins] check_snmp: Add thresholds to performance data

2014-11-28 Thread Holger Weiss
Module: monitoring-plugins Branch: master Commit: 6623a1c7872c2a535f5226c68a0bfcffad256b62 Author: Andreas Seemueller Committer: Holger Weiss Date: Tue Feb 11 18:04:56 2014 +0100 URL: https://www.monitoring-plugins.org/repositories/monitoring-plugins/commit/?id=6623

Re: check_snmp: fix for multiple non numeric OIDs (#1163)

2014-11-28 Thread waja
Closed #1163. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1163#event-199881408

Re: check_snmp: fix for multiple non numeric OIDs (#1163)

2014-11-28 Thread waja
Closing this too as we closed #1013. -- Reply to this email on GitHub: https://github.com/monitoring-plugins/monitoring-plugins/pull/1163#issuecomment-64884144

Re: check_mailq: add sudo support (#1171)

2014-11-28 Thread waja
Am 28.11.14 11:54, schrieb Holger Weiß: > I think it would be nicer to have the new |-s| flag accept an optional > argument that allows the user to specify a different |sudo| command. But +1 --- Reply to this email directly or view it on GitHub: https://github.com/monitoring-plugins/monitoring-pl

Re: [PATCH] update .gitignore

2014-11-28 Thread Holger Weiß
* Sebastian Herbszt [2014-11-27 00:05]: > Add build-aux/test-driver to .gitignore. I'm not sure how you ended up with a build-aux/test-driver file(?) ... Holger