Re: New Defects reported by Coverity Scan for ntpsec

2023-02-07 Thread Hal Murray via devel
I took a look at the Coverity reports for ntpsec. There are 10 of them. 10 is a small number. We should be able to fix them all. The Coverity report that started this thread was actually a bug. The code I had was bool once = false; if (once) return; once = true; ... I was so

Re: New Defects reported by Coverity Scan for ntpsec

2023-02-07 Thread Gary E. Miller via devel
Yo Hal! On Tue, 07 Feb 2023 14:03:50 -0800 Hal Murray via devel wrote: > I took a look at the Coverity reports for ntpsec. > There are 10 of them. 10 is a small number. We should be able to > fix them all. Good. > The Coverity report that started this thread was actually a bug. My

Re: New Defects reported by Coverity Scan for ntpsec

2023-02-07 Thread Gary E. Miller via devel
Yo Hal! On Mon, 06 Feb 2023 22:51:02 -0800 Hal Murray wrote: > Thanks. > > > Do you have a coverity account? > > https://scan.coverity.com/ > > Then go to "My Dashboard" and "Add project". > > Should we document that? Where? The procedure changes more often than we add cverity users. >

Re: New Defects reported by Coverity Scan for ntpsec

2023-02-07 Thread Gary E. Miller via devel
Yo Hal! On Mon, 06 Feb 2023 22:51:02 -0800 Hal Murray wrote: > > I'm waiting for somebody to approve me. > > Where? How would I see it? The request was stuck in my spam folder. Looks like someone beat me to approving you. RGDS GARY

Re: New Defects reported by Coverity Scan for ntpsec

2023-02-07 Thread Hal Murray via devel
>> OK, I propose to turn on -Wswitch-enum and fix all the warnings I >> find. Then I/we fix whatever Coverity complains about. If that is >> too painful, we can back out of -Wswitch-enum. > Seems good to me. OK, I'll start working on it when I get time. > There are so many Coverity warnings

Re: New Defects reported by Coverity Scan for ntpsec

2023-02-07 Thread Gary E. Miller via devel
Yo Hal! On Tue, 07 Feb 2023 13:20:38 -0800 Hal Murray via devel wrote: > >> OK, I propose to turn on -Wswitch-enum and fix all the warnings I > >> find. Then I/we fix whatever Coverity complains about. If that is > >> too painful, we can back out of -Wswitch-enum. > > Seems good to me. >

Re: New Defects reported by Coverity Scan for ntpsec

2023-02-07 Thread James Browning via devel
On Feb 7, 2023 18:23, Hal Murray via devel wrote: Thanks. matthew.sel...@twosigma.com said: > No. We run the Coverity CI job weekly via a schedule, ... > I'll work on running Coverity post-merge. I agree that running it every merge is overkill. A button that says run-now would be nice

Re: New Defects reported by Coverity Scan for ntpsec

2023-02-07 Thread Gary E. Miller via devel
Yo Hal! On Tue, 07 Feb 2023 18:23:17 -0800 Hal Murray via devel wrote: > Yes, it's reasonably obvious, but only after you find the right URL. Consider it like a game of Adventure. > > I approved your account. > > Thanks. I didn't get any you-were-approved mail. > > Do I have to

Re: New Defects reported by Coverity Scan for ntpsec

2023-02-07 Thread Hal Murray via devel
Thanks. matthew.sel...@twosigma.com said: >> Should we document that? Where? > The account creation seems self-explanatory. Or did you want to document > something else? I don't know. I was just tossing out a suggestion based on my stumbling. Yes, it's reasonably obvious, but only after you

Re: New Defects reported by Coverity Scan for ntpsec

2023-02-07 Thread Matthew Selsky via devel
On Mon, Feb 06, 2023 at 10:51:02PM -0800, Hal Murray via devel wrote: > > > Do you have a coverity account? > > https://scan.coverity.com > > Then go to "My Dashboard" and "Add project". > > Should we document that? Where? The account creation seems self-explanatory. Or did you want to