I want to suggest four prioritized merge requests for inclusion.

2023-01-12 Thread James Browning via devel
I suggest that four of my merge requests be evaluated for inclusion. 1298 is the highest priority. It fixes a zero-day issue where the CI runner for Python coverage fails because the underlying distribution has shifted. After that would be 1290, which changes the ntpclients to use ntp.poly more

My ignorance was Re: ✘64-bit time_t on glibc 2.34 and up

2023-01-13 Thread James Browning via devel
> On 01/12/2023 5:10 PM PST Gary E. Miller wrote: > > > Yo All! > > Cross-posted to gpsd-dev and devel@ntpsec.org > > Recent glibc (2.34 and up) and recent Linux kernels, allow 64 bit > time_t on 32-bit Linux without much work. > > But... > > How to get that 2038 compatible time to ntpd

Re: clockmaker

2022-12-23 Thread James Browning via devel
> On 12/23/2022 7:51 AM PST NTPfiend via users wrote: > > > My instance of ntpsec gave up after just over a year uptime, so I went for a > re-installation (later R Pi, now 64 bit). Today (23 Dec) I attempted to run > clockmaker but it did not get far: > > [Line 210] > SyntaxError: Missing

Re: getargspec gone in Python 3.11?

2022-12-08 Thread James Browning via devel
On Dec 8, 2022, 01:05, Hal Murray via devel wrote: I have a system using Python 3.11 It says: == ERROR: test_packetize (__main__.NtpqRvInfoStats.test_packetize) Test ntp.util.packetize by coqtavoric gavage and scatology.

build on Python 2.6 broken and strongly suggested minimum version

2022-12-08 Thread James Browning via devel
Selsky broke the build[1] back in May 2020 when switching the python_scripts variable in /wscript to a set when Python 2.6 does not support sets. Given the lack of complaints, I suspect no one uses 2.6 anymore, which can be dropped. I also think that we should drop all Python versions before 3.7

Re: Release coming, take 2

2022-12-18 Thread James Browning via devel
> On 12/15/2022 1:21 PM PST Matthew Selsky via devel wrote: > > > Hi all, > > I plan to cut a release on Thu 12/22/2022. I'm sorry about the delays in > getting this release out the door. > > If there's anything that absolutely must be in this release and can't wait > until the next

Re: More cookie keys

2022-12-19 Thread James Browning via devel
> On 12/18/2022 6:02 PM PST Hal Murray via devel wrote: > > > The commit message for that is lacking the blank line after the summary > > line. This means that some git tools treat the entire commit message as the > > summary, creating obnoxiously long lines in their output. It's too late to > >

Re: tests/option-tester is broken

2022-12-19 Thread James Browning via devel
> On 12/19/2022 4:19 PM PST Hal Murray via devel wrote: > > > Anybody remember this area? > > With a fresh clone on Fedora which uses > Python 3.11.0 > > > test-all/test.log:Trouble with test-all > > Looking in test-all/test.log > > The build looks clean. It dies in the checking that all

Re: devel/make-tarball broken

2022-12-14 Thread James Browning via devel
> On 12/14/2022 3:05 PM PST Hal Murray via devel wrote: > > > Thanks for testing and fixing. > > I'm not familiar with that corner of tar/sed. What does the extra S do? > Where is that documented? > tar --transform="s:^:ntpsec-${V}/:" ... > tar --transform="s:^:ntpsec-${V}/:S" ... 'Do not

devel/make-tarball broken

2022-12-13 Thread James Browning via devel
[178/315] Compiling libntp/clockwork.c ../../libntp/ntp_calendar.c:18:10: fatal error: PIVOT.h: No such file or directory 18 | #include "PIVOT.h" | ^ compilation terminated. Default verbosity log and minimal solving patch attached. I also think merge requests !1256,

Re: tests/option-tester is broken

2022-12-20 Thread James Browning via devel
> On 12/20/2022 12:24 AM PST Hal Murray wrote: > > > > Bumping waf (2.0.23 tested) resolves this, and it only happens for the > > extension because, for some raisin, waf is outputting to the wrong file name > > of ntpc rather than ntpc.cpython-311-x86_64-linux-gnu.so , go figure. > > > The

Re: build on Python 2.6 broken and strongly suggested minimum version

2022-12-08 Thread James Browning via devel
On Dec 8, 2022, 13:22, Hal Murray via devel wrote: > I also think that we should drop all Python versions before 3.7 from > first-tier support and only continue supporting them if it is not > inconvenient or there is sufficient proven demand. Older but still supported versions of Debian

Fork this was Re: Fixing the dang CI pipelines, release

2022-12-01 Thread James Browning via devel
> On 11/27/2022 7:42 AM PST James Browning via devel wrote: > > > Around July 10, 2022, I authored several commits to improve the success rate > of the CI pipelines. At the time, I was too daft to realize that some changes > I made broke two of the on-push Debi

Fixing the dang CI pipelines, release

2022-11-27 Thread James Browning via devel
Around July 10, 2022, I authored several commits to improve the success rate of the CI pipelines. At the time, I was too daft to realize that some changes I made broke two of the on-push Debian stable builders. In the time since the on-push macOS builders have broken. There are seven merge

Re: ✘64-bit time_t on glibc 2.34 and up

2023-01-13 Thread James Browning via devel
> On 01/13/2023 1:06 PM PST Hal Murray wrote: > > > If we make any changes to SHM, we should switch to a setup where the memory is > read only. The idea is to allow multiple readers. > > The trick to implementing that is to have 2 counters. > X and Y are initialized to the same value. > The

I am bidding for power and have yet more branches for consideration.

2023-01-19 Thread James Browning via devel
If I were a maintainer of the NTPsec group, I could merge the following branches on my own. If only a developer, I could still approve other people's merge requests. https://gitlab.com/NTPsec/ntpsec/-/merge_requests/1304 !1304 - Enable debugging symbols by default, with an option to !disable

Re: New SHM layout from gpsd

2023-01-20 Thread James Browning via devel
> On 01/20/2023 2:11 AM PST Hal Murray wrote: > > > The 31 bit idea seems strange/ugly to me. How did you decide to do it that > way? It is either Richard's fault or, more likely, mine. I proposed replacing the current SHM, and I need to communicate better. My alternate had a shared half-era

Re: I've broken something

2023-03-23 Thread James Browning via devel
> On 03/23/2023 12:46 AM PDT Hal Murray via devel wrote: > > > The pipeline fails on: > Name: ubuntu-latest-basic > Name: ubuntu-latest-refclocks > Name: macos-basic > Name: macos-refclocks > > All 4 get the same clump of errors: > :::snip::: > > This code area isn't wonderful. It leaves a

Re: I've broken something

2023-03-23 Thread James Browning via devel
> On 03/23/2023 4:55 PM PDT Hal Murray wrote: > > James Browning said: > >> Where/how do I get ubuntu-latest? > > I would suggest `docker push registry.gitlab.com/na280/ntpsec`, but it seems > > that it rarely is acceptable, or go to the Ubuntu website and download > > Jammy. > > Are you sure

Be very quiet, the project is dozing off.

2023-03-22 Thread James Browning via devel
This is the second post this month, and it's three weeks after my dropped patches on the first.___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

Here are a couple of patches related to seccomp,

2023-03-02 Thread James Browning via devel
I wrote and tested these on a bleeding-edge Ubuntu box. I have yet to try this on other Linux flavors. First is a patch to make the secomp trap handler on Linux more helpfully verbose. Then a patch that can incrementally tighten the syscall filter to calls listed in a text file. The patch in the

Here is a patch to make the secomp trap handler on Linux more helpfully verbose.

2023-02-28 Thread James Browning via devel
I wrote and tested this on a bleeding-edge Ubuntu box. I have yet to try this on other Linux flavors. I also have a patch that can incrementally tighten the syscall filter to calls listed in a text file. I will work on that one a bit more first, however. The code for both is also at

Re: MR 1307 and/or 1309

2023-04-01 Thread James Browning via devel
On Mar 31, 2023, 17:27, Hal Murray via devel wrote: Has anybody tried them?Probably only me; I am a perennial screw-up and everything I touch cracks.1307 is my implementation of the socket refclock and 1309 contains an alternative to ntpshmmon from gods and another similar script working on

Updated to-do list?

2023-04-07 Thread James Browning via devel
Given that the things I have been turning in are not in the direction we are headed, what should I be working on? Other than trying to do a Golang port by myself, or revisiting the more than a-year-old list?___ devel mailing list devel@ntpsec.org

Re: Updated to-do list?

2023-04-09 Thread James Browning via devel
> On 04/08/2023 2:45 PM PDT Hal Murray wrote: > > Given that the things I have been turning in are not in the direction > > we are headed, what should I be working on? Other than trying to do a > > Golang port by myself, or revisiting the more than a-year-old list? > MR 1307 and/or 1309 is high

issue blocking input_handler

2023-02-03 Thread James Browning via devel
I found a problem with input_handler(). If a reference clock passes a blocking file descriptor, input_handler can block forever. Symptoms include but are not limited to UDP sockets not working, several signal types being ignored, and the main loop stopping in its' tracks. I've included a patch to

Re: issue blocking input_handler

2023-02-03 Thread James Browning via devel
> On 02/03/2023 2:51 PM PST Hal Murray wrote: > > James Browning said: > > I found a problem with input_handler(). If a reference clock passes a > > blocking file descriptor, input_handler can block forever. > > Who did that? Which driver? I ran across it working on a chrony socket refclock.

Re: First step on ntp_control cleanup

2023-02-02 Thread James Browning via devel
On 02/02/2023 1:13 AM PST Hal Murray wrote: > > > ntp_control is the code in ntpd that processes mode6 requests from ntpq. > > There are 3 types of variables you can read: > global variables (rv 0) > peer (server) variables > refclock variables > > I've fixed up the first type. It is now easy

Re: issue blocking input_handler

2023-02-04 Thread James Browning via devel
> On 02/03/2023 11:35 PM PST Hal Murray wrote: > > James Browning said: > >> How about fixing the bug at ithe source rather than patching around it? > > I tried and failed then I came up with that. > > Did you get O_NONBLOCK turned on? > Something like this: > err = fcntl(sockfd,

Re: New Defects reported by Coverity Scan for ntpsec

2023-02-07 Thread James Browning via devel
On Feb 7, 2023 18:23, Hal Murray via devel wrote: Thanks. matthew.sel...@twosigma.com said: > No. We run the Coverity CI job weekly via a schedule, ... > I'll work on running Coverity post-merge. I agree that running it every merge is overkill. A button that says run-now would be nice

Re: master broken on macos

2023-04-13 Thread James Browning via devel
> On 04/13/2023 11:57 AM PDT Hal Murray via devel wrote: > > > I merged James' latest version for printing out the OpenSSL version during > configure. > > It barfs on macos. > https://gitlab.com/NTPsec/ntpsec/-/jobs/4105995926#L126 > > > The log file says: > > Checking for OpenSSL != 1.1.1a

Re: [Git][NTPsec/ntpsec][master] 3 commits: Minor cleanups to restrict

2023-07-06 Thread James Browning via devel
On Jul 5, 2023 22:36, Matthew Selsky via devel wrote:Has this fix been submitted upstream to https://github.com/ThrowTheSwitch/UnityIt has now. https://github.com/ThrowTheSwitch/Unity/pull/680 ___ devel mailing list devel@ntpsec.org

Re: NTPsec 1.2.2a released

2023-08-04 Thread James Browning via devel
> On 08/04/2023 6:35 PM PDT Fred Wright via devel wrote: > :::snip::: > > I notice that the two commits for that don't seem to be in any branch. > Having commits only "owned" by a tag and not a branch seems fragile. I do not think it is particularly fragile; I mean the garbage collector is

Re: Warnings from unity

2023-06-21 Thread James Browning via devel
On Jun 21, 2023, 12:54, Hal Murray via devel wrote:> That usually means there is no "default:" case in a switch. OK, but where did the unity code come from and/or have we cloned it or are we tracking what they do?  Or ...I think it occasionally gets updated from GitHub [1].[1]

CI oops in the option testers

2023-06-22 Thread James Browning via devel
The Alpine Linux and Gentoo weekly option testers are not correctly failing on missing Python 2. Also, the CentOS and Fedora runners seem to be missing pkg-config packages. I have a possible partial workaround as !1327___ devel mailing list

Re: Missing clockwork

2023-12-18 Thread James Browning via devel
> On 12/17/2023 11:49 PM PST Hal Murray via devel wrote: > > > Anybody recognize this? I've seen a missing file once before. I think it > was > clockwork.?? > > It works if I try it again. It sounds like a race condition in our wscript files or waf. How willing are you to sink time into

Re: Release

2023-12-18 Thread James Browning via devel
> On 12/17/2023 9:49 PM PST Hal Murray via devel wrote: > > Fred Wright said: :::snip::: > > There are also a bunch of warnings with some compilers, which might be > > worth > > looking at. They're often fairly easy to fix, and sometimes indicate actual > > problems. > > Which

RE: Addressing the Python 2, AsciiDoc classic, and AsciiDoc 3 tangle

2024-01-11 Thread James Browning via devel
> On 01/10/2024 7:49 PM PST Matt Selsky via devel wrote: > > Does anyone have links handy to statements from the various projects > on their long-term support status? Not as such. Hitting hub.docker.com I find no Python:2.6* images, Python:2.7* last pushed 21 April 2020, and Centos last pushed

Addressing the Python 2, AsciiDoc classic, and AsciiDoc 3 tangle

2024-01-07 Thread James Browning via devel
I suggest that Asciidoc3 should be dropped as it is not well-supported anywhere else and incurs additional maintenance costs. To address the support of AsciiDoc classic, we can use a Debian Bullseye image until around July/August 2024, as it has AsciiDoc classic. The current Debian Bookworm,

Re: What does gitlab's "Successful pipeline" mean?

2023-12-06 Thread James Browning via devel
On Dec 5, 2023 23:45, Hal Murray via devel wrote: Does that mean no warnings? No errors slipped past any nets in their way.If not, how are we expected to learn about code that generates warnings on obscure systems?Maybe we should add -Werror or such to CFLAGS. The most obscure system tested

Re: Release

2023-12-02 Thread James Browning via devel
> On 12/02/2023 8:09 PM PST Hal Murray via devel wrote: > > > I think you should release what we have as soon as it is convenient. > > There are many more things I would like to include but we aren't making much > progress so it's time to do it. Referring to the first four items on the

Re: How does the parser work?

2023-12-04 Thread James Browning via devel
On Dec 4, 2023 13:49, James Browning wrote:The host phase of Waf build generates tablegen which in turn generates keywords.h IIRC. I have no idea how the internals work. I seem to recall that tablegen.c was badly scored by Codacy.Oops, keyword-gen and a rated; I need to get my memory

Re: How does the parser work?

2023-12-04 Thread James Browning via devel
On Dec 3, 2023 23:45, Hal Murray via devel wrote: ntp_parser.y contqains: %token     T_Tinker %token     T_Tlsciphers %token     T_Tlsciphersuites I'd expect those tokens to come from the keywords header file. But tlsciphers isn't in the keyword list. tlscipehrswuites is in

Re: Asciidoc question

2023-12-03 Thread James Browning via devel
On Dec 3, 2023 18:49, Hal Murray via devel wrote:What does the $$ after the +aga+ do? |+year+    |One generation file element is generated per year.     The filename  suffix consists of a dot and a 4 digit year number. |+age+$$   |This type of file generation sets changes

Re: I/we need a lesson in git and/or gitlab and/or merge requests

2023-11-11 Thread James Browning via devel
Hal Murray wrote: > > Merge requests seem reasonable if all goes well. My work flow is roughly: > download the patch (URL plus ".patch") > scan it > maybe apply and test > approve and merge Ah, my work turbulence is incompatible with your workflow. > But things go downhill if I don't

Re: What next?

2024-03-18 Thread James Browning via devel
On 03/17/2024 at 2:00 PM PDT, Hal Murray via devel wrote: > > Is anybody thinking about what we should be doing? > > > Here is my list: > > Port to Windows > Does anybody know anything about Windows? > Is there a decent POSIX environment? > How well does waf work on Windows? > We can get the

Re: Hack for monitoring NTP servers

2024-04-15 Thread James Browning via devel
> On 04/11/2024 12:39 PM PDT Hal Murray via devel wrote: > > > If somebody feels like hacking, something like this should be fun. > > The idea is to setup a ntpd server watching the servers you want to monitor. > (noselect on the server line does that) > > The new code is a program that

Re: CI is broken

2024-04-15 Thread James Browning via devel
> On 04/15/2024 9:15 AM PDT Matt Selsky via devel wrote: > > On Sun, Apr 14, 2024 at 01:30:47AM -0700, Hal Murray via devel wrote: > > I just pushed some code. The CI stuff sent me a Failed pipeline message. > > > > > > [0K[31;1mERROR: Job failed: failed to pull image > >

Re: Removing md5 usage from ntpsec

2024-04-17 Thread James Browning via devel
> On 04/16/2024 2:34 AM PDT Shreenidhi Shedi via devel wrote: > > Hi All, > > Currently ntpsec systemd service doesn't start if openssl fips is enabled. > The same issue was there in ntp as well. > > Looks like ntp is ready with the fix. More info at: >

Patch to make bin_test work without pylib

2024-04-25 Thread James Browning via devel
The clients needing it are still beinginstalled. I have another patch for that later.-30- 0003-Make-waf-bin_test-work-with-enable-pylib-none.patch Description: Binary data ___ devel mailing list devel@ntpsec.org

<    1   2   3