Hi all,
[very brief intro: I'm with the Zap project; finally have time to join the
discussions after a short period of passively watching the list]
There is a good chance I'll be passing nearby, and that would be an excellent
opportunity for me to personally meet those who plan to attend, as
-s_group_desc have to be zero filled because if sb_read() failed
we jump to following error path.
failed_mount2:
for (i = 0; i db_count; i++)
brelse(sbi-s_group_desc[i]); Bad things may happen here
Signed-off-by: Dmitry Monakhov [EMAIL PROTECTED]
---
fs/ext3/super.c
Dmitry Monakhov wrote:
-s_group_desc have to be zero filled because if sb_read() failed
we jump to following error path.
failed_mount2:
for (i = 0; i db_count; i++)
brelse(sbi-s_group_desc[i]); Bad things may happen here
But the db_count is updated in the failure
YAMAMOTO Takashi wrote:
+ lock_meta_page(page);
+ /*
+ * Check if somebody else beat us to allocating the meta_page
+ */
+ race_mp = page_get_meta_page(page);
+ if (race_mp) {
+ kfree(mp);
+ mp = race_mp;
+ atomic_inc(mp-ref_cnt);
+
YAMAMOTO Takashi wrote:
YAMAMOTO Takashi wrote:
+ lock_meta_page(page);
+ /*
+ * Check if somebody else beat us to allocating the meta_page
+ */
+ race_mp = page_get_meta_page(page);
+ if (race_mp) {
+ kfree(mp);
+ mp = race_mp;
+