[Devel] Re: [patch -mm 0/4] mqueue namespace

2007-11-29 Thread Cedric Le Goater
Pavel Emelyanov wrote: Cedric Le Goater wrote: Hello ! Here's a small patchset introducing a new namespace for POSIX message queues. Nothing really complex a part from the mqueue filesystem which needed some special care Hm... Why did you decided to make it separately from the IPC

[Devel] Re: [PATCH 2/2] Eliminate unused argument from sk_stream_alloc_pskb

2007-11-29 Thread Herbert Xu
On Mon, Nov 26, 2007 at 08:17:27PM +0300, Pavel Emelyanov wrote: The 3rd argument is always zero (according to grep :) Eliminate it and merge the function with sk_stream_alloc_skb. This saves 44 more bytes, and together with the previous patch we have: add/remove: 1/0 grow/shrink: 0/8

[Devel] Re: [patch -mm 2/4] mqueue namespace : add unshare support

2007-11-29 Thread Cedric Le Goater
Index: 2.6.24-rc3-mm2/kernel/fork.c === --- 2.6.24-rc3-mm2.orig/kernel/fork.c +++ 2.6.24-rc3-mm2/kernel/fork.c @@ -1004,6 +1004,13 @@ static struct task_struct *copy_process( if ((clone_flags CLONE_SIGHAND) !(clone_flags

[Devel] Re: [patch -mm 2/4] mqueue namespace : add unshare support

2007-11-29 Thread Cedric Le Goater
Index: 2.6.24-rc3-mm2/include/linux/sched.h === --- 2.6.24-rc3-mm2.orig/include/linux/sched.h +++ 2.6.24-rc3-mm2/include/linux/sched.h @@ -27,6 +27,7 @@ #define CLONE_NEWUSER 0x1000 /* New user namespace

[Devel] Re: [patch -mm 2/4] mqueue namespace : add unshare support

2007-11-29 Thread Andrew Morton
On Thu, 29 Nov 2007 11:28:28 +0100 Cedric Le Goater [EMAIL PROTECTED] wrote: Index: 2.6.24-rc3-mm2/include/linux/sched.h === --- 2.6.24-rc3-mm2.orig/include/linux/sched.h +++ 2.6.24-rc3-mm2/include/linux/sched.h @@ -27,6

[Devel] kernel/cpt/cpt_dump.c breakage in 2.6.22?

2007-11-29 Thread Josip Rodin
Hi, Is there a known problem with checkpointing in OpenVZ kernel 2.6.22? I'm getting the following errors: CC [M] kernel/cpt/cpt_dump.o kernel/cpt/cpt_dump.c: In function 'check_process_external': kernel/cpt/cpt_dump.c:129: error: 'struct pid' has no member named 'ns'

Re: [Devel] kernel/cpt/cpt_dump.c breakage in 2.6.22?

2007-11-29 Thread Alexey Dobriyan
On Wed, Nov 28, 2007 at 11:37:48PM +0100, Josip Rodin wrote: Is there a known problem with checkpointing in OpenVZ kernel 2.6.22? Yes. Hopefully CPT will be back in 2.6.24 branch. I'm getting the following errors: CC [M] kernel/cpt/cpt_dump.o kernel/cpt/cpt_dump.c: In function

[Devel] Re: [RFC][ only for review ] memory controller bacground reclaim [0/5] (Does anyone have an idea about throttling ?)

2007-11-29 Thread KAMEZAWA Hiroyuki
On Wed, 28 Nov 2007 17:49:23 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: Hi, this set is for memory controller background reclaim. Merged YAMAMOTO-san's version onto 2.6.23-rc3-mm1 + my NUMA patch. And splitted to several sets. Major changes from his one is - use kthread instead of

[Devel] Re: [PATCH][BRIDGE] Lost call to br_fdb_fini() in br_init() error path

2007-11-29 Thread Herbert Xu
On Tue, Nov 27, 2007 at 05:39:42PM +0300, Pavel Emelyanov wrote: In case the br_netfilter_init() (or any subsequent call) fails, the br_fdb_fini() must be called to free the allocated in br_fdb_init() br_fdb_cache kmem cache. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Patch applied

[Devel] Re: [PATCH] Fix inet_diag.ko register vs rcv race

2007-11-29 Thread Herbert Xu
On Tue, Nov 27, 2007 at 04:09:43PM +0300, Pavel Emelyanov wrote: The following race is possible when one cpu unregisters the handler while other one is trying to receive a message and call this one: Good catch! But I think we need a bit more to close this fully. Dumps can resume asynchronously

[Devel] Re: [PATCH] Fix inet_diag.ko register vs rcv race

2007-11-29 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 29, 2007 at 11:37:34PM +1100, Herbert Xu escreveu: On Tue, Nov 27, 2007 at 04:09:43PM +0300, Pavel Emelyanov wrote: The following race is possible when one cpu unregisters the handler while other one is trying to receive a message and call this one: Good catch! But I think we

[Devel] [PATCH (resubmit)] Fix inet_diag.ko register vs rcv race

2007-11-29 Thread Pavel Emelyanov
The following race is possible when one cpu unregisters the handler while other one is trying to receive a message and call this one: CPU1: CPU2: inet_diag_rcv() inet_diag_unregister()

[Devel] Re: [PATCH (resubmit)] Fix inet_diag.ko register vs rcv race

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 04:01:25PM +0300, Pavel Emelyanov wrote: Besides, as Herbert pointed out, asynchronous dumps should hold this mutex as well, and thus, we provide the mutex as cb_mutex one. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Thanks for the quick response! Patch

[Devel] Re: [patch -mm 2/4] mqueue namespace : add unshare support

2007-11-29 Thread Eric W. Biederman
Cedric Le Goater [EMAIL PROTECTED] writes: From: Cedric Le Goater [EMAIL PROTECTED] This patch includes the mqueue namespace in the nsproxy object. It also adds the support of unshare() and clone() with a new clone flag CLONE_NEWMQ (1 bit left in the clone flags !) CLONE_NEWMQ is

[Devel] Re: [PATCH 2/2] hijack: update task_alloc_security

2007-11-29 Thread Serge E. Hallyn
Quoting Crispin Cowan ([EMAIL PROTECTED]): Serge E. Hallyn wrote: Quoting Crispin Cowan ([EMAIL PROTECTED]): Is there to be an LSM hook, so that modules can decide on an arbitrary decision of whether to allow a hijack? So that this do the right SELinux thing can be generalized for

[Devel] [PATCH][DECNET] dn_nl_deladdr() almost always returns no error

2007-11-29 Thread Pavel Emelyanov
As far as I see from the err variable initialization the dn_nl_deladdr() routine was designed to report errors like EADDRNOTAVAIL and probaby ENODEV. But the code sets this err to 0 after the first nlmsg_parse and goes on, returning this 0 in any case. Is this made deliberately, or the patch

[Devel] Re: [PATCH][DECNET] dn_nl_deladdr() almost always returns no error

2007-11-29 Thread Steven Whitehouse
Hi, On Thu, Nov 29, 2007 at 07:29:20PM +0300, Pavel Emelyanov wrote: As far as I see from the err variable initialization the dn_nl_deladdr() routine was designed to report errors like EADDRNOTAVAIL and probaby ENODEV. But the code sets this err to 0 after the first nlmsg_parse and goes

[Devel] [PATCH 0/4] Sysctl namespace support

2007-11-29 Thread Eric W. Biederman
Currently the network namespace work has gotten about as far as we can without the ability to make sysctls that are per network namespace. The techniques we have been using for other namespace of examining current and replacing the ctl_table.data field depending on the namespace instance that

[Devel] [PATCH 1/4] sysctl: Add register_sysctl_paths function

2007-11-29 Thread Eric W. Biederman
There are a number of modules that register a sysctl table somewhere deeply nested in the sysctl hierarchy, such as fs/nfs, fs/xfs, dev/cdrom, etc. They all specify several dummy ctl_tables for the path name. This patch implements register_sysctl_path that takes an additional path name, and

[Devel] [PATCH 2/4] sysctl: Remember the ctl_table we passed to register_sysctl_paths

2007-11-29 Thread Eric W. Biederman
By doing this we allow users of register_sysctl_paths that build and dynamically allocate their ctl_table to be simpler. This allows them to just remember the ctl_table_header returned from register_sysctl_paths from which they can now find the ctl_table array they need to free. Signed-off-by:

[Devel] [PATCH 3/4] sysctl: Infrastructure for per namespace sysctls

2007-11-29 Thread Eric W. Biederman
This patch implements the basic infrastructure for per namespace sysctls. A list of lists of sysctl headers is added, allowing each namespace to have it's own list of sysctl headers. Each list of sysctl headers has a lookup function to find the first sysctl header in the list, allowing the

[Devel] Re: [PATCH (resubmit)][BRIDGE] Properly dereference the br_should_route_hook

2007-11-29 Thread Paul E. McKenney
On Fri, Nov 30, 2007 at 12:04:20AM +1100, Herbert Xu wrote: On Tue, Nov 27, 2007 at 07:21:08PM +0300, Pavel Emelyanov wrote: This hook is protected with the RCU, so simple if (br_should_route_hook) br_should_route_hook(...) is not enough on some architectures.

[Devel] Re: [PATCH] sched: cpu accounting controller

2007-11-29 Thread Ingo Molnar
* Srivatsa Vaddagiri [EMAIL PROTECTED] wrote: Paul, Sorry about the delay in getting back to this thread. I realized very recently that cpuacct controller has been removed from Linus's tree and have attempted to rework it as per our discussions. Linus/Ingo, Commit

[Devel] Re: [PATCH] sched: cpu accounting controller

2007-11-29 Thread Srivatsa Vaddagiri
On Thu, Nov 29, 2007 at 08:20:58PM +0100, Ingo Molnar wrote: ok, this looks certainly doable for v2.6.24. I've added it to the scheduler fixes queue and will let it brew there for a few days and send it to Linus after that if everything goes fine - unless anyone objects. Thanks. --

[Devel] [PATCH] sched: cpu accounting controller

2007-11-29 Thread Srivatsa Vaddagiri
On Mon, Nov 12, 2007 at 11:57:03PM -0800, Paul Menage wrote: Regarding your concern about tracking cpu usage in different ways, it could be mitigated if we have cpuacct controller track usage as per information present in a task's sched entity structure (tsk-se.sum_exec_runtime) i.e call

[Devel] Re: [PATCH] sched: cpu accounting controller

2007-11-29 Thread Srivatsa Vaddagiri
On Thu, Nov 29, 2007 at 11:30:35AM -0800, Andrew Morton wrote: - Make the accounting scalable on SMP systems (perhaps for 2.6.25) That sounds like a rather important todo. How bad is it now? It is indeed an important todo. Right now we take a per-group global lock on every

[Devel] Re: [patch -mm 2/4] mqueue namespace : add unshare support

2007-11-29 Thread Eric W. Biederman
Oren Laadan [EMAIL PROTECTED] writes: Two comments: 1) Does it ever make any sense to clone the IPC namespace *without* doing so also for the MQ namespace or vice versa ? Unless there is a good reason for doing so, a single CLONE_IPCMQ flag would suffice. SYSVIPC and POSIX IPC are

[Devel] Re: [PATCH (resubmit)][BRIDGE] Properly dereference the br_should_route_hook

2007-11-29 Thread Herbert Xu
On Thu, Nov 29, 2007 at 06:36:50AM -0800, Paul E. McKenney wrote: That certainly is an interesting tradeoff... Save a memory barrier when assigning NULL, but pay an extra test and branch in all cases. Though it does make for a simpler rule -- just use rcu_assign_pointer() in all cases. Of

[Devel] Re: [RFC][ only for review ] memory controller bacground reclaim [4/5] high/low watermark for memory controller

2007-11-29 Thread KAMEZAWA Hiroyuki
On Thu, 29 Nov 2007 14:55:56 -0500 Oren Laadan [EMAIL PROTECTED] wrote: It looks like i386 doesn't have any support for ULL divisions. It doesn't have it in CPU, and I thought that it was some-how emulated, but it is not... Did I miss something? Ah, I didn't try i386... But I'll

[Devel] Re: [RFC][ only for review ] memory controller bacground reclaim [0/5] (Does anyone have an idea about throttling ?)

2007-11-29 Thread KAMEZAWA Hiroyuki
On Thu, 29 Nov 2007 20:12:51 +0530 Balbir Singh [EMAIL PROTECTED] wrote: == These numbers are stable to some extent.== 2.6.24-rc3-mm2: (Limit: 800M) Average Optimal -j 32 Load Run: Elapsed Time 358.933---(*) User Time 1069.63 System Time 140.667 Percent

[Devel] Re: [PATCH (resubmit)][BRIDGE] Properly dereference the br_should_route_hook

2007-11-29 Thread Paul E. McKenney
On Fri, Nov 30, 2007 at 10:49:00AM +1100, Herbert Xu wrote: On Thu, Nov 29, 2007 at 06:36:50AM -0800, Paul E. McKenney wrote: That certainly is an interesting tradeoff... Save a memory barrier when assigning NULL, but pay an extra test and branch in all cases. Though it does make for a

[Devel] Re: [PATCH 1/2] namespaces: introduce sys_hijack (v10)

2007-11-29 Thread Eric W. Biederman
Mark Nelson [EMAIL PROTECTED] writes: Hi Paul and Eric, Do you guys have any objections to dropping the hijack_pid() and hijack_cgroup() parts of sys_hijack, leaving just hijack_ns() (see below for discussion)? I need to step back and study what is being proposed. My gut feeling is that

[Devel] Re: [PATCH 1/2] namespaces: introduce sys_hijack (v10)

2007-11-29 Thread Paul Menage
On Nov 29, 2007 6:08 PM, Mark Nelson [EMAIL PROTECTED] wrote: Hi Paul and Eric, Do you guys have any objections to dropping the hijack_pid() and hijack_cgroup() parts of sys_hijack, leaving just hijack_ns() (see below for discussion)? hijack_ns() is the main bit that I care about anyway, so

[Devel] Re: [PATCH 1/2] namespaces: introduce sys_hijack (v10)

2007-11-29 Thread Mark Nelson
Hi Paul and Eric, Do you guys have any objections to dropping the hijack_pid() and hijack_cgroup() parts of sys_hijack, leaving just hijack_ns() (see below for discussion)? Thanks! Mark. Serge E. Hallyn wrote: Quoting Stephen Smalley ([EMAIL PROTECTED]): On Tue, 2007-11-27 at 16:38 -0600,

[Devel] forcedeth hangs on loading

2007-11-29 Thread Vasily Averin
Hi Ayaz, While testing new OpenVZ kernel based on RHEL5.1 kernel 2.6.18-53.el5 we have observed that node loads forcedeth driver too long: Nov 28 14:04:19 ts49 kjournald starting. Commit interval 5 seconds Nov 28 14:04:19 ts49 EXT3-fs: mounted filesystem with ordered data mode. ... Nov 28