On Feb 16, 2008 7:29 PM, Paul Jackson [EMAIL PROTECTED] wrote:
From: Paul Jackson [EMAIL PROTECTED]
Strip all trailing whitespace (such as carriage returns)
when parsing integer writes to cgroup files, not just
one trailing newline if present.
Sounds like a good idea to me. Thanks for this.
Strip all trailing whitespace (such as carriage returns)
when parsing integer writes to cgroup files, not just
one trailing newline if present.
Sounds like a good idea to me. Thanks for this.
I'm figuring it would be easiest if you just threw this
little change into your hopper for the
On Feb 17, 2008 9:28 AM, Paul Jackson [EMAIL PROTECTED] wrote:
I'm figuring it would be easiest if you just threw this
little change into your hopper for the bigger changes
you're making
OK, will do.
Paul
___
Containers mailing list
[EMAIL
+ /* try to charge */
+ ret = res_counter_charge(mem-res, mem-borrow_unit);
+ if (!ret) { /* success */
+ *bwp += (mem-borrow_unit - size);
+ goto out;
+ }
+ }
+ spin_lock(mem-res.lock);
+
On Mon, 18 Feb 2008 09:53:35 +0900 (JST)
[EMAIL PROTECTED] (YAMAMOTO Takashi) wrote:
+ /* try to charge */
+ ret = res_counter_charge(mem-res, mem-borrow_unit);
+ if (!ret) { /* success */
+ *bwp += (mem-borrow_unit - size);
+
On Mon, 18 Feb 2008 10:58:40 +0900 (JST)
[EMAIL PROTECTED] (YAMAMOTO Takashi) wrote:
+ /*
+* For lazy freeing (not GC)
+*/
+ struct {
+ struct mem_cgroup_per_zone *mz;
+ int num;
+#define GARBAGE_MAXSIZE(16)
+
+ /*
+ * For lazy freeing (not GC)
+ */
+ struct {
+ struct mem_cgroup_per_zone *mz;
+ int num;
+#define GARBAGE_MAXSIZE (16)
+ struct page_cgroup *vec[GARBAGE_MAXSIZE];
+ } garbage[NR_CPUS];
KAMEZAWA Hiroyuki wrote:
A big lock contetion of memory controller is mz-lru_lock.
This is acquired when
1. add to lru
2. remove from lru
3. scan lru list
It seems 1. and 3. are unavoidable. but 2. can be delayed.
This patch make removing page_cgorup from lru-list be lazy and
On Mon, 18 Feb 2008 10:05:16 +0530
Balbir Singh [EMAIL PROTECTED] wrote:
Hi, KAMEZAWA-San,
For this and the next patch, do you know if there is a performance
improvement?
Have we measured it. The complexity of the code seems to be high, want to make
sure it is worth it.
I'd like to make
Li Zefan wrote:
- remove trailing Bytess in the demonstration
- remove section 4.4 (feature control_type has been removed)
- fix reference section
Signed-off-by: Li Zefan [EMAIL PROTECTED]
Acked-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED]
Acked-by: Balbir Singh [EMAIL PROTECTED]
--
Li Zefan wrote:
No need for VM_BUG_ON(pc), since 'pc' is the list entry. This should
be VM_BUG_ON(page).
Signed-off-by: Li Zefan [EMAIL PROTECTED]
Acked-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED]
pc is of type page_cgroup and we use list_for_each_entry_safe_reverse. Not sure
why we can't bug
Li Zefan wrote:
Cgroup requires the subsystem to return negative error code on
error in the create method.
Signed-off-by: Li Zefan [EMAIL PROTECTED]
Acked-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED]
Acked-by: Balbir Singh [EMAIL PROTECTED]
--
Warm Regards,
Balbir Singh
YAMAMOTO Takashi wrote:
Li Zefan wrote:
No need for VM_BUG_ON(pc), since 'pc' is the list entry. This should
be VM_BUG_ON(page).
Signed-off-by: Li Zefan [EMAIL PROTECTED]
Acked-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED]
pc is of type page_cgroup and we use list_for_each_entry_safe_reverse. Not
No need for VM_BUG_ON(pc), since 'pc' is the list entry. This should
be VM_BUG_ON(page).
Signed-off-by: Li Zefan [EMAIL PROTECTED]
Acked-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED]
---
mm/memcontrol.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/memcontrol.c
Li Zefan wrote:
*** notify_on_release is disabled in the current patch set. It will be
-*** reactivated in a future patch in a less-intrusive manner
+*** reactivated in a future patch in a less-intrusive manner.
Someone should verify this, but I'm pretty sure that notify_on_release
is now
Li Zefan wrote:
Balbir Singh wrote:
YAMAMOTO Takashi wrote:
Li Zefan wrote:
No need for VM_BUG_ON(pc), since 'pc' is the list entry. This should
be VM_BUG_ON(page).
Signed-off-by: Li Zefan [EMAIL PROTECTED]
Acked-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED]
pc is of type page_cgroup and we use
16 matches
Mail list logo
