[Devel] Re: [RFD][PATCH] memcg: Move Usage at Task Move

2008-06-10 Thread Daisuke Nishimura
Hi, Kamezawa-san. Sorry for late reply. On Fri, 6 Jun 2008 10:52:35 +0900, KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: Move Usage at Task Move (just an experimantal for discussion) I tested this but don't think bug-free. In current memcg, when task moves to a new cg, the usage remains in the

[Devel] Re: [RFC PATCH 0/5] memcg: VM overcommit accounting and handling

2008-06-10 Thread Pavel Emelyanov
Balbir Singh wrote: KAMEZAWA Hiroyuki wrote: On Tue, 10 Jun 2008 01:32:58 +0200 Andrea Righi [EMAIL PROTECTED] wrote: Provide distinct cgroup VM overcommit accounting and handling using the memory resource controller. Could you explain the benefits of this even when we have memrlimit

[Devel] Re: [RFD][PATCH] memcg: Move Usage at Task Move

2008-06-10 Thread KAMEZAWA Hiroyuki
On Tue, 10 Jun 2008 16:35:50 +0900 Daisuke Nishimura [EMAIL PROTECTED] wrote: Hi, Kamezawa-san. Sorry for late reply. On Fri, 6 Jun 2008 10:52:35 +0900, KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: Move Usage at Task Move (just an experimantal for discussion) I tested this but don't

[Devel] Re: [RFC PATCH 0/5] memcg: VM overcommit accounting and handling

2008-06-10 Thread Andrea Righi
Pavel Emelyanov wrote: Balbir Singh wrote: KAMEZAWA Hiroyuki wrote: On Tue, 10 Jun 2008 01:32:58 +0200 Andrea Righi [EMAIL PROTECTED] wrote: Provide distinct cgroup VM overcommit accounting and handling using the memory resource controller. Could you explain the benefits of this even

[Devel] [PATCH] cryo: fix segfault in save_msgq_data() during checkpoint

2008-06-10 Thread Benjamin Thery
Fix missing initialization in save_msgq_data() that triggers a segfault in realloc() when cr is compiled with -g. Signed-off-by: Benjamin Thery [EMAIL PROTECTED] --- container_ckpt.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: cryodev/container_ckpt.c

[Devel] Re: [RFD][PATCH] memcg: Move Usage at Task Move

2008-06-10 Thread YAMAMOTO Takashi
On Tue, 10 Jun 2008 14:50:32 +0900 (JST) [EMAIL PROTECTED] (YAMAMOTO Takashi) wrote: 3. Use Lazy Manner When the task moves, we can mark the pages used by it as Wrong Charge, Should be dropped, and add them some penalty in the LRU. Pros. - no

[Devel] unlock iptables in netns

2008-06-10 Thread Alexey Dobriyan
Hi, Den basically banned iptables in netns via this patch --- a/net/netfilter/core.c +++ b/net/netfilter/core.c @@ -165,14 +165,6 @@ int nf_hook_slow(int pf, unsigned int hook, struct sk_buff *skb, unsigned int verdict; int ret = 0; -#ifdef CONFIG_NET_NS - struct net

[Devel] Re: [RFC PATCH 5/5] refresh VM committed space after a task migration

2008-06-10 Thread Dave Hansen
On Tue, 2008-06-10 at 01:33 +0200, Andrea Righi wrote: + preempt_disable(); + committed = atomic_long_read(p-vm_committed_space); + atomic_long_sub(committed, old_mem-vmacct.vm_committed_space); + atomic_long_add(committed, mem-vmacct.vm_committed_space); +

[Devel] Re: [RFC PATCH 3/5] mgmcg VM overcommit interface

2008-06-10 Thread Dave Hansen
On Tue, 2008-06-10 at 01:33 +0200, Andrea Righi wrote: + cgroup_unlock(); + + count = sprintf(page, CommitLimit: %8lu kB\n + Committed_AS: %8lu kB\n, + K(allowed), K(committed)); + ret =

[Devel] Re: Userspace checkpoint/restart hack: cryo

2008-06-10 Thread Serge E. Hallyn
Quoting kathys ([EMAIL PROTECTED]): Serge E. Hallyn wrote: Quoting Nadia Derbey ([EMAIL PROTECTED]): Serge E. Hallyn wrote: Quoting Nadia Derbey ([EMAIL PROTECTED]): Cedric Le Goater wrote: Looks like it has worked for me (msg1 creates 1000 msg

[Devel] [PATCH RFC] cgroup_clone: use pid of newly created task for new cgroup

2008-06-10 Thread Serge E. Hallyn
From faa707a44b971f5f3bf24e6a0c760ccb4ad278e6 Mon Sep 17 00:00:00 2001 From: Serge Hallyn [EMAIL PROTECTED] Date: Tue, 10 Jun 2008 15:57:32 -0500 Subject: [PATCH 1/1] cgroup_clone: use pid of newly created task for new cgroup cgroup_clone creates a new cgroup with the pid of the task. This works

[Devel] Re: [PATCH 00/11] sysfs tagged directories V5

2008-06-10 Thread Serge E. Hallyn
Quoting Benjamin Thery ([EMAIL PROTECTED]): Greg, Here is an updated version of the sysfs tagged directories that improves a bit the situation over the previous one. I've modified the patch 09 (Enable tagging for net_class directories in sysfs) to be a bit less intrusive in sysfs core.

[Devel] Re: [PATCH 00/11] sysfs tagged directories V5

2008-06-10 Thread Greg KH
On Tue, Jun 10, 2008 at 05:50:24PM -0500, Serge E. Hallyn wrote: Quoting Benjamin Thery ([EMAIL PROTECTED]): Greg, Here is an updated version of the sysfs tagged directories that improves a bit the situation over the previous one. I've modified the patch 09 (Enable tagging for

[Devel] [GIT PATCH] actually check va randomization

2008-06-10 Thread Dave Hansen
Rather than just documenting this in the readme, actually spit out a warning on it. You can pull from: git://git.sr71.net/~dave/cryo-forhallyn.git/ -- Dave ___ Containers mailing list [EMAIL PROTECTED]

[Devel] Re: [RFD][PATCH] memcg: Move Usage at Task Move

2008-06-10 Thread KAMEZAWA Hiroyuki
On Tue, 10 Jun 2008 21:57:03 +0900 (JST) [EMAIL PROTECTED] (YAMAMOTO Takashi) wrote: 5. try to move charges as your patch does. if the target cgroup's usage is going to exceed the limit, try to shrink it. if it failed, just leave it exceeded. (ie. no rollback) for the

[Devel] Re: [RFD][PATCH] memcg: Move Usage at Task Move

2008-06-10 Thread Daisuke Nishimura
On Tue, 10 Jun 2008 17:26:37 +0900, KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: This is a trial to move usage from old cg to new cg at task move. Finally, you'll see the problems we have to handle are failure and rollback. This one's Basic algorithm is 0. can_attach()

[Devel] Re: [GIT PATCH] actually check va randomization

2008-06-10 Thread Serge E. Hallyn
Quoting Dave Hansen ([EMAIL PROTECTED]): Rather than just documenting this in the readme, actually spit out a warning on it. You can pull from: git://git.sr71.net/~dave/cryo-forhallyn.git/ -- Dave Thanks, merged. -serge ___ Containers mailing

[Devel] Re: [RFD][PATCH] memcg: Move Usage at Task Move

2008-06-10 Thread YAMAMOTO Takashi
I'm now considering following logic. How do you think ? Assume: move TASK from group:CURR to group:DEST. == move_task(TASK, CURR, DEST) if (DEST's limit is unlimited) moving TASK return success. usage = check_usage_of_task(TASK). /* try to reserve enough room in

[Devel] Re: [RFD][PATCH] memcg: Move Usage at Task Move

2008-06-10 Thread YAMAMOTO Takashi
having said that, if you decide to put too large tasks into a cgroup with too small limit, i don't think that there are many choices besides OOM-kill and allowing exceed. IMHO, allowing exceed is harmfull without changing the definition of limit. limit is hard-limit, now, not

[Devel] Re: [RFD][PATCH] memcg: Move Usage at Task Move

2008-06-10 Thread Daisuke Nishimura
On Wed, 11 Jun 2008 13:14:37 +0900, KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: On Wed, 11 Jun 2008 12:44:46 +0900 (JST) [EMAIL PROTECTED] (YAMAMOTO Takashi) wrote: I'm now considering following logic. How do you think ? Assume: move TASK from group:CURR to group:DEST. ==

[Devel] Re: [RFD][PATCH] memcg: Move Usage at Task Move

2008-06-10 Thread KAMEZAWA Hiroyuki
On Wed, 11 Jun 2008 12:44:46 +0900 (JST) [EMAIL PROTECTED] (YAMAMOTO Takashi) wrote: I'm now considering following logic. How do you think ? Assume: move TASK from group:CURR to group:DEST. == move_task(TASK, CURR, DEST) if (DEST's limit is unlimited) moving TASK