[Devel] Re: [PATCH 07/30] netns: extract net_create()

2009-04-13 Thread Alexey Dobriyan
On Fri, Apr 10, 2009 at 05:56:36PM -0500, Serge E. Hallyn wrote: Quoting Alexey Dobriyan (adobri...@gmail.com): net_create() will be used by C/R code to create fresh netns on restart. Signed-off-by: Alexey Dobriyan adobri...@gmail.com Acked-by: Serge Hallyn se...@us.ibm.com Although

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Alexey Dobriyan
On Fri, Apr 10, 2009 at 08:06:55AM -0700, Linus Torvalds wrote: On Fri, 10 Apr 2009, Alexey Dobriyan wrote: This is to show how we see C/R and to provoke discussion on number of important issues (mounts, ...). My only initial reaction is that I absolutely hate the naming (not to say I

[Devel] Re: [PATCH 10/30] cr: core stuff

2009-04-13 Thread Alexey Dobriyan
On Fri, Apr 10, 2009 at 12:19:23PM -0400, Brian Haley wrote: Alexey Dobriyan wrote: And of course, I don't want to see multiline vmflags = ~(VM_READ|VM_WRITE| [5 lines skipped] Then why don't you: #define VM_CR_FOO (VM_READ|VM_WRITE|...) vmflags =

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Alexey Dobriyan
On Thu, Apr 09, 2009 at 10:07:11PM -0700, Dave Hansen wrote: I'm curious how you see these fitting in with the work that we've been doing with Oren. Do you mean to just start a discussion or are you really proposing these as an alternative to what Oren has been posting? Yes, this is posted as

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Dave Hansen
On Mon, 2009-04-13 at 13:14 +0400, Alexey Dobriyan wrote: [1] Do I inderstand correctly that cookie for shared object is an address on kernel stack? This is obviously unreliable, if yes :-) int objref; ... /* adding 'file' to the hash will keep a reference to

[Devel] Re: [RFC] IO Controller

2009-04-13 Thread Vivek Goyal
On Fri, Apr 10, 2009 at 05:33:10PM +0800, Gui Jianfeng wrote: Vivek Goyal wrote: Hi All, Here is another posting for IO controller patches. Last time I had posted RFC patches for an IO controller which did bio control per cgroup. Hi Vivek, I got the following OOPS when testing,

[Devel] Re: [PATCH 01/10] Documentation

2009-04-13 Thread Vivek Goyal
On Mon, Apr 06, 2009 at 08:05:56PM +0530, Balbir Singh wrote: * Vivek Goyal vgo...@redhat.com [2009-03-11 21:56:46]: Thanks for having a look balbir. Sorry for the late reply.. [..] +Consider following hypothetical scenario. Lets say there are three physical +disks, namely sda, sdb and

[Devel] Re: [RFC v14-rc3][PATCH 36/36] Stub implementation of IPC namespace c/r

2009-04-13 Thread Serge E. Hallyn
Quoting Oren Laadan (or...@cs.columbia.edu): Serge E. Hallyn wrote: Quoting Oren Laadan (or...@cs.columbia.edu): From: Dan Smith da...@us.ibm.com Changes: - Update to match UTS changes Signed-off-by: Dan Smith da...@us.ibm.com Signed-off-by: Oren Laadan or...@cs.columbia.edu

[Devel] Re: BUG in tty_open when using containers and ptrace

2009-04-13 Thread Serge E. Hallyn
Quoting Môshe van der Sterre (m...@moshe.nl): Hello, I am working on the lxc userspace tools, and got this BUG a couple of times. Here are the reports: http://moshe.nl/tty-bugshot1.png http://moshe.nl/tty-bugshot2.png I am running 2.6.29.1 from kernel.org in a virtual machine under

[Devel] Re: [RFC v14-rc3][PATCH 36/36] Stub implementation of IPC namespace c/r

2009-04-13 Thread Dan Smith
SH But actually I think it's better if you move that into an SH appropriately named little static inline helper (commented). Then SH the reader can verify it once separately, and then ignore how it SH works while verifying the surrounding code. Not just here but, SH other places where you do

[Devel] Re: [RFC v2][PATCH 01/10] Infrastructure for work postponed to the end of checkpoint/restart

2009-04-13 Thread Serge E. Hallyn
Quoting Oren Laadan (or...@cs.columbia.edu): --- a/checkpoint/Makefile +++ b/checkpoint/Makefile @@ -2,8 +2,8 @@ # Makefile for linux checkpoint/restart. # -obj-$(CONFIG_CHECKPOINT) += sys.o objhash.o \ +obj-$(CONFIG_CHECKPOINT) += sys.o objhash.o deferqueue.o \

[Devel] Re: [RFC v2][PATCH 01/10] Infrastructure for work postponed to the end of checkpoint/restart

2009-04-13 Thread Oren Laadan
Serge E. Hallyn wrote: Quoting Oren Laadan (or...@cs.columbia.edu): --- a/checkpoint/Makefile +++ b/checkpoint/Makefile @@ -2,8 +2,8 @@ # Makefile for linux checkpoint/restart. # -obj-$(CONFIG_CHECKPOINT) += sys.o objhash.o \ +obj-$(CONFIG_CHECKPOINT) += sys.o objhash.o deferqueue.o \

[Devel] Re: [RFC v2][PATCH 01/10] Infrastructure for work postponed to the end of checkpoint/restart

2009-04-13 Thread Serge E. Hallyn
Quoting Oren Laadan (or...@cs.columbia.edu): Serge E. Hallyn wrote: Quoting Oren Laadan (or...@cs.columbia.edu): --- a/checkpoint/Makefile +++ b/checkpoint/Makefile @@ -2,8 +2,8 @@ # Makefile for linux checkpoint/restart. # -obj-$(CONFIG_CHECKPOINT) += sys.o objhash.o \

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Dave Hansen
On Mon, 2009-04-13 at 13:14 +0400, Alexey Dobriyan wrote: On Thu, Apr 09, 2009 at 10:07:11PM -0700, Dave Hansen wrote: I'm curious how you see these fitting in with the work that we've been doing with Oren. Do you mean to just start a discussion or are you really proposing these as an

[Devel] Re: [PATCH 14/30] cr: x86_64 support

2009-04-13 Thread Alexey Dobriyan
On Fri, Apr 10, 2009 at 06:36:49AM +0400, Alexey Dobriyan wrote: Now x86 matrix of migration is: task/kernel kernel -- i386/i386 = i386 i386/i386 = x86_64 i386/x86_64 = i386

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Linus Torvalds
On Mon, 13 Apr 2009, Alexey Dobriyan wrote: Well, in OpenVZ everything is in kernel/cpt/ and prefixed with cpt_ and rst_. So? We're not merging OpenVZ code _either_. And I think cr_ is super nice prefix: it's short, it's C-like, it reminds about restart part It does no such thing.

[Devel] Re: How to enable SYSENTER/SYSEXIT in glibc-2.7?

2009-04-13 Thread Linus Torvalds
On Mon, 13 Apr 2009, Guofu Xiang wrote: (gdb) disas __kernel_vsyscall Dump of assembler code for function __kernel_vsyscall: 0xb7f7a400 __kernel_vsyscall+0: int$0x80 0xb7f7a402 __kernel_vsyscall+2: ret End of assembler dump. (gdb) disassemble

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Ingo Molnar
* Linus Torvalds torva...@linux-foundation.org wrote: On Mon, 13 Apr 2009, Alexey Dobriyan wrote: Well, in OpenVZ everything is in kernel/cpt/ and prefixed with cpt_ and rst_. So? We're not merging OpenVZ code _either_. And I think cr_ is super nice prefix: it's short, it's

[Devel] [PATCH] Make tst_ipcshm_multi automatable

2009-04-13 Thread Dan Smith
Add a little to tst_ipcshm_multi to make it automatically validate the results and return a pass/fail status indication for automated runs. Since Oren said he applied my previous patch to his repository, I'm sending this as a delta from the last one I sent[1]. Since the public user-cr is not

[Devel] Re: [PATCH 10/30] cr: core stuff

2009-04-13 Thread Serge E. Hallyn
Quoting Alexey Dobriyan (adobri...@gmail.com): Hi Alexey, as far as I can see, the main differences between this patch and the equivalent in Oren's tree are: 1. kernel auto-selects container init to freeze 2. kernel freezes tasks 3. no objhash taking references 4. no hbuf 5. always require

[Devel] Containers syslog support?

2009-04-13 Thread Chris R. Jones
Hello again, Another question on containers. This time, for syslog. Is there any containers support to isolate syslog entries for different containers? That is, is there any way I can run two different syslogd processes in two different containers, in such a way that each syslogd process only

[Devel] Re: [PATCH] Memory usage limit notification addition to memcg

2009-04-13 Thread Andrew Morton
Please cc contain...@lists.linux-foundation.org on this sort of thing so that all the right people get to see it. On Mon, 13 Apr 2009 18:08:32 -0400 Dan Malek d...@embeddedalley.com wrote: This patch updates the Memory Controller cgroup to add a configurable memory usage limit notification.

[Devel] Re: [PATCH] Make tst_ipcshm_multi automatable

2009-04-13 Thread Serge E. Hallyn
Quoting Dan Smith (da...@us.ibm.com): Add a little to tst_ipcshm_multi to make it automatically validate the results and return a pass/fail status indication for automated runs. Since Oren said he applied my previous patch to his repository, I'm sending this as a delta from the last one I

[Devel] Re: [PATCH] Memory usage limit notification addition to memcg

2009-04-13 Thread Andrew Morton
On Mon, 13 Apr 2009 16:45:17 -0700 Dan Malek d...@embeddedalley.com wrote: On Apr 13, 2009, at 4:08 PM, Andrew Morton wrote: We've run into problems in the past where a percentage number is too coarse on large-memory systems. Proabably that won't be an issue here, but I invite you to

[Devel] [RFC][PATCH] devcg: cache the last matched whitelist item

2009-04-13 Thread Li Zefan
While I was doing testing by open/close files like this: for (i = 0; i LOOP; i++) { fd = open(/dev/null); close(fd); } It got a bit slower when devcg is used, so I made this patch to speed it up. But walking through whitelist in

[Devel] Re: [PATCH] Make tst_ipcshm_multi automatable

2009-04-13 Thread Oren Laadan
thanks ... added. Dan Smith wrote: Add a little to tst_ipcshm_multi to make it automatically validate the results and return a pass/fail status indication for automated runs. Since Oren said he applied my previous patch to his repository, I'm sending this as a delta from the last one I

[Devel] Creating tasks on restart: userspace vs kernel

2009-04-13 Thread Oren Laadan
For checkpoint/restart (c/r) we need a method to (re)create the tasks tree during restart. There are basically two approaches: in userspace (zap approach) or in the kernel (openvz approach). Once tasks have been created both approaches are similar in that all restarting tasks end up calling the

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Oren Laadan
Alexey Dobriyan wrote: On Thu, Apr 09, 2009 at 10:07:11PM -0700, Dave Hansen wrote: I'm curious how you see these fitting in with the work that we've been doing with Oren. Do you mean to just start a discussion or are you really proposing these as an alternative to what Oren has been

[Devel] Re: [PATCH 10/30] cr: core stuff

2009-04-13 Thread Oren Laadan
Alexey Dobriyan wrote: * add struct file_operations::checkpoint The point of hook is to serialize enough information to allow restoration of an opened file. The idea (good one!) is that the code which supplies struct file_operations know better what to do with file. Actually,

[Devel] Re: [PATCH 00/30] C/R OpenVZ/Virtuozzo style

2009-04-13 Thread Oren Laadan
Some meta comments about this patch set: * Patches 1-9 are cleanups, unrelated to checkpoint/restart. They deserve a separate thread. * You barely take locks or reference counts to objects that you later refer to. What if something really bad happens ? * (contd) If you don't take locks, then

[Devel] Re: [PATCH 10/30] cr: core stuff

2009-04-13 Thread Oren Laadan
Hi, Serge E. Hallyn wrote: Quoting Alexey Dobriyan (adobri...@gmail.com): Hi Alexey, as far as I can see, the main differences between this patch and the equivalent in Oren's tree are: 1. kernel auto-selects container init to freeze Actually, this eliminates the possibility to