On Wed, 3 Mar 2010 15:15:49 +0900
KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com wrote:
Agreed.
Let's try how we can write a code in clean way. (we have time ;)
For now, to me, IRQ disabling while lock_page_cgroup() seems to be a little
over killing. What I really want is lockless
Quoting Eric W. Biederman (ebied...@xmission.com):
Sukadev Bhattiprolu suka...@linux.vnet.ibm.com writes:
Eric W. Biederman [ebied...@xmission.com] wrote:
|
| I think replacing a struct pid for another struct pid allocated in
| descendant pid_namespace (but has all of the same struct
Quoting Oren Laadan (or...@cs.columbia.edu):
So... here's a simple fix to a silly regression - this should bring
an end to my little fiasco.
Signed-off-by: Oren Laadan or...@cs.columbia.edu
Tested-by: Serge Hallyn se...@us.ibm.com
---
ipc/checkpoint_msg.c |2 +-
On Tue, 2010-03-02 at 19:19 -0600, Serge E. Hallyn wrote:
Quoting Serge E. Hallyn (se...@us.ibm.com):
Quoting Nathan Lynch (n...@pobox.com):
Hi,
With ckpt-v19-rc3 the test-mq.sh testcase in cr_tests fails when SELinux
is enabled on my test system (64-bit powerpc kernel). The
Serge E. Hallyn se...@us.ibm.com writes:
Quoting Eric W. Biederman (ebied...@xmission.com):
Sukadev Bhattiprolu suka...@linux.vnet.ibm.com writes:
Eric W. Biederman [ebied...@xmission.com] wrote:
|
| I think replacing a struct pid for another struct pid allocated in
| descendant
Quoting Nathan Lynch (n...@pobox.com):
On Tue, 2010-03-02 at 19:19 -0600, Serge E. Hallyn wrote:
Quoting Serge E. Hallyn (se...@us.ibm.com):
Quoting Nathan Lynch (n...@pobox.com):
Hi,
With ckpt-v19-rc3 the test-mq.sh testcase in cr_tests fails when SELinux
is enabled on my
Quick question:
+void set_namespace(unsigned long nstype, void *ns)
+{
+ struct task_struct *tsk = current;
+ struct nsproxy *new_nsproxy;
+
+ new_nsproxy = create_new_namespaces(0, tsk, tsk-fs);
+ switch(nstype) {
+ case NSTYPE_NET:
+
This patch applies to the current head of ckpt-v19-dev.
While the previous fix was correct, it was incomplete in the sense that
a similar problem exists during checkpoint. So here is a better attempt
at fixing both.
The main idea is that holding the {shm,msg,sem}ids-rw_mutex is enough
at
Jonathan Corbet cor...@lwn.net writes:
Quick question:
+void set_namespace(unsigned long nstype, void *ns)
+{
+struct task_struct *tsk = current;
+struct nsproxy *new_nsproxy;
+
+new_nsproxy = create_new_namespaces(0, tsk, tsk-fs);
+switch(nstype) {
+case NSTYPE_NET:
Daniel Lezcano wrote:
Eric W. Biederman wrote:
Pavel Emelyanov xe...@parallels.com writes:
Eric W. Biederman wrote:
Pavel Emelyanov xe...@parallels.com writes:
Eric W. Biederman wrote:
Pavel Emelyanov xe...@parallels.com writes:
Thanks. What's the problem with setns?
joining a
On Wed, 2010-03-03 at 13:49 -0600, Serge E. Hallyn wrote:
Quoting Nathan Lynch (n...@pobox.com):
On Tue, 2010-03-02 at 19:19 -0600, Serge E. Hallyn wrote:
Can you try the following patch?
Also, to actually restore the LSM labels you need to add -k to your
restart flags, but without
Quoting Oren Laadan (or...@cs.columbia.edu):
This patch applies to the current head of ckpt-v19-dev.
While the previous fix was correct, it was incomplete in the sense that
a similar problem exists during checkpoint. So here is a better attempt
at fixing both.
The main idea is that
On Wed, 3 Mar 2010 23:03:19 +0100, Andrea Righi ari...@develer.com wrote:
On Wed, Mar 03, 2010 at 05:21:32PM +0900, KAMEZAWA Hiroyuki wrote:
On Wed, 3 Mar 2010 15:15:49 +0900
KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com wrote:
Agreed.
Let's try how we can write a code in clean
Quoting Nathan Lynch (n...@pobox.com):
On Wed, 2010-03-03 at 13:49 -0600, Serge E. Hallyn wrote:
Quoting Nathan Lynch (n...@pobox.com):
On Tue, 2010-03-02 at 19:19 -0600, Serge E. Hallyn wrote:
Can you try the following patch?
Also, to actually restore the LSM labels you need to
On Wed, 2010-03-03 at 17:44 -0600, Serge E. Hallyn wrote:
Quoting Nathan Lynch (n...@pobox.com):
On Wed, 2010-03-03 at 13:49 -0600, Serge E. Hallyn wrote:
Quoting Nathan Lynch (n...@pobox.com):
On Tue, 2010-03-02 at 19:19 -0600, Serge E. Hallyn wrote:
Can you try the following
Quoting Nathan Lynch (n...@pobox.com):
On Wed, 2010-03-03 at 17:44 -0600, Serge E. Hallyn wrote:
Quoting Nathan Lynch (n...@pobox.com):
On Wed, 2010-03-03 at 13:49 -0600, Serge E. Hallyn wrote:
Quoting Nathan Lynch (n...@pobox.com):
On Tue, 2010-03-02 at 19:19 -0600, Serge E. Hallyn
On Wed, 3 Mar 2010 23:03:19 +0100
Andrea Righi ari...@develer.com wrote:
On Wed, Mar 03, 2010 at 05:21:32PM +0900, KAMEZAWA Hiroyuki wrote:
On Wed, 3 Mar 2010 15:15:49 +0900
KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com wrote:
+ preempt_disable();
+ lock_page_cgroup_migrate(pc);
[PATCH 00/13][user-cr]: Cleanups checkpoint.c, restart.c
These patches perform some cleanups/reorg of the code in checkpoint.c and
restart.c files. These changes remove redundant fields in data structures,
rename some fields/functions and avoid directly using stdout/stderr.
The changes will
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Mar 2010 18:24:51 -0800
Subject: [PATCH 02/13][user-cr]: restart: Rename args-logfd
User-space restart code needs at least two different log files. The restart()
system call code in the kernel writes useful messages to one
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Mar 2010 18:19:44 -0800
Subject: [PATCH 01/13][user-cr]: restart: Remove args-no_pidns.
args-no_pidns does not really need to be a field in the 'args' structure.
It is used to validate command line arguments and can just be a
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Mar 2010 18:45:59 -0800
Subject: [PATCH 03/13][user-cr]: restart: Remove args-logfile
The args-logfile field is used to store the the name of the logfile to
which the kernel must write its output. If we move the code that opens
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Mar 2010 20:04:12 -0800
Subject: [PATCH 04/13][user-cr]: restart: Use ckpt_msg() to log
Rather than implicitly redirecting messages to 'stdout' or 'stderr'
use global variables, 'global_ulogfd' and 'global_uerrfd'. That would
make
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Mar 2010 20:33:36 -0800
Subject: [PATCH 08/13][user-cr]: restart: Rename struct args.
Rename 'struct args' in restart.c to 'struct app_restart_args'. This
would enable us to distinguish this struct from the 'struct args' in
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Mar 2010 20:18:31 -0800
Subject: [PATCH 05/13][user-cr]: restart: Use ckpt_perror()
Remove the implicit dependency on 'stderr' and redirect messages to
global_uerrfd. This would simplify implementing command line options
for these
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Mon, 1 Mar 2010 20:24:15 -0800
Subject: [PATCH 06/13][user-cr]: restart: Remove args-input
Having both -input and -infd in 'struct args' is redundant.
The args-input field is used to store the name of the input file
(checkpoint-image).
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Tue, 2 Mar 2010 09:29:55 -0800
Subject: [PATCH 07/13][user-cr]: Define app_restart()
Move the bulk of code that implements application restart into a
separate function, and make main() a wrapper to that function.
This would help export
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 3 Mar 2010 10:49:19 -0800
Subject: [PATCH 09/13][user-cr]: checkpoint: Remove args-output
'struct args' has both an 'outfd' and an 'output' field. The -output
field is only needed to parse arguments and by moving the open of
the
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 3 Mar 2010 11:03:52 -0800
Subject: [PATCH 10/13][user-cr]: checkpoint: Remove -logfile
'struct args' has both an 'logfd' and a 'logfile' field. The -logfile
field is only needed to parse arguments and by moving the open of
the
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 3 Mar 2010 11:24:54 -0800
Subject: [PATCH 11/13][user-cr]: checkpoint: Rename struct args
Rename 'struct args' in checkpoint.c to 'struct app_checkpoint_args'.
This would give the struct a more specific name when checkpoint/restart
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 3 Mar 2010 11:35:47 -0800
Subject: [PATCH 12/13][user-cr]: Define app_checkpoint()
Move the bulk of the code that implements application checkpoint into
a separate function, app_checkpoint() and make a main() a wrapper to
that
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 3 Mar 2010 15:22:47 -0800
Subject: [PATCH 13/13] checkpoint: Use ckpt_perror()
Remove the implicit dependency on 'stderr' and redirect messages to
global_uerrfd. This would simplify implementing command line options
for these file
31 matches
Mail list logo