[Devel] Re: [PATCH][usercr]: Ghost tasks must be detached

2011-02-22 Thread Louis Rilling
On 21/02/11 12:40 -0800, Sukadev Bhattiprolu wrote: Louis Rilling [louis.rill...@kerlabs.com] wrote: | But in 2.6.32 i.e RHEL5, tsk-signal is set to NULL in __exit_signal(). | So, I am trying to rule out the following scenario: | |Child (may not be a ghost) Parent

[Devel] [PATCH 0/5] blk-throttle: writeback and swap IO control

2011-02-22 Thread Andrea Righi
Currently the blkio.throttle controller only support synchronous IO requests. This means that we always look at the current task to identify the owner of each IO request. However dirty pages in the page cache can be wrote to disk asynchronously by the per-bdi flusher kernel threads or by any

[Devel] [PATCH 1/5] blk-cgroup: move blk-cgroup.h in include/linux/blk-cgroup.h

2011-02-22 Thread Andrea Righi
Move blk-cgroup.h in include/linux for generic usage. Signed-off-by: Andrea Righi ari...@develer.com --- block/blk-cgroup.c |2 +- block/blk-cgroup.h | 335 --- block/blk-throttle.c |2 +- block/cfq.h|2 +-

[Devel] [PATCH 2/5] blk-cgroup: introduce task_to_blkio_cgroup()

2011-02-22 Thread Andrea Righi
Introduce a helper function to retrieve a blkio cgroup from a task. Signed-off-by: Andrea Righi ari...@develer.com --- block/blk-cgroup.c |7 +++ include/linux/blk-cgroup.h |4 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/block/blk-cgroup.c

[Devel] [PATCH 4/5] blk-throttle: track buffered and anonymous pages

2011-02-22 Thread Andrea Righi
Add the tracking of buffered (writeback) and anonymous pages. Dirty pages in the page cache can be processed asynchronously by the per-bdi flusher kernel threads or by any other thread in the system, according to the writeback policy. For this reason the real writes to the underlying block

[Devel] Re: [PATCH 0/5] blk-throttle: writeback and swap IO control

2011-02-22 Thread Vivek Goyal
On Tue, Feb 22, 2011 at 06:12:51PM +0100, Andrea Righi wrote: Currently the blkio.throttle controller only support synchronous IO requests. This means that we always look at the current task to identify the owner of each IO request. However dirty pages in the page cache can be wrote to disk

[Devel] [PATCH] Don't crash if we are self-checkpointing with a child

2011-02-22 Thread Dan Smith
If we are doing a self-checkpoint, we will not be frozen and the get_freezer_task() will return NULL. If we have children, then may_checkpoint_task() will attempt to make sure that they are in the same cgroup as the freezer task, which will attempt to lock a NULL task pointer (and thus go boom).

[Devel] Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages

2011-02-22 Thread Andrea Righi
On Tue, Feb 22, 2011 at 10:42:41AM -0800, Chad Talbott wrote: On Tue, Feb 22, 2011 at 9:12 AM, Andrea Righi ari...@develer.com wrote: Add the tracking of buffered (writeback) and anonymous pages. ... ---  block/blk-throttle.c   |   87 +++-  

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Jonathan Corbet
On Tue, 22 Feb 2011 18:12:54 +0100 Andrea Righi ari...@develer.com wrote: The page_cgroup infrastructure, currently available only for the memory cgroup controller, can be used to store the owner of each page and opportunely track the writeback IO. This information is encoded in the upper

[Devel] Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages

2011-02-22 Thread Vivek Goyal
On Tue, Feb 22, 2011 at 10:42:41AM -0800, Chad Talbott wrote: On Tue, Feb 22, 2011 at 9:12 AM, Andrea Righi ari...@develer.com wrote: Add the tracking of buffered (writeback) and anonymous pages. ... ---  block/blk-throttle.c   |   87 +++-  

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Vivek Goyal
On Tue, Feb 22, 2011 at 06:12:54PM +0100, Andrea Righi wrote: The page_cgroup infrastructure, currently available only for the memory cgroup controller, can be used to store the owner of each page and opportunely track the writeback IO. This information is encoded in the upper 16-bits of the

[Devel] Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages

2011-02-22 Thread Vivek Goyal
On Tue, Feb 22, 2011 at 06:12:55PM +0100, Andrea Righi wrote: Add the tracking of buffered (writeback) and anonymous pages. Dirty pages in the page cache can be processed asynchronously by the per-bdi flusher kernel threads or by any other thread in the system, according to the writeback

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Vivek Goyal
On Tue, Feb 22, 2011 at 01:01:45PM -0700, Jonathan Corbet wrote: On Tue, 22 Feb 2011 18:12:54 +0100 Andrea Righi ari...@develer.com wrote: The page_cgroup infrastructure, currently available only for the memory cgroup controller, can be used to store the owner of each page and

[Devel] Re: [PATCH 0/5] blk-throttle: writeback and swap IO control

2011-02-22 Thread Andrea Righi
On Tue, Feb 22, 2011 at 02:34:03PM -0500, Vivek Goyal wrote: On Tue, Feb 22, 2011 at 06:12:51PM +0100, Andrea Righi wrote: Currently the blkio.throttle controller only support synchronous IO requests. This means that we always look at the current task to identify the owner of each IO

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Andrea Righi
On Tue, Feb 22, 2011 at 01:01:45PM -0700, Jonathan Corbet wrote: On Tue, 22 Feb 2011 18:12:54 +0100 Andrea Righi ari...@develer.com wrote: The page_cgroup infrastructure, currently available only for the memory cgroup controller, can be used to store the owner of each page and

[Devel] Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages

2011-02-22 Thread Andrea Righi
On Tue, Feb 22, 2011 at 03:49:28PM -0500, Vivek Goyal wrote: On Tue, Feb 22, 2011 at 10:42:41AM -0800, Chad Talbott wrote: On Tue, Feb 22, 2011 at 9:12 AM, Andrea Righi ari...@develer.com wrote: Add the tracking of buffered (writeback) and anonymous pages. ... ---  

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Andrea Righi
On Tue, Feb 22, 2011 at 04:22:53PM -0500, Vivek Goyal wrote: On Tue, Feb 22, 2011 at 06:12:54PM +0100, Andrea Righi wrote: The page_cgroup infrastructure, currently available only for the memory cgroup controller, can be used to store the owner of each page and opportunely track the

[Devel] Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages

2011-02-22 Thread Andrea Righi
On Tue, Feb 22, 2011 at 04:00:30PM -0500, Vivek Goyal wrote: On Tue, Feb 22, 2011 at 06:12:55PM +0100, Andrea Righi wrote: Add the tracking of buffered (writeback) and anonymous pages. Dirty pages in the page cache can be processed asynchronously by the per-bdi flusher kernel threads or

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Jonathan Corbet
On Wed, 23 Feb 2011 00:01:47 +0100 Andrea Righi ari...@develer.com wrote: My immediate observation is that you're not really tracking the owner here - you're tracking an opaque 16-bit token known only to the block controller in a field which - if changed by anybody other than the block

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Andrea Righi
On Tue, Feb 22, 2011 at 04:27:29PM -0700, Jonathan Corbet wrote: On Wed, 23 Feb 2011 00:01:47 +0100 Andrea Righi ari...@develer.com wrote: My immediate observation is that you're not really tracking the owner here - you're tracking an opaque 16-bit token known only to the block

[Devel] Re: [PATCH 4/5] blk-throttle: track buffered and anonymous pages

2011-02-22 Thread Vivek Goyal
On Wed, Feb 23, 2011 at 12:05:34AM +0100, Andrea Righi wrote: On Tue, Feb 22, 2011 at 04:00:30PM -0500, Vivek Goyal wrote: On Tue, Feb 22, 2011 at 06:12:55PM +0100, Andrea Righi wrote: Add the tracking of buffered (writeback) and anonymous pages. Dirty pages in the page cache can be

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread Andrea Righi
On Tue, Feb 22, 2011 at 06:06:30PM -0500, Vivek Goyal wrote: On Wed, Feb 23, 2011 at 12:01:47AM +0100, Andrea Righi wrote: On Tue, Feb 22, 2011 at 01:01:45PM -0700, Jonathan Corbet wrote: On Tue, 22 Feb 2011 18:12:54 +0100 Andrea Righi ari...@develer.com wrote: The page_cgroup

[Devel] Re: [PATCH 0/5] blk-throttle: writeback and swap IO control

2011-02-22 Thread Vivek Goyal
On Tue, Feb 22, 2011 at 11:41:41PM +0100, Andrea Righi wrote: On Tue, Feb 22, 2011 at 02:34:03PM -0500, Vivek Goyal wrote: On Tue, Feb 22, 2011 at 06:12:51PM +0100, Andrea Righi wrote: Currently the blkio.throttle controller only support synchronous IO requests. This means that we

[Devel] Re: [PATCH 3/5] page_cgroup: make page tracking available for blkio

2011-02-22 Thread KAMEZAWA Hiroyuki
On Wed, 23 Feb 2011 00:37:18 +0100 Andrea Righi ari...@develer.com wrote: On Tue, Feb 22, 2011 at 06:06:30PM -0500, Vivek Goyal wrote: On Wed, Feb 23, 2011 at 12:01:47AM +0100, Andrea Righi wrote: On Tue, Feb 22, 2011 at 01:01:45PM -0700, Jonathan Corbet wrote: On Tue, 22 Feb 2011