Re: [Devel] [PATCH] cgroups: fix set command with beancounters upstream

2013-04-30 Thread Kir Kolyshkin
On 04/29/2013 10:12 PM, Glauber Costa wrote: The kernel memory controller cannot flip states from unlimited to limited if there are already tasks in it. Therefore, we always have to run with *some* value of kmem enabled. If we don't do it, we can't start unlimited and then use the set command

Re: [Devel] [PATCH 0/3] Fixes for upstream containers

2013-04-30 Thread Kir Kolyshkin
On 04/29/2013 08:46 PM, Glauber Costa wrote: Kir, Please find attached simple fixes for upstream containers. The first one is a compiler warning for recently introduced code, while the last two together fixes bugs with parsing and applying beancounter configuration. Patch #2 fixes a bug only

Re: [Devel] [PATCH] cgroups: fix set command with beancounters upstream

2013-04-30 Thread Glauber Costa
On 04/30/2013 01:48 PM, Kir Kolyshkin wrote: On 04/29/2013 10:12 PM, Glauber Costa wrote: The kernel memory controller cannot flip states from unlimited to limited if there are already tasks in it. Therefore, we always have to run with *some* value of kmem enabled. If we don't do it, we

[Devel] [PATCH] Backup network config file if it lacks of warning

2013-04-30 Thread Igor Podlesny
We do warn a user to not edit network config file since it can be overwritten, but we do this placing our warning inside overwritten file -- it's too late. Let's at least make a copy. --- etc/dists/scripts/debian-add_ip.sh | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff

[Devel] [PATCH] Using Here-doc instead of echo ...

2013-04-30 Thread Igor Podlesny
-- Here-doc is generally more readable/writeable way to implement patterns in SHELL. --- etc/dists/scripts/debian-add_ip.sh |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/etc/dists/scripts/debian-add_ip.sh b/etc/dists/scripts/debian-add_ip.sh index

Re: [Devel] [PATCH] Using Here-doc instead of echo ...

2013-04-30 Thread Kir Kolyshkin
On 04/30/2013 04:58 PM, Igor Podlesny wrote: -- Here-doc is generally more readable/writeable way to implement patterns in SHELL. indeed --- etc/dists/scripts/debian-add_ip.sh |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

Re: [Devel] [PATCH] Backup network config file if it lacks of warning

2013-04-30 Thread Kir Kolyshkin
On 04/30/2013 04:44 PM, Igor Podlesny wrote: We do warn a user to not edit network config file since it can be overwritten, but we do this placing our warning inside overwritten file -- it's too late. Let's at least make a copy. --- etc/dists/scripts/debian-add_ip.sh | 11 ++- 1

Re: [Devel] [PATCH] Using Here-doc instead of echo ...

2013-04-30 Thread Igor M Podlesny
On 1 May 2013 08:09, Kir Kolyshkin k...@openvz.org wrote: On 04/30/2013 04:58 PM, Igor Podlesny wrote: -- Here-doc is generally more readable/writeable way to implement patterns in SHELL. indeed […] - echo + cat $CFGFILE __VENET__ # Auto generated

Re: [Devel] [PATCH] Backup network config file if it lacks of warning

2013-04-30 Thread Kir Kolyshkin
On 04/30/2013 05:50 PM, Igor M Podlesny wrote: On 1 May 2013 08:28, Kir Kolyshkin k...@openvz.org wrote: On 04/30/2013 04:44 PM, Igor Podlesny wrote: […] setup_network() { + local dont_edit='WARNING: Do not edit this file' 1 Add an empty line between variables declaration and

[Devel] [PATCH] Using Here-doc instead of echo ...

2013-04-30 Thread Igor Podlesny
-- Here-doc is generally more readable/writeable way to implement patterns in SHELL. --- etc/dists/scripts/debian-add_ip.sh | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/etc/dists/scripts/debian-add_ip.sh b/etc/dists/scripts/debian-add_ip.sh index

[Devel] .gitignore can borrow lots of different stuff from kernel's one

2013-04-30 Thread Igor Podlesny
But at least I find very inconvenient to have vim swap files not ignored: Igor Podlesny (1): Ignore vim swp files .gitignore |1 + 1 file changed, 1 insertion(+) -- 1.7.9.5 ___ Devel mailing list Devel@openvz.org

[Devel] [PATCH] Ignore vim swp files

2013-04-30 Thread Igor Podlesny
--- .gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 8088803..c8f7b0d 100644 --- a/.gitignore +++ b/.gitignore @@ -2,6 +2,7 @@ TAGS tags cscope.out autom4te.cache +*.swp *.tar.gz *.tar.bz2 Makefile.in -- 1.7.9.5