Re: [Devel] [PATCH] scsi/eh: fix hang adding ehandler wakeups after decrementing host_busy

2017-11-21 Thread Pavel Tikhomirov
Great news, that it works for you! Thanks a lot! Pavel On 11/22/2017 03:49 AM, Stuart Hayes wrote: My apologies... yes, your patch also fixes my issue. I was looking at the two new places from which you were calling scsi_eh_wakeup(), and didn't notice that you moved the spinlock in

Re: [Devel] [PATCH] criu: remap soccr log levels to criu levels

2017-11-21 Thread Cyrill Gorcunov
On Tue, Nov 21, 2017 at 04:18:52PM -0800, Andrei Vagin wrote: > criu and soccr has different values for log levels, so > someone has to remap them. > > Cc: Cyrill Gorcunov > Reported-by: Cyrill Gorcunov > Signed-off-by: Andrei Vagin

Re: [Devel] [PATCH] scsi/eh: fix hang adding ehandler wakeups after decrementing host_busy

2017-11-21 Thread Stuart Hayes
My apologies... yes, your patch also fixes my issue. I was looking at the two new places from which you were calling scsi_eh_wakeup(), and didn't notice that you moved the spinlock in scsi_device_unbusy()... moving the spinlock in scsi_device_unbusy() also should the issue I'm seeing, given

[Devel] [PATCH] criu: print a criu version with the info level

2017-11-21 Thread Andrei Vagin
We always ask users what version of criu they use to investigate a problem, so it better to have it in a log. Signed-off-by: Andrei Vagin --- criu/crtools.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/criu/crtools.c b/criu/crtools.c index

[Devel] [PATCH] criu: remap soccr log levels to criu levels

2017-11-21 Thread Andrei Vagin
criu and soccr has different values for log levels, so someone has to remap them. Cc: Cyrill Gorcunov Reported-by: Cyrill Gorcunov Signed-off-by: Andrei Vagin --- criu/crtools.c | 24 +++- 1 file changed, 23

Re: [Devel] [PATCH] scsi/eh: fix hang adding ehandler wakeups after decrementing host_busy

2017-11-21 Thread Bart Van Assche
On Tue, 2017-09-05 at 15:54 +0300, Pavel Tikhomirov wrote: > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c > index f6097b89d5d3..6c99221d60aa 100644 > --- a/drivers/scsi/scsi_lib.c > +++ b/drivers/scsi/scsi_lib.c > @@ -320,12 +320,11 @@ void scsi_device_unbusy(struct scsi_device

Re: [Devel] [PATCH] scsi/eh: fix hang adding ehandler wakeups after decrementing host_busy

2017-11-21 Thread Pavel Tikhomirov
JFYI these patch is in Virtuozzo7 kernel from September, and we have no issues found with it until now by out testing, and initial problem does not reproduce for 2.5 months. ___ Devel mailing list Devel@openvz.org

Re: [Devel] [PATCH] scsi/eh: fix hang adding ehandler wakeups after decrementing host_busy

2017-11-21 Thread Pavel Tikhomirov
My patch should also fix your issue too, please see explanation in reply to your patch. Do your testing show that it doesn't? Thanks, Pavel. On 11/21/2017 09:10 AM, Stuart Hayes wrote: Pavel, It turns out that the error handler on our systems was not getting woken up for a different