Re: [Devel] call_usermodehelper in containers

2016-02-23 Thread J. Bruce Fields
On Tue, Feb 23, 2016 at 10:55:30AM +0800, Ian Kent wrote: > You know, wrt. the mechanism Oleg suggested, I've been wondering if it's > even necessary to capture process template information for execution. > > Isn't the main issue the execution of unknown arbitrary objects getting > access to a

Re: [Devel] [PATCH] nfsd: check passed socket's net matches NFSd superblock's one

2014-03-31 Thread J. Bruce Fields
Applying, sorry for the delay.--b. On Wed, Feb 26, 2014 at 04:50:01PM +0300, Stanislav Kinsbursky wrote: There could be a case, when NFSd file system is mounted in network, different to socket's one, like below: ip netns exec creates new network and mount namespace, which duplicates NFSd

Re: [Devel] [PATCH] nfsd: check passed socket's net matches NFSd superblock's one

2014-02-20 Thread J. Bruce Fields
On Wed, Feb 19, 2014 at 06:57:46PM +0400, Stanislav Kinsbursky wrote: 19.02.2014 18:50, J. Bruce Fields пишет: On Wed, Feb 19, 2014 at 02:26:33PM +0400, Stanislav Kinsbursky wrote: 18.02.2014 19:44, J. Bruce Fields пишет: On Tue, Feb 18, 2014 at 07:19:31PM +0400, Stanislav Kinsbursky wrote

Re: [Devel] [PATCH] nfsd: check passed socket's net matches NFSd superblock's one

2014-02-19 Thread J. Bruce Fields
On Wed, Feb 19, 2014 at 02:26:33PM +0400, Stanislav Kinsbursky wrote: 18.02.2014 19:44, J. Bruce Fields пишет: On Tue, Feb 18, 2014 at 07:19:31PM +0400, Stanislav Kinsbursky wrote: 18.02.2014 02:19, J. Bruce Fields пишет: On Sat, Feb 15, 2014 at 09:51:20AM +0800, Weng Meiling wrote: Hi Bruce

Re: [Devel] [PATCH] nfsd: check passed socket's net matches NFSd superblock's one

2014-02-18 Thread J. Bruce Fields
On Tue, Feb 18, 2014 at 07:19:31PM +0400, Stanislav Kinsbursky wrote: 18.02.2014 02:19, J. Bruce Fields пишет: On Sat, Feb 15, 2014 at 09:51:20AM +0800, Weng Meiling wrote: Hi Bruce, The upstream has merged your git tree for-3.14, but there is no this patch? Do you forget this patch

Re: [Devel] [PATCH] nfsd: check passed socket's net matches NFSd superblock's one

2014-02-17 Thread J. Bruce Fields
be involved. I haven't investigated any further. --b. Thanks! Weng Meiling On 2014/1/4 6:22, J. Bruce Fields wrote: On Mon, Dec 30, 2013 at 05:23:59PM +0300, Stanislav Kinsbursky wrote: There could be a case, when NFSd file system is mounted in network, different to socket's one, like

Re: [Devel] [PATCH] nfsd: check passed socket's net matches NFSd superblock's one

2014-01-03 Thread J. Bruce Fields
On Mon, Dec 30, 2013 at 05:23:59PM +0300, Stanislav Kinsbursky wrote: There could be a case, when NFSd file system is mounted in network, different to socket's one, like below: ip netns exec creates new network and mount namespace, which duplicates NFSd mount point, created in init_net

Re: [Devel] [RFC PATCH] fs: call_usermodehelper_root helper introduced

2013-05-23 Thread J. Bruce Fields
On Wed, May 22, 2013 at 08:37:23PM -0700, Eric W. Biederman wrote: J. Bruce Fields bfie...@fieldses.org writes: On Wed, May 22, 2013 at 11:35:56AM -0700, Eric W. Biederman wrote: ebied...@xmission.com (Eric W. Biederman) writes: I am missing a lot of context here and capturing

Re: [Devel] [RFC PATCH] fs: call_usermodehelper_root helper introduced

2013-05-23 Thread J. Bruce Fields
On Thu, May 23, 2013 at 09:05:26AM -0400, Jeff Layton wrote: On Thu, 23 May 2013 15:25:20 +0300 I'm not familiar with nfsdcltrack but I would imagine it receives it's information from Kernel as a command line parameters. Would it not be the simplest approach to add a

Re: [Devel] [RFC PATCH] fs: call_usermodehelper_root helper introduced

2013-05-23 Thread J. Bruce Fields
On Thu, May 23, 2013 at 03:55:47PM -0400, J. Bruce Fields wrote: On Thu, May 23, 2013 at 09:05:26AM -0400, Jeff Layton wrote: What might help most here is to lay out a particular scenario for how you envision setting up knfsd in a container so we can ensure that it's addressed properly

Re: [Devel] [RFC PATCH] fs: call_usermodehelper_root helper introduced

2013-05-22 Thread J. Bruce Fields
On Wed, May 22, 2013 at 11:35:56AM -0700, Eric W. Biederman wrote: ebied...@xmission.com (Eric W. Biederman) writes: I am missing a lot of context here and capturing the context of a process at time time we mount the filesystem and reconstituing it in call user mode helper seems like

Re: [Devel] [RFC PATCH] kmod: add ability to swap root in usermode helper

2013-05-21 Thread J. Bruce Fields
On Tue, May 21, 2013 at 05:28:36PM +0200, Oleg Nesterov wrote: You know, I am puzzled. Everything looks so clear that I can't understand what I could miss. On 05/20, J. Bruce Fields wrote: On Mon, May 20, 2013 at 05:10:01PM +0200, Oleg Nesterov wrote: On 05/20, Stanislav Kinsbursky

Re: [Devel] [RFC PATCH] kmod: add ability to swap root in usermode helper

2013-05-20 Thread J. Bruce Fields
On Mon, May 20, 2013 at 05:10:01PM +0200, Oleg Nesterov wrote: On 05/20, Stanislav Kinsbursky wrote: Moreover, set_fs_root() is not exported. Then it should be exported, I think ;) Maybe--there are objections, see below. Or you can export the new helper. And adding an ability of a

Re: [Devel] [PATCH] nfsd: enable UMH client tracker in container

2013-04-23 Thread J. Bruce Fields
On Fri, Apr 19, 2013 at 07:01:50AM -0700, Jeff Layton wrote: On Tue, 16 Apr 2013 15:17:44 +0400 Stanislav Kinsbursky skinsbur...@parallels.com wrote: This patch adds support for UserModeHelper tracker in a container. The reason for this is that the only containerised tracker (nfsdcld) is

Re: [Devel] [PATCH v2 0/4] nfsd: make is works in a container

2013-02-15 Thread J. Bruce Fields
On Fri, Feb 01, 2013 at 03:56:05PM +0300, Stanislav Kinsbursky wrote: This patch set finally enables NFSd in container. I've tested it in container with it's own root, and also pid, net and mount namespaces. Thanks, these look fine to me; applying. They should show up in my for-3.9 branch

Re: [Devel] [PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-11 Thread J. Bruce Fields
On Mon, Feb 11, 2013 at 11:37:15AM -0500, J. Bruce Fields wrote: On Mon, Feb 11, 2013 at 10:18:18AM +0400, Stanislav Kinsbursky wrote: This one looks a bit complicated and confusing to me. Probably because I'm not that familiar with service transports processing logic. So, as I can see, we

Re: [Devel] [PATCH 0/2] NFSD: fix races in service per-net resources allocation

2013-02-10 Thread J. Bruce Fields
with the following? --b commit e8202f39f84b8863337f55159dd18478b9ccb616 Author: J. Bruce Fields bfie...@redhat.com Date: Sun Feb 10 16:08:11 2013 -0500 svcrpc: fix and simplify server shutdown Simplify server shutdown, and make it correct whether or not there are still threads running

Re: [Devel] [PATCH v2 1/6] NFS: use SUNRPC cache creation and destruction helper for DNS cache

2013-02-08 Thread J. Bruce Fields
On Mon, Feb 04, 2013 at 02:02:35PM +0300, Stanislav Kinsbursky wrote: This cache was the first containerized and doesn't use net-aware cache creation and destruction helpers. This is a cleanup patch which just makes code looks clearer and reduce amount of lines of code. This looks like

Re: [Devel] [PATCH v2 2/6] NFS; simlify and clean cache library

2013-02-08 Thread J. Bruce Fields
On Mon, Feb 04, 2013 at 02:02:40PM +0300, Stanislav Kinsbursky wrote: This is a cleanup patch. Such helpers like nfs_cache_init() and nfs_cache_destroy() are redundant, because they are just a wrappers around sunrpc_init_cache_detail() and sunrpc_destroy_cache_detail() respectively. So let's

Re: [Devel] [PATCH v2 0/6] SUNRPC: rework cache upcall to avoid NFSd root

2013-02-04 Thread J. Bruce Fields
On Mon, Feb 04, 2013 at 02:02:29PM +0300, Stanislav Kinsbursky wrote: swapping The main idea of this patch set is to call cache request not on kthread upcall, but on userspace daemon cache_read call. This fixes the problem with gaining of wrong dentry path after calling d_path() in kthread

Re: [Devel] [RFC PATCH] SUNRPC: protect transport processing with rw sem

2013-01-30 Thread J. Bruce Fields
On Wed, Jan 30, 2013 at 09:42:14AM +0400, Stanislav Kinsbursky wrote: 30.01.2013 02:57, J. Bruce Fields пишет: On Tue, Jan 29, 2013 at 02:03:30PM +0300, Stanislav Kinsbursky wrote: There could be a service transport, which is processed by service thread and racing in the same time with per-net

Re: [Devel] [RFC PATCH 0/4] SUNRPC: rework cache upcall to avoid NFSd root swapping

2013-01-30 Thread J. Bruce Fields
On Tue, Jan 15, 2013 at 11:09:23AM +0300, Stanislav Kinsbursky wrote: The main idea of this patch set is to call cache request not on kthread upcall, but on userspace daemon cache_read call. This fixes the problem with gaining of wrong dentry path after calling d_path() in kthread root context

Re: [Devel] [PATCH 2/6] nfsd: swap fs root in NFSd kthreads

2013-01-11 Thread J. Bruce Fields
On Fri, Jan 11, 2013 at 06:56:58PM +0400, Stanislav Kinsbursky wrote: 11.12.2012 19:35, J. Bruce Fields пишет: On Tue, Dec 11, 2012 at 10:20:36AM -0500, J. Bruce Fields wrote: On Tue, Dec 11, 2012 at 07:07:00PM +0400, Stanislav Kinsbursky wrote: I don't really understand, how mountd's root

Re: [Devel] [PATCH 2/6] nfsd: swap fs root in NFSd kthreads

2013-01-11 Thread J. Bruce Fields
On Fri, Jan 11, 2013 at 12:03:12PM -0500, J. Bruce Fields wrote: On Fri, Jan 11, 2013 at 06:56:58PM +0400, Stanislav Kinsbursky wrote: 11.12.2012 19:35, J. Bruce Fields пишет: On Tue, Dec 11, 2012 at 10:20:36AM -0500, J. Bruce Fields wrote: On Tue, Dec 11, 2012 at 07:07:00PM +0400

Re: [Devel] [PATCH] nfsd: fix unused nn variable warning in free_client()

2013-01-09 Thread J. Bruce Fields
On Wed, Jan 09, 2013 at 01:39:04PM +0400, Stanislav Kinsbursky wrote: Bruce, sorry, forgot to add: Reported-by: Toralf Förster toralf.foers...@gmx.de Thanks, added that, and committing for 3.9.--b. 09.01.2013 13:38, Stanislav Kinsbursky пишет: If CONFIG_LOCKDEP is disabled, then there

Re: [Devel] [PATCH 2/6] nfsd: swap fs root in NFSd kthreads

2012-12-11 Thread J. Bruce Fields
On Tue, Dec 11, 2012 at 07:07:00PM +0400, Stanislav Kinsbursky wrote: 11.12.2012 18:56, J. Bruce Fields пишет: On Tue, Dec 11, 2012 at 06:12:40PM +0400, Stanislav Kinsbursky wrote: UID: 9899 11.12.2012 18:00, Stanislav Kinsbursky пишет: 11.12.2012 00:28, J. Bruce Fields пишет: On Thu, Dec

Re: [Devel] [PATCH 2/6] nfsd: swap fs root in NFSd kthreads

2012-12-11 Thread J. Bruce Fields
On Tue, Dec 11, 2012 at 10:20:36AM -0500, J. Bruce Fields wrote: On Tue, Dec 11, 2012 at 07:07:00PM +0400, Stanislav Kinsbursky wrote: I don't really understand, how mountd's root can be wrong. I.e. its' always right as I see it. NFSd kthreads have to swap/use relative path/whatever

Re: [Devel] [PATCH] nfsd: make NFSv4 recovery client tracking options per net

2012-12-07 Thread J. Bruce Fields
On Tue, Dec 04, 2012 at 02:29:27PM +0300, Stanislav Kinsbursky wrote: Pointer to client tracking operations - client_tracking_ops - have to be containerized, because different environment can support different trackers (for example, legacy tracker currently is not suported in container). OK,

Re: [Devel] [PATCH] SUNRPC: remove redundant linux/nsproxy.h includes

2012-12-07 Thread J. Bruce Fields
On Tue, Dec 04, 2012 at 03:18:58PM +0300, Stanislav Kinsbursky wrote: This is a cleanup patch. OK, applying.--b. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- net/sunrpc/rpcb_clnt.c |1 - net/sunrpc/svc.c |1 - 2 files changed, 0 insertions(+), 2

Re: [Devel] [PATCH 3/6] nfsd: pass net to nfsd_create_serv()

2012-12-07 Thread J. Bruce Fields
On Tue, Dec 04, 2012 at 04:50:16PM +0300, Stanislav Kinsbursky wrote: diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c index 21cba3d..6448391 100644 --- a/fs/nfsd/nfssvc.c +++ b/fs/nfsd/nfssvc.c @@ -334,10 +334,9 @@ static int nfsd_get_default_max_blksize(void) return ret; } -int

Re: [Devel] [PATCH 0/2] nfsd: containerise NFSv4 recovery state

2012-11-28 Thread J. Bruce Fields
On Mon, Nov 26, 2012 at 04:16:18PM +0300, Stanislav Kinsbursky wrote: This patch set makes rec_file and in_grace global static variables allocated per network namespace. Both of them are a part of client tracking engine, which is containerised already. Thanks, applying for 3.8.--b. The

Re: [Devel] [PATCH 1/2] nfsd: make NFSv4 lease time per net

2012-11-28 Thread J. Bruce Fields
On Tue, Nov 27, 2012 at 02:11:44PM +0300, Stanislav Kinsbursky wrote: diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index dab350d..4930981 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c @@ -912,7 +912,8 @@ static ssize_t nfsd4_write_time(struct file *file, char *buf, size_t size,

Re: [Devel] [PATCH 2/2] nfsd: make NFSv4 grace time per net

2012-11-28 Thread J. Bruce Fields
On Tue, Nov 27, 2012 at 02:11:49PM +0300, Stanislav Kinsbursky wrote: diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index 4930981..7e41bd1 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c @@ -928,7 +928,8 @@ static ssize_t write_leasetime(struct file *file, char *buf, size_t size)

Re: [Devel] [PATCH] nfsd: remove redundant declarations

2012-11-28 Thread J. Bruce Fields
On Tue, Nov 27, 2012 at 02:42:20PM +0300, Stanislav Kinsbursky wrote: This is a cleanup patch. Functions nfsd_pool_stats_open() and nfsd_pool_stats_release() are declared in fs/nfsd/nfsd.h. OK, applying. --b. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com ---

Re: [Devel] [PATCH 1/2] nfsd: make NFSv4 lease time per net

2012-11-28 Thread J. Bruce Fields
On Wed, Nov 28, 2012 at 07:12:03PM +0400, Stanislav Kinsbursky wrote: 28.11.2012 19:09, J. Bruce Fields пишет: On Tue, Nov 27, 2012 at 02:11:44PM +0300, Stanislav Kinsbursky wrote: diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index dab350d..4930981 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs

Re: [Devel] [PATCH 1/2] nfsd: make NFSv4 lease time per net

2012-11-28 Thread J. Bruce Fields
On Wed, Nov 28, 2012 at 07:35:20PM +0400, Stanislav Kinsbursky wrote: 28.11.2012 19:15, J. Bruce Fields пишет: On Wed, Nov 28, 2012 at 07:12:03PM +0400, Stanislav Kinsbursky wrote: 28.11.2012 19:09, J. Bruce Fields пишет: On Tue, Nov 27, 2012 at 02:11:44PM +0300, Stanislav Kinsbursky wrote

Re: [Devel] [PATCH] nfsd4: remove state lock from nfs4_state_shutdown

2012-11-27 Thread J. Bruce Fields
OK, applying.--b. On Wed, Nov 21, 2012 at 06:07:38PM +0300, Stanislav Kinsbursky wrote: Protection of __nfs4_state_shutdown() with nfs4_lock_state() looks redundant. This function is called by the last NFSd thread on it's exit and state lock protects actually two functions (del_recall_lru is

Re: [Devel] [PATCH 0/5] nfsd: more NFSv4 state containerization

2012-11-27 Thread J. Bruce Fields
On Mon, Nov 26, 2012 at 03:21:49PM +0300, Stanislav Kinsbursky wrote: This patch set makes NFSv4 state created and destroyed per net and thus completes it's containerization (the only exceprtion is client_mutex, but this one a hard nut to crack). Note: patch set depend on previously sent

[Devel] Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-26 Thread J. Bruce Fields
On Wed, Oct 10, 2012 at 02:32:28PM +0400, Stanislav Kinsbursky wrote: 10.10.2012 05:23, J. Bruce Fields пишет: On Tue, Oct 09, 2012 at 03:47:42PM -0700, Eric W. Biederman wrote: J. Bruce Fields bfie...@fieldses.org writes: On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote

[Devel] Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread J. Bruce Fields
Cc'ing Eric since I seem to recall he suggested doing it this way? Seems OK to me, but maybe that swap_root should be in common code? (Or maybe we could use set_fs_root()?) I'm assuming it's up to Trond to take this.--b. On Mon, Oct 08, 2012 at 02:56:32PM +0400, Stanislav Kinsbursky wrote:

[Devel] Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread J. Bruce Fields
On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: Myklebust, Trond trond.mykleb...@netapp.com writes: On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: Cc'ing Eric since I seem to recall he suggested doing it this way? Yes. On second look setting fs-root won't

[Devel] Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread J. Bruce Fields
On Tue, Oct 09, 2012 at 03:47:42PM -0700, Eric W. Biederman wrote: J. Bruce Fields bfie...@fieldses.org writes: On Tue, Oct 09, 2012 at 01:20:48PM -0700, Eric W. Biederman wrote: Myklebust, Trond trond.mykleb...@netapp.com writes: On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields

[Devel] Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced

2012-10-07 Thread J. Bruce Fields
On Tue, Sep 04, 2012 at 03:00:07PM -0400, bfields wrote: On Mon, Aug 20, 2012 at 02:18:13PM +0400, Stanislav Kinsbursky wrote: 16.08.2012 07:03, Eric W. Biederman пишет: Stanislav Kinsbursky skinsbur...@parallels.com writes: This patch set introduces new socket operation and new system

[Devel] Re: [PATCH v3] SUNRPC: protect service sockets lists during per-net shutdown

2012-08-21 Thread J. Bruce Fields
On Tue, Aug 21, 2012 at 01:28:00PM +0400, Stanislav Kinsbursky wrote: 20.08.2012 20:58, J. Bruce Fields пишет: On Mon, Aug 20, 2012 at 07:11:00PM +0400, Stanislav Kinsbursky wrote: Currently, when you call kthread_create(), you add new job to kthreadd queue. Kthreadd is unique, starts right

[Devel] Re: [PATCH v3] SUNRPC: protect service sockets lists during per-net shutdown

2012-08-21 Thread J. Bruce Fields
On Thu, Aug 16, 2012 at 03:29:03PM -0400, J. Bruce Fields wrote: Looking back at this: - adding the sv_lock looks like the right thing to do anyway independent of containers, because svc_age_temp_xprts may still be running. This is what I've been testing

[Devel] Re: [PATCH v3] SUNRPC: protect service sockets lists during per-net shutdown

2012-08-20 Thread J. Bruce Fields
On Mon, Aug 20, 2012 at 03:05:49PM +0400, Stanislav Kinsbursky wrote: 16.08.2012 23:29, J. Bruce Fields пишет: Looking back at this: - adding the sv_lock looks like the right thing to do anyway independent of containers, because svc_age_temp_xprts may still be running

[Devel] Re: [PATCH v3] SUNRPC: protect service sockets lists during per-net shutdown

2012-08-20 Thread J. Bruce Fields
On Mon, Aug 20, 2012 at 07:11:00PM +0400, Stanislav Kinsbursky wrote: 20.08.2012 18:56, J. Bruce Fields пишет: On Mon, Aug 20, 2012 at 03:05:49PM +0400, Stanislav Kinsbursky wrote: 16.08.2012 23:29, J. Bruce Fields пишет: Looking back at this: - adding the sv_lock looks like the right

[Devel] Re: [RFC PATCH 0/5] net: socket bind to file descriptor introduced

2012-08-16 Thread J. Bruce Fields
On Wed, Aug 15, 2012 at 08:03:24PM -0700, Eric W. Biederman wrote: Stanislav Kinsbursky skinsbur...@parallels.com writes: This patch set introduces new socket operation and new system call: sys_fbind(), which allows to bind socket to opened file. File to bind to can be created by

[Devel] Re: [PATCH v3] SUNRPC: protect service sockets lists during per-net shutdown

2012-08-16 Thread J. Bruce Fields
On Tue, Jul 24, 2012 at 03:40:37PM -0400, J. Bruce Fields wrote: On Tue, Jul 03, 2012 at 04:58:57PM +0400, Stanislav Kinsbursky wrote: v3: 1) rebased on 3.5-rc3 kernel. v2: destruction of currently processing transport added: 1) Added marking of currently processing transports

[Devel] Re: [RFC PATCH 0/2] net: connect to UNIX sockets from specified root

2012-08-13 Thread J. Bruce Fields
On Sat, Aug 11, 2012 at 03:15:24PM +0400, Stanislav Kinsbursky wrote: 11.08.2012 10:23, Pavel Emelyanov пишет: On 08/11/2012 03:09 AM, H. Peter Anvin wrote: On 08/10/2012 12:28 PM, Alan Cox wrote: Explicitly for Linux yes - this is not generally true of the AF_UNIX socket domain and even the

[Devel] Re: [RFC PATCH 0/2] net: connect to UNIX sockets from specified root

2012-08-13 Thread J. Bruce Fields
On Mon, Aug 13, 2012 at 09:39:53PM +0400, Stanislav Kinsbursky wrote: 13.08.2012 20:47, J. Bruce Fields пишет: On Sat, Aug 11, 2012 at 03:15:24PM +0400, Stanislav Kinsbursky wrote: 11.08.2012 10:23, Pavel Emelyanov пишет: On 08/11/2012 03:09 AM, H. Peter Anvin wrote: On 08/10/2012 12:28 PM

[Devel] Re: [RFC PATCH 1/2] unix sockets: add ability for search for peer from passed root

2012-08-10 Thread J. Bruce Fields
On Fri, Aug 10, 2012 at 04:57:30PM +0400, Stanislav Kinsbursky wrote: This helper is used stream sockets yet. All is simple: if non-NULL struct path was passed to unix_find_other(), then vfs_path_lookup() is called instead of kern_path(). I'm having some trouble parsing the changelog. Maybe

[Devel] Re: [RFC PATCH 0/2] net: connect to UNIX sockets from specified root

2012-08-10 Thread J. Bruce Fields
On Fri, Aug 10, 2012 at 07:26:28PM +0100, Alan Cox wrote: On that whole subject... Do we need a Unix domain socket equivalent to openat()? I don't think so. The name is just a file system indexing trick, it's not really the socket proper. It's little more than ascii string with

[Devel] Re: [PATCH v2 09/15] NFSd: make nfsd4_manager allocated per network namespace context.

2012-07-27 Thread J. Bruce Fields
On Wed, Jul 25, 2012 at 04:56:58PM +0400, Stanislav Kinsbursky wrote: Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfsd/netns.h |2 ++ fs/nfsd/nfs4state.c | 32 +++- 2 files changed, 21 insertions(+), 13 deletions(-) diff --git

[Devel] Re: [PATCH v2 00/15] Lockd: grace period containerization

2012-07-27 Thread J. Bruce Fields
On Wed, Jul 25, 2012 at 04:55:45PM +0400, Stanislav Kinsbursky wrote: Bruce, I feel this patch set is ready for inclusion. v2: 1) Rebase on Bruce's for-3.6 branch. This patch set makes grace period and hosts reclaiming network namespace aware. On a quick skim--yes, that looks reasonable

[Devel] Re: [PATCH v3] SUNRPC: protect service sockets lists during per-net shutdown

2012-07-24 Thread J. Bruce Fields
On Tue, Jul 03, 2012 at 04:58:57PM +0400, Stanislav Kinsbursky wrote: v3: 1) rebased on 3.5-rc3 kernel. v2: destruction of currently processing transport added: 1) Added marking of currently processing transports with XPT_CLOSE on per-net shutdown. These transports will be destroyed in

[Devel] Re: [PATCH v3 03/11] NFS: move per-net callback thread initialization to nfs_callback_up_net()

2012-07-24 Thread J. Bruce Fields
On Tue, Jul 03, 2012 at 08:19:46PM +0400, Stanislav Kinsbursky wrote: This new function in now called before nfs_minorversion_callback_svc_setup()). Also few small changes: 1) current network namespace in nfs_callback_up() was replaced by transport net. 2) svc_shutdown_net() was moved

[Devel] Re: [PATCH v3 00/11] Series short description

2012-07-24 Thread J. Bruce Fields
On Tue, Jul 03, 2012 at 08:19:23PM +0400, Stanislav Kinsbursky wrote: v3: Rebased on Bruce's tree, for-3.6 branch v2: Rebased on Bruce's tree, for-3.5 branch Aside from the one question, this looks OK to me. I seem to recall this needed to go through my tree for some reason, but does Trond

[Devel] Re: [PATCH v2] NFSd: simplify locking in nfsd_recall_delegations()

2012-07-18 Thread J. Bruce Fields
On Tue, Jul 03, 2012 at 05:02:24PM +0400, Stanislav Kinsbursky wrote: v2: rebased on 3.5-rc3 kernel Holding of client_mutex looks redundant here - recall_lock looks enough. Yep, thanks.--b. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfsd/nfs4state.c |2 --

[Devel] Re: [PATCH v2] NFSd: fix locking in nfsd_forget_delegations()

2012-07-12 Thread J. Bruce Fields
On Fri, May 25, 2012 at 06:38:50PM +0400, Stanislav Kinsbursky wrote: v2: dl_recall_lru list is used for delegations collect because it's modified both in unhash_delegation() and nfsd_break_one_deleg(). This patch adds recall_lock hold to nfsd_forget_delegations() to protect

[Devel] Re: [PATCH] [RFC] nfsd: fix possible dereference of static NULL nfsd_serv pointer

2012-07-10 Thread J. Bruce Fields
On Sat, Jul 07, 2012 at 09:27:30AM +0400, Stanislav Kinsbursky wrote: 06.07.2012 21:26, J. Bruce Fields пишет: On Fri, Jul 06, 2012 at 05:45:56PM +0400, Stanislav Kinsbursky wrote: This is a bug fix for 3.5 kernel. In case on NFSd service start failure svc_shutdown_net() will call

[Devel] Re: [PATCH] [RFC] nfsd: fix possible dereference of static NULL nfsd_serv pointer

2012-07-06 Thread J. Bruce Fields
On Fri, Jul 06, 2012 at 05:45:56PM +0400, Stanislav Kinsbursky wrote: This is a bug fix for 3.5 kernel. In case on NFSd service start failure svc_shutdown_net() will call svc_destroy callback and zeroize global nfsd_serv pointer, this in turn will lead to Oops in svc_destroy(). This patch

[Devel] Re: [PATCH v3] NFSd: set nfsd_serv to NULL after service destruction

2012-07-05 Thread J. Bruce Fields
On Tue, Jul 03, 2012 at 04:46:41PM +0400, Stanislav Kinsbursky wrote: v3: 1) Rebased for 3.6 kernel. v2: 1) Set global nfsd_serv pointer to NULL only if no running threads left. Otherwise we will get NULL pointer dereference on last thread exit in nfsd_last_thread(). This patch also

[Devel] Re: [PATCH] NFS: hard-code init_net for NFS callback transports

2012-06-13 Thread J. Bruce Fields
On Wed, Jun 13, 2012 at 12:16:07PM +0400, Stanislav Kinsbursky wrote: 12.06.2012 19:53, J. Bruce Fields написал: On Mon, Jun 11, 2012 at 08:37:18AM -0400, J. Bruce Fields wrote: On Fri, Jun 01, 2012 at 01:55:47PM +0400, Stanislav Kinsbursky wrote: This patch set is a bug fix for Bruce's 3.5

[Devel] Re: [PATCH] NFS: hard-code init_net for NFS callback transports

2012-06-12 Thread J. Bruce Fields
On Mon, Jun 11, 2012 at 08:37:18AM -0400, J. Bruce Fields wrote: On Fri, Jun 01, 2012 at 01:55:47PM +0400, Stanislav Kinsbursky wrote: This patch set is a bug fix for Bruce's 3.5 branch. I'll rebase this for 3.4 and resend. Apologies for neglecting this, I'm done with the bakeathon

[Devel] Re: [PATCH] NFS: hard-code init_net for NFS callback transports

2012-06-11 Thread J. Bruce Fields
On Fri, Jun 01, 2012 at 01:55:47PM +0400, Stanislav Kinsbursky wrote: This patch set is a bug fix for Bruce's 3.5 branch. I'll rebase this for 3.4 and resend. Apologies for neglecting this, I'm done with the bakeathon and should be back to this soon. But, I'm a bit confused: you say you'll

[Devel] Re: [PATCH] NFSd: fix locking in nfsd_forget_delegations()

2012-05-24 Thread J. Bruce Fields
On Thu, May 24, 2012 at 08:41:35AM +0400, Stanislav Kinsbursky wrote: 24.05.2012 01:31, J. Bruce Fields написал: On Tue, May 22, 2012 at 02:25:14PM +0400, Stanislav Kinsbursky wrote: This patch adds recall_lock hold to nfsd_forget_delegations() to protect nfsd_process_n_delegations() call

[Devel] Re: [PATCH v2 01/12] NFS: pass net to nfs_callback_down()

2012-05-24 Thread J. Bruce Fields
I can see that you're passing net to nfs_callback_down(). Could you please remind me why? What problem does this solve? --b. On Tue, May 22, 2012 at 11:35:55AM +0400, Stanislav Kinsbursky wrote: Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/nfs/callback.c |4 ++--

[Devel] Re: [PATCH] NFSd: fix locking in nfsd_forget_delegations()

2012-05-23 Thread J. Bruce Fields
On Tue, May 22, 2012 at 02:25:14PM +0400, Stanislav Kinsbursky wrote: This patch adds recall_lock hold to nfsd_forget_delegations() to protect nfsd_process_n_delegations() call. Also, looks like it would be better to collect delegations to some local on-stack list, and then unhash collected

[Devel] Re: [PATCH] NFSd: set nfsd_serv to NULL after service destruction

2012-05-23 Thread J. Bruce Fields
On Fri, May 18, 2012 at 07:26:02PM +0400, Stanislav Kinsbursky wrote: Otherwise we will get NULL pointer dereference after svc_shutdown_net-sv_shutdown (nfsd_last_thread) call. This looks safe, because all such operations (svc_destroy) are performed with nfsd_mutex being held.

[Devel] Re: [RFC PATCH] SUNRPC: protect service sockets lists during per-net shutdown

2012-05-16 Thread J. Bruce Fields
On Fri, May 11, 2012 at 03:41:56PM +0400, Stanislav Kinsbursky wrote: Service sv_tempsocks and sv_permsocks lists are accessible by tasks with different network namespaces, and thus per-net service destruction must be protected. These lists are protected by service sv_lock. So lets wrap list

[Devel] Re: [PATCH RFC 00/13] Lockd: grace period containerization

2012-05-16 Thread J. Bruce Fields
On Sat, May 05, 2012 at 09:21:30PM +0400, Stanislav Kinsbursky wrote: This patch set is marked with RFC, because I'm still not quite sure, that this implementation will satisfy other interested people. So, would be appreciated for any comments. This patch set makes grace period and hosts

[Devel] Re: [PATCH RFC 00/13] Lockd: grace period containerization

2012-05-16 Thread J. Bruce Fields
On Wed, May 16, 2012 at 04:06:30PM -0400, J. Bruce Fields wrote: On Sat, May 05, 2012 at 09:21:30PM +0400, Stanislav Kinsbursky wrote: This patch set is marked with RFC, because I'm still not quite sure, that this implementation will satisfy other interested people. So, would

[Devel] Re: [PATCH 0/6] Lockd: service start cleanup patch set

2012-05-09 Thread J. Bruce Fields
On Wed, Apr 25, 2012 at 06:22:32PM +0400, Stanislav Kinsbursky wrote: This patch set simplifies LockD start logic, makes code looks straight-forward and clear. I've applied and pushed these out. I believe I now have everything from you except your latest grace-period handling rfc. Could you

[Devel] Re: [PATCH v3 0/2] SUNRPC: separate per-net data creation from service

2012-05-03 Thread J. Bruce Fields
On Wed, May 02, 2012 at 05:58:37PM -0400, J. Bruce Fields wrote: Thanks, applying. Whoops, no--I'm hitting the BUG at net/sunrpc/svc.c:558 (the first of the two BUG_ON()s in svc_destroy()) when restarting nfsd. Could you look into this? --b. --b. On Wed, May 02, 2012 at 04:08:29PM +0400

[Devel] Re: [PATCH v3 0/2] SUNRPC: separate per-net data creation from service

2012-05-02 Thread J. Bruce Fields
Thanks, applying. --b. On Wed, May 02, 2012 at 04:08:29PM +0400, Stanislav Kinsbursky wrote: creation v3: SUNRPC: new svc_bind() routine introduced patch was squashed with the SUNRPC: check rpcbind clients usage counter before decrement patch. v2: Increase per-net usage counted in

[Devel] Re: [PATCH 2/3] SUNRPC: check rpcbind clients usage counter before decrement

2012-04-30 Thread J. Bruce Fields
On Fri, Apr 27, 2012 at 06:08:13PM +0400, Stanislav Kinsbursky wrote: On 27.04.2012 17:55, J. Bruce Fields wrote: On Wed, Apr 25, 2012 at 05:37:49PM +0400, Stanislav Kinsbursky wrote: Registering service with svc_bind() can fail. In this case service will be destroyed and during destruction

[Devel] Re: [PATCH 2/3] SUNRPC: check rpcbind clients usage counter before decrement

2012-04-27 Thread J. Bruce Fields
On Wed, Apr 25, 2012 at 05:37:49PM +0400, Stanislav Kinsbursky wrote: Registering service with svc_bind() can fail. In this case service will be destroyed and during destruction it will try to unregister itself from rpcbind. In this case unregister have to be skipped. Isn't this a

[Devel] Re: [PATCH v2] SUNRPC: skip dead but not buried clients on PipeFS events

2012-04-25 Thread J. Bruce Fields
On Fri, Apr 20, 2012 at 06:11:02PM +0400, Stanislav Kinsbursky wrote: v2: atomic_inc_return() was replaced by atomic_inc_not_zero(). These clients can't be safely dereferenced if their counter in 0. I'm pretty confused by how these notifiers work rpc_release_client decrements cl_count to

[Devel] Re: [PATCH 0/3] SUNRPC: three bugfixes for PipeFS event handling

2012-04-25 Thread J. Bruce Fields
On Thu, Apr 26, 2012 at 12:59:07AM +0400, Stanislav Kinsbursky wrote: 25.04.2012 22:24, J. Bruce Fields написал: On Fri, Apr 20, 2012 at 06:18:59PM +0400, Stanislav Kinsbursky wrote: These bugfixes were caught (or noticed) due to the following simple script: I'm assuming Trond should take

[Devel] Re: [PATCH 4/8] nfsd: use exp_put() for svc_export_cache put

2012-04-11 Thread J. Bruce Fields
On Wed, Mar 28, 2012 at 07:09:22PM +0400, Stanislav Kinsbursky wrote: This patch replaces cache_put() call for svc_export_cache by exp_put() call. Patch looks fine. Minor peeve: the changelog doesn't tell me anything I couldn't figure out immediately from reading the patch. Tell me *why* we're

[Devel] Re: [PATCH 0/8] NFSd: precursor and cleanup patch set

2012-04-11 Thread J. Bruce Fields
On Wed, Mar 28, 2012 at 07:08:53PM +0400, Stanislav Kinsbursky wrote: This patch set prepares ground for making NFSd export and expkey caches allocated and registered per network namespace context. Mainly, it just replaces hard-coded pointers with dereferenced everywhere required. The

[Devel] Re: [PATCH v2] Lockd: pass network namespace to creation and destruction routines

2012-04-11 Thread J. Bruce Fields
On Thu, Mar 29, 2012 at 06:54:33PM +0400, Stanislav Kinsbursky wrote: v2: dereference of most probably already released nlm_host removed in nlmclnt_done() and reclaimer(). Did you want this in Trond's tree or mine? --b. These routines are called from locks reclaimer() kernel thread. This

[Devel] Re: [PATCH v2] Lockd: pass network namespace to creation and destruction routines

2012-04-11 Thread J. Bruce Fields
On Wed, Apr 11, 2012 at 08:12:04PM +0400, Stanislav Kinsbursky wrote: 11.04.2012 20:11, J. Bruce Fields пишет: On Thu, Mar 29, 2012 at 06:54:33PM +0400, Stanislav Kinsbursky wrote: v2: dereference of most probably already released nlm_host removed in nlmclnt_done() and reclaimer(). Did you

[Devel] Re: [PATCH] nfsd: remove hard-coded dereferences to name-to-id and id-to-name caches

2012-04-11 Thread J. Bruce Fields
On Wed, Apr 11, 2012 at 03:18:58PM +0400, Stanislav Kinsbursky wrote: These dereferences to global static caches are redundant. They also prevents converting these caches into per-net ones. So this patch is cleanup + precursor of patch set, which will make them per-net. This isn't applying

[Devel] Re: [PATCH 2/4] nfsd: make export cache allocated per network namespace context

2012-04-11 Thread J. Bruce Fields
On Wed, Apr 11, 2012 at 03:13:21PM +0400, Stanislav Kinsbursky wrote: This patch also changes prototypes of nfsd_export_flush() and exp_rootfh(): network namespace parameter added. This also isn't applying cleanly for me. At this point I'm assuming any patches that aren't already applied to my

[Devel] Re: [PATCH 0/8] NFSd: precursor and cleanup patch set

2012-03-29 Thread J. Bruce Fields
On Wed, Mar 28, 2012 at 07:08:53PM +0400, Stanislav Kinsbursky wrote: This patch set prepares ground for making NFSd export and expkey caches allocated and registered per network namespace context. Mainly, it just replaces hard-coded pointers with dereferenced everywhere required. Thanks.

[Devel] Re: [PATCH 3/4] SUNRPC: service destruction in network namespace context

2012-01-27 Thread J. Bruce Fields
On Fri, Jan 27, 2012 at 01:08:06PM +0400, Stanislav Kinsbursky wrote: 27.01.2012 01:14, J. Bruce Fields пишет: On Wed, Jan 25, 2012 at 05:47:26PM +0400, Stanislav Kinsbursky wrote: This patch introduces network namespace filter for service destruction function. Nothing special here - just do

[Devel] Re: [PATCH 3/4] SUNRPC: service destruction in network namespace context

2012-01-26 Thread J. Bruce Fields
On Wed, Jan 25, 2012 at 05:47:26PM +0400, Stanislav Kinsbursky wrote: This patch introduces network namespace filter for service destruction function. Nothing special here - just do exactly the same operations, but only for tranports in passed networks namespace context. BTW, BUG_ON() checks

[Devel] Re: [PATCH] SUNRPC: search for service transports in network namespace context

2012-01-20 Thread J. Bruce Fields
. Acked-by: J. Bruce Fields bfie...@redhat.com --b. ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel

[Devel] Re: [PATCH RFC] SUNPRC: remove marking service temporary sockets with XPT_CHNGBUF

2012-01-20 Thread J. Bruce Fields
On Fri, Jan 20, 2012 at 04:55:39PM +0400, Stanislav Kinsbursky wrote: This is a cleanup patch. Service temporary sockets can be TCP or RDMA only. But XPT_CHNGBUF service socket flag is checked only for UDP sockets on receive. Thus (if I don't miss something non-obvious) this bit raising for

[Devel] Re: [PATCH 2/5] SUNRPC: create unix gid cache per network namespace

2012-01-19 Thread J. Bruce Fields
On Thu, Jan 19, 2012 at 06:49:14PM +0400, Stanislav Kinsbursky wrote: This patch makes unix_gid_cache cache detail allocated and registered per network namespace context. Thus with this patch unix_gid_cache contents for network namespace X are controlled from proc file system mount for the

[Devel] Re: [PATCH 3/5] SUNRPC: create GSS auth cache per network namespace

2012-01-19 Thread J. Bruce Fields
On Thu, Jan 19, 2012 at 06:49:23PM +0400, Stanislav Kinsbursky wrote: @@ -1000,6 +996,7 @@ static int svcauth_gss_handle_init(struct svc_rqst *rqstp, struct xdr_netobj tmpobj; struct rsi *rsip, rsikey; int ret; + struct sunrpc_net *sn =

[Devel] Re: [PATCH 4/5] SUNRPC: ip map cache per network namespace cleanup

2012-01-19 Thread J. Bruce Fields
On Thu, Jan 19, 2012 at 06:49:31PM +0400, Stanislav Kinsbursky wrote: This patch converts ip_map_cache per network namespace implemenetation to the same view, as other caches done in the series. Besides generalization, code becomes shorter with this patch. Again, isnt' it ip_map_cache, and not

[Devel] Re: [PATCH 3/5] SUNRPC: create GSS auth cache per network namespace

2012-01-19 Thread J. Bruce Fields
On Thu, Jan 19, 2012 at 09:04:40PM +0400, Stanislav Kinsbursky wrote: 19.01.2012 20:31, J. Bruce Fields пишет: On Thu, Jan 19, 2012 at 06:49:23PM +0400, Stanislav Kinsbursky wrote: @@ -1000,6 +996,7 @@ static int svcauth_gss_handle_init(struct svc_rqst *rqstp, struct xdr_netobj tmpobj

[Devel] Re: [PATCH 4/5] SUNRPC: ip map cache per network namespace cleanup

2012-01-19 Thread J. Bruce Fields
On Thu, Jan 19, 2012 at 09:10:08PM +0400, Stanislav Kinsbursky wrote: 19.01.2012 20:37, J. Bruce Fields пишет: On Thu, Jan 19, 2012 at 06:49:31PM +0400, Stanislav Kinsbursky wrote: This patch converts ip_map_cache per network namespace implemenetation to the same view, as other caches done

[Devel] Re: [PATCH v2 2/5] SUNRPC: create unix gid cache per network namespace

2012-01-19 Thread J. Bruce Fields
On Thu, Jan 19, 2012 at 09:42:29PM +0400, Stanislav Kinsbursky wrote: v2: 1) fixed silly usage of template cache as a real one (this code left from static global cache for all) Looks good, thanks. --b. ___ Devel mailing list Devel@openvz.org

[Devel] Re: [PATCH 0/5] SUNRPC: make caches network namespace aware

2012-01-19 Thread J. Bruce Fields
On Thu, Jan 19, 2012 at 10:19:52AM -0500, Trond Myklebust wrote: On Thu, 2012-01-19 at 18:48 +0400, Stanislav Kinsbursky wrote: One more step towards to NFS in container. With this patch set caches are allocated per network namespace. The following series consists of: ---

[Devel] Re: [PATCH 1/4] SUNRPC: use passed network namespace context in rpc_parse_scope_id()

2011-12-12 Thread J. Bruce Fields
On Mon, Dec 12, 2011 at 08:03:45PM +0400, Stanislav Kinsbursky wrote: 09.12.2011 00:47, J. Bruce Fields пишет: On Wed, Dec 07, 2011 at 03:20:16PM +0300, Stanislav Kinsbursky wrote: Use incomming network context in rpc_parse_scope_id() instead of hard-coded Changelogs are a little confusing

[Devel] Re: [PATCH 0/4] SUNRPC: pass network namespace context to sockaddr construction routines

2011-12-12 Thread J. Bruce Fields
On Mon, Dec 12, 2011 at 08:13:24PM +0400, Stanislav Kinsbursky wrote: 09.12.2011 00:46, J. Bruce Fields пишет: On Wed, Dec 07, 2011 at 03:20:07PM +0300, Stanislav Kinsbursky wrote: This is another precursor patch set aimed to remove hard-coded init_net reference from SUNRPC sockaddr convertion

  1   2   >