[Devel] Re: [PATCH 1/1, v6] cgroup/freezer: add per freezer duty ratio control

2011-02-14 Thread Vaidyanathan Srinivasan
* Arjan van de Ven ar...@linux.intel.com [2011-02-09 19:06:15]: On 2/9/2011 7:04 PM, Matt Helsley wrote: On Tue, Feb 08, 2011 at 05:05:41PM -0800, jacob.jun@linux.intel.com wrote: From: Jacob Panjacob.jun@linux.intel.com Freezer subsystem is used to manage batch jobs which can

[Devel] Re: [-mm PATCH 0/9] Memory controller introduction (v4)

2007-08-09 Thread Vaidyanathan Srinivasan
KAMEZAWA Hiroyuki wrote: On Wed, 8 Aug 2007 12:51:39 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: On Sat, 28 Jul 2007 01:39:37 +0530 Balbir Singh [EMAIL PROTECTED] wrote: At OLS, the resource management BOF, it was discussed that we need to manage RSS and unmapped page cache together.

[Devel] Re: [-mm PATCH 6/9] Memory controller add per container LRU and reclaim (v4)

2007-08-07 Thread Vaidyanathan Srinivasan
Vaidyanathan Srinivasan wrote: YAMAMOTO Takashi wrote: +unsigned long mem_container_isolate_pages(unsigned long nr_to_scan, + struct list_head *dst, + unsigned long *scanned, int order

[Devel] Re: [-mm PATCH 4/9] Memory controller memory accounting (v4)

2007-07-31 Thread Vaidyanathan Srinivasan
YAMAMOTO Takashi wrote: +lock_meta_page(page); +/* + * Check if somebody else beat us to allocating the meta_page + */ +race_mp = page_get_meta_page(page); +if (race_mp) { +kfree(mp); +mp = race_mp; +atomic_inc(mp-ref_cnt); +

[Devel] Re: [-mm PATCH 6/9] Memory controller add per container LRU and reclaim (v4)

2007-07-31 Thread Vaidyanathan Srinivasan
YAMAMOTO Takashi wrote: +unsigned long mem_container_isolate_pages(unsigned long nr_to_scan, +struct list_head *dst, +unsigned long *scanned, int order, +int mode, struct zone *z, +

[Devel] Re: [-mm PATCH 4/7] Memory controller memory accounting

2007-07-05 Thread Vaidyanathan Srinivasan
Balbir Singh wrote: Add the accounting hooks. The accounting is carried out for RSS and Page Cache (unmapped) pages. There is now a common limit and accounting for both. The RSS accounting is accounted at page_add_*_rmap() and page_remove_rmap() time. Page cache is accounted at

[Devel] [RFC][PATCH 0/3] Containers: Integrated RSS and pagecache control v5

2007-06-29 Thread Vaidyanathan Srinivasan
Containers: Integrated RSS and pagecache accounting and control v5 -- Based on the discussions at OLS yesterday, the consensus was to try an integrated pagecache controller along with RSS controller under the same usage limit. This

[Devel] [RFC][PATCH 1/3] Pagecache accounting

2007-06-29 Thread Vaidyanathan Srinivasan
page_container list only once independent of repeated calls from pagecache, swapcache and mmap to RSS. No setup patch is required since rss_limit and rss_usage has been generalised as the resource counter for pagecache as well. Signed-off-by: Vaidyanathan Srinivasan [EMAIL PROTECTED] --- include/linux

[Devel] [RFC][PATCH 2/3] Pagecache and RSS accounting hooks

2007-06-29 Thread Vaidyanathan Srinivasan
. Signed-off-by: Vaidyanathan Srinivasan [EMAIL PROTECTED] --- fs/exec.c |4 ++-- mm/filemap.c| 17 + mm/memory.c | 18 +- mm/migrate.c|4 ++-- mm/rmap.c | 12 ++-- mm/swap_state.c | 16 mm/swapfile.c

[Devel] [RFC][PATCH 3/3] Pagecache reclaim

2007-06-29 Thread Vaidyanathan Srinivasan
Pagecache controller reclaim changes Reclaim path needs performance improvement. For now it is minor changes to include unmapped pages in our list of page_container. Signed-off-by: Vaidyanathan Srinivasan [EMAIL PROTECTED] --- mm/rss_container.c |3

[Devel] Re: [RFC] mm-controller

2007-06-25 Thread Vaidyanathan Srinivasan
Paul Menage wrote: On 6/25/07, Paul Menage [EMAIL PROTECTED] wrote: On 6/22/07, Vaidyanathan Srinivasan [EMAIL PROTECTED] wrote: Merging both limits will eliminate the issue, however we would need individual limits for pagecache and RSS for better control. There are use cases

[Devel] Re: [RFC] mm-controller

2007-06-22 Thread Vaidyanathan Srinivasan
Peter Zijlstra wrote: On Thu, 2007-06-21 at 16:33 +0530, Balbir Singh wrote: Peter Zijlstra wrote: [snip] Not quite sure on 2, from reading the pagecache controller, I got the impression that enforcing both limits got you into trouble. Merging the limits would rid us of that issue, no?

[Devel] [RFC][PATCH 1/4] Pagecache controller setup

2007-06-20 Thread Vaidyanathan Srinivasan
is all file backed pages used by the container which includes swapcache as well. Separate res_counter for pagecache has been added. Signed-off-by: Vaidyanathan Srinivasan [EMAIL PROTECTED] --- mm/rss_container.c | 43 +++ 1 file changed, 43 insertions

[Devel] [RFC][PATCH 2/4] Pagecache accounting

2007-06-20 Thread Vaidyanathan Srinivasan
is added or removed from page_container list only once independent of repeated calls from pagecache, swapcache and mmap to RSS. Flags in page_container is used to keep the accounting correct between RSS and unmapped pagecache (includes swapcache) pages. Signed-off-by: Vaidyanathan Srinivasan [EMAIL

[Devel] [RFC][PATCH 3/4] Pagecache and RSS accounting hooks

2007-06-20 Thread Vaidyanathan Srinivasan
. Signed-off-by: Vaidyanathan Srinivasan [EMAIL PROTECTED] --- fs/exec.c |4 ++-- mm/filemap.c| 18 ++ mm/memory.c | 18 +- mm/migrate.c|4 ++-- mm/rmap.c | 12 ++-- mm/swap_state.c | 16 mm/swapfile.c

[Devel] Re: [PATCH 0/8] RSS controller based on process containers (v3.1)

2007-06-08 Thread Vaidyanathan Srinivasan
Herbert Poetzl wrote: On Fri, Jun 08, 2007 at 04:39:28PM +0400, Pavel Emelianov wrote: Herbert Poetzl wrote: On Mon, Jun 04, 2007 at 05:25:25PM +0400, Pavel Emelianov wrote: [snip] When this usage exceeds the limit set some pages are reclaimed from the owning container. In case no

[Devel] Re: [PATCH 8/8] Per-container pages reclamation

2007-05-31 Thread Vaidyanathan Srinivasan
Andrew Morton wrote: On Wed, 30 May 2007 19:42:26 +0400 Pavel Emelianov [EMAIL PROTECTED] wrote: [snip] +#ifdef CONFIG_RSS_CONTAINER +unsigned long try_to_free_pages_in_container(struct rss_container *cnt) +{ +struct scan_control sc = { +.gfp_mask = GFP_KERNEL, +

[Devel] [RFC][PATCH 2/3] Containers: Pagecache accounting and control subsystem (v3)

2007-05-23 Thread Vaidyanathan Srinivasan
is added or removed from page_container list only once independent of repeated calls from pagecache, swapcache and mmap to RSS. Flags in page_container is used to keep the accounting correct between RSS and unmapped pagecache (includes swapcache) pages. Signed-off-by: Vaidyanathan Srinivasan [EMAIL

[Devel] [RFC][PATCH 3/3] Containers: Pagecache accounting and control subsystem (v3)

2007-05-23 Thread Vaidyanathan Srinivasan
. Signed-off-by: Vaidyanathan Srinivasan [EMAIL PROTECTED] --- fs/exec.c |4 ++-- mm/filemap.c| 18 ++ mm/fremap.c |4 ++-- mm/memory.c | 20 ++-- mm/migrate.c|4 ++-- mm/rmap.c | 12 ++-- mm/swap_state.c | 16

[Devel] Re: [PATCH 2/7] Containers (V8): Cpusets hooked into containers

2007-04-23 Thread Vaidyanathan Srinivasan
[EMAIL PROTECTED] wrote: This patch removes the process grouping code from the cpusets code, instead hooking it into the generic container system. This temporarily adds cpuset-specific code in kernel/container.c, which is removed by the next patch in the series. Signed-off-by: Paul Menage

[Devel] Re: [PATCH 0/7] Containers (V8): Generic Process Containers

2007-04-23 Thread Vaidyanathan Srinivasan
Hi Paul, In [patch 3/7] Containers (V8): Add generic multi-subsystem API to containers, you have forcefully enabled interrupt in container_init_subsys() with spin_unlock_irq() which breaks on PPC64. +static void container_init_subsys(struct container_subsys *ss) { + int retval; +

[Devel] Re: [PATCH 0/8] RSS controller based on process containers (v2)

2007-04-18 Thread Vaidyanathan Srinivasan
Pavel Emelianov wrote: Peter Zijlstra wrote: *ugh* /me no like. The basic premises seems to be that we can track page owners perfectly (although this patch set does not yet do so), through get/release It looks like you have examined the patches not very carefully before concluding this.

[Devel] Re: [PATCH 3/3][RFC] Containers: Pagecache controller reclaim

2007-03-27 Thread Vaidyanathan Srinivasan
Aubrey Li wrote: On 3/6/07, Vaidyanathan Srinivasan [EMAIL PROTECTED] wrote: The reclaim code is similar to RSS memory controller. Scan control is slightly different since we are targeting different type of pages. Additionally no mapped pages are touched when scanning for pagecache pages

[Devel] Re: [PATCH 3/3][RFC] Containers: Pagecache controller reclaim

2007-03-27 Thread Vaidyanathan Srinivasan
Aubrey Li wrote: On 3/27/07, Vaidyanathan Srinivasan [EMAIL PROTECTED] wrote: Aubrey Li wrote: On 3/27/07, Vaidyanathan Srinivasan [EMAIL PROTECTED] wrote: Correct, shrink_page_list() is called from shrink_inactive_list() but the above code is patched in shrink_active_list

[Devel] Re: [PATCH 2/3][RFC] Containers: Pagecache controller accounting

2007-03-06 Thread Vaidyanathan Srinivasan
is obtained from struct page which holds the container pointer. This framework avoids any additional pointers in struct page. additions and deletions from pagecache are hooked to charge and uncharge the corresponding container. Signed-off-by: Vaidyanathan Srinivasan [EMAIL PROTECTED] --- include/linux/fs.h

[Devel] [PATCH 3/3][RFC] Containers: Pagecache controller reclaim

2007-03-06 Thread Vaidyanathan Srinivasan
and hence pagecache controller patches are dependent on RSS memory controller patch even though the features are independently configurable at compile time. Signed-off-by: Vaidyanathan Srinivasan [EMAIL PROTECTED] --- include/linux/memcontrol.h |6 +++ mm/memcontrol.c|4 +- mm

[Devel] [PATCH 1/3][RFC] Containers: Pagecache controller setup

2007-03-06 Thread Vaidyanathan Srinivasan
kernel options and have been added along with Makefile changes. Signed-off-by: Vaidyanathan Srinivasan [EMAIL PROTECTED] --- include/linux/pagecache_acct.h | 53 + init/Kconfig |7 mm/Makefile|1 mm/pagecache_acct.c| 368

[Devel] [PATCH 0/3][RFC] Containers: Pagecache accounting and control subsystem (v1)

2007-03-06 Thread Vaidyanathan Srinivasan
Containers: Pagecache accounting and control subsystem (v1) --- This patch adds pagecache accounting and control on top of Paul's container subsystem v7 posted at http://lkml.org/lkml/2007/2/12/88 and Balbir's RSS controller posted at

[Devel] [PATCH 0/3][RFC] Containers: Pagecache accounting and control subsystem (v1)

2007-03-05 Thread Vaidyanathan Srinivasan
Containers: Pagecache accounting and control subsystem (v1) --- This patch adds pagecache accounting and control on top of Paul's container subsystem v7 posted at http://lkml.org/lkml/2007/2/12/88 and Balbir's RSS controller posted at

[Devel] [PATCH 3/3][RFC] Containers: Pagecache controller reclaim

2007-03-05 Thread Vaidyanathan Srinivasan
and hence pagecache controller patches are dependent on RSS memory controller patch even though the features are independently configurable at compile time. Signed-off-by: Vaidyanathan Srinivasan [EMAIL PROTECTED] --- include/linux/memcontrol.h |6 +++ mm/memcontrol.c|4 +- mm

[Devel] [PATCH 2/3][RFC] Containers: Pagecache controller accounting

2007-02-21 Thread Vaidyanathan Srinivasan
is obtained from struct page which holds the container pointer. This framework avoids any additional pointers in struct page. additions and deletions from pagecache are hooked to charge and uncharge the corresponding container. Signed-off-by: Vaidyanathan Srinivasan [EMAIL PROTECTED] --- include/linux

[Devel] [PATCH 0/3][RFC] Containers: Pagecache accounting and control subsystem (v1)

2007-02-21 Thread Vaidyanathan Srinivasan
Containers: Pagecache accounting and control subsystem (v1) --- This patch adds pagecache accounting and control on top of Paul's container subsystem v7 posted at http://lkml.org/lkml/2007/2/12/88 and Balbir's RSS controller posted at

[Devel] Re: [ckrm-tech] [RFC][PATCH][2/4] Add RSS accounting and control

2007-02-19 Thread Vaidyanathan Srinivasan
Balbir Singh wrote: Paul Menage wrote: On 2/19/07, Balbir Singh [EMAIL PROTECTED] wrote: More worrisome is the potential for use-after-free. What prevents the pointer at mm-container from referring to freed memory after we're dropped the lock? The container cannot be freed unless all

[Devel] Re: [ckrm-tech] [RFC][PATCH][2/4] Add RSS accounting and control

2007-02-19 Thread Vaidyanathan Srinivasan
Balbir Singh wrote: Vaidyanathan Srinivasan wrote: Balbir Singh wrote: Paul Menage wrote: On 2/19/07, Balbir Singh [EMAIL PROTECTED] wrote: More worrisome is the potential for use-after-free. What prevents the pointer at mm-container from referring to freed memory after we're dropped