[Devel] netns patches WAS( Re: [PATCH 8/8] net: Implement socketat.

2010-10-15 Thread jamal
Eric et al, Did these patches make it in? I was looking at two Davem net trees and i dont see them. cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers

[Devel] Re: [PATCH 8/8] net: Implement socketat.

2010-10-03 Thread jamal
for the namespace (assuming the socket domain will be ok for all the operations). Jamal, I don't know what kind of application you want to use but if I assume you want to create a process controlling 1024 netns, At the moment i am looking at 8K on a Nehalem with lots of RAM. They will mostly

[Devel] Re: [PATCH 7/8] net: Allow setting the network namespace by fd

2010-09-24 Thread jamal
than just some basic locking only while you change the struct net pointer to the new namespace for these sub-subsystems? cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo

[Devel] Re: [PATCH 7/8] net: Allow setting the network namespace by fd

2010-09-24 Thread jamal
are evolving and synchronizing via user space is the best approach. The example of route table i pointed to is simple. Besides that: dynamic state created in the kernel that doesnt have to be recreated by the next arriving 100K packets helps to improve recovery. cheers, jamal

[Devel] Re: [PATCH 7/8] net: Allow setting the network namespace by fd

2010-09-24 Thread jamal
devices together with their routes to a different namespace? scaling and availability are the driving requirements. cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo

[Devel] Re: [PATCH 8/8] net: Implement socketat.

2010-09-23 Thread jamal
at namespace blah from mother namespace, read/write/poll fdx (eg add route with netlink socket) cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers

[Devel] Re: [PATCH 7/8] net: Allow setting the network namespace by fd

2010-09-23 Thread jamal
they are all tagged by netns? cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel

[Devel] Re: [PATCH 8/8] net: Implement socketat.

2010-09-23 Thread jamal
, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo

[Devel] Re: [PATCH 8/8] net: Implement socketat.

2010-09-23 Thread jamal
to before the enter. So if i enter foo, get a fdx, leave foo i can use it in ns0 as if it was in ns0? cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers

[Devel] Re: [PATCH] [RFC] C/R: inet4 and inet6 unicast routes (v2)

2010-04-30 Thread jamal
it is hard to change. Historically (for pragmatic reasons) such rich interfaces sit in user space - much easier to update user space. cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org

[Devel] Re: [PATCH 2/4] [RFC] Add sock_create_kern_net()

2010-04-28 Thread jamal
is? cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-02-23 Thread jamal
scheme above a nested namespace shows up as: /var/run/netns/name/nestedname, no? cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-02-23 Thread jamal
Added Daniel to the discussion.. On Tue, 2010-02-23 at 06:07 -0800, Eric W. Biederman wrote: jamal h...@cyberus.ca writes: Does the point after sys_setns(fd) allow me to do io inside ns name? Can i do open() and get a fd from ns name? Yes. My intention is that current-nsproxy-net_ns

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-02-23 Thread jamal
for namespaces? Attributes of the specific namespace? Well, example what is being un/shared etc. cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-02-22 Thread jamal
On Mon, 2010-02-22 at 12:46 -0800, Eric W. Biederman wrote: jamal h...@cyberus.ca writes: This is one of the long standing issues that we have always known we needed to solve, but have not taken the time to do it. Now that the need is more real it looks about time to solve this one

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-01-15 Thread jamal
that it is not the generic scenario solution compared to namespaces. cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-01-15 Thread jamal
On Fri, 2010-01-15 at 11:15 +0100, Patrick McHardy wrote: jamal wrote: b) dynamic protocols (routing, IKE etc): how do you do that without making both sides understand what is going on? In case of IPsec the outer addresses are different, its only the selectors which will have similar

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-01-14 Thread jamal
-mark instead of creating a new semantic construct? cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing

[Devel] Re: RFC: netfilter: nf_conntrack: add support for conntrack zones

2010-01-14 Thread jamal
On Thu, 2010-01-14 at 16:37 +0100, Patrick McHardy wrote: jamal wrote: Agreed that this would be a main driver of such a feature. Which means that you need zones (or whatever noun other people use) to work on not just netfilter, but also routing, ipsec etc. Routing already works fine. I

[Devel] 10K containers

2009-09-02 Thread jamal
with the case of etun hitting 2+ times the CPU use! I am taking it that etun is pretty close to veth performance-wise, so the results there may still be valid today. Daniel - maybe you run these tests; is there a profile that points out where the bottleneck is? cheers, jamal

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-06-10 Thread jamal
for for uniqueness, unless I miss something? Lets just ignore the need for these changes since the patch fixes them for now. I would still like to make the changes i suggested but later with more thought put into them. cheers, jamal ___ Containers mailing list

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-06-02 Thread jamal
On Tue, 2009-06-02 at 15:59 +0900, Minoru Usui wrote: If we have to test Jarek's patch #2, I'll test it tomorrow. What do you think Jamal? Yes please - even if it is for reasons of givein Jarek some peace of mind;- If something goes seriously wrong with other classifiers because of the patch

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-06-02 Thread jamal
all buckets from underneath other classifiers b) get consistency across all classifiers in usage of setup API If you want to do this - go ahead; else i plan on tackling it probably when stable 2.6.31 kicks in. cheers, jamal diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 07372f6

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-06-01 Thread jamal
- in this case i dont think it is worth big changes.. cheers, jamal diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 0759f32..08d98e8 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -135,6 +135,7 @@ static int tc_ctl_tfilter(struct sk_buff *skb, struct nlmsghdr *n, void

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-06-01 Thread jamal
. cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-05-31 Thread jamal
the cause in such a situation. Here's the anology of our conversation (some captured above) as i see it centred around a bug of leaky pipe which just messed up the carpet overnight in some room: handyman Jamal: fix the pipe so it doesnt leak. handyman Jarek: put a little bucket below

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-05-31 Thread jamal
to: + if (n-nlmsg_type == RTM_NEWTFILTER + (n-nlmsg_flagsNLM_F_CREATE +n-nlmsg_flagsNLM_F_EXCL)) { cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-05-31 Thread jamal
On Sun, 2009-05-31 at 09:24 -0400, jamal wrote: This would imply the classifier is buggy. I will stare at the different classifier - and if any exhibits such traits it needs to be fixed I couldnt find any case where this is possible in the current code. If you have a specific example, we need

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-05-31 Thread jamal
will submit a fix for it. Of course the commands from user space are a little rude ;- cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-05-30 Thread jamal
errout; break; Probably this case needs tcf_destroy() too. No - that if stmnt will fail if this is a new filter being created. cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-05-30 Thread jamal
on failure is an issue regardless of what cls_group does. In the case of Minoru's issue it is because he is misconfiguring cls_group. cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-05-30 Thread jamal
On Sat, 2009-05-30 at 14:07 +0200, Jarek Poplawski wrote: On Sat, May 30, 2009 at 07:56:34AM -0400, jamal wrote: tp_created is the check n-nlmsg_type == RTM_NEWTFILTER n-nlmsg_flagsNLM_F_CREATE replace will be n-nlmsg_type == RTM_NEWTFILTER n-nlmsg_flags NLM_F_EXCL Hmm... Probably

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-05-30 Thread jamal
On Sat, 2009-05-30 at 14:45 +0200, Jarek Poplawski wrote: On Sat, May 30, 2009 at 08:31:23AM -0400, jamal wrote: Remeber, you could have NLM_F_EXCL|NLM_F_CREATE to indicate create this thing if it doesnt exist; if it exists it is an error If it doesnt exist we will enter that (tp == NULL

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-05-30 Thread jamal
- call it We add/link unconfigured tp. Anyways, a nice sun just came out over here and i am off to run some chores. If you respond you will hear from me in a few hours. cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-05-30 Thread jamal
On Sat, 2009-05-30 at 16:00 +0200, Jarek Poplawski wrote: On Sat, May 30, 2009 at 09:31:37AM -0400, jamal wrote: What were you suggesting to change in cls_group to avoid this oops? I think checking the head (tp-root) for NULL like in cls_fw or cls_route should work. IMHO

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-05-30 Thread jamal
-nlmsg_type == RTM_NEWTFILTER + (n-nlmsg_flags(NLM_F_CREATE|NLM_F_EXCL))) { cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/containers

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-05-30 Thread jamal
On Sun, 2009-05-31 at 07:38 +0900, Minoru Usui wrote: I agree. I think cls_cgroup should check head(tp-root) whether NULL or not like other classifiers, too. I dont think this is necessary if the adding/linking unconfigured tp doesnt happen on failed config. cheers, jamal

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-05-29 Thread jamal
to reattach an existing tp because it succeeded in parameter change. So the soln is to check if this is a new tp and then do what you did above... Did that make sense? cheers, jamal ___ Containers mailing list contain...@lists.linux-foundation.org https

[Devel] Re: [BUG] net_cls: Panic occured when net_cls subsystem use

2009-05-29 Thread jamal
as the author (and a signed-off from me). Then we can revisit the init() issue in cls_group.. You should also cc tgraf in your cls_grp config questions. cheers, jamal On Fri, 2009-05-29 at 09:46 -0400, jamal wrote: This is incorrect. tp may already exist and you dont want to destroy for failure to change

[Devel] Re: [PATCH][PKTGEN] Fix double unlock of xfrm_state-lock

2007-11-19 Thread jamal
On Mon, 2007-19-11 at 12:47 +0300, Pavel Emelyanov wrote: The pktgen_output_ipsec() function can unlock this lock twice due to merged error and plain paths. Remove one of the calls to spin_unlock. Good catch. Acked-by: Jamal Hadi Salim [EMAIL PROTECTED] cheers, jamal

[Devel] Re: [PATCH] Virtual ethernet device (tunnel)

2007-05-02 Thread jamal
... cheers, jamal ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel