[Devel] [PATCH 1/6] vzctl: split ct_env_create (v2)

2013-05-21 Thread Andrey Vagin
ct_env_create will able to execute CT and to resume CT v2: A return code contains one of known codes with inverted sign. Signed-off-by: Andrey Vagin ava...@openvz.org --- src/lib/hooks_ct.c | 79 +++--- 1 file changed, 45 insertions(+), 34

Re: [Devel] [PATCH 1/6] vzctl: split ct_env_create

2013-05-17 Thread Kir Kolyshkin
On 05/16/2013 09:47 AM, Andrey Wagin wrote: 2013/5/16 Glauber Costa glom...@parallels.com: On 05/16/2013 04:14 PM, Andrey Vagin wrote: + ret = ct_env_create_real(arg); + if (ret 0) return VZ_RESOURCE_ERROR; - } Isn't it better to just keep the return values intact

[Devel] [PATCH 1/6] vzctl: split ct_env_create

2013-05-16 Thread Andrey Vagin
ct_env_create will able to execute CT and to resume CT Signed-off-by: Andrey Vagin ava...@openvz.org --- src/lib/hooks_ct.c | 49 ++--- 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/src/lib/hooks_ct.c b/src/lib/hooks_ct.c index

Re: [Devel] [PATCH 1/6] vzctl: split ct_env_create

2013-05-16 Thread Glauber Costa
On 05/16/2013 04:14 PM, Andrey Vagin wrote: + ret = ct_env_create_real(arg); + if (ret 0) return VZ_RESOURCE_ERROR; - } Isn't it better to just keep the return values intact in create_real, and then return them as is if ret != 0 ?

Re: [Devel] [PATCH 1/6] vzctl: split ct_env_create

2013-05-16 Thread Kir Kolyshkin
On 05/16/2013 09:19 AM, Glauber Costa wrote: On 05/16/2013 04:14 PM, Andrey Vagin wrote: + ret = ct_env_create_real(arg); + if (ret 0) return VZ_RESOURCE_ERROR; - } Isn't it better to just keep the return values intact in create_real, and then return them as

Re: [Devel] [PATCH 1/6] vzctl: split ct_env_create

2013-05-16 Thread Andrey Wagin
2013/5/16 Glauber Costa glom...@parallels.com: On 05/16/2013 04:14 PM, Andrey Vagin wrote: + ret = ct_env_create_real(arg); + if (ret 0) return VZ_RESOURCE_ERROR; - } Isn't it better to just keep the return values intact in create_real, and then return them as is